Skip to content

Commit 072afc5

Browse files
committed
test(hapi): cover 16.x and 21+ and skip the EOL 19/20 majors that hang CI
1 parent 19989f1 commit 072afc5

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

packages/datadog-plugin-hapi/test/index.spec.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,11 @@ const semver = require('semver')
1111
const { ERROR_MESSAGE, ERROR_TYPE, ERROR_STACK } = require('../../dd-trace/src/constants')
1212
const agent = require('../../dd-trace/test/plugins/agent')
1313
const { withVersions } = require('../../dd-trace/test/setup/mocha')
14+
// hapi 19.x and 20.x are EOL and hang CI: on error and 404 replies they crash inside their own
15+
// `Request._finalize` (null `response.statusCode`) and never finish the request, stalling the
16+
// worker until the job is cancelled. 21.x fixed it, so the matrix covers 16.x and 21+.
1417
const versionRange = parseInt(process.versions.node.split('.')[0]) > 14
15-
? '<17 || >18'
18+
? '<17 || >=21'
1619
: ''
1720

1821
describe('Plugin', () => {

0 commit comments

Comments
 (0)