Switch Code-Origin startup logging from INFO to DEBUG#9949
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: d527ee8 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (331.384 µs) : 300, 362
. : milestone, 331,
basic (296.282 µs) : 289, 304
. : milestone, 296,
loop (8.444 ms) : 8383, 8505
. : milestone, 8444,
section candidate
noprobe (327.213 µs) : 282, 372
. : milestone, 327,
basic (294.556 µs) : 287, 302
. : milestone, 295,
loop (8.442 ms) : 8380, 8504
. : milestone, 8442,
|
jpbempel
left a comment
There was a problem hiding this comment.
should remove completely the info level, it would be easier 😁
BenchmarksStartupParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 8 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~d527ee8c5b, baseline=1.56.0-SNAPSHOT~b112f74d8e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1100122
Total [baseline] (8.84 s) : 0, 8840230
Agent [candidate] (1.105 s) : 0, 1104590
Total [candidate] (8.838 s) : 0, 8837812
section iast
Agent [baseline] (1.242 s) : 0, 1242086
Total [baseline] (9.593 s) : 0, 9593017
Agent [candidate] (1.249 s) : 0, 1249340
Total [candidate] (9.554 s) : 0, 9553736
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~d527ee8c5b, baseline=1.56.0-SNAPSHOT~b112f74d8e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (704.083 ms) : 0, 704083
BytebuddyAgent [candidate] (710.56 ms) : 0, 710560
GlobalTracer [baseline] (247.647 ms) : 0, 247647
GlobalTracer [candidate] (248.971 ms) : 0, 248971
AppSec [baseline] (32.288 ms) : 0, 32288
AppSec [candidate] (32.435 ms) : 0, 32435
Debugger [baseline] (67.686 ms) : 0, 67686
Debugger [candidate] (63.679 ms) : 0, 63679
Remote Config [baseline] (640.094 µs) : 0, 640
Remote Config [candidate] (627.264 µs) : 0, 627
Telemetry [baseline] (8.117 ms) : 0, 8117
Telemetry [candidate] (8.164 ms) : 0, 8164
Flare Poller [baseline] (3.645 ms) : 0, 3645
Flare Poller [candidate] (3.675 ms) : 0, 3675
section iast
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (828.186 ms) : 0, 828186
BytebuddyAgent [candidate] (839.289 ms) : 0, 839289
GlobalTracer [baseline] (238.71 ms) : 0, 238710
GlobalTracer [candidate] (239.584 ms) : 0, 239584
IAST [baseline] (26.935 ms) : 0, 26935
IAST [candidate] (32.553 ms) : 0, 32553
AppSec [baseline] (34.919 ms) : 0, 34919
AppSec [candidate] (29.447 ms) : 0, 29447
Debugger [baseline] (65.322 ms) : 0, 65322
Debugger [candidate] (60.093 ms) : 0, 60093
Remote Config [baseline] (543.514 µs) : 0, 544
Remote Config [candidate] (538.565 µs) : 0, 539
Telemetry [baseline] (7.718 ms) : 0, 7718
Telemetry [candidate] (7.64 ms) : 0, 7640
Flare Poller [baseline] (3.582 ms) : 0, 3582
Flare Poller [candidate] (3.529 ms) : 0, 3529
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~d527ee8c5b, baseline=1.56.0-SNAPSHOT~b112f74d8e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1102853
Total [baseline] (10.732 s) : 0, 10732168
Agent [candidate] (1.103 s) : 0, 1103239
Total [candidate] (10.756 s) : 0, 10756195
section appsec
Agent [baseline] (1.274 s) : 0, 1274166
Total [baseline] (11.031 s) : 0, 11031481
Agent [candidate] (1.285 s) : 0, 1284782
Total [candidate] (11.137 s) : 0, 11136589
section iast
Agent [baseline] (1.248 s) : 0, 1247691
Total [baseline] (10.632 s) : 0, 10631647
Agent [candidate] (1.243 s) : 0, 1242541
Total [candidate] (11.253 s) : 0, 11252533
section profiling
Agent [baseline] (1.23 s) : 0, 1230165
Total [baseline] (11.025 s) : 0, 11024616
Agent [candidate] (1.229 s) : 0, 1229328
Total [candidate] (11.044 s) : 0, 11044152
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~d527ee8c5b, baseline=1.56.0-SNAPSHOT~b112f74d8e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (705.405 ms) : 0, 705405
BytebuddyAgent [candidate] (708.098 ms) : 0, 708098
GlobalTracer [baseline] (248.104 ms) : 0, 248104
GlobalTracer [candidate] (249.21 ms) : 0, 249210
AppSec [baseline] (32.319 ms) : 0, 32319
AppSec [candidate] (32.563 ms) : 0, 32563
Debugger [baseline] (68.44 ms) : 0, 68440
Debugger [candidate] (64.386 ms) : 0, 64386
Remote Config [baseline] (635.014 µs) : 0, 635
Remote Config [candidate] (645.49 µs) : 0, 645
Telemetry [baseline] (8.11 ms) : 0, 8110
Telemetry [candidate] (8.244 ms) : 0, 8244
Flare Poller [baseline] (3.673 ms) : 0, 3673
Flare Poller [candidate] (3.755 ms) : 0, 3755
section appsec
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (726.764 ms) : 0, 726764
BytebuddyAgent [candidate] (733.103 ms) : 0, 733103
GlobalTracer [baseline] (239.651 ms) : 0, 239651
GlobalTracer [candidate] (242.366 ms) : 0, 242366
AppSec [baseline] (173.569 ms) : 0, 173569
AppSec [candidate] (174.075 ms) : 0, 174075
Debugger [baseline] (60.559 ms) : 0, 60559
Debugger [candidate] (61.011 ms) : 0, 61011
Remote Config [baseline] (712.625 µs) : 0, 713
Remote Config [candidate] (687.382 µs) : 0, 687
Telemetry [baseline] (8.306 ms) : 0, 8306
Telemetry [candidate] (8.304 ms) : 0, 8304
Flare Poller [baseline] (3.842 ms) : 0, 3842
Flare Poller [candidate] (3.831 ms) : 0, 3831
IAST [baseline] (24.639 ms) : 0, 24639
IAST [candidate] (24.899 ms) : 0, 24899
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (833.703 ms) : 0, 833703
BytebuddyAgent [candidate] (832.172 ms) : 0, 832172
GlobalTracer [baseline] (237.61 ms) : 0, 237610
GlobalTracer [candidate] (239.421 ms) : 0, 239421
AppSec [baseline] (29.804 ms) : 0, 29804
AppSec [candidate] (28.788 ms) : 0, 28788
Debugger [baseline] (66.488 ms) : 0, 66488
Debugger [candidate] (61.402 ms) : 0, 61402
Remote Config [baseline] (566.429 µs) : 0, 566
Remote Config [candidate] (561.017 µs) : 0, 561
Telemetry [baseline] (7.827 ms) : 0, 7827
Telemetry [candidate] (7.758 ms) : 0, 7758
Flare Poller [baseline] (3.681 ms) : 0, 3681
Flare Poller [candidate] (3.564 ms) : 0, 3564
IAST [baseline] (31.778 ms) : 0, 31778
IAST [candidate] (32.452 ms) : 0, 32452
section profiling
ProfilingAgent [baseline] (97.337 ms) : 0, 97337
ProfilingAgent [candidate] (97.043 ms) : 0, 97043
crashtracking [baseline] (1.42 ms) : 0, 1420
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (728.281 ms) : 0, 728281
BytebuddyAgent [candidate] (730.451 ms) : 0, 730451
GlobalTracer [baseline] (221.332 ms) : 0, 221332
GlobalTracer [candidate] (223.048 ms) : 0, 223048
AppSec [baseline] (32.153 ms) : 0, 32153
AppSec [candidate] (32.243 ms) : 0, 32243
Debugger [baseline] (67.646 ms) : 0, 67646
Debugger [candidate] (63.048 ms) : 0, 63048
Remote Config [baseline] (638.677 µs) : 0, 639
Remote Config [candidate] (640.184 µs) : 0, 640
Telemetry [baseline] (7.949 ms) : 0, 7949
Telemetry [candidate] (7.921 ms) : 0, 7921
Flare Poller [baseline] (3.735 ms) : 0, 3735
Flare Poller [candidate] (3.678 ms) : 0, 3678
Profiling [baseline] (97.936 ms) : 0, 97936
Profiling [candidate] (97.622 ms) : 0, 97622
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~d527ee8c5b, baseline=1.56.0-SNAPSHOT~b112f74d8e
dateFormat X
axisFormat %s
section baseline
no_agent (1.211 ms) : 1199, 1223
. : milestone, 1211,
iast (3.249 ms) : 3211, 3286
. : milestone, 3249,
iast_FULL (6.138 ms) : 6075, 6201
. : milestone, 6138,
iast_GLOBAL (3.749 ms) : 3690, 3808
. : milestone, 3749,
profiling (1.959 ms) : 1943, 1975
. : milestone, 1959,
tracing (1.838 ms) : 1822, 1854
. : milestone, 1838,
section candidate
no_agent (1.189 ms) : 1177, 1200
. : milestone, 1189,
iast (3.279 ms) : 3234, 3323
. : milestone, 3279,
iast_FULL (5.895 ms) : 5836, 5954
. : milestone, 5895,
iast_GLOBAL (3.561 ms) : 3515, 3607
. : milestone, 3561,
profiling (2.071 ms) : 2051, 2092
. : milestone, 2071,
tracing (1.843 ms) : 1827, 1858
. : milestone, 1843,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~d527ee8c5b, baseline=1.56.0-SNAPSHOT~b112f74d8e
dateFormat X
axisFormat %s
section baseline
no_agent (19.386 ms) : 19184, 19588
. : milestone, 19386,
appsec (19.625 ms) : 19426, 19823
. : milestone, 19625,
code_origins (17.882 ms) : 17702, 18061
. : milestone, 17882,
iast (17.671 ms) : 17495, 17847
. : milestone, 17671,
profiling (18.813 ms) : 18626, 19001
. : milestone, 18813,
tracing (17.942 ms) : 17763, 18122
. : milestone, 17942,
section candidate
no_agent (18.079 ms) : 17896, 18262
. : milestone, 18079,
appsec (19.643 ms) : 19446, 19839
. : milestone, 19643,
code_origins (17.498 ms) : 17325, 17671
. : milestone, 17498,
iast (17.841 ms) : 17664, 18018
. : milestone, 17841,
profiling (18.763 ms) : 18577, 18950
. : milestone, 18763,
tracing (17.582 ms) : 17409, 17755
. : milestone, 17582,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~d527ee8c5b, baseline=1.56.0-SNAPSHOT~b112f74d8e
dateFormat X
axisFormat %s
section baseline
no_agent (15.347 s) : 15347000, 15347000
. : milestone, 15347000,
appsec (14.716 s) : 14716000, 14716000
. : milestone, 14716000,
iast (18.461 s) : 18461000, 18461000
. : milestone, 18461000,
iast_GLOBAL (17.956 s) : 17956000, 17956000
. : milestone, 17956000,
profiling (15.494 s) : 15494000, 15494000
. : milestone, 15494000,
tracing (14.686 s) : 14686000, 14686000
. : milestone, 14686000,
section candidate
no_agent (15.498 s) : 15498000, 15498000
. : milestone, 15498000,
appsec (14.859 s) : 14859000, 14859000
. : milestone, 14859000,
iast (18.164 s) : 18164000, 18164000
. : milestone, 18164000,
iast_GLOBAL (18.083 s) : 18083000, 18083000
. : milestone, 18083000,
profiling (15.125 s) : 15125000, 15125000
. : milestone, 15125000,
tracing (14.778 s) : 14778000, 14778000
. : milestone, 14778000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~d527ee8c5b, baseline=1.56.0-SNAPSHOT~b112f74d8e
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.613 ms) : 3401, 3826
. : milestone, 3613,
iast (2.218 ms) : 2154, 2282
. : milestone, 2218,
iast_GLOBAL (2.256 ms) : 2192, 2320
. : milestone, 2256,
profiling (2.052 ms) : 2001, 2104
. : milestone, 2052,
tracing (2.022 ms) : 1973, 2071
. : milestone, 2022,
section candidate
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (3.658 ms) : 3444, 3871
. : milestone, 3658,
iast (2.217 ms) : 2153, 2281
. : milestone, 2217,
iast_GLOBAL (2.253 ms) : 2189, 2317
. : milestone, 2253,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (2.025 ms) : 1975, 2075
. : milestone, 2025,
|
I'll let you handle any wider logging changes to |
What Does This Do
With the Code-Origin feature on by default, we now get two INFO log messages every time a JVM starts with
dd-java-agentattached:These log messages should be switched to DEBUG so they are still available for triage purposes, but don't contribute to unwanted log-spam.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]