-
Notifications
You must be signed in to change notification settings - Fork 320
add inject datadog attribute config #9943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~f4a0b3bfb0, baseline=1.57.0-SNAPSHOT~4d1a38c992
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051033
Total [baseline] (10.84 s) : 0, 10839929
Agent [candidate] (1.051 s) : 0, 1051469
Total [candidate] (10.761 s) : 0, 10760736
section appsec
Agent [baseline] (1.236 s) : 0, 1235682
Total [baseline] (10.971 s) : 0, 10971232
Agent [candidate] (1.227 s) : 0, 1226995
Total [candidate] (10.956 s) : 0, 10956179
section iast
Agent [baseline] (1.193 s) : 0, 1193450
Total [baseline] (11.137 s) : 0, 11136552
Agent [candidate] (1.193 s) : 0, 1193409
Total [candidate] (11.096 s) : 0, 11096157
section profiling
Agent [baseline] (1.2 s) : 0, 1200283
Total [baseline] (10.893 s) : 0, 10892685
Agent [candidate] (1.197 s) : 0, 1196964
Total [candidate] (10.855 s) : 0, 10855373
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~f4a0b3bfb0, baseline=1.57.0-SNAPSHOT~4d1a38c992
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (706.124 ms) : 0, 706124
BytebuddyAgent [candidate] (706.798 ms) : 0, 706798
GlobalTracer [baseline] (248.954 ms) : 0, 248954
GlobalTracer [candidate] (249.266 ms) : 0, 249266
AppSec [baseline] (32.068 ms) : 0, 32068
AppSec [candidate] (31.955 ms) : 0, 31955
Debugger [baseline] (6.38 ms) : 0, 6380
Debugger [candidate] (6.389 ms) : 0, 6389
Remote Config [baseline] (683.32 µs) : 0, 683
Remote Config [candidate] (667.268 µs) : 0, 667
Telemetry [baseline] (16.386 ms) : 0, 16386
Telemetry [candidate] (14.612 ms) : 0, 14612
Flare Poller [baseline] (4.132 ms) : 0, 4132
Flare Poller [candidate] (5.592 ms) : 0, 5592
section appsec
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (736.64 ms) : 0, 736640
BytebuddyAgent [candidate] (729.539 ms) : 0, 729539
GlobalTracer [baseline] (243.066 ms) : 0, 243066
GlobalTracer [candidate] (241.386 ms) : 0, 241386
IAST [baseline] (24.75 ms) : 0, 24750
IAST [candidate] (24.87 ms) : 0, 24870
AppSec [baseline] (175.444 ms) : 0, 175444
AppSec [candidate] (175.68 ms) : 0, 175680
Debugger [baseline] (6.246 ms) : 0, 6246
Debugger [candidate] (6.33 ms) : 0, 6330
Remote Config [baseline] (680.928 µs) : 0, 681
Remote Config [candidate] (680.293 µs) : 0, 680
Telemetry [baseline] (8.124 ms) : 0, 8124
Telemetry [candidate] (8.068 ms) : 0, 8068
Flare Poller [baseline] (4.042 ms) : 0, 4042
Flare Poller [candidate] (3.987 ms) : 0, 3987
section iast
crashtracking [baseline] (1.489 ms) : 0, 1489
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (831.486 ms) : 0, 831486
BytebuddyAgent [candidate] (832.68 ms) : 0, 832680
GlobalTracer [baseline] (238.506 ms) : 0, 238506
GlobalTracer [candidate] (237.468 ms) : 0, 237468
IAST [baseline] (31.775 ms) : 0, 31775
IAST [candidate] (30.906 ms) : 0, 30906
AppSec [baseline] (29.739 ms) : 0, 29739
AppSec [candidate] (30.545 ms) : 0, 30545
Debugger [baseline] (6.102 ms) : 0, 6102
Debugger [candidate] (6.065 ms) : 0, 6065
Remote Config [baseline] (611.058 µs) : 0, 611
Remote Config [candidate] (611.907 µs) : 0, 612
Telemetry [baseline] (7.989 ms) : 0, 7989
Telemetry [candidate] (7.99 ms) : 0, 7990
Flare Poller [baseline] (10.81 ms) : 0, 10810
Flare Poller [candidate] (10.834 ms) : 0, 10834
section profiling
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (735.175 ms) : 0, 735175
BytebuddyAgent [candidate] (733.075 ms) : 0, 733075
GlobalTracer [baseline] (222.905 ms) : 0, 222905
GlobalTracer [candidate] (222.437 ms) : 0, 222437
AppSec [baseline] (32.257 ms) : 0, 32257
AppSec [candidate] (32.056 ms) : 0, 32056
Debugger [baseline] (6.901 ms) : 0, 6901
Debugger [candidate] (6.804 ms) : 0, 6804
Remote Config [baseline] (689.363 µs) : 0, 689
Remote Config [candidate] (680.559 µs) : 0, 681
Telemetry [baseline] (16.272 ms) : 0, 16272
Telemetry [candidate] (16.326 ms) : 0, 16326
Flare Poller [baseline] (4.219 ms) : 0, 4219
Flare Poller [candidate] (4.205 ms) : 0, 4205
ProfilingAgent [baseline] (110.99 ms) : 0, 110990
ProfilingAgent [candidate] (110.724 ms) : 0, 110724
Profiling [baseline] (111.644 ms) : 0, 111644
Profiling [candidate] (111.348 ms) : 0, 111348
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~f4a0b3bfb0, baseline=1.57.0-SNAPSHOT~4d1a38c992
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050261
Total [baseline] (8.704 s) : 0, 8703681
Agent [candidate] (1.055 s) : 0, 1055149
Total [candidate] (8.662 s) : 0, 8662189
section iast
Agent [baseline] (1.193 s) : 0, 1193286
Total [baseline] (9.283 s) : 0, 9283450
Agent [candidate] (1.192 s) : 0, 1191831
Total [candidate] (9.311 s) : 0, 9310624
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~f4a0b3bfb0, baseline=1.57.0-SNAPSHOT~4d1a38c992
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (705.785 ms) : 0, 705785
BytebuddyAgent [candidate] (709.633 ms) : 0, 709633
GlobalTracer [baseline] (249.004 ms) : 0, 249004
GlobalTracer [candidate] (249.688 ms) : 0, 249688
AppSec [baseline] (31.95 ms) : 0, 31950
AppSec [candidate] (32.067 ms) : 0, 32067
Debugger [baseline] (6.378 ms) : 0, 6378
Debugger [candidate] (6.402 ms) : 0, 6402
Remote Config [baseline] (670.844 µs) : 0, 671
Remote Config [candidate] (671.682 µs) : 0, 672
Telemetry [baseline] (16.146 ms) : 0, 16146
Telemetry [candidate] (15.334 ms) : 0, 15334
Flare Poller [baseline] (4.069 ms) : 0, 4069
Flare Poller [candidate] (4.791 ms) : 0, 4791
section iast
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (832.346 ms) : 0, 832346
BytebuddyAgent [candidate] (830.854 ms) : 0, 830854
GlobalTracer [baseline] (237.943 ms) : 0, 237943
GlobalTracer [candidate] (237.63 ms) : 0, 237630
IAST [baseline] (32.468 ms) : 0, 32468
IAST [candidate] (33.571 ms) : 0, 33571
AppSec [baseline] (28.847 ms) : 0, 28847
AppSec [candidate] (27.902 ms) : 0, 27902
Debugger [baseline] (6.072 ms) : 0, 6072
Debugger [candidate] (6.049 ms) : 0, 6049
Remote Config [baseline] (608.828 µs) : 0, 609
Remote Config [candidate] (604.076 µs) : 0, 604
Telemetry [baseline] (7.817 ms) : 0, 7817
Telemetry [candidate] (7.93 ms) : 0, 7930
Flare Poller [baseline] (10.805 ms) : 0, 10805
Flare Poller [candidate] (10.853 ms) : 0, 10853
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~f4a0b3bfb0, baseline=1.57.0-SNAPSHOT~4d1a38c992
dateFormat X
axisFormat %s
section baseline
no_agent (18.213 ms) : 18025, 18401
. : milestone, 18213,
appsec (18.996 ms) : 18802, 19189
. : milestone, 18996,
code_origins (17.87 ms) : 17689, 18051
. : milestone, 17870,
iast (17.633 ms) : 17453, 17813
. : milestone, 17633,
profiling (18.483 ms) : 18296, 18670
. : milestone, 18483,
tracing (17.675 ms) : 17500, 17849
. : milestone, 17675,
section candidate
no_agent (19.427 ms) : 19227, 19626
. : milestone, 19427,
appsec (18.722 ms) : 18529, 18915
. : milestone, 18722,
code_origins (17.661 ms) : 17484, 17838
. : milestone, 17661,
iast (17.611 ms) : 17436, 17786
. : milestone, 17611,
profiling (18.218 ms) : 18039, 18398
. : milestone, 18218,
tracing (18.776 ms) : 18583, 18969
. : milestone, 18776,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~f4a0b3bfb0, baseline=1.57.0-SNAPSHOT~4d1a38c992
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1178, 1200
. : milestone, 1189,
iast (3.035 ms) : 2998, 3072
. : milestone, 3035,
iast_FULL (5.733 ms) : 5677, 5790
. : milestone, 5733,
iast_GLOBAL (3.651 ms) : 3590, 3713
. : milestone, 3651,
profiling (1.917 ms) : 1899, 1935
. : milestone, 1917,
tracing (1.785 ms) : 1771, 1800
. : milestone, 1785,
section candidate
no_agent (1.173 ms) : 1161, 1184
. : milestone, 1173,
iast (3.134 ms) : 3095, 3172
. : milestone, 3134,
iast_FULL (5.806 ms) : 5747, 5864
. : milestone, 5806,
iast_GLOBAL (3.599 ms) : 3536, 3662
. : milestone, 3599,
profiling (2.012 ms) : 1994, 2030
. : milestone, 2012,
tracing (1.776 ms) : 1762, 1791
. : milestone, 1776,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~f4a0b3bfb0, baseline=1.57.0-SNAPSHOT~4d1a38c992
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.695 ms) : 3476, 3913
. : milestone, 3695,
iast (2.215 ms) : 2150, 2279
. : milestone, 2215,
iast_GLOBAL (2.25 ms) : 2185, 2315
. : milestone, 2250,
profiling (2.095 ms) : 2041, 2149
. : milestone, 2095,
tracing (2.042 ms) : 1991, 2093
. : milestone, 2042,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.645 ms) : 3433, 3857
. : milestone, 3645,
iast (2.214 ms) : 2150, 2278
. : milestone, 2214,
iast_GLOBAL (2.267 ms) : 2202, 2332
. : milestone, 2267,
profiling (2.064 ms) : 2012, 2116
. : milestone, 2064,
tracing (2.047 ms) : 1996, 2098
. : milestone, 2047,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~f4a0b3bfb0, baseline=1.57.0-SNAPSHOT~4d1a38c992
dateFormat X
axisFormat %s
section baseline
no_agent (15.257 s) : 15257000, 15257000
. : milestone, 15257000,
appsec (14.568 s) : 14568000, 14568000
. : milestone, 14568000,
iast (18.309 s) : 18309000, 18309000
. : milestone, 18309000,
iast_GLOBAL (18.045 s) : 18045000, 18045000
. : milestone, 18045000,
profiling (14.551 s) : 14551000, 14551000
. : milestone, 14551000,
tracing (14.778 s) : 14778000, 14778000
. : milestone, 14778000,
section candidate
no_agent (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
appsec (14.451 s) : 14451000, 14451000
. : milestone, 14451000,
iast (18.188 s) : 18188000, 18188000
. : milestone, 18188000,
iast_GLOBAL (18.031 s) : 18031000, 18031000
. : milestone, 18031000,
profiling (14.864 s) : 14864000, 14864000
. : milestone, 14864000,
tracing (14.787 s) : 14787000, 14787000
. : milestone, 14787000,
|
mhlidd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments/nits!
dd-trace-api/src/main/java/datadog/trace/api/config/TraceInstrumentationConfig.java
Outdated
Show resolved
Hide resolved
mhlidd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit but otherwise LGTM!
What Does This Do
Motivation
FRSLES-777
APMSVLS-274
tldr: currently, injecting _datadog attribute into Step Function input is disrupting Glue-based automation pipeline, due to schema constraints.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMSVLS-247