Skip to content

Migrate JDBC instrumentation to singleSpanBuilder #9927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dougqh merged 2 commits into from
Nov 11, 2025
Merged

Migrate JDBC instrumentation to singleSpanBuilder #9927

dougqh merged 2 commits into from
Nov 11, 2025

Conversation

@dougqh
Copy link
Contributor

@dougqh dougqh commented Nov 10, 2025 •
edited
Loading

What Does This Do

Updating JDBC instrumentation to use singleSpanBuilder instead of buildSpan

Motivation

Replaces calls to buildSpan with singleSpanBuilder
Each call to singleSpanBuilder is only allowed build s single span, but that allows the underlying SpanBuilder to be reused

SpanBuilder reuse reduces allocation leading to less garbage collection overhead

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@dougqh dougqh requested review from a team as code owners November 10, 2025 20:30
@dougqh dougqh requested review from mtoffl01 and removed request for a team November 10, 2025 20:30
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@dougqh dougqh added comp: database Database Monitoring type: enhancement Enhancements and improvements labels Nov 10, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 10, 2025 •
edited by datadog-official bot
Loading

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.57% (-0.05%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7918e69 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 10, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master dougqh/jdbc-single-span-buider
git_commit_date 1762804509 1762806827
git_commit_sha 7aef6ed 7918e69
release_version 1.56.0-SNAPSHOT~7aef6ed5f2 1.56.0-SNAPSHOT~7918e69524
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762808651 1762808651
ci_job_id 1226532188 1226532188
ci_pipeline_id 81874873 81874873
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-1nuh9dvg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-1nuh9dvg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~7918e69524, baseline=1.56.0-SNAPSHOT~7aef6ed5f2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046944
Total [baseline] (8.654 s) : 0, 8654238
Agent [candidate] (1.069 s) : 0, 1068526
Total [candidate] (8.758 s) : 0, 8757936
section iast
Agent [baseline] (1.179 s) : 0, 1179292
Total [baseline] (9.271 s) : 0, 9270919
Agent [candidate] (1.179 s) : 0, 1178756
Total [candidate] (9.273 s) : 0, 9273185
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.179 s 132.348 ms (12.6%)
Total tracing 8.654 s -
Total iast 9.271 s 616.681 ms (7.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.179 s 110.229 ms (10.3%)
Total tracing 8.758 s -
Total iast 9.273 s 515.248 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~7918e69524, baseline=1.56.0-SNAPSHOT~7aef6ed5f2

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (704.479 ms) : 0, 704479
BytebuddyAgent [candidate] (717.701 ms) : 0, 717701
GlobalTracer [baseline] (245.66 ms) : 0, 245660
GlobalTracer [candidate] (251.466 ms) : 0, 251466
AppSec [baseline] (32.501 ms) : 0, 32501
AppSec [candidate] (33.518 ms) : 0, 33518
Debugger [baseline] (6.436 ms) : 0, 6436
Debugger [candidate] (6.707 ms) : 0, 6707
Remote Config [baseline] (716.395 µs) : 0, 716
Remote Config [candidate] (723.451 µs) : 0, 723
Telemetry [baseline] (14.464 ms) : 0, 14464
Telemetry [candidate] (13.462 ms) : 0, 13462
Flare Poller [baseline] (6.553 ms) : 0, 6553
Flare Poller [candidate] (8.304 ms) : 0, 8304
section iast
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (827.372 ms) : 0, 827372
BytebuddyAgent [candidate] (827.745 ms) : 0, 827745
GlobalTracer [baseline] (234.961 ms) : 0, 234961
GlobalTracer [candidate] (234.463 ms) : 0, 234463
AppSec [baseline] (28.68 ms) : 0, 28680
AppSec [candidate] (28.652 ms) : 0, 28652
Debugger [baseline] (6.008 ms) : 0, 6008
Debugger [candidate] (5.988 ms) : 0, 5988
Remote Config [baseline] (609.0 µs) : 0, 609
Remote Config [candidate] (603.861 µs) : 0, 604
Telemetry [baseline] (8.428 ms) : 0, 8428
Telemetry [candidate] (8.454 ms) : 0, 8454
Flare Poller [baseline] (4.087 ms) : 0, 4087
Flare Poller [candidate] (4.101 ms) : 0, 4101
IAST [baseline] (32.854 ms) : 0, 32854
IAST [candidate] (32.521 ms) : 0, 32521
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~7918e69524, baseline=1.56.0-SNAPSHOT~7aef6ed5f2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058019
Total [baseline] (10.925 s) : 0, 10925334
Agent [candidate] (1.054 s) : 0, 1054453
Total [candidate] (10.861 s) : 0, 10861052
section appsec
Agent [baseline] (1.222 s) : 0, 1222162
Total [baseline] (10.914 s) : 0, 10913772
Agent [candidate] (1.225 s) : 0, 1225145
Total [candidate] (10.899 s) : 0, 10899070
section iast
Agent [baseline] (1.183 s) : 0, 1183358
Total [baseline] (11.233 s) : 0, 11233406
Agent [candidate] (1.18 s) : 0, 1180409
Total [candidate] (11.223 s) : 0, 11222788
section profiling
Agent [baseline] (1.195 s) : 0, 1194774
Total [baseline] (10.874 s) : 0, 10874327
Agent [candidate] (1.197 s) : 0, 1197105
Total [candidate] (10.926 s) : 0, 10925750
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.222 s 164.143 ms (15.5%)
Agent iast 1.183 s 125.34 ms (11.8%)
Agent profiling 1.195 s 136.755 ms (12.9%)
Total tracing 10.925 s -
Total appsec 10.914 s -11.562 ms (-0.1%)
Total iast 11.233 s 308.073 ms (2.8%)
Total profiling 10.874 s -51.006 ms (-0.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.225 s 170.693 ms (16.2%)
Agent iast 1.18 s 125.956 ms (11.9%)
Agent profiling 1.197 s 142.653 ms (13.5%)
Total tracing 10.861 s -
Total appsec 10.899 s 38.018 ms (0.4%)
Total iast 11.223 s 361.735 ms (3.3%)
Total profiling 10.926 s 64.697 ms (0.6%) 
gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~7918e69524, baseline=1.56.0-SNAPSHOT~7aef6ed5f2

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (713.076 ms) : 0, 713076
BytebuddyAgent [candidate] (710.994 ms) : 0, 710994
GlobalTracer [baseline] (247.888 ms) : 0, 247888
GlobalTracer [candidate] (246.389 ms) : 0, 246389
AppSec [baseline] (32.469 ms) : 0, 32469
AppSec [candidate] (32.504 ms) : 0, 32504
Debugger [baseline] (6.406 ms) : 0, 6406
Debugger [candidate] (6.411 ms) : 0, 6411
Remote Config [baseline] (723.479 µs) : 0, 723
Remote Config [candidate] (706.173 µs) : 0, 706
Telemetry [baseline] (15.178 ms) : 0, 15178
Telemetry [candidate] (13.815 ms) : 0, 13815
Flare Poller [baseline] (5.87 ms) : 0, 5870
Flare Poller [candidate] (7.245 ms) : 0, 7245
section appsec
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (729.403 ms) : 0, 729403
BytebuddyAgent [candidate] (730.674 ms) : 0, 730674
GlobalTracer [baseline] (237.776 ms) : 0, 237776
GlobalTracer [candidate] (238.478 ms) : 0, 238478
AppSec [baseline] (174.65 ms) : 0, 174650
AppSec [candidate] (175.342 ms) : 0, 175342
Debugger [baseline] (6.07 ms) : 0, 6070
Debugger [candidate] (6.003 ms) : 0, 6003
Remote Config [baseline] (655.8 µs) : 0, 656
Remote Config [candidate] (656.276 µs) : 0, 656
Telemetry [baseline] (8.534 ms) : 0, 8534
Telemetry [candidate] (8.614 ms) : 0, 8614
Flare Poller [baseline] (3.984 ms) : 0, 3984
Flare Poller [candidate] (4.004 ms) : 0, 4004
IAST [baseline] (24.728 ms) : 0, 24728
IAST [candidate] (24.921 ms) : 0, 24921
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (830.399 ms) : 0, 830399
BytebuddyAgent [candidate] (828.857 ms) : 0, 828857
GlobalTracer [baseline] (235.918 ms) : 0, 235918
GlobalTracer [candidate] (235.015 ms) : 0, 235015
AppSec [baseline] (30.575 ms) : 0, 30575
AppSec [candidate] (27.787 ms) : 0, 27787
Debugger [baseline] (6.006 ms) : 0, 6006
Debugger [candidate] (5.988 ms) : 0, 5988
Remote Config [baseline] (599.526 µs) : 0, 600
Remote Config [candidate] (603.572 µs) : 0, 604
Telemetry [baseline] (8.443 ms) : 0, 8443
Telemetry [candidate] (8.362 ms) : 0, 8362
Flare Poller [baseline] (4.208 ms) : 0, 4208
Flare Poller [candidate] (4.173 ms) : 0, 4173
IAST [baseline] (30.863 ms) : 0, 30863
IAST [candidate] (33.358 ms) : 0, 33358
section profiling
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (730.241 ms) : 0, 730241
BytebuddyAgent [candidate] (730.82 ms) : 0, 730820
GlobalTracer [baseline] (222.235 ms) : 0, 222235
GlobalTracer [candidate] (222.526 ms) : 0, 222526
AppSec [baseline] (32.214 ms) : 0, 32214
AppSec [candidate] (32.367 ms) : 0, 32367
Debugger [baseline] (7.412 ms) : 0, 7412
Debugger [candidate] (6.704 ms) : 0, 6704
Remote Config [baseline] (702.816 µs) : 0, 703
Remote Config [candidate] (1.444 ms) : 0, 1444
Telemetry [baseline] (15.226 ms) : 0, 15226
Telemetry [candidate] (15.705 ms) : 0, 15705
Flare Poller [baseline] (4.097 ms) : 0, 4097
Flare Poller [candidate] (4.207 ms) : 0, 4207
ProfilingAgent [baseline] (111.16 ms) : 0, 111160
ProfilingAgent [candidate] (111.936 ms) : 0, 111936
Profiling [baseline] (111.828 ms) : 0, 111828
Profiling [candidate] (112.615 ms) : 0, 112615
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master dougqh/jdbc-single-span-buider
git_commit_date 1762804509 1762806827
git_commit_sha 7aef6ed 7918e69
release_version 1.56.0-SNAPSHOT~7aef6ed5f2 1.56.0-SNAPSHOT~7918e69524
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762809237 1762809237
ci_job_id 1226532189 1226532189
ci_pipeline_id 81874873 81874873
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-2a1a0z0v 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-2a1a0z0v 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load worse
[+126.284µs; +165.174µs] or [+6.605%; +8.639%]		 unstable
[-460.160op/s; +135.597op/s] or [-19.530%; +5.755%]		 2.058ms 2193.844op/s 1.912ms 2356.125op/s
scenario:load:insecure-bank:no_agent:high_load worse
[+66.775µs; +93.428µs] or [+5.719%; +8.002%]		 unstable
[-853.424op/s; +187.708op/s] or [-22.641%; +4.980%]		 1.248ms 3436.455op/s 1.168ms 3769.312op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load worse
[+71.959µs; +194.317µs] or [+2.002%; +5.405%]		 unstable
[-199.272op/s; +108.897op/s] or [-15.620%; +8.536%]		 3.728ms 1230.562op/s 3.595ms 1275.750op/s
scenario:load:petclinic:no_agent:high_load better
[-1.237ms; -0.821ms] or [-6.467%; -4.292%]		 unstable
[-13.922op/s; +41.485op/s] or [-5.705%; +17.000%]		 18.099ms 257.812op/s 19.128ms 244.031op/s
scenario:load:petclinic:iast:high_load better
[-933.456µs; -542.265µs] or [-5.017%; -2.914%]		 unstable
[-15.229op/s; +35.854op/s] or [-6.072%; +14.297%]		 17.869ms 261.094op/s 18.607ms 250.781op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~7918e69524, baseline=1.56.0-SNAPSHOT~7aef6ed5f2
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.128 ms) : 18931, 19326
.   : milestone, 19128,
appsec (18.288 ms) : 18103, 18473
.   : milestone, 18288,
code_origins (17.597 ms) : 17422, 17773
.   : milestone, 17597,
iast (18.607 ms) : 18422, 18792
.   : milestone, 18607,
profiling (18.661 ms) : 18475, 18847
.   : milestone, 18661,
tracing (17.931 ms) : 17749, 18114
.   : milestone, 17931,
section candidate
no_agent (18.099 ms) : 17911, 18288
.   : milestone, 18099,
appsec (18.224 ms) : 18039, 18409
.   : milestone, 18224,
code_origins (17.74 ms) : 17562, 17918
.   : milestone, 17740,
iast (17.869 ms) : 17691, 18048
.   : milestone, 17869,
profiling (18.917 ms) : 18728, 19105
.   : milestone, 18917,
tracing (17.702 ms) : 17528, 17876
.   : milestone, 17702,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.128 ms [18.931 ms, 19.326 ms] -
appsec 18.288 ms [18.103 ms, 18.473 ms] -840.062 µs (-4.4%)
code_origins 17.597 ms [17.422 ms, 17.773 ms] -1.531 ms (-8.0%)
iast 18.607 ms [18.422 ms, 18.792 ms] -521.126 µs (-2.7%)
profiling 18.661 ms [18.475 ms, 18.847 ms] -467.663 µs (-2.4%)
tracing 17.931 ms [17.749 ms, 18.114 ms] -1.197 ms (-6.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.099 ms [17.911 ms, 18.288 ms] -
appsec 18.224 ms [18.039 ms, 18.409 ms] 124.56 µs (0.7%)
code_origins 17.74 ms [17.562 ms, 17.918 ms] -358.919 µs (-2.0%)
iast 17.869 ms [17.691 ms, 18.048 ms] -229.978 µs (-1.3%)
profiling 18.917 ms [18.728 ms, 19.105 ms] 817.264 µs (4.5%)
tracing 17.702 ms [17.528 ms, 17.876 ms] -397.356 µs (-2.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~7918e69524, baseline=1.56.0-SNAPSHOT~7aef6ed5f2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.168 ms) : 1156, 1179
.   : milestone, 1168,
iast (3.258 ms) : 3208, 3308
.   : milestone, 3258,
iast_FULL (5.777 ms) : 5719, 5835
.   : milestone, 5777,
iast_GLOBAL (3.595 ms) : 3543, 3647
.   : milestone, 3595,
profiling (1.912 ms) : 1896, 1928
.   : milestone, 1912,
tracing (1.867 ms) : 1851, 1883
.   : milestone, 1867,
section candidate
no_agent (1.248 ms) : 1234, 1261
.   : milestone, 1248,
iast (3.304 ms) : 3259, 3349
.   : milestone, 3304,
iast_FULL (5.939 ms) : 5880, 5998
.   : milestone, 5939,
iast_GLOBAL (3.728 ms) : 3667, 3789
.   : milestone, 3728,
profiling (2.058 ms) : 2038, 2078
.   : milestone, 2058,
tracing (1.881 ms) : 1865, 1897
.   : milestone, 1881,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.168 ms [1.156 ms, 1.179 ms] -
iast 3.258 ms [3.208 ms, 3.308 ms] 2.09 ms (179.1%)
iast_FULL 5.777 ms [5.719 ms, 5.835 ms] 4.61 ms (394.8%)
iast_GLOBAL 3.595 ms [3.543 ms, 3.647 ms] 2.428 ms (207.9%)
profiling 1.912 ms [1.896 ms, 1.928 ms] 744.498 µs (63.8%)
tracing 1.867 ms [1.851 ms, 1.883 ms] 699.483 µs (59.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.248 ms [1.234 ms, 1.261 ms] -
iast 3.304 ms [3.259 ms, 3.349 ms] 2.056 ms (164.8%)
iast_FULL 5.939 ms [5.88 ms, 5.998 ms] 4.691 ms (376.0%)
iast_GLOBAL 3.728 ms [3.667 ms, 3.789 ms] 2.481 ms (198.8%)
profiling 2.058 ms [2.038 ms, 2.078 ms] 810.125 µs (64.9%)
tracing 1.881 ms [1.865 ms, 1.897 ms] 633.415 µs (50.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master dougqh/jdbc-single-span-buider
git_commit_date 1762804509 1762806827
git_commit_sha 7aef6ed 7918e69
release_version 1.56.0-SNAPSHOT~7aef6ed5f2 1.56.0-SNAPSHOT~7918e69524
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1762808791 1762808791
ci_job_id 1226532190 1226532190
ci_pipeline_id 81874873 81874873
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-ckjhx9za 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-ckjhx9za 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~7918e69524, baseline=1.56.0-SNAPSHOT~7aef6ed5f2
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.55 s) : 15550000, 15550000
.   : milestone, 15550000,
appsec (15.012 s) : 15012000, 15012000
.   : milestone, 15012000,
iast (18.299 s) : 18299000, 18299000
.   : milestone, 18299000,
iast_GLOBAL (17.992 s) : 17992000, 17992000
.   : milestone, 17992000,
profiling (15.346 s) : 15346000, 15346000
.   : milestone, 15346000,
tracing (14.591 s) : 14591000, 14591000
.   : milestone, 14591000,
section candidate
no_agent (15.34 s) : 15340000, 15340000
.   : milestone, 15340000,
appsec (14.831 s) : 14831000, 14831000
.   : milestone, 14831000,
iast (18.529 s) : 18529000, 18529000
.   : milestone, 18529000,
iast_GLOBAL (18.055 s) : 18055000, 18055000
.   : milestone, 18055000,
profiling (15.559 s) : 15559000, 15559000
.   : milestone, 15559000,
tracing (14.629 s) : 14629000, 14629000
.   : milestone, 14629000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.55 s [15.55 s, 15.55 s] -
appsec 15.012 s [15.012 s, 15.012 s] -538.0 ms (-3.5%)
iast 18.299 s [18.299 s, 18.299 s] 2.749 s (17.7%)
iast_GLOBAL 17.992 s [17.992 s, 17.992 s] 2.442 s (15.7%)
profiling 15.346 s [15.346 s, 15.346 s] -204.0 ms (-1.3%)
tracing 14.591 s [14.591 s, 14.591 s] -959.0 ms (-6.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.34 s [15.34 s, 15.34 s] -
appsec 14.831 s [14.831 s, 14.831 s] -509.0 ms (-3.3%)
iast 18.529 s [18.529 s, 18.529 s] 3.189 s (20.8%)
iast_GLOBAL 18.055 s [18.055 s, 18.055 s] 2.715 s (17.7%)
profiling 15.559 s [15.559 s, 15.559 s] 219.0 ms (1.4%)
tracing 14.629 s [14.629 s, 14.629 s] -711.0 ms (-4.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~7918e69524, baseline=1.56.0-SNAPSHOT~7aef6ed5f2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (3.711 ms) : 3490, 3932
.   : milestone, 3711,
iast (2.204 ms) : 2140, 2268
.   : milestone, 2204,
iast_GLOBAL (2.25 ms) : 2186, 2314
.   : milestone, 2250,
profiling (2.056 ms) : 2004, 2108
.   : milestone, 2056,
tracing (2.025 ms) : 1975, 2074
.   : milestone, 2025,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (3.641 ms) : 3429, 3854
.   : milestone, 3641,
iast (2.208 ms) : 2144, 2272
.   : milestone, 2208,
iast_GLOBAL (2.249 ms) : 2185, 2313
.   : milestone, 2249,
profiling (2.079 ms) : 2026, 2132
.   : milestone, 2079,
tracing (2.028 ms) : 1978, 2078
.   : milestone, 2028,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 3.711 ms [3.49 ms, 3.932 ms] 2.239 ms (152.1%)
iast 2.204 ms [2.14 ms, 2.268 ms] 732.244 µs (49.7%)
iast_GLOBAL 2.25 ms [2.186 ms, 2.314 ms] 777.55 µs (52.8%)
profiling 2.056 ms [2.004 ms, 2.108 ms] 584.04 µs (39.7%)
tracing 2.025 ms [1.975 ms, 2.074 ms] 552.486 µs (37.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 3.641 ms [3.429 ms, 3.854 ms] 2.171 ms (147.6%)
iast 2.208 ms [2.144 ms, 2.272 ms] 737.174 µs (50.1%)
iast_GLOBAL 2.249 ms [2.185 ms, 2.313 ms] 777.82 µs (52.9%)
profiling 2.079 ms [2.026 ms, 2.132 ms] 608.271 µs (41.4%)
tracing 2.028 ms [1.978 ms, 2.078 ms] 557.598 µs (37.9%)

@dougqh dougqh changed the title Using singleSpanBuilder instead of buildSpan In JDBC instrumentation, use singleSpanBuilder instead of buildSpan Nov 11, 2025
mhlidd
mhlidd approved these changes Nov 11, 2025
View reviewed changes
internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentTracer.java
return buildSpan(DEFAULT_INSTRUMENTATION_NAME, spanName);
}

@Deprecated
Copy link
Contributor

@mhlidd mhlidd Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Should this method be marked as deprecated even though it was just introduced?

Copy link
Contributor Author

@dougqh dougqh Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's deliberate. Ideally, we want instrumentations to be setting instrumentation name, but I decided to handle that separately.

@dougqh dougqh merged commit 5db793a into master Nov 11, 2025
543 checks passed
@dougqh dougqh deleted the dougqh/jdbc-single-span-buider branch November 11, 2025 17:17
@github-actions github-actions bot added this to the 1.56.0 milestone Nov 11, 2025
@PerfectSlayer PerfectSlayer added the tag: performance Performance related changes label Nov 20, 2025
@PerfectSlayer PerfectSlayer changed the title In JDBC instrumentation, use singleSpanBuilder instead of buildSpan Migrate JDBC instrumentation to singleSpanBuilder Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhlidd mhlidd mhlidd approved these changes

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01 mtoffl01 is a code owner automatically assigned from DataDog/apm-sdk-capabilities-java

Assignees

No one assigned

Labels

comp: database Database Monitoring tag: performance Performance related changes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dougqh @mhlidd @PerfectSlayer