-
Notifications
You must be signed in to change notification settings - Fork 320
Apply critical patch for ddprof dependency. #9920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: ef64fc0 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~ef64fc061f, baseline=1.56.0-SNAPSHOT~d0b125896b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049104
Total [baseline] (10.661 s) : 0, 10661315
Agent [candidate] (1.066 s) : 0, 1065930
Total [candidate] (10.899 s) : 0, 10899236
section appsec
Agent [baseline] (1.225 s) : 0, 1224697
Total [baseline] (10.895 s) : 0, 10894710
Agent [candidate] (1.22 s) : 0, 1220488
Total [candidate] (10.896 s) : 0, 10895580
section iast
Agent [baseline] (1.192 s) : 0, 1191589
Total [baseline] (11.262 s) : 0, 11262118
Agent [candidate] (1.175 s) : 0, 1175268
Total [candidate] (11.172 s) : 0, 11172441
section profiling
Agent [baseline] (1.194 s) : 0, 1193664
Total [baseline] (10.921 s) : 0, 10921004
Agent [candidate] (1.195 s) : 0, 1195262
Total [candidate] (10.831 s) : 0, 10830545
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~ef64fc061f, baseline=1.56.0-SNAPSHOT~d0b125896b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.492 ms) : 0, 1492
BytebuddyAgent [baseline] (705.951 ms) : 0, 705951
BytebuddyAgent [candidate] (717.237 ms) : 0, 717237
GlobalTracer [baseline] (246.188 ms) : 0, 246188
GlobalTracer [candidate] (250.124 ms) : 0, 250124
AppSec [baseline] (32.432 ms) : 0, 32432
AppSec [candidate] (33.217 ms) : 0, 33217
Debugger [baseline] (6.363 ms) : 0, 6363
Debugger [candidate] (6.627 ms) : 0, 6627
Remote Config [baseline] (708.278 µs) : 0, 708
Remote Config [candidate] (739.07 µs) : 0, 739
Telemetry [baseline] (13.831 ms) : 0, 13831
Telemetry [candidate] (12.508 ms) : 0, 12508
Flare Poller [baseline] (7.293 ms) : 0, 7293
Flare Poller [candidate] (8.851 ms) : 0, 8851
section appsec
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (730.257 ms) : 0, 730257
BytebuddyAgent [candidate] (728.139 ms) : 0, 728139
GlobalTracer [baseline] (237.955 ms) : 0, 237955
GlobalTracer [candidate] (237.394 ms) : 0, 237394
IAST [baseline] (24.886 ms) : 0, 24886
IAST [candidate] (24.805 ms) : 0, 24805
AppSec [baseline] (175.92 ms) : 0, 175920
AppSec [candidate] (174.589 ms) : 0, 174589
Debugger [baseline] (6.006 ms) : 0, 6006
Debugger [candidate] (6.016 ms) : 0, 6016
Remote Config [baseline] (668.699 µs) : 0, 669
Remote Config [candidate] (652.428 µs) : 0, 652
Telemetry [baseline] (8.575 ms) : 0, 8575
Telemetry [candidate] (8.59 ms) : 0, 8590
Flare Poller [baseline] (4.02 ms) : 0, 4020
Flare Poller [candidate] (3.987 ms) : 0, 3987
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (836.317 ms) : 0, 836317
BytebuddyAgent [candidate] (825.327 ms) : 0, 825327
GlobalTracer [baseline] (237.251 ms) : 0, 237251
GlobalTracer [candidate] (234.052 ms) : 0, 234052
IAST [baseline] (33.096 ms) : 0, 33096
IAST [candidate] (34.986 ms) : 0, 34986
AppSec [baseline] (29.04 ms) : 0, 29040
AppSec [candidate] (25.905 ms) : 0, 25905
Debugger [baseline] (6.062 ms) : 0, 6062
Debugger [candidate] (6.015 ms) : 0, 6015
Remote Config [baseline] (612.463 µs) : 0, 612
Remote Config [candidate] (598.012 µs) : 0, 598
Telemetry [baseline] (8.624 ms) : 0, 8624
Telemetry [candidate] (8.224 ms) : 0, 8224
Flare Poller [baseline] (4.217 ms) : 0, 4217
Flare Poller [candidate] (4.136 ms) : 0, 4136
section profiling
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (729.243 ms) : 0, 729243
BytebuddyAgent [candidate] (730.158 ms) : 0, 730158
GlobalTracer [baseline] (221.823 ms) : 0, 221823
GlobalTracer [candidate] (222.505 ms) : 0, 222505
AppSec [baseline] (32.093 ms) : 0, 32093
AppSec [candidate] (32.202 ms) : 0, 32202
Debugger [baseline] (8.33 ms) : 0, 8330
Debugger [candidate] (8.251 ms) : 0, 8251
Remote Config [baseline] (694.356 µs) : 0, 694
Remote Config [candidate] (680.465 µs) : 0, 680
Telemetry [baseline] (14.74 ms) : 0, 14740
Telemetry [candidate] (14.608 ms) : 0, 14608
Flare Poller [baseline] (4.151 ms) : 0, 4151
Flare Poller [candidate] (4.134 ms) : 0, 4134
ProfilingAgent [baseline] (111.234 ms) : 0, 111234
ProfilingAgent [candidate] (111.226 ms) : 0, 111226
Profiling [baseline] (111.897 ms) : 0, 111897
Profiling [candidate] (111.876 ms) : 0, 111876
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~ef64fc061f, baseline=1.56.0-SNAPSHOT~d0b125896b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045327
Total [baseline] (8.651 s) : 0, 8650672
Agent [candidate] (1.051 s) : 0, 1050757
Total [candidate] (8.682 s) : 0, 8681621
section iast
Agent [baseline] (1.182 s) : 0, 1181688
Total [baseline] (9.269 s) : 0, 9269302
Agent [candidate] (1.181 s) : 0, 1180552
Total [candidate] (9.274 s) : 0, 9274391
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~ef64fc061f, baseline=1.56.0-SNAPSHOT~d0b125896b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (703.341 ms) : 0, 703341
BytebuddyAgent [candidate] (707.222 ms) : 0, 707222
GlobalTracer [baseline] (245.446 ms) : 0, 245446
GlobalTracer [candidate] (246.688 ms) : 0, 246688
AppSec [baseline] (32.343 ms) : 0, 32343
AppSec [candidate] (32.383 ms) : 0, 32383
Debugger [baseline] (6.367 ms) : 0, 6367
Debugger [candidate] (6.404 ms) : 0, 6404
Remote Config [baseline] (703.064 µs) : 0, 703
Remote Config [candidate] (705.366 µs) : 0, 705
Telemetry [baseline] (13.655 ms) : 0, 13655
Telemetry [candidate] (14.473 ms) : 0, 14473
Flare Poller [baseline] (7.275 ms) : 0, 7275
Flare Poller [candidate] (6.567 ms) : 0, 6567
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (829.859 ms) : 0, 829859
BytebuddyAgent [candidate] (829.342 ms) : 0, 829342
GlobalTracer [baseline] (234.968 ms) : 0, 234968
GlobalTracer [candidate] (234.658 ms) : 0, 234658
IAST [baseline] (31.53 ms) : 0, 31530
IAST [candidate] (34.283 ms) : 0, 34283
AppSec [baseline] (29.848 ms) : 0, 29848
AppSec [candidate] (26.98 ms) : 0, 26980
Debugger [baseline] (5.98 ms) : 0, 5980
Debugger [candidate] (5.945 ms) : 0, 5945
Remote Config [baseline] (598.55 µs) : 0, 599
Remote Config [candidate] (592.815 µs) : 0, 593
Telemetry [baseline] (8.415 ms) : 0, 8415
Telemetry [candidate] (8.333 ms) : 0, 8333
Flare Poller [baseline] (4.201 ms) : 0, 4201
Flare Poller [candidate] (4.142 ms) : 0, 4142
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~ef64fc061f, baseline=1.56.0-SNAPSHOT~d0b125896b
dateFormat X
axisFormat %s
section baseline
no_agent (1.192 ms) : 1180, 1204
. : milestone, 1192,
iast (3.277 ms) : 3235, 3319
. : milestone, 3277,
iast_FULL (5.989 ms) : 5929, 6050
. : milestone, 5989,
iast_GLOBAL (3.648 ms) : 3590, 3705
. : milestone, 3648,
profiling (1.971 ms) : 1955, 1988
. : milestone, 1971,
tracing (1.826 ms) : 1810, 1842
. : milestone, 1826,
section candidate
no_agent (1.202 ms) : 1190, 1214
. : milestone, 1202,
iast (3.146 ms) : 3107, 3186
. : milestone, 3146,
iast_FULL (5.733 ms) : 5676, 5791
. : milestone, 5733,
iast_GLOBAL (3.608 ms) : 3555, 3662
. : milestone, 3608,
profiling (2.166 ms) : 2146, 2186
. : milestone, 2166,
tracing (1.818 ms) : 1803, 1833
. : milestone, 1818,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~ef64fc061f, baseline=1.56.0-SNAPSHOT~d0b125896b
dateFormat X
axisFormat %s
section baseline
no_agent (19.31 ms) : 19113, 19508
. : milestone, 19310,
appsec (19.636 ms) : 19438, 19835
. : milestone, 19636,
code_origins (18.769 ms) : 18581, 18957
. : milestone, 18769,
iast (17.558 ms) : 17383, 17733
. : milestone, 17558,
profiling (18.801 ms) : 18612, 18991
. : milestone, 18801,
tracing (17.751 ms) : 17571, 17931
. : milestone, 17751,
section candidate
no_agent (19.103 ms) : 18906, 19299
. : milestone, 19103,
appsec (18.514 ms) : 18321, 18707
. : milestone, 18514,
code_origins (17.743 ms) : 17565, 17921
. : milestone, 17743,
iast (17.711 ms) : 17536, 17885
. : milestone, 17711,
profiling (19.412 ms) : 19216, 19607
. : milestone, 19412,
tracing (17.56 ms) : 17386, 17735
. : milestone, 17560,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~ef64fc061f, baseline=1.56.0-SNAPSHOT~d0b125896b
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.653 ms) : 3442, 3864
. : milestone, 3653,
iast (2.211 ms) : 2148, 2275
. : milestone, 2211,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.046 ms) : 1995, 2097
. : milestone, 2046,
tracing (2.028 ms) : 1979, 2078
. : milestone, 2028,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.509 ms) : 2456, 2563
. : milestone, 2509,
iast (2.215 ms) : 2151, 2279
. : milestone, 2215,
iast_GLOBAL (2.256 ms) : 2192, 2320
. : milestone, 2256,
profiling (2.038 ms) : 1987, 2089
. : milestone, 2038,
tracing (2.021 ms) : 1972, 2070
. : milestone, 2021,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~ef64fc061f, baseline=1.56.0-SNAPSHOT~d0b125896b
dateFormat X
axisFormat %s
section baseline
no_agent (14.759 s) : 14759000, 14759000
. : milestone, 14759000,
appsec (14.735 s) : 14735000, 14735000
. : milestone, 14735000,
iast (18.589 s) : 18589000, 18589000
. : milestone, 18589000,
iast_GLOBAL (17.961 s) : 17961000, 17961000
. : milestone, 17961000,
profiling (14.829 s) : 14829000, 14829000
. : milestone, 14829000,
tracing (14.715 s) : 14715000, 14715000
. : milestone, 14715000,
section candidate
no_agent (15.404 s) : 15404000, 15404000
. : milestone, 15404000,
appsec (15.131 s) : 15131000, 15131000
. : milestone, 15131000,
iast (18.609 s) : 18609000, 18609000
. : milestone, 18609000,
iast_GLOBAL (18.102 s) : 18102000, 18102000
. : milestone, 18102000,
profiling (15.857 s) : 15857000, 15857000
. : milestone, 15857000,
tracing (14.732 s) : 14732000, 14732000
. : milestone, 14732000,
|
Pull request was converted to draft
d41a67b to
c151c2c
Compare
Bump to version 1.34.3
c151c2c to
ef64fc0
Compare
What Does This Do
Bump to version 1.34.3
Motivation
In version 1.34.0 of ddprof-java we have a critical concurrency bug which can lead to crashes under heavy load.
We need to apply the fix ASAP and then backport it to dd-trace-java patch release.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-12970