Skip to content

Avoid early tasks realization when creating forkedTest task#9817

Merged
bric3 merged 3 commits intomasterfrom
bdu/forkedTest-unnecessary-check-if-empty
Nov 26, 2025
Merged

Avoid early tasks realization when creating forkedTest task#9817
bric3 merged 3 commits intomasterfrom
bdu/forkedTest-unnecessary-check-if-empty

Conversation

@bric3
Copy link
Copy Markdown
Contributor

@bric3 bric3 commented Oct 21, 2025 •
edited
Loading

What Does This Do

The check was asking gradle to find whether the project had any forkedTest test task. But this check is useless, because when it's done no forkedTest tasks has yet be created. No project actually register the forkedTest task. So let's configure it right away.

Also since it's a test task, this change explicitly indicates this task is using the JUnitPlatform.

Motivation

Additional Notes

Follow-up fix:

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Oct 21, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/forkedTest-unnecessary-check-if-empty
git_commit_date 1764082412 1764173546
git_commit_sha 6bbe053 9786a6c
release_version 1.57.0-SNAPSHOT~6bbe0531a7 1.57.0-SNAPSHOT~9786a6cc17
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1764175409 1764175409
ci_job_id 1258802755 1258802755
ci_pipeline_id 84135495 84135495
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-es6bpeu4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-es6bpeu4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~9786a6cc17, baseline=1.57.0-SNAPSHOT~6bbe0531a7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052087
Total [baseline] (10.728 s) : 0, 10728437
Agent [candidate] (1.053 s) : 0, 1052575
Total [candidate] (10.797 s) : 0, 10797268
section appsec
Agent [baseline] (1.225 s) : 0, 1225394
Total [baseline] (10.953 s) : 0, 10952724
Agent [candidate] (1.223 s) : 0, 1222719
Total [candidate] (10.833 s) : 0, 10832805
section iast
Agent [baseline] (1.199 s) : 0, 1199223
Total [baseline] (11.237 s) : 0, 11237000
Agent [candidate] (1.191 s) : 0, 1191470
Total [candidate] (11.241 s) : 0, 11241040
section profiling
Agent [baseline] (1.208 s) : 0, 1207743
Total [baseline] (10.891 s) : 0, 10891344
Agent [candidate] (1.199 s) : 0, 1199215
Total [candidate] (10.934 s) : 0, 10934383
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.225 s 173.307 ms (16.5%)
Agent iast 1.199 s 147.137 ms (14.0%)
Agent profiling 1.208 s 155.656 ms (14.8%)
Total tracing 10.728 s -
Total appsec 10.953 s 224.287 ms (2.1%)
Total iast 11.237 s 508.563 ms (4.7%)
Total profiling 10.891 s 162.907 ms (1.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent appsec 1.223 s 170.144 ms (16.2%)
Agent iast 1.191 s 138.895 ms (13.2%)
Agent profiling 1.199 s 146.64 ms (13.9%)
Total tracing 10.797 s -
Total appsec 10.833 s 35.537 ms (0.3%)
Total iast 11.241 s 443.772 ms (4.1%)
Total profiling 10.934 s 137.115 ms (1.3%) 
gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~9786a6cc17, baseline=1.57.0-SNAPSHOT~6bbe0531a7

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (707.024 ms) : 0, 707024
BytebuddyAgent [candidate] (707.598 ms) : 0, 707598
GlobalTracer [baseline] (248.889 ms) : 0, 248889
GlobalTracer [candidate] (249.129 ms) : 0, 249129
AppSec [baseline] (32.14 ms) : 0, 32140
AppSec [candidate] (32.136 ms) : 0, 32136
Debugger [baseline] (6.402 ms) : 0, 6402
Debugger [candidate] (6.393 ms) : 0, 6393
Remote Config [baseline] (696.345 µs) : 0, 696
Remote Config [candidate] (674.688 µs) : 0, 675
Telemetry [baseline] (15.74 ms) : 0, 15740
Telemetry [candidate] (15.516 ms) : 0, 15516
Flare Poller [baseline] (4.924 ms) : 0, 4924
Flare Poller [candidate] (4.877 ms) : 0, 4877
section appsec
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (729.898 ms) : 0, 729898
BytebuddyAgent [candidate] (729.241 ms) : 0, 729241
GlobalTracer [baseline] (240.24 ms) : 0, 240240
GlobalTracer [candidate] (239.488 ms) : 0, 239488
AppSec [baseline] (175.063 ms) : 0, 175063
AppSec [candidate] (173.975 ms) : 0, 173975
Debugger [baseline] (6.294 ms) : 0, 6294
Debugger [candidate] (6.261 ms) : 0, 6261
Remote Config [baseline] (694.892 µs) : 0, 695
Remote Config [candidate] (677.792 µs) : 0, 678
Telemetry [baseline] (8.14 ms) : 0, 8140
Telemetry [candidate] (8.073 ms) : 0, 8073
Flare Poller [baseline] (3.996 ms) : 0, 3996
Flare Poller [candidate] (3.917 ms) : 0, 3917
IAST [baseline] (24.631 ms) : 0, 24631
IAST [candidate] (24.707 ms) : 0, 24707
section iast
crashtracking [baseline] (1.502 ms) : 0, 1502
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (837.244 ms) : 0, 837244
BytebuddyAgent [candidate] (830.604 ms) : 0, 830604
GlobalTracer [baseline] (238.653 ms) : 0, 238653
GlobalTracer [candidate] (237.253 ms) : 0, 237253
AppSec [baseline] (29.741 ms) : 0, 29741
AppSec [candidate] (30.037 ms) : 0, 30037
Debugger [baseline] (6.039 ms) : 0, 6039
Debugger [candidate] (6.06 ms) : 0, 6060
Remote Config [baseline] (603.837 µs) : 0, 604
Remote Config [candidate] (617.932 µs) : 0, 618
Telemetry [baseline] (7.939 ms) : 0, 7939
Telemetry [candidate] (8.025 ms) : 0, 8025
Flare Poller [baseline] (10.701 ms) : 0, 10701
Flare Poller [candidate] (10.929 ms) : 0, 10929
IAST [baseline] (31.824 ms) : 0, 31824
IAST [candidate] (31.667 ms) : 0, 31667
section profiling
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (740.237 ms) : 0, 740237
BytebuddyAgent [candidate] (734.888 ms) : 0, 734888
GlobalTracer [baseline] (224.216 ms) : 0, 224216
GlobalTracer [candidate] (222.943 ms) : 0, 222943
AppSec [baseline] (32.424 ms) : 0, 32424
AppSec [candidate] (32.091 ms) : 0, 32091
Debugger [baseline] (6.882 ms) : 0, 6882
Debugger [candidate] (7.555 ms) : 0, 7555
Remote Config [baseline] (711.567 µs) : 0, 712
Remote Config [candidate] (707.032 µs) : 0, 707
Telemetry [baseline] (16.406 ms) : 0, 16406
Telemetry [candidate] (15.5 ms) : 0, 15500
Flare Poller [baseline] (4.218 ms) : 0, 4218
Flare Poller [candidate] (4.115 ms) : 0, 4115
ProfilingAgent [baseline] (111.576 ms) : 0, 111576
ProfilingAgent [candidate] (110.858 ms) : 0, 110858
Profiling [baseline] (112.236 ms) : 0, 112236
Profiling [candidate] (111.497 ms) : 0, 111497
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~9786a6cc17, baseline=1.57.0-SNAPSHOT~6bbe0531a7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051704
Total [baseline] (8.683 s) : 0, 8683118
Agent [candidate] (1.049 s) : 0, 1048805
Total [candidate] (8.706 s) : 0, 8706239
section iast
Agent [baseline] (1.19 s) : 0, 1189924
Total [baseline] (9.3 s) : 0, 9300388
Agent [candidate] (1.189 s) : 0, 1188787
Total [candidate] (9.331 s) : 0, 9330910
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.19 s 138.22 ms (13.1%)
Total tracing 8.683 s -
Total iast 9.3 s 617.271 ms (7.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.189 s 139.982 ms (13.3%)
Total tracing 8.706 s -
Total iast 9.331 s 624.671 ms (7.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~9786a6cc17, baseline=1.57.0-SNAPSHOT~6bbe0531a7

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.495 ms) : 0, 1495
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (707.115 ms) : 0, 707115
BytebuddyAgent [candidate] (705.725 ms) : 0, 705725
GlobalTracer [baseline] (248.44 ms) : 0, 248440
GlobalTracer [candidate] (247.833 ms) : 0, 247833
AppSec [baseline] (31.957 ms) : 0, 31957
AppSec [candidate] (31.9 ms) : 0, 31900
Debugger [baseline] (6.429 ms) : 0, 6429
Debugger [candidate] (6.373 ms) : 0, 6373
Remote Config [baseline] (694.551 µs) : 0, 695
Remote Config [candidate] (664.033 µs) : 0, 664
Telemetry [baseline] (14.844 ms) : 0, 14844
Telemetry [candidate] (14.592 ms) : 0, 14592
Flare Poller [baseline] (5.674 ms) : 0, 5674
Flare Poller [candidate] (5.468 ms) : 0, 5468
section iast
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (829.557 ms) : 0, 829557
BytebuddyAgent [candidate] (829.12 ms) : 0, 829120
GlobalTracer [baseline] (236.934 ms) : 0, 236934
GlobalTracer [candidate] (236.764 ms) : 0, 236764
AppSec [baseline] (31.353 ms) : 0, 31353
AppSec [candidate] (28.626 ms) : 0, 28626
Debugger [baseline] (6.036 ms) : 0, 6036
Debugger [candidate] (5.989 ms) : 0, 5989
Remote Config [baseline] (609.956 µs) : 0, 610
Remote Config [candidate] (601.4 µs) : 0, 601
Telemetry [baseline] (7.998 ms) : 0, 7998
Telemetry [candidate] (7.83 ms) : 0, 7830
Flare Poller [baseline] (10.9 ms) : 0, 10900
Flare Poller [candidate] (10.683 ms) : 0, 10683
IAST [baseline] (30.195 ms) : 0, 30195
IAST [candidate] (32.833 ms) : 0, 32833
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/forkedTest-unnecessary-check-if-empty
git_commit_date 1764082412 1764173546
git_commit_sha 6bbe053 9786a6c
release_version 1.57.0-SNAPSHOT~6bbe0531a7 1.57.0-SNAPSHOT~9786a6cc17
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1764175898 1764175898
ci_job_id 1258802756 1258802756
ci_pipeline_id 84135495 84135495
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-96bql68a 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-96bql68a 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:petclinic:tracing:high_load better
[-1.574ms; -0.549ms] or [-8.602%; -3.000%]		 unsure
[-1.831ms; -0.365ms] or [-6.169%; -1.230%]		 unstable
[-13.016op/s; +40.704op/s] or [-5.182%; +16.205%]		 17.234ms 28.575ms 265.031op/s 18.295ms 29.673ms 251.188op/s
scenario:load:petclinic:iast:high_load better
[-1.582ms; -0.656ms] or [-8.693%; -3.603%]		 better
[-3.143ms; -1.448ms] or [-10.354%; -4.771%]		 unstable
[-9.588op/s; +44.213op/s] or [-3.835%; +17.683%]		 17.085ms 28.058ms 267.344op/s 18.204ms 30.354ms 250.031op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~9786a6cc17, baseline=1.57.0-SNAPSHOT~6bbe0531a7
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.616 ms) : 19408, 19824
.   : milestone, 19616,
appsec (18.43 ms) : 18243, 18618
.   : milestone, 18430,
code_origins (17.552 ms) : 17379, 17726
.   : milestone, 17552,
iast (18.667 ms) : 18471, 18863
.   : milestone, 18667,
profiling (18.335 ms) : 18155, 18515
.   : milestone, 18335,
tracing (18.579 ms) : 18391, 18767
.   : milestone, 18579,
section candidate
no_agent (18.108 ms) : 17922, 18295
.   : milestone, 18108,
appsec (18.606 ms) : 18418, 18794
.   : milestone, 18606,
code_origins (17.724 ms) : 17551, 17897
.   : milestone, 17724,
iast (17.454 ms) : 17281, 17626
.   : milestone, 17454,
profiling (18.367 ms) : 18180, 18554
.   : milestone, 18367,
tracing (17.604 ms) : 17427, 17780
.   : milestone, 17604,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.616 ms [19.408 ms, 19.824 ms] -
appsec 18.43 ms [18.243 ms, 18.618 ms] -1.186 ms (-6.0%)
code_origins 17.552 ms [17.379 ms, 17.726 ms] -2.064 ms (-10.5%)
iast 18.667 ms [18.471 ms, 18.863 ms] -948.775 µs (-4.8%)
profiling 18.335 ms [18.155 ms, 18.515 ms] -1.281 ms (-6.5%)
tracing 18.579 ms [18.391 ms, 18.767 ms] -1.037 ms (-5.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.108 ms [17.922 ms, 18.295 ms] -
appsec 18.606 ms [18.418 ms, 18.794 ms] 497.674 µs (2.7%)
code_origins 17.724 ms [17.551 ms, 17.897 ms] -384.281 µs (-2.1%)
iast 17.454 ms [17.281 ms, 17.626 ms] -654.716 µs (-3.6%)
profiling 18.367 ms [18.18 ms, 18.554 ms] 258.523 µs (1.4%)
tracing 17.604 ms [17.427 ms, 17.78 ms] -504.637 µs (-2.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~9786a6cc17, baseline=1.57.0-SNAPSHOT~6bbe0531a7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.195 ms) : 1183, 1206
.   : milestone, 1195,
iast (3.169 ms) : 3129, 3208
.   : milestone, 3169,
iast_FULL (5.998 ms) : 5936, 6059
.   : milestone, 5998,
iast_GLOBAL (3.451 ms) : 3402, 3499
.   : milestone, 3451,
profiling (2.136 ms) : 2117, 2156
.   : milestone, 2136,
tracing (1.834 ms) : 1818, 1850
.   : milestone, 1834,
section candidate
no_agent (1.2 ms) : 1188, 1212
.   : milestone, 1200,
iast (3.243 ms) : 3203, 3283
.   : milestone, 3243,
iast_FULL (5.822 ms) : 5764, 5879
.   : milestone, 5822,
iast_GLOBAL (3.579 ms) : 3515, 3643
.   : milestone, 3579,
profiling (1.932 ms) : 1916, 1948
.   : milestone, 1932,
tracing (1.843 ms) : 1828, 1858
.   : milestone, 1843,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.195 ms [1.183 ms, 1.206 ms] -
iast 3.169 ms [3.129 ms, 3.208 ms] 1.974 ms (165.2%)
iast_FULL 5.998 ms [5.936 ms, 6.059 ms] 4.803 ms (402.0%)
iast_GLOBAL 3.451 ms [3.402 ms, 3.499 ms] 2.256 ms (188.8%)
profiling 2.136 ms [2.117 ms, 2.156 ms] 941.496 µs (78.8%)
tracing 1.834 ms [1.818 ms, 1.85 ms] 639.311 µs (53.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.2 ms [1.188 ms, 1.212 ms] -
iast 3.243 ms [3.203 ms, 3.283 ms] 2.043 ms (170.2%)
iast_FULL 5.822 ms [5.764 ms, 5.879 ms] 4.622 ms (385.1%)
iast_GLOBAL 3.579 ms [3.515 ms, 3.643 ms] 2.379 ms (198.2%)
profiling 1.932 ms [1.916 ms, 1.948 ms] 731.98 µs (61.0%)
tracing 1.843 ms [1.828 ms, 1.858 ms] 642.766 µs (53.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/forkedTest-unnecessary-check-if-empty
git_commit_date 1764082412 1764173546
git_commit_sha 6bbe053 9786a6c
release_version 1.57.0-SNAPSHOT~6bbe0531a7 1.57.0-SNAPSHOT~9786a6cc17
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1764175539 1764175539
ci_job_id 1258802757 1258802757
ci_pipeline_id 84135495 84135495
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-zhk7wmt7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-zhk7wmt7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~9786a6cc17, baseline=1.57.0-SNAPSHOT~6bbe0531a7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.451 ms) : 2399, 2502
.   : milestone, 2451,
iast (2.2 ms) : 2135, 2264
.   : milestone, 2200,
iast_GLOBAL (2.249 ms) : 2185, 2314
.   : milestone, 2249,
profiling (2.078 ms) : 2024, 2131
.   : milestone, 2078,
tracing (2.038 ms) : 1987, 2088
.   : milestone, 2038,
section candidate
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.459 ms) : 2408, 2511
.   : milestone, 2459,
iast (2.214 ms) : 2149, 2278
.   : milestone, 2214,
iast_GLOBAL (2.251 ms) : 2186, 2316
.   : milestone, 2251,
profiling (2.057 ms) : 2005, 2109
.   : milestone, 2057,
tracing (2.042 ms) : 1991, 2093
.   : milestone, 2042,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.451 ms [2.399 ms, 2.502 ms] 977.31 µs (66.3%)
iast 2.2 ms [2.135 ms, 2.264 ms] 726.262 µs (49.3%)
iast_GLOBAL 2.249 ms [2.185 ms, 2.314 ms] 775.964 µs (52.7%)
profiling 2.078 ms [2.024 ms, 2.131 ms] 604.294 µs (41.0%)
tracing 2.038 ms [1.987 ms, 2.088 ms] 564.277 µs (38.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 2.459 ms [2.408 ms, 2.511 ms] 984.682 µs (66.8%)
iast 2.214 ms [2.149 ms, 2.278 ms] 739.151 µs (50.1%)
iast_GLOBAL 2.251 ms [2.186 ms, 2.316 ms] 776.46 µs (52.7%)
profiling 2.057 ms [2.005 ms, 2.109 ms] 582.413 µs (39.5%)
tracing 2.042 ms [1.991 ms, 2.093 ms] 567.619 µs (38.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~9786a6cc17, baseline=1.57.0-SNAPSHOT~6bbe0531a7
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.05 s) : 15050000, 15050000
.   : milestone, 15050000,
appsec (15.067 s) : 15067000, 15067000
.   : milestone, 15067000,
iast (18.435 s) : 18435000, 18435000
.   : milestone, 18435000,
iast_GLOBAL (18.009 s) : 18009000, 18009000
.   : milestone, 18009000,
profiling (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,
tracing (14.808 s) : 14808000, 14808000
.   : milestone, 14808000,
section candidate
no_agent (15.296 s) : 15296000, 15296000
.   : milestone, 15296000,
appsec (14.566 s) : 14566000, 14566000
.   : milestone, 14566000,
iast (18.595 s) : 18595000, 18595000
.   : milestone, 18595000,
iast_GLOBAL (17.961 s) : 17961000, 17961000
.   : milestone, 17961000,
profiling (14.565 s) : 14565000, 14565000
.   : milestone, 14565000,
tracing (14.607 s) : 14607000, 14607000
.   : milestone, 14607000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.05 s [15.05 s, 15.05 s] -
appsec 15.067 s [15.067 s, 15.067 s] 17.0 ms (0.1%)
iast 18.435 s [18.435 s, 18.435 s] 3.385 s (22.5%)
iast_GLOBAL 18.009 s [18.009 s, 18.009 s] 2.959 s (19.7%)
profiling 15.242 s [15.242 s, 15.242 s] 192.0 ms (1.3%)
tracing 14.808 s [14.808 s, 14.808 s] -242.0 ms (-1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.296 s [15.296 s, 15.296 s] -
appsec 14.566 s [14.566 s, 14.566 s] -730.0 ms (-4.8%)
iast 18.595 s [18.595 s, 18.595 s] 3.299 s (21.6%)
iast_GLOBAL 17.961 s [17.961 s, 17.961 s] 2.665 s (17.4%)
profiling 14.565 s [14.565 s, 14.565 s] -731.0 ms (-4.8%)
tracing 14.607 s [14.607 s, 14.607 s] -689.0 ms (-4.5%)

@bric3 bric3 force-pushed the bdu/forkedTest-unnecessary-check-if-empty branch from 0a42e0e to 497a935 Compare November 25, 2025 15:19
@bric3 bric3 marked this pull request as ready for review November 26, 2025 17:04
@bric3 bric3 requested a review from a team as a code owner November 26, 2025 17:04
@bric3 bric3 requested a review from smola November 26, 2025 17:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 26, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

bric3
bric3 commented Nov 26, 2025
View reviewed changes
Comment thread dd-smoke-tests/osgi/build.gradle

plugins {
id 'biz.aQute.bnd.builder' version '6.1.0' apply true
id 'biz.aQute.bnd.builder' version '6.4.0' apply true
Copy link
Copy Markdown
Contributor Author

@bric3 bric3 Nov 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: bnd gradle plugin 6.1 was modifying the configurations after they were made immutable by Gradle. EDIT: this is incorrect, and the underlying issue is fixed in #10039

Can't update to 7.x as it requires a JDK 17

Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put a TODO here, since we are close to update JDK for Gradle?

Copy link
Copy Markdown
Contributor Author

@bric3 bric3 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's write that in the gdoc instead

@bric3 bric3 added type: enhancement Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Nov 26, 2025
@bric3 bric3 requested a review from sarahchen6 November 26, 2025 17:06
@bric3 bric3 enabled auto-merge (squash) November 26, 2025 17:15
AlexeyKuznetsov-DD
AlexeyKuznetsov-DD approved these changes Nov 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left 2 minor comments

Comment thread dd-smoke-tests/osgi/build.gradle

plugins {
id 'biz.aQute.bnd.builder' version '6.1.0' apply true
id 'biz.aQute.bnd.builder' version '6.4.0' apply true
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put a TODO here, since we are close to update JDK for Gradle?

Comment thread gradle/java_no_deps.gradle
Comment on lines +127 to +129
tasks.register('forkedTest', Test) {
group = LifecycleBasePlugin.VERIFICATION_GROUP
useJUnitPlatform()
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I understand correctly, but PR descriptions is "Remove unneeded configuration", and here you added...
Probably you need to update PR description?

Copy link
Copy Markdown
Contributor Author

@bric3 bric3 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rename the PR name.

@bric3 bric3 merged commit 497bd13 into master Nov 26, 2025
543 of 545 checks passed
@bric3 bric3 deleted the bdu/forkedTest-unnecessary-check-if-empty branch November 26, 2025 18:41
@github-actions github-actions Bot added this to the 1.57.0 milestone Nov 26, 2025
AlexeyKuznetsov-DD
AlexeyKuznetsov-DD reviewed Nov 26, 2025
View reviewed changes
Comment thread dd-smoke-tests/osgi/build.gradle
attributes('Bundle-Activator': 'datadog.smoketest.osgi.client.Activator')
}
}
clientBundle.get()
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: what this line is doing?

Copy link
Copy Markdown
Contributor Author

@bric3 bric3 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, that's wrong. proper fix should be here :

@bric3 bric3 mentioned this pull request Nov 26, 2025
Merged
@bric3 bric3 changed the title Removes unneeded task configuration for forkedTest Avoid early tasks realization when creating forkedTest task Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

@sarahchen6 sarahchen6 Awaiting requested review from sarahchen6

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.57.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bric3 @AlexeyKuznetsov-DD