-
Notifications
You must be signed in to change notification settings - Fork 320
Protect intercepted null traces from NPE #9797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d9460ed to
6a43331
Compare
|
🎯 Code Coverage 🔗 Commit SHA: c43d227 | Docs | Was this helpful? Give us feedback! |
c2e5178 to
268429d
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~c43d2277f9, baseline=1.55.0-SNAPSHOT~2e46666c2f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018022
Total [baseline] (8.659 s) : 0, 8658737
Agent [candidate] (1.016 s) : 0, 1015963
Total [candidate] (8.656 s) : 0, 8656245
section iast
Agent [baseline] (1.165 s) : 0, 1165460
Total [baseline] (9.35 s) : 0, 9349676
Agent [candidate] (1.153 s) : 0, 1152726
Total [candidate] (9.288 s) : 0, 9287884
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~c43d2277f9, baseline=1.55.0-SNAPSHOT~2e46666c2f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (693.352 ms) : 0, 693352
BytebuddyAgent [candidate] (692.613 ms) : 0, 692613
GlobalTracer [baseline] (242.74 ms) : 0, 242740
GlobalTracer [candidate] (242.992 ms) : 0, 242992
AppSec [baseline] (32.072 ms) : 0, 32072
AppSec [candidate] (32.141 ms) : 0, 32141
Debugger [baseline] (6.285 ms) : 0, 6285
Debugger [candidate] (6.26 ms) : 0, 6260
Remote Config [baseline] (681.949 µs) : 0, 682
Remote Config [candidate] (668.887 µs) : 0, 669
Telemetry [baseline] (9.337 ms) : 0, 9337
Telemetry [candidate] (9.224 ms) : 0, 9224
Flare Poller [baseline] (10.937 ms) : 0, 10937
Flare Poller [candidate] (9.638 ms) : 0, 9638
section iast
crashtracking [baseline] (1.5 ms) : 0, 1500
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (825.823 ms) : 0, 825823
BytebuddyAgent [candidate] (816.043 ms) : 0, 816043
GlobalTracer [baseline] (233.659 ms) : 0, 233659
GlobalTracer [candidate] (232.097 ms) : 0, 232097
AppSec [baseline] (35.564 ms) : 0, 35564
AppSec [candidate] (35.121 ms) : 0, 35121
Debugger [baseline] (6.251 ms) : 0, 6251
Debugger [candidate] (6.168 ms) : 0, 6168
Remote Config [baseline] (621.683 µs) : 0, 622
Remote Config [candidate] (602.757 µs) : 0, 603
Telemetry [baseline] (8.799 ms) : 0, 8799
Telemetry [candidate] (8.782 ms) : 0, 8782
Flare Poller [baseline] (4.378 ms) : 0, 4378
Flare Poller [candidate] (4.283 ms) : 0, 4283
IAST [baseline] (27.208 ms) : 0, 27208
IAST [candidate] (26.741 ms) : 0, 26741
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~c43d2277f9, baseline=1.55.0-SNAPSHOT~2e46666c2f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1030253
Total [baseline] (10.853 s) : 0, 10853032
Agent [candidate] (1.021 s) : 0, 1021065
Total [candidate] (10.787 s) : 0, 10787014
section appsec
Agent [baseline] (1.194 s) : 0, 1194120
Total [baseline] (10.834 s) : 0, 10834345
Agent [candidate] (1.196 s) : 0, 1195989
Total [candidate] (10.842 s) : 0, 10841714
section iast
Agent [baseline] (1.154 s) : 0, 1154187
Total [baseline] (11.128 s) : 0, 11128194
Agent [candidate] (1.155 s) : 0, 1155215
Total [candidate] (11.07 s) : 0, 11070143
section profiling
Agent [baseline] (1.163 s) : 0, 1163138
Total [baseline] (10.847 s) : 0, 10846508
Agent [candidate] (1.167 s) : 0, 1166772
Total [candidate] (10.87 s) : 0, 10869803
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~c43d2277f9, baseline=1.55.0-SNAPSHOT~2e46666c2f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (703.087 ms) : 0, 703087
BytebuddyAgent [candidate] (695.497 ms) : 0, 695497
GlobalTracer [baseline] (244.232 ms) : 0, 244232
GlobalTracer [candidate] (243.914 ms) : 0, 243914
AppSec [baseline] (32.7 ms) : 0, 32700
AppSec [candidate] (32.338 ms) : 0, 32338
Debugger [baseline] (6.358 ms) : 0, 6358
Debugger [candidate] (6.334 ms) : 0, 6334
Remote Config [baseline] (687.73 µs) : 0, 688
Remote Config [candidate] (671.448 µs) : 0, 671
Telemetry [baseline] (9.364 ms) : 0, 9364
Telemetry [candidate] (9.41 ms) : 0, 9410
Flare Poller [baseline] (10.942 ms) : 0, 10942
Flare Poller [candidate] (10.277 ms) : 0, 10277
section appsec
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (718.151 ms) : 0, 718151
BytebuddyAgent [candidate] (719.674 ms) : 0, 719674
GlobalTracer [baseline] (234.505 ms) : 0, 234505
GlobalTracer [candidate] (235.16 ms) : 0, 235160
AppSec [baseline] (174.814 ms) : 0, 174814
AppSec [candidate] (174.612 ms) : 0, 174612
Debugger [baseline] (6.07 ms) : 0, 6070
Debugger [candidate] (6.089 ms) : 0, 6089
Remote Config [baseline] (632.911 µs) : 0, 633
Remote Config [candidate] (628.733 µs) : 0, 629
Telemetry [baseline] (8.523 ms) : 0, 8523
Telemetry [candidate] (8.566 ms) : 0, 8566
Flare Poller [baseline] (3.868 ms) : 0, 3868
Flare Poller [candidate] (3.901 ms) : 0, 3901
IAST [baseline] (24.871 ms) : 0, 24871
IAST [candidate] (24.804 ms) : 0, 24804
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (817.394 ms) : 0, 817394
BytebuddyAgent [candidate] (819.169 ms) : 0, 819169
GlobalTracer [baseline] (232.036 ms) : 0, 232036
GlobalTracer [candidate] (231.888 ms) : 0, 231888
AppSec [baseline] (35.326 ms) : 0, 35326
AppSec [candidate] (34.854 ms) : 0, 34854
Debugger [baseline] (6.119 ms) : 0, 6119
Debugger [candidate] (6.091 ms) : 0, 6091
Remote Config [baseline] (602.691 µs) : 0, 603
Remote Config [candidate] (598.349 µs) : 0, 598
Telemetry [baseline] (8.672 ms) : 0, 8672
Telemetry [candidate] (8.798 ms) : 0, 8798
Flare Poller [baseline] (4.278 ms) : 0, 4278
Flare Poller [candidate] (4.241 ms) : 0, 4241
IAST [baseline] (26.731 ms) : 0, 26731
IAST [candidate] (26.654 ms) : 0, 26654
section profiling
ProfilingAgent [baseline] (109.402 ms) : 0, 109402
ProfilingAgent [candidate] (109.69 ms) : 0, 109690
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (719.72 ms) : 0, 719720
BytebuddyAgent [candidate] (722.112 ms) : 0, 722112
GlobalTracer [baseline] (219.072 ms) : 0, 219072
GlobalTracer [candidate] (219.528 ms) : 0, 219528
AppSec [baseline] (32.226 ms) : 0, 32226
AppSec [candidate] (32.411 ms) : 0, 32411
Debugger [baseline] (7.448 ms) : 0, 7448
Debugger [candidate] (7.461 ms) : 0, 7461
Remote Config [baseline] (700.771 µs) : 0, 701
Remote Config [candidate] (702.165 µs) : 0, 702
Telemetry [baseline] (15.236 ms) : 0, 15236
Telemetry [candidate] (13.815 ms) : 0, 13815
Flare Poller [baseline] (4.108 ms) : 0, 4108
Flare Poller [candidate] (5.759 ms) : 0, 5759
Profiling [baseline] (110.049 ms) : 0, 110049
Profiling [candidate] (110.346 ms) : 0, 110346
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~c43d2277f9, baseline=1.55.0-SNAPSHOT~2e46666c2f
dateFormat X
axisFormat %s
section baseline
no_agent (4.473 ms) : 4422, 4524
. : milestone, 4473,
iast (9.749 ms) : 9587, 9911
. : milestone, 9749,
iast_FULL (13.879 ms) : 13600, 14158
. : milestone, 13879,
iast_GLOBAL (10.622 ms) : 10436, 10808
. : milestone, 10622,
profiling (8.783 ms) : 8646, 8921
. : milestone, 8783,
tracing (8.25 ms) : 8129, 8371
. : milestone, 8250,
section candidate
no_agent (4.234 ms) : 4180, 4289
. : milestone, 4234,
iast (9.578 ms) : 9417, 9739
. : milestone, 9578,
iast_FULL (13.863 ms) : 13585, 14140
. : milestone, 13863,
iast_GLOBAL (10.879 ms) : 10688, 11071
. : milestone, 10879,
profiling (8.965 ms) : 8805, 9125
. : milestone, 8965,
tracing (7.883 ms) : 7772, 7994
. : milestone, 7883,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~c43d2277f9, baseline=1.55.0-SNAPSHOT~2e46666c2f
dateFormat X
axisFormat %s
section baseline
no_agent (36.391 ms) : 36105, 36677
. : milestone, 36391,
appsec (48.806 ms) : 48387, 49224
. : milestone, 48806,
code_origins (43.872 ms) : 43491, 44252
. : milestone, 43872,
iast (43.529 ms) : 43151, 43906
. : milestone, 43529,
profiling (49.464 ms) : 48981, 49946
. : milestone, 49464,
tracing (45.016 ms) : 44629, 45404
. : milestone, 45016,
section candidate
no_agent (36.76 ms) : 36462, 37057
. : milestone, 36760,
appsec (47.89 ms) : 47445, 48336
. : milestone, 47890,
code_origins (43.746 ms) : 43377, 44114
. : milestone, 43746,
iast (44.961 ms) : 44570, 45353
. : milestone, 44961,
profiling (46.982 ms) : 46523, 47440
. : milestone, 46982,
tracing (42.493 ms) : 42126, 42860
. : milestone, 42493,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~c43d2277f9, baseline=1.55.0-SNAPSHOT~2e46666c2f
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1478, 1501
. : milestone, 1489,
appsec (3.666 ms) : 3453, 3879
. : milestone, 3666,
iast (2.223 ms) : 2159, 2286
. : milestone, 2223,
iast_GLOBAL (2.268 ms) : 2204, 2332
. : milestone, 2268,
profiling (2.077 ms) : 2024, 2130
. : milestone, 2077,
tracing (2.033 ms) : 1983, 2082
. : milestone, 2033,
section candidate
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.677 ms) : 3464, 3890
. : milestone, 3677,
iast (2.218 ms) : 2154, 2281
. : milestone, 2218,
iast_GLOBAL (2.266 ms) : 2202, 2330
. : milestone, 2266,
profiling (2.063 ms) : 2012, 2115
. : milestone, 2063,
tracing (2.041 ms) : 1991, 2091
. : milestone, 2041,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~c43d2277f9, baseline=1.55.0-SNAPSHOT~2e46666c2f
dateFormat X
axisFormat %s
section baseline
no_agent (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
appsec (14.905 s) : 14905000, 14905000
. : milestone, 14905000,
iast (18.799 s) : 18799000, 18799000
. : milestone, 18799000,
iast_GLOBAL (17.886 s) : 17886000, 17886000
. : milestone, 17886000,
profiling (15.253 s) : 15253000, 15253000
. : milestone, 15253000,
tracing (15.169 s) : 15169000, 15169000
. : milestone, 15169000,
section candidate
no_agent (15.371 s) : 15371000, 15371000
. : milestone, 15371000,
appsec (14.84 s) : 14840000, 14840000
. : milestone, 14840000,
iast (18.777 s) : 18777000, 18777000
. : milestone, 18777000,
iast_GLOBAL (18.06 s) : 18060000, 18060000
. : milestone, 18060000,
profiling (14.775 s) : 14775000, 14775000
. : milestone, 14775000,
tracing (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
|
What Does This Do
If a customer is making an interceptor returning
nullit will make our writer breaking for a NPE. This PR protect the access to the returned trace if null, replacing with a empty oneMotivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]