-
Notifications
You must be signed in to change notification settings - Fork 320
Safely set context classloader on final blocks #9795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 09e53f1 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~09e53f1d91, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019424
Total [baseline] (8.665 s) : 0, 8665187
Agent [candidate] (1.019 s) : 0, 1019436
Total [candidate] (8.667 s) : 0, 8667409
section iast
Agent [baseline] (1.149 s) : 0, 1149390
Total [baseline] (9.302 s) : 0, 9301677
Agent [candidate] (1.15 s) : 0, 1150003
Total [candidate] (9.296 s) : 0, 9296135
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~09e53f1d91, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (695.666 ms) : 0, 695666
BytebuddyAgent [candidate] (694.385 ms) : 0, 694385
GlobalTracer [baseline] (243.389 ms) : 0, 243389
GlobalTracer [candidate] (243.081 ms) : 0, 243081
AppSec [baseline] (32.496 ms) : 0, 32496
AppSec [candidate] (32.282 ms) : 0, 32282
Debugger [baseline] (6.342 ms) : 0, 6342
Debugger [candidate] (6.291 ms) : 0, 6291
Remote Config [baseline] (677.196 µs) : 0, 677
Remote Config [candidate] (674.803 µs) : 0, 675
Telemetry [baseline] (9.373 ms) : 0, 9373
Telemetry [candidate] (9.353 ms) : 0, 9353
Flare Poller [baseline] (8.821 ms) : 0, 8821
Flare Poller [candidate] (10.823 ms) : 0, 10823
section iast
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (814.152 ms) : 0, 814152
BytebuddyAgent [candidate] (814.231 ms) : 0, 814231
GlobalTracer [baseline] (231.002 ms) : 0, 231002
GlobalTracer [candidate] (231.355 ms) : 0, 231355
AppSec [baseline] (35.03 ms) : 0, 35030
AppSec [candidate] (35.176 ms) : 0, 35176
Debugger [baseline] (6.132 ms) : 0, 6132
Debugger [candidate] (6.142 ms) : 0, 6142
Remote Config [baseline] (596.079 µs) : 0, 596
Remote Config [candidate] (607.068 µs) : 0, 607
Telemetry [baseline] (8.652 ms) : 0, 8652
Telemetry [candidate] (8.676 ms) : 0, 8676
Flare Poller [baseline] (4.281 ms) : 0, 4281
Flare Poller [candidate] (4.201 ms) : 0, 4201
IAST [baseline] (26.697 ms) : 0, 26697
IAST [candidate] (26.732 ms) : 0, 26732
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~09e53f1d91, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018220
Total [baseline] (10.701 s) : 0, 10701311
Agent [candidate] (1.025 s) : 0, 1025125
Total [candidate] (10.654 s) : 0, 10653855
section appsec
Agent [baseline] (1.203 s) : 0, 1203438
Total [baseline] (10.842 s) : 0, 10841726
Agent [candidate] (1.201 s) : 0, 1201289
Total [candidate] (10.939 s) : 0, 10938878
section iast
Agent [baseline] (1.158 s) : 0, 1158040
Total [baseline] (11.115 s) : 0, 11115403
Agent [candidate] (1.153 s) : 0, 1153035
Total [candidate] (11.061 s) : 0, 11061474
section profiling
Agent [baseline] (1.176 s) : 0, 1175929
Total [baseline] (10.968 s) : 0, 10968099
Agent [candidate] (1.172 s) : 0, 1171590
Total [candidate] (10.816 s) : 0, 10816025
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~09e53f1d91, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (692.873 ms) : 0, 692873
BytebuddyAgent [candidate] (698.135 ms) : 0, 698135
GlobalTracer [baseline] (242.975 ms) : 0, 242975
GlobalTracer [candidate] (243.766 ms) : 0, 243766
AppSec [baseline] (32.217 ms) : 0, 32217
AppSec [candidate] (32.451 ms) : 0, 32451
Debugger [baseline] (6.307 ms) : 0, 6307
Debugger [candidate] (6.277 ms) : 0, 6277
Remote Config [baseline] (680.875 µs) : 0, 681
Remote Config [candidate] (671.086 µs) : 0, 671
Telemetry [baseline] (9.287 ms) : 0, 9287
Telemetry [candidate] (9.231 ms) : 0, 9231
Flare Poller [baseline] (11.341 ms) : 0, 11341
Flare Poller [candidate] (11.833 ms) : 0, 11833
section appsec
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (723.764 ms) : 0, 723764
BytebuddyAgent [candidate] (722.805 ms) : 0, 722805
GlobalTracer [baseline] (237.024 ms) : 0, 237024
GlobalTracer [candidate] (236.47 ms) : 0, 236470
AppSec [baseline] (175.534 ms) : 0, 175534
AppSec [candidate] (175.209 ms) : 0, 175209
Debugger [baseline] (6.145 ms) : 0, 6145
Debugger [candidate] (6.105 ms) : 0, 6105
Remote Config [baseline] (623.229 µs) : 0, 623
Remote Config [candidate] (623.724 µs) : 0, 624
Telemetry [baseline] (8.558 ms) : 0, 8558
Telemetry [candidate] (8.539 ms) : 0, 8539
Flare Poller [baseline] (3.906 ms) : 0, 3906
Flare Poller [candidate] (3.907 ms) : 0, 3907
IAST [baseline] (25.179 ms) : 0, 25179
IAST [candidate] (24.907 ms) : 0, 24907
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (820.642 ms) : 0, 820642
BytebuddyAgent [candidate] (816.672 ms) : 0, 816672
GlobalTracer [baseline] (232.827 ms) : 0, 232827
GlobalTracer [candidate] (232.064 ms) : 0, 232064
AppSec [baseline] (34.982 ms) : 0, 34982
AppSec [candidate] (34.931 ms) : 0, 34931
Debugger [baseline] (6.144 ms) : 0, 6144
Debugger [candidate] (6.142 ms) : 0, 6142
Remote Config [baseline] (602.577 µs) : 0, 603
Remote Config [candidate] (610.64 µs) : 0, 611
Telemetry [baseline] (8.764 ms) : 0, 8764
Telemetry [candidate] (8.737 ms) : 0, 8737
Flare Poller [baseline] (4.193 ms) : 0, 4193
Flare Poller [candidate] (4.263 ms) : 0, 4263
IAST [baseline] (26.912 ms) : 0, 26912
IAST [candidate] (26.748 ms) : 0, 26748
section profiling
ProfilingAgent [baseline] (110.075 ms) : 0, 110075
ProfilingAgent [candidate] (109.777 ms) : 0, 109777
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (729.169 ms) : 0, 729169
BytebuddyAgent [candidate] (726.09 ms) : 0, 726090
GlobalTracer [baseline] (220.862 ms) : 0, 220862
GlobalTracer [candidate] (220.218 ms) : 0, 220218
AppSec [baseline] (32.51 ms) : 0, 32510
AppSec [candidate] (32.531 ms) : 0, 32531
Debugger [baseline] (8.212 ms) : 0, 8212
Debugger [candidate] (7.507 ms) : 0, 7507
Remote Config [baseline] (724.179 µs) : 0, 724
Remote Config [candidate] (691.799 µs) : 0, 692
Telemetry [baseline] (12.9 ms) : 0, 12900
Telemetry [candidate] (15.113 ms) : 0, 15113
Flare Poller [baseline] (5.659 ms) : 0, 5659
Flare Poller [candidate] (4.206 ms) : 0, 4206
Profiling [baseline] (110.696 ms) : 0, 110696
Profiling [candidate] (110.377 ms) : 0, 110377
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 12 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~09e53f1d91, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
dateFormat X
axisFormat %s
section baseline
no_agent (36.305 ms) : 36014, 36596
. : milestone, 36305,
appsec (48.157 ms) : 47729, 48585
. : milestone, 48157,
code_origins (43.818 ms) : 43453, 44183
. : milestone, 43818,
iast (44.248 ms) : 43861, 44634
. : milestone, 44248,
profiling (46.583 ms) : 46157, 47009
. : milestone, 46583,
tracing (44.004 ms) : 43627, 44381
. : milestone, 44004,
section candidate
no_agent (35.663 ms) : 35377, 35948
. : milestone, 35663,
appsec (48.727 ms) : 48295, 49159
. : milestone, 48727,
code_origins (43.1 ms) : 42729, 43470
. : milestone, 43100,
iast (44.364 ms) : 43981, 44747
. : milestone, 44364,
profiling (46.554 ms) : 46131, 46977
. : milestone, 46554,
tracing (43.903 ms) : 43520, 44286
. : milestone, 43903,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~09e53f1d91, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
dateFormat X
axisFormat %s
section baseline
no_agent (4.336 ms) : 4282, 4390
. : milestone, 4336,
iast (9.884 ms) : 9714, 10054
. : milestone, 9884,
iast_FULL (13.936 ms) : 13660, 14212
. : milestone, 13936,
iast_GLOBAL (10.606 ms) : 10421, 10790
. : milestone, 10606,
profiling (8.838 ms) : 8694, 8983
. : milestone, 8838,
tracing (7.874 ms) : 7763, 7986
. : milestone, 7874,
section candidate
no_agent (4.293 ms) : 4246, 4339
. : milestone, 4293,
iast (10.124 ms) : 9949, 10298
. : milestone, 10124,
iast_FULL (13.875 ms) : 13597, 14153
. : milestone, 13875,
iast_GLOBAL (10.665 ms) : 10473, 10857
. : milestone, 10665,
profiling (9.047 ms) : 8906, 9188
. : milestone, 9047,
tracing (7.618 ms) : 7506, 7730
. : milestone, 7618,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~09e53f1d91, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (2.782 ms) : 2700, 2864
. : milestone, 2782,
iast (2.559 ms) : 2460, 2658
. : milestone, 2559,
iast_GLOBAL (2.609 ms) : 2509, 2709
. : milestone, 2609,
profiling (2.409 ms) : 2323, 2495
. : milestone, 2409,
tracing (2.349 ms) : 2268, 2430
. : milestone, 2349,
section candidate
no_agent (1.488 ms) : 1476, 1500
. : milestone, 1488,
appsec (4.15 ms) : 3901, 4398
. : milestone, 4150,
iast (2.569 ms) : 2470, 2669
. : milestone, 2569,
iast_GLOBAL (2.611 ms) : 2511, 2711
. : milestone, 2611,
profiling (2.414 ms) : 2328, 2500
. : milestone, 2414,
tracing (2.338 ms) : 2257, 2419
. : milestone, 2338,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~09e53f1d91, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
dateFormat X
axisFormat %s
section baseline
no_agent (14.634 s) : 14634000, 14634000
. : milestone, 14634000,
appsec (14.81 s) : 14810000, 14810000
. : milestone, 14810000,
iast (17.764 s) : 17764000, 17764000
. : milestone, 17764000,
iast_GLOBAL (16.997 s) : 16997000, 16997000
. : milestone, 16997000,
profiling (14.314 s) : 14314000, 14314000
. : milestone, 14314000,
tracing (14.607 s) : 14607000, 14607000
. : milestone, 14607000,
section candidate
no_agent (14.962 s) : 14962000, 14962000
. : milestone, 14962000,
appsec (14.563 s) : 14563000, 14563000
. : milestone, 14563000,
iast (17.916 s) : 17916000, 17916000
. : milestone, 17916000,
iast_GLOBAL (17.308 s) : 17308000, 17308000
. : milestone, 17308000,
profiling (14.317 s) : 14317000, 14317000
. : milestone, 14317000,
tracing (14.441 s) : 14441000, 14441000
. : milestone, 14441000,
|
What Does This Do
When a security manager is installed, this method call can cause a SecurityException. At least, on the finally block, we should do it safely.
Example::
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]