Skip to content

Keep generic signature aligned when adding TaskWrapper interface #9794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcculls merged 2 commits into from
Oct 17, 2025
Merged

Keep generic signature aligned when adding TaskWrapper interface #9794

mcculls merged 2 commits into from
Oct 17, 2025

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Oct 17, 2025 •
edited
Loading

What Does This Do

When adding TaskWrapper to the declared interfaces, make sure we also add it to the generic signature

Motivation

Avoid causing issues with introspection tools/agents that expect the interface list and generic signature to be aligned.

We did a similar fix for field-injection in #2203

Contributor Checklist

Jira ticket: PROF-12675

@mcculls mcculls added type: bug Bug report and fix comp: profiling Profiling labels Oct 17, 2025
@datadog-official
Copy link

datadog-official bot commented Oct 17, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 63.34% (+3.64%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6939eba | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fix-unwrapping-class-visitor
git_commit_date 1760711091 1760719312
git_commit_sha c60b3c3 6939eba
release_version 1.55.0-SNAPSHOT~c60b3c3cbf 1.55.0-SNAPSHOT~6939eba0aa
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1760721331 1760721331
ci_job_id 1185479900 1185479900
ci_pipeline_id 79647384 79647384
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-utxzoy8i 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-utxzoy8i 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~6939eba0aa, baseline=1.55.0-SNAPSHOT~c60b3c3cbf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1016017
Total [baseline] (8.665 s) : 0, 8665272
Agent [candidate] (1.02 s) : 0, 1019611
Total [candidate] (8.643 s) : 0, 8643236
section iast
Agent [baseline] (1.152 s) : 0, 1151508
Total [baseline] (9.27 s) : 0, 9269874
Agent [candidate] (1.16 s) : 0, 1159990
Total [candidate] (9.281 s) : 0, 9281294
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.016 s -
Agent iast 1.152 s 135.491 ms (13.3%)
Total tracing 8.665 s -
Total iast 9.27 s 604.602 ms (7.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent iast 1.16 s 140.379 ms (13.8%)
Total tracing 8.643 s -
Total iast 9.281 s 638.058 ms (7.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~6939eba0aa, baseline=1.55.0-SNAPSHOT~c60b3c3cbf

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (691.693 ms) : 0, 691693
BytebuddyAgent [candidate] (694.29 ms) : 0, 694290
GlobalTracer [baseline] (242.366 ms) : 0, 242366
GlobalTracer [candidate] (243.063 ms) : 0, 243063
AppSec [baseline] (32.285 ms) : 0, 32285
AppSec [candidate] (32.413 ms) : 0, 32413
Debugger [baseline] (6.342 ms) : 0, 6342
Debugger [candidate] (6.327 ms) : 0, 6327
Remote Config [baseline] (679.456 µs) : 0, 679
Remote Config [candidate] (671.809 µs) : 0, 672
Telemetry [baseline] (9.3 ms) : 0, 9300
Telemetry [candidate] (9.287 ms) : 0, 9287
Flare Poller [baseline] (10.897 ms) : 0, 10897
Flare Poller [candidate] (10.986 ms) : 0, 10986
section iast
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (815.427 ms) : 0, 815427
BytebuddyAgent [candidate] (821.832 ms) : 0, 821832
GlobalTracer [baseline] (231.512 ms) : 0, 231512
GlobalTracer [candidate] (232.947 ms) : 0, 232947
IAST [baseline] (26.713 ms) : 0, 26713
IAST [candidate] (27.031 ms) : 0, 27031
AppSec [baseline] (35.273 ms) : 0, 35273
AppSec [candidate] (35.239 ms) : 0, 35239
Debugger [baseline] (6.159 ms) : 0, 6159
Debugger [candidate] (6.234 ms) : 0, 6234
Remote Config [baseline] (607.581 µs) : 0, 608
Remote Config [candidate] (602.329 µs) : 0, 602
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (8.759 ms) : 0, 8759
Flare Poller [baseline] (4.269 ms) : 0, 4269
Flare Poller [candidate] (4.285 ms) : 0, 4285
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~6939eba0aa, baseline=1.55.0-SNAPSHOT~c60b3c3cbf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019002
Total [baseline] (10.641 s) : 0, 10640906
Agent [candidate] (1.025 s) : 0, 1024962
Total [candidate] (10.807 s) : 0, 10806879
section appsec
Agent [baseline] (1.198 s) : 0, 1198364
Total [baseline] (10.835 s) : 0, 10834814
Agent [candidate] (1.193 s) : 0, 1193085
Total [candidate] (10.831 s) : 0, 10831067
section iast
Agent [baseline] (1.152 s) : 0, 1152444
Total [baseline] (11.136 s) : 0, 11135779
Agent [candidate] (1.151 s) : 0, 1151387
Total [candidate] (11.122 s) : 0, 11121883
section profiling
Agent [baseline] (1.168 s) : 0, 1168303
Total [baseline] (10.818 s) : 0, 10817829
Agent [candidate] (1.166 s) : 0, 1165521
Total [candidate] (10.856 s) : 0, 10856176
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent appsec 1.198 s 179.361 ms (17.6%)
Agent iast 1.152 s 133.442 ms (13.1%)
Agent profiling 1.168 s 149.3 ms (14.7%)
Total tracing 10.641 s -
Total appsec 10.835 s 193.908 ms (1.8%)
Total iast 11.136 s 494.873 ms (4.7%)
Total profiling 10.818 s 176.923 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.025 s -
Agent appsec 1.193 s 168.122 ms (16.4%)
Agent iast 1.151 s 126.424 ms (12.3%)
Agent profiling 1.166 s 140.558 ms (13.7%)
Total tracing 10.807 s -
Total appsec 10.831 s 24.188 ms (0.2%)
Total iast 11.122 s 315.004 ms (2.9%)
Total profiling 10.856 s 49.297 ms (0.5%) 
gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~6939eba0aa, baseline=1.55.0-SNAPSHOT~c60b3c3cbf

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (694.364 ms) : 0, 694364
BytebuddyAgent [candidate] (698.2 ms) : 0, 698200
GlobalTracer [baseline] (243.323 ms) : 0, 243323
GlobalTracer [candidate] (243.82 ms) : 0, 243820
AppSec [baseline] (32.278 ms) : 0, 32278
AppSec [candidate] (32.582 ms) : 0, 32582
Debugger [baseline] (6.286 ms) : 0, 6286
Debugger [candidate] (6.366 ms) : 0, 6366
Remote Config [baseline] (672.932 µs) : 0, 673
Remote Config [candidate] (680.681 µs) : 0, 681
Telemetry [baseline] (9.292 ms) : 0, 9292
Telemetry [candidate] (9.444 ms) : 0, 9444
Flare Poller [baseline] (10.212 ms) : 0, 10212
Flare Poller [candidate] (11.224 ms) : 0, 11224
section appsec
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (720.422 ms) : 0, 720422
BytebuddyAgent [candidate] (717.571 ms) : 0, 717571
GlobalTracer [baseline] (235.756 ms) : 0, 235756
GlobalTracer [candidate] (234.94 ms) : 0, 234940
AppSec [baseline] (175.023 ms) : 0, 175023
AppSec [candidate] (174.293 ms) : 0, 174293
Debugger [baseline] (6.163 ms) : 0, 6163
Debugger [candidate] (6.035 ms) : 0, 6035
Remote Config [baseline] (634.191 µs) : 0, 634
Remote Config [candidate] (625.244 µs) : 0, 625
Telemetry [baseline] (8.689 ms) : 0, 8689
Telemetry [candidate] (8.489 ms) : 0, 8489
Flare Poller [baseline] (3.998 ms) : 0, 3998
Flare Poller [candidate] (3.881 ms) : 0, 3881
IAST [baseline] (25.079 ms) : 0, 25079
IAST [candidate] (24.72 ms) : 0, 24720
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (815.62 ms) : 0, 815620
BytebuddyAgent [candidate] (815.276 ms) : 0, 815276
GlobalTracer [baseline] (232.159 ms) : 0, 232159
GlobalTracer [candidate] (231.802 ms) : 0, 231802
AppSec [baseline] (35.456 ms) : 0, 35456
AppSec [candidate] (35.028 ms) : 0, 35028
Debugger [baseline] (6.155 ms) : 0, 6155
Debugger [candidate] (6.179 ms) : 0, 6179
Remote Config [baseline] (598.718 µs) : 0, 599
Remote Config [candidate] (609.774 µs) : 0, 610
Telemetry [baseline] (8.707 ms) : 0, 8707
Telemetry [candidate] (8.794 ms) : 0, 8794
Flare Poller [baseline] (4.246 ms) : 0, 4246
Flare Poller [candidate] (4.256 ms) : 0, 4256
IAST [baseline] (26.656 ms) : 0, 26656
IAST [candidate] (26.636 ms) : 0, 26636
section profiling
ProfilingAgent [baseline] (110.059 ms) : 0, 110059
ProfilingAgent [candidate] (109.641 ms) : 0, 109641
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (723.055 ms) : 0, 723055
BytebuddyAgent [candidate] (721.897 ms) : 0, 721897
GlobalTracer [baseline] (219.764 ms) : 0, 219764
GlobalTracer [candidate] (218.922 ms) : 0, 218922
AppSec [baseline] (32.538 ms) : 0, 32538
AppSec [candidate] (32.326 ms) : 0, 32326
Debugger [baseline] (6.778 ms) : 0, 6778
Debugger [candidate] (7.479 ms) : 0, 7479
Remote Config [baseline] (710.762 µs) : 0, 711
Remote Config [candidate] (696.536 µs) : 0, 697
Telemetry [baseline] (15.232 ms) : 0, 15232
Telemetry [candidate] (15.115 ms) : 0, 15115
Flare Poller [baseline] (4.963 ms) : 0, 4963
Flare Poller [candidate] (4.127 ms) : 0, 4127
Profiling [baseline] (110.67 ms) : 0, 110670
Profiling [candidate] (110.268 ms) : 0, 110268
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fix-unwrapping-class-visitor
git_commit_date 1760711091 1760719312
git_commit_sha c60b3c3 6939eba
release_version 1.55.0-SNAPSHOT~c60b3c3cbf 1.55.0-SNAPSHOT~6939eba0aa
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1760720914 1760720914
ci_job_id 1185479901 1185479901
ci_pipeline_id 79647384 79647384
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-o6wu0h4p 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-o6wu0h4p 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 5 performance improvements and 3 performance regressions! Performance is the same for 4 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load better
[-247.459µs; -134.317µs] or [-5.511%; -2.991%]		 unstable
[-66.787op/s; +155.100op/s] or [-6.532%; +15.168%]		 4.299ms 1066.688op/s 4.490ms 1022.531op/s
scenario:load:insecure-bank:tracing:high_load worse
[+189.180µs; +432.473µs] or [+2.449%; +5.598%]		 unstable
[-92.040op/s; +46.103op/s] or [-15.352%; +7.690%]		 8.036ms 576.562op/s 7.725ms 599.531op/s
scenario:load:insecure-bank:profiling:high_load worse
[+203.107µs; +497.677µs] or [+2.358%; +5.777%]		 unstable
[-87.752op/s; +46.315op/s] or [-16.304%; +8.605%]		 8.965ms 517.500op/s 8.615ms 538.219op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-1168.387µs; -739.490µs] or [-10.018%; -6.340%]		 unstable
[-11.724op/s; +82.036op/s] or [-2.939%; +20.565%]		 10.709ms 434.062op/s 11.663ms 398.906op/s
scenario:load:insecure-bank:iast_FULL:high_load better
[-1186.144µs; -567.427µs] or [-7.939%; -3.798%]		 unstable
[-15.028op/s; +53.653op/s] or [-4.817%; +17.197%]		 14.064ms 331.312op/s 14.941ms 312.000op/s
scenario:load:petclinic:no_agent:high_load better
[-2.328ms; -1.691ms] or [-6.227%; -4.523%]		 unstable
[-1.633op/s; +15.708op/s] or [-1.305%; +12.556%]		 35.373ms 132.137op/s 37.383ms 125.100op/s
scenario:load:petclinic:code_origins:high_load better
[-3.691ms; -2.893ms] or [-8.160%; -6.396%]		 unstable
[+0.729op/s; +15.446op/s] or [+0.705%; +14.931%]		 41.937ms 111.537op/s 45.229ms 103.450op/s
scenario:load:petclinic:profiling:high_load worse
[+1.580ms; +2.525ms] or [+3.350%; +5.355%]		 unstable
[-11.013op/s; +2.788op/s] or [-11.100%; +2.810%]		 49.203ms 95.100op/s 47.151ms 99.213op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~6939eba0aa, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.49 ms) : 4439, 4541
.   : milestone, 4490,
iast (10.267 ms) : 10093, 10442
.   : milestone, 10267,
iast_FULL (14.941 ms) : 14647, 15235
.   : milestone, 14941,
iast_GLOBAL (11.663 ms) : 11453, 11874
.   : milestone, 11663,
profiling (8.615 ms) : 8480, 8749
.   : milestone, 8615,
tracing (7.725 ms) : 7617, 7834
.   : milestone, 7725,
section candidate
no_agent (4.299 ms) : 4245, 4353
.   : milestone, 4299,
iast (10.02 ms) : 9850, 10191
.   : milestone, 10020,
iast_FULL (14.064 ms) : 13784, 14345
.   : milestone, 14064,
iast_GLOBAL (10.709 ms) : 10522, 10897
.   : milestone, 10709,
profiling (8.965 ms) : 8826, 9104
.   : milestone, 8965,
tracing (8.036 ms) : 7919, 8154
.   : milestone, 8036,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.49 ms [4.439 ms, 4.541 ms] -
iast 10.267 ms [10.093 ms, 10.442 ms] 5.777 ms (128.7%)
iast_FULL 14.941 ms [14.647 ms, 15.235 ms] 10.451 ms (232.8%)
iast_GLOBAL 11.663 ms [11.453 ms, 11.874 ms] 7.173 ms (159.8%)
profiling 8.615 ms [8.48 ms, 8.749 ms] 4.125 ms (91.9%)
tracing 7.725 ms [7.617 ms, 7.834 ms] 3.235 ms (72.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.299 ms [4.245 ms, 4.353 ms] -
iast 10.02 ms [9.85 ms, 10.191 ms] 5.721 ms (133.1%)
iast_FULL 14.064 ms [13.784 ms, 14.345 ms] 9.765 ms (227.1%)
iast_GLOBAL 10.709 ms [10.522 ms, 10.897 ms] 6.41 ms (149.1%)
profiling 8.965 ms [8.826 ms, 9.104 ms] 4.666 ms (108.5%)
tracing 8.036 ms [7.919 ms, 8.154 ms] 3.737 ms (86.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~6939eba0aa, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.383 ms) : 37075, 37690
.   : milestone, 37383,
appsec (45.785 ms) : 45381, 46189
.   : milestone, 45785,
code_origins (45.229 ms) : 44838, 45619
.   : milestone, 45229,
iast (44.384 ms) : 43993, 44775
.   : milestone, 44384,
profiling (47.151 ms) : 46734, 47568
.   : milestone, 47151,
tracing (45.234 ms) : 44852, 45615
.   : milestone, 45234,
section candidate
no_agent (35.373 ms) : 35090, 35657
.   : milestone, 35373,
appsec (46.695 ms) : 46281, 47109
.   : milestone, 46695,
code_origins (41.937 ms) : 41587, 42286
.   : milestone, 41937,
iast (43.982 ms) : 43599, 44366
.   : milestone, 43982,
profiling (49.203 ms) : 48743, 49664
.   : milestone, 49203,
tracing (44.464 ms) : 44081, 44847
.   : milestone, 44464,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.383 ms [37.075 ms, 37.69 ms] -
appsec 45.785 ms [45.381 ms, 46.189 ms] 8.402 ms (22.5%)
code_origins 45.229 ms [44.838 ms, 45.619 ms] 7.846 ms (21.0%)
iast 44.384 ms [43.993 ms, 44.775 ms] 7.001 ms (18.7%)
profiling 47.151 ms [46.734 ms, 47.568 ms] 9.768 ms (26.1%)
tracing 45.234 ms [44.852 ms, 45.615 ms] 7.851 ms (21.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 35.373 ms [35.09 ms, 35.657 ms] -
appsec 46.695 ms [46.281 ms, 47.109 ms] 11.322 ms (32.0%)
code_origins 41.937 ms [41.587 ms, 42.286 ms] 6.563 ms (18.6%)
iast 43.982 ms [43.599 ms, 44.366 ms] 8.609 ms (24.3%)
profiling 49.203 ms [48.743 ms, 49.664 ms] 13.83 ms (39.1%)
tracing 44.464 ms [44.081 ms, 44.847 ms] 9.091 ms (25.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fix-unwrapping-class-visitor
git_commit_date 1760711091 1760719312
git_commit_sha c60b3c3 6939eba
release_version 1.55.0-SNAPSHOT~c60b3c3cbf 1.55.0-SNAPSHOT~6939eba0aa
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1760721533 1760721533
ci_job_id 1185479902 1185479902
ci_pipeline_id 79647384 79647384
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-wicmau56 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-wicmau56 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~6939eba0aa, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.485 ms) : 1473, 1497
.   : milestone, 1485,
appsec (3.736 ms) : 3517, 3954
.   : milestone, 3736,
iast (2.218 ms) : 2154, 2282
.   : milestone, 2218,
iast_GLOBAL (2.267 ms) : 2203, 2331
.   : milestone, 2267,
profiling (2.06 ms) : 2009, 2111
.   : milestone, 2060,
tracing (2.039 ms) : 1989, 2089
.   : milestone, 2039,
section candidate
no_agent (1.482 ms) : 1471, 1494
.   : milestone, 1482,
appsec (3.822 ms) : 3598, 4046
.   : milestone, 3822,
iast (2.216 ms) : 2153, 2279
.   : milestone, 2216,
iast_GLOBAL (2.257 ms) : 2193, 2321
.   : milestone, 2257,
profiling (2.066 ms) : 2015, 2118
.   : milestone, 2066,
tracing (2.04 ms) : 1990, 2089
.   : milestone, 2040,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.485 ms [1.473 ms, 1.497 ms] -
appsec 3.736 ms [3.517 ms, 3.954 ms] 2.251 ms (151.6%)
iast 2.218 ms [2.154 ms, 2.282 ms] 732.939 µs (49.4%)
iast_GLOBAL 2.267 ms [2.203 ms, 2.331 ms] 781.721 µs (52.6%)
profiling 2.06 ms [2.009 ms, 2.111 ms] 574.763 µs (38.7%)
tracing 2.039 ms [1.989 ms, 2.089 ms] 554.173 µs (37.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.471 ms, 1.494 ms] -
appsec 3.822 ms [3.598 ms, 4.046 ms] 2.34 ms (157.8%)
iast 2.216 ms [2.153 ms, 2.279 ms] 733.591 µs (49.5%)
iast_GLOBAL 2.257 ms [2.193 ms, 2.321 ms] 774.827 µs (52.3%)
profiling 2.066 ms [2.015 ms, 2.118 ms] 583.659 µs (39.4%)
tracing 2.04 ms [1.99 ms, 2.089 ms] 557.431 µs (37.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~6939eba0aa, baseline=1.55.0-SNAPSHOT~c60b3c3cbf
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
appsec (14.87 s) : 14870000, 14870000
.   : milestone, 14870000,
iast (18.754 s) : 18754000, 18754000
.   : milestone, 18754000,
iast_GLOBAL (17.924 s) : 17924000, 17924000
.   : milestone, 17924000,
profiling (14.865 s) : 14865000, 14865000
.   : milestone, 14865000,
tracing (15.107 s) : 15107000, 15107000
.   : milestone, 15107000,
section candidate
no_agent (15.283 s) : 15283000, 15283000
.   : milestone, 15283000,
appsec (14.759 s) : 14759000, 14759000
.   : milestone, 14759000,
iast (18.746 s) : 18746000, 18746000
.   : milestone, 18746000,
iast_GLOBAL (18.116 s) : 18116000, 18116000
.   : milestone, 18116000,
profiling (15.308 s) : 15308000, 15308000
.   : milestone, 15308000,
tracing (15.11 s) : 15110000, 15110000
.   : milestone, 15110000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.988 s [14.988 s, 14.988 s] -
appsec 14.87 s [14.87 s, 14.87 s] -118.0 ms (-0.8%)
iast 18.754 s [18.754 s, 18.754 s] 3.766 s (25.1%)
iast_GLOBAL 17.924 s [17.924 s, 17.924 s] 2.936 s (19.6%)
profiling 14.865 s [14.865 s, 14.865 s] -123.0 ms (-0.8%)
tracing 15.107 s [15.107 s, 15.107 s] 119.0 ms (0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.283 s [15.283 s, 15.283 s] -
appsec 14.759 s [14.759 s, 14.759 s] -524.0 ms (-3.4%)
iast 18.746 s [18.746 s, 18.746 s] 3.463 s (22.7%)
iast_GLOBAL 18.116 s [18.116 s, 18.116 s] 2.833 s (18.5%)
profiling 15.308 s [15.308 s, 15.308 s] 25.0 ms (0.2%)
tracing 15.11 s [15.11 s, 15.11 s] -173.0 ms (-1.1%)

@mcculls mcculls force-pushed the mcculls/fix-unwrapping-class-visitor branch from 33b5404 to 65510c3 Compare October 17, 2025 15:45
@mcculls mcculls marked this pull request as ready for review October 17, 2025 15:45
@mcculls mcculls requested a review from a team as a code owner October 17, 2025 15:45
@mcculls mcculls requested review from jbachorik and ygree October 17, 2025 15:45
@mcculls mcculls changed the title Keep generic signature aligned when adding TASK_WRAPPER interface Keep generic signature aligned when adding TaskWrapper interface Oct 17, 2025
@mcculls mcculls force-pushed the mcculls/fix-unwrapping-class-visitor branch from 65510c3 to 7ff726e Compare October 17, 2025 16:39
@mcculls mcculls force-pushed the mcculls/fix-unwrapping-class-visitor branch from 7ff726e to 6939eba Compare October 17, 2025 16:42
@mcculls mcculls merged commit 666b4a0 into master Oct 17, 2025
534 checks passed
@mcculls mcculls deleted the mcculls/fix-unwrapping-class-visitor branch October 17, 2025 21:48
@github-actions github-actions bot added this to the 1.55.0 milestone Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@jbachorik jbachorik Awaiting requested review from jbachorik

Assignees

No one assigned

Labels

comp: profiling Profiling type: bug Bug report and fix

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @PerfectSlayer