-
Notifications
You must be signed in to change notification settings - Fork 320
Add quick 'datadog.' prefix check before applying delegation fix #9793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: fe84603 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~fe84603740, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018793
Total [baseline] (8.679 s) : 0, 8678569
Agent [candidate] (1.016 s) : 0, 1016451
Total [candidate] (8.653 s) : 0, 8652793
section iast
Agent [baseline] (1.152 s) : 0, 1152087
Total [baseline] (9.306 s) : 0, 9306412
Agent [candidate] (1.149 s) : 0, 1148545
Total [candidate] (9.281 s) : 0, 9280887
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~fe84603740, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (693.524 ms) : 0, 693524
BytebuddyAgent [candidate] (692.662 ms) : 0, 692662
GlobalTracer [baseline] (242.503 ms) : 0, 242503
GlobalTracer [candidate] (242.438 ms) : 0, 242438
AppSec [baseline] (32.477 ms) : 0, 32477
AppSec [candidate] (32.258 ms) : 0, 32258
Debugger [baseline] (6.287 ms) : 0, 6287
Debugger [candidate] (6.284 ms) : 0, 6284
Remote Config [baseline] (685.314 µs) : 0, 685
Remote Config [candidate] (685.5 µs) : 0, 685
Telemetry [baseline] (9.188 ms) : 0, 9188
Telemetry [candidate] (9.32 ms) : 0, 9320
Flare Poller [baseline] (11.594 ms) : 0, 11594
Flare Poller [candidate] (10.257 ms) : 0, 10257
section iast
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (815.548 ms) : 0, 815548
BytebuddyAgent [candidate] (813.217 ms) : 0, 813217
GlobalTracer [baseline] (231.69 ms) : 0, 231690
GlobalTracer [candidate] (231.174 ms) : 0, 231174
AppSec [baseline] (35.309 ms) : 0, 35309
AppSec [candidate] (34.973 ms) : 0, 34973
Debugger [baseline] (6.156 ms) : 0, 6156
Debugger [candidate] (6.168 ms) : 0, 6168
Remote Config [baseline] (614.615 µs) : 0, 615
Remote Config [candidate] (601.594 µs) : 0, 602
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.762 ms) : 0, 8762
Flare Poller [baseline] (4.306 ms) : 0, 4306
Flare Poller [candidate] (4.202 ms) : 0, 4202
IAST [baseline] (26.804 ms) : 0, 26804
IAST [candidate] (26.597 ms) : 0, 26597
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~fe84603740, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1014471
Total [baseline] (10.668 s) : 0, 10668446
Agent [candidate] (1.018 s) : 0, 1017550
Total [candidate] (10.628 s) : 0, 10628422
section appsec
Agent [baseline] (1.193 s) : 0, 1193333
Total [baseline] (10.796 s) : 0, 10795962
Agent [candidate] (1.201 s) : 0, 1200579
Total [candidate] (10.848 s) : 0, 10847993
section iast
Agent [baseline] (1.15 s) : 0, 1150195
Total [baseline] (11.152 s) : 0, 11151538
Agent [candidate] (1.162 s) : 0, 1162018
Total [candidate] (11.152 s) : 0, 11151695
section profiling
Agent [baseline] (1.164 s) : 0, 1164328
Total [baseline] (10.815 s) : 0, 10814625
Agent [candidate] (1.161 s) : 0, 1160549
Total [candidate] (10.891 s) : 0, 10890634
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~fe84603740, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (690.425 ms) : 0, 690425
BytebuddyAgent [candidate] (692.999 ms) : 0, 692998
GlobalTracer [baseline] (241.889 ms) : 0, 241889
GlobalTracer [candidate] (243.002 ms) : 0, 243002
AppSec [baseline] (32.217 ms) : 0, 32217
AppSec [candidate] (32.321 ms) : 0, 32321
Debugger [baseline] (6.28 ms) : 0, 6280
Debugger [candidate] (6.279 ms) : 0, 6279
Remote Config [baseline] (674.72 µs) : 0, 675
Remote Config [candidate] (683.722 µs) : 0, 684
Telemetry [baseline] (9.184 ms) : 0, 9184
Telemetry [candidate] (9.337 ms) : 0, 9337
Flare Poller [baseline] (11.239 ms) : 0, 11239
Flare Poller [candidate] (10.394 ms) : 0, 10394
section appsec
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (717.233 ms) : 0, 717233
BytebuddyAgent [candidate] (722.443 ms) : 0, 722443
GlobalTracer [baseline] (234.539 ms) : 0, 234539
GlobalTracer [candidate] (236.053 ms) : 0, 236053
IAST [baseline] (24.831 ms) : 0, 24831
IAST [candidate] (24.983 ms) : 0, 24983
AppSec [baseline] (175.044 ms) : 0, 175044
AppSec [candidate] (175.063 ms) : 0, 175063
Debugger [baseline] (6.067 ms) : 0, 6067
Debugger [candidate] (6.127 ms) : 0, 6127
Remote Config [baseline] (643.775 µs) : 0, 644
Remote Config [candidate] (627.368 µs) : 0, 627
Telemetry [baseline] (8.47 ms) : 0, 8470
Telemetry [candidate] (8.601 ms) : 0, 8601
Flare Poller [baseline] (3.964 ms) : 0, 3964
Flare Poller [candidate] (3.908 ms) : 0, 3908
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (813.953 ms) : 0, 813953
BytebuddyAgent [candidate] (822.531 ms) : 0, 822531
GlobalTracer [baseline] (231.503 ms) : 0, 231503
GlobalTracer [candidate] (233.374 ms) : 0, 233374
IAST [baseline] (26.674 ms) : 0, 26674
IAST [candidate] (27.043 ms) : 0, 27043
AppSec [baseline] (35.133 ms) : 0, 35133
AppSec [candidate] (35.756 ms) : 0, 35756
Debugger [baseline] (6.253 ms) : 0, 6253
Debugger [candidate] (6.284 ms) : 0, 6284
Remote Config [baseline] (616.835 µs) : 0, 617
Remote Config [candidate] (626.983 µs) : 0, 627
Telemetry [baseline] (8.833 ms) : 0, 8833
Telemetry [candidate] (8.925 ms) : 0, 8925
Flare Poller [baseline] (4.275 ms) : 0, 4275
Flare Poller [candidate] (4.391 ms) : 0, 4391
section profiling
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (720.444 ms) : 0, 720444
BytebuddyAgent [candidate] (718.134 ms) : 0, 718134
GlobalTracer [baseline] (218.553 ms) : 0, 218553
GlobalTracer [candidate] (218.211 ms) : 0, 218211
AppSec [baseline] (32.301 ms) : 0, 32301
AppSec [candidate] (32.316 ms) : 0, 32316
Debugger [baseline] (7.523 ms) : 0, 7523
Debugger [candidate] (7.429 ms) : 0, 7429
Remote Config [baseline] (692.293 µs) : 0, 692
Remote Config [candidate] (685.693 µs) : 0, 686
Telemetry [baseline] (14.44 ms) : 0, 14440
Telemetry [candidate] (14.371 ms) : 0, 14371
Flare Poller [baseline] (4.862 ms) : 0, 4862
Flare Poller [candidate] (4.887 ms) : 0, 4887
ProfilingAgent [baseline] (110.262 ms) : 0, 110262
ProfilingAgent [candidate] (109.465 ms) : 0, 109465
Profiling [baseline] (110.912 ms) : 0, 110912
Profiling [candidate] (110.091 ms) : 0, 110091
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~fe84603740, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section baseline
no_agent (38.182 ms) : 37879, 38486
. : milestone, 38182,
appsec (50.213 ms) : 49748, 50677
. : milestone, 50213,
code_origins (42.11 ms) : 41753, 42467
. : milestone, 42110,
iast (44.607 ms) : 44227, 44986
. : milestone, 44607,
profiling (49.693 ms) : 49209, 50177
. : milestone, 49693,
tracing (44.022 ms) : 43650, 44395
. : milestone, 44022,
section candidate
no_agent (38.034 ms) : 37723, 38344
. : milestone, 38034,
appsec (50.718 ms) : 50250, 51185
. : milestone, 50718,
code_origins (41.789 ms) : 41438, 42141
. : milestone, 41789,
iast (44.672 ms) : 44282, 45061
. : milestone, 44672,
profiling (49.09 ms) : 48643, 49537
. : milestone, 49090,
tracing (43.644 ms) : 43259, 44030
. : milestone, 43644,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~fe84603740, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section baseline
no_agent (4.368 ms) : 4319, 4418
. : milestone, 4368,
iast (9.954 ms) : 9787, 10122
. : milestone, 9954,
iast_FULL (14.787 ms) : 14482, 15091
. : milestone, 14787,
iast_GLOBAL (10.612 ms) : 10425, 10799
. : milestone, 10612,
profiling (9.033 ms) : 8875, 9191
. : milestone, 9033,
tracing (7.517 ms) : 7410, 7624
. : milestone, 7517,
section candidate
no_agent (4.317 ms) : 4268, 4366
. : milestone, 4317,
iast (9.783 ms) : 9619, 9947
. : milestone, 9783,
iast_FULL (14.016 ms) : 13742, 14291
. : milestone, 14016,
iast_GLOBAL (11.269 ms) : 11064, 11474
. : milestone, 11269,
profiling (8.666 ms) : 8533, 8800
. : milestone, 8666,
tracing (8.218 ms) : 8096, 8340
. : milestone, 8218,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~fe84603740, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section baseline
no_agent (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
appsec (14.833 s) : 14833000, 14833000
. : milestone, 14833000,
iast (18.283 s) : 18283000, 18283000
. : milestone, 18283000,
iast_GLOBAL (17.974 s) : 17974000, 17974000
. : milestone, 17974000,
profiling (15.481 s) : 15481000, 15481000
. : milestone, 15481000,
tracing (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
section candidate
no_agent (15.588 s) : 15588000, 15588000
. : milestone, 15588000,
appsec (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
iast (18.649 s) : 18649000, 18649000
. : milestone, 18649000,
iast_GLOBAL (18.104 s) : 18104000, 18104000
. : milestone, 18104000,
profiling (15.789 s) : 15789000, 15789000
. : milestone, 15789000,
tracing (15.277 s) : 15277000, 15277000
. : milestone, 15277000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~fe84603740, baseline=1.55.0-SNAPSHOT~666b4a0af9
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.673 ms) : 3460, 3885
. : milestone, 3673,
iast (2.218 ms) : 2153, 2282
. : milestone, 2218,
iast_GLOBAL (2.252 ms) : 2188, 2316
. : milestone, 2252,
profiling (2.499 ms) : 2336, 2661
. : milestone, 2499,
tracing (2.027 ms) : 1977, 2076
. : milestone, 2027,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.523 ms) : 2469, 2577
. : milestone, 2523,
iast (2.217 ms) : 2153, 2282
. : milestone, 2217,
iast_GLOBAL (2.252 ms) : 2188, 2317
. : milestone, 2252,
profiling (2.054 ms) : 2002, 2106
. : milestone, 2054,
tracing (2.026 ms) : 1976, 2076
. : milestone, 2026,
|
amarziali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice quick win
e414800 to
fe84603
Compare
Motivation
We know all the packages listed under
Constants.BOOTSTRAP_PACKAGE_PREFIXESstart with"datadog."so we can do that quick check inline without touching any other types. This avoids book-keeping overhead for the majority of classes, limiting it to only those we suspect we might need to apply the delegation fix.(Especially as the list of
BOOTSTRAP_PACKAGE_PREFIXEScontinues to grow...)Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]