-
Notifications
You must be signed in to change notification settings - Fork 320
Include dd-instrument-java #9792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~9a3e6e606e, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1027289
Total [baseline] (10.709 s) : 0, 10708610
Agent [candidate] (1.02 s) : 0, 1019877
Total [candidate] (10.637 s) : 0, 10636566
section appsec
Agent [baseline] (1.206 s) : 0, 1205927
Total [baseline] (10.907 s) : 0, 10906635
Agent [candidate] (1.194 s) : 0, 1194426
Total [candidate] (10.81 s) : 0, 10809570
section iast
Agent [baseline] (1.153 s) : 0, 1153259
Total [baseline] (11.166 s) : 0, 11165665
Agent [candidate] (1.153 s) : 0, 1152965
Total [candidate] (11.162 s) : 0, 11161667
section profiling
Agent [baseline] (1.164 s) : 0, 1163947
Total [baseline] (10.881 s) : 0, 10880541
Agent [candidate] (1.169 s) : 0, 1169042
Total [candidate] (10.975 s) : 0, 10975086
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~9a3e6e606e, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.495 ms) : 0, 1495
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (699.692 ms) : 0, 699692
BytebuddyAgent [candidate] (694.253 ms) : 0, 694253
GlobalTracer [baseline] (244.953 ms) : 0, 244953
GlobalTracer [candidate] (243.438 ms) : 0, 243438
AppSec [baseline] (32.734 ms) : 0, 32734
AppSec [candidate] (32.695 ms) : 0, 32695
Debugger [baseline] (6.561 ms) : 0, 6561
Debugger [candidate] (6.416 ms) : 0, 6416
Remote Config [baseline] (686.106 µs) : 0, 686
Remote Config [candidate] (680.074 µs) : 0, 680
Telemetry [baseline] (9.476 ms) : 0, 9476
Telemetry [candidate] (9.495 ms) : 0, 9495
Flare Poller [baseline] (10.351 ms) : 0, 10351
Flare Poller [candidate] (10.129 ms) : 0, 10129
section appsec
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (723.163 ms) : 0, 723163
BytebuddyAgent [candidate] (716.9 ms) : 0, 716900
GlobalTracer [baseline] (238.307 ms) : 0, 238307
GlobalTracer [candidate] (235.551 ms) : 0, 235551
IAST [baseline] (25.23 ms) : 0, 25230
IAST [candidate] (24.717 ms) : 0, 24717
AppSec [baseline] (176.965 ms) : 0, 176965
AppSec [candidate] (175.41 ms) : 0, 175410
Debugger [baseline] (6.207 ms) : 0, 6207
Debugger [candidate] (6.114 ms) : 0, 6114
Remote Config [baseline] (643.833 µs) : 0, 644
Remote Config [candidate] (623.854 µs) : 0, 624
Telemetry [baseline] (8.68 ms) : 0, 8680
Telemetry [candidate] (8.553 ms) : 0, 8553
Flare Poller [baseline] (3.966 ms) : 0, 3966
Flare Poller [candidate] (3.941 ms) : 0, 3941
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (816.074 ms) : 0, 816074
BytebuddyAgent [candidate] (815.701 ms) : 0, 815701
GlobalTracer [baseline] (232.676 ms) : 0, 232676
GlobalTracer [candidate] (232.819 ms) : 0, 232819
IAST [baseline] (26.497 ms) : 0, 26497
IAST [candidate] (26.437 ms) : 0, 26437
AppSec [baseline] (35.152 ms) : 0, 35152
AppSec [candidate] (35.32 ms) : 0, 35320
Debugger [baseline] (6.148 ms) : 0, 6148
Debugger [candidate] (6.157 ms) : 0, 6157
Remote Config [baseline] (608.041 µs) : 0, 608
Remote Config [candidate] (601.126 µs) : 0, 601
Telemetry [baseline] (8.727 ms) : 0, 8727
Telemetry [candidate] (8.647 ms) : 0, 8647
Flare Poller [baseline] (4.328 ms) : 0, 4328
Flare Poller [candidate] (4.295 ms) : 0, 4295
section profiling
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (721.541 ms) : 0, 721541
BytebuddyAgent [candidate] (724.748 ms) : 0, 724748
GlobalTracer [baseline] (219.054 ms) : 0, 219054
GlobalTracer [candidate] (220.064 ms) : 0, 220064
AppSec [baseline] (32.236 ms) : 0, 32236
AppSec [candidate] (32.497 ms) : 0, 32497
Debugger [baseline] (6.686 ms) : 0, 6686
Debugger [candidate] (6.765 ms) : 0, 6765
Remote Config [baseline] (1.525 ms) : 0, 1525
Remote Config [candidate] (1.442 ms) : 0, 1442
Telemetry [baseline] (15.216 ms) : 0, 15216
Telemetry [candidate] (14.573 ms) : 0, 14573
Flare Poller [baseline] (4.123 ms) : 0, 4123
Flare Poller [candidate] (4.999 ms) : 0, 4999
ProfilingAgent [baseline] (108.405 ms) : 0, 108405
ProfilingAgent [candidate] (109.012 ms) : 0, 109012
Profiling [baseline] (109.7 ms) : 0, 109700
Profiling [candidate] (110.18 ms) : 0, 110180
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~9a3e6e606e, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019346
Total [baseline] (8.678 s) : 0, 8677744
Agent [candidate] (1.018 s) : 0, 1017795
Total [candidate] (8.722 s) : 0, 8721831
section iast
Agent [baseline] (1.153 s) : 0, 1152912
Total [baseline] (9.33 s) : 0, 9330095
Agent [candidate] (1.154 s) : 0, 1153681
Total [candidate] (9.362 s) : 0, 9361732
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~9a3e6e606e, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (693.615 ms) : 0, 693615
BytebuddyAgent [candidate] (693.667 ms) : 0, 693667
GlobalTracer [baseline] (243.171 ms) : 0, 243171
GlobalTracer [candidate] (242.8 ms) : 0, 242800
AppSec [baseline] (32.45 ms) : 0, 32450
AppSec [candidate] (32.508 ms) : 0, 32508
Debugger [baseline] (6.463 ms) : 0, 6463
Debugger [candidate] (6.342 ms) : 0, 6342
Remote Config [baseline] (679.903 µs) : 0, 680
Remote Config [candidate] (676.556 µs) : 0, 677
Telemetry [baseline] (9.426 ms) : 0, 9426
Telemetry [candidate] (9.409 ms) : 0, 9409
Flare Poller [baseline] (10.911 ms) : 0, 10911
Flare Poller [candidate] (9.63 ms) : 0, 9630
section iast
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (815.987 ms) : 0, 815987
BytebuddyAgent [candidate] (815.828 ms) : 0, 815828
GlobalTracer [baseline] (232.74 ms) : 0, 232740
GlobalTracer [candidate] (232.794 ms) : 0, 232794
IAST [baseline] (26.518 ms) : 0, 26518
IAST [candidate] (26.608 ms) : 0, 26608
AppSec [baseline] (34.916 ms) : 0, 34916
AppSec [candidate] (35.599 ms) : 0, 35599
Debugger [baseline] (6.189 ms) : 0, 6189
Debugger [candidate] (6.226 ms) : 0, 6226
Remote Config [baseline] (624.825 µs) : 0, 625
Remote Config [candidate] (609.652 µs) : 0, 610
Telemetry [baseline] (8.657 ms) : 0, 8657
Telemetry [candidate] (8.709 ms) : 0, 8709
Flare Poller [baseline] (4.275 ms) : 0, 4275
Flare Poller [candidate] (4.271 ms) : 0, 4271
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~9a3e6e606e, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section baseline
no_agent (36.676 ms) : 36381, 36970
. : milestone, 36676,
appsec (48.58 ms) : 48138, 49022
. : milestone, 48580,
code_origins (41.653 ms) : 41296, 42010
. : milestone, 41653,
iast (44.473 ms) : 44095, 44851
. : milestone, 44473,
profiling (47.371 ms) : 46896, 47845
. : milestone, 47371,
tracing (43.185 ms) : 42826, 43544
. : milestone, 43185,
section candidate
no_agent (35.9 ms) : 35616, 36184
. : milestone, 35900,
appsec (48.301 ms) : 47874, 48728
. : milestone, 48301,
code_origins (43.247 ms) : 42883, 43612
. : milestone, 43247,
iast (44.287 ms) : 43901, 44673
. : milestone, 44287,
profiling (46.987 ms) : 46543, 47431
. : milestone, 46987,
tracing (44.861 ms) : 44463, 45260
. : milestone, 44861,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~9a3e6e606e, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section baseline
no_agent (4.448 ms) : 4397, 4500
. : milestone, 4448,
iast (9.719 ms) : 9557, 9882
. : milestone, 9719,
iast_FULL (14.324 ms) : 14033, 14615
. : milestone, 14324,
iast_GLOBAL (10.446 ms) : 10252, 10640
. : milestone, 10446,
profiling (9.154 ms) : 9004, 9304
. : milestone, 9154,
tracing (7.772 ms) : 7658, 7886
. : milestone, 7772,
section candidate
no_agent (4.368 ms) : 4317, 4419
. : milestone, 4368,
iast (10.219 ms) : 10045, 10394
. : milestone, 10219,
iast_FULL (14.383 ms) : 14095, 14671
. : milestone, 14383,
iast_GLOBAL (10.592 ms) : 10403, 10781
. : milestone, 10592,
profiling (8.787 ms) : 8642, 8932
. : milestone, 8787,
tracing (7.46 ms) : 7349, 7571
. : milestone, 7460,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~9a3e6e606e, baseline=1.55.0-SNAPSHOT~4eed5d7ec6
dateFormat X
axisFormat %s
section baseline
no_agent (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
appsec (15.025 s) : 15025000, 15025000
. : milestone, 15025000,
iast (18.554 s) : 18554000, 18554000
. : milestone, 18554000,
iast_GLOBAL (18.076 s) : 18076000, 18076000
. : milestone, 18076000,
profiling (15.485 s) : 15485000, 15485000
. : milestone, 15485000,
tracing (15.36 s) : 15360000, 15360000
. : milestone, 15360000,
section candidate
no_agent (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
appsec (15.06 s) : 15060000, 15060000
. : milestone, 15060000,
iast (18.768 s) : 18768000, 18768000
. : milestone, 18768000,
iast_GLOBAL (18.162 s) : 18162000, 18162000
. : milestone, 18162000,
profiling (15.892 s) : 15892000, 15892000
. : milestone, 15892000,
tracing (15.295 s) : 15295000, 15295000
. : milestone, 15295000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~9a3e6e606e, baseline=1.55.0-SNAPSHOT~4eed5d7ec6
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.684 ms) : 3467, 3901
. : milestone, 3684,
iast (2.195 ms) : 2132, 2259
. : milestone, 2195,
iast_GLOBAL (2.243 ms) : 2180, 2307
. : milestone, 2243,
profiling (2.061 ms) : 2009, 2113
. : milestone, 2061,
tracing (2.031 ms) : 1981, 2081
. : milestone, 2031,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.773 ms) : 3551, 3994
. : milestone, 3773,
iast (2.197 ms) : 2134, 2260
. : milestone, 2197,
iast_GLOBAL (2.246 ms) : 2183, 2310
. : milestone, 2246,
profiling (2.043 ms) : 1992, 2094
. : milestone, 2043,
tracing (2.026 ms) : 1977, 2076
. : milestone, 2026,
|
amarziali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM excited about it thanks
What Does This Do
Include https://github.com/DataDog/dd-instrument-java but don't activate its features yet.
Note we include it in the bootstrap layer so we can start using its features as early as possible, and across any product that wants to use it. Its only dependency is a repackaged minimal copy of ASM which won't conflict with application dependencies.
Motivation
Start rolling out features provided by
dd-instrument-javaContributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMAPI-1654