-
Notifications
You must be signed in to change notification settings - Fork 320
Crashtracking: improve OS version parsing #9785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: b416a4e | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 5 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~b416a4eebf, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017940
Total [baseline] (8.699 s) : 0, 8698910
Agent [candidate] (1.018 s) : 0, 1018104
Total [candidate] (8.671 s) : 0, 8670587
section iast
Agent [baseline] (1.156 s) : 0, 1155629
Total [baseline] (9.323 s) : 0, 9322717
Agent [candidate] (1.175 s) : 0, 1174888
Total [candidate] (9.403 s) : 0, 9403030
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~b416a4eebf, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (693.239 ms) : 0, 693239
BytebuddyAgent [candidate] (692.977 ms) : 0, 692977
GlobalTracer [baseline] (242.8 ms) : 0, 242800
GlobalTracer [candidate] (242.033 ms) : 0, 242033
AppSec [baseline] (32.464 ms) : 0, 32464
AppSec [candidate] (32.552 ms) : 0, 32552
Debugger [baseline] (6.372 ms) : 0, 6372
Debugger [candidate] (6.442 ms) : 0, 6442
Remote Config [baseline] (679.464 µs) : 0, 679
Remote Config [candidate] (695.504 µs) : 0, 696
Telemetry [baseline] (9.394 ms) : 0, 9394
Telemetry [candidate] (9.222 ms) : 0, 9222
Flare Poller [baseline] (10.346 ms) : 0, 10346
Flare Poller [candidate] (11.629 ms) : 0, 11629
section iast
crashtracking [baseline] (1.515 ms) : 0, 1515
crashtracking [candidate] (1.523 ms) : 0, 1523
BytebuddyAgent [baseline] (818.712 ms) : 0, 818712
BytebuddyAgent [candidate] (834.146 ms) : 0, 834146
GlobalTracer [baseline] (232.693 ms) : 0, 232693
GlobalTracer [candidate] (234.679 ms) : 0, 234679
AppSec [baseline] (34.81 ms) : 0, 34810
AppSec [candidate] (35.67 ms) : 0, 35670
Debugger [baseline] (6.221 ms) : 0, 6221
Debugger [candidate] (6.281 ms) : 0, 6281
Remote Config [baseline] (619.536 µs) : 0, 620
Remote Config [candidate] (624.26 µs) : 0, 624
Telemetry [baseline] (8.677 ms) : 0, 8677
Telemetry [candidate] (8.792 ms) : 0, 8792
Flare Poller [baseline] (4.184 ms) : 0, 4184
Flare Poller [candidate] (4.313 ms) : 0, 4313
IAST [baseline] (26.483 ms) : 0, 26483
IAST [candidate] (27.029 ms) : 0, 27029
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~b416a4eebf, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018789
Total [baseline] (10.71 s) : 0, 10710242
Agent [candidate] (1.024 s) : 0, 1023700
Total [candidate] (10.662 s) : 0, 10662453
section appsec
Agent [baseline] (1.198 s) : 0, 1198237
Total [baseline] (10.942 s) : 0, 10942246
Agent [candidate] (1.191 s) : 0, 1191307
Total [candidate] (11.106 s) : 0, 11106032
section iast
Agent [baseline] (1.153 s) : 0, 1153357
Total [baseline] (11.101 s) : 0, 11101461
Agent [candidate] (1.149 s) : 0, 1149369
Total [candidate] (11.047 s) : 0, 11046777
section profiling
Agent [baseline] (1.16 s) : 0, 1160100
Total [baseline] (10.811 s) : 0, 10810606
Agent [candidate] (1.158 s) : 0, 1158148
Total [candidate] (11.028 s) : 0, 11027689
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~b416a4eebf, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (692.696 ms) : 0, 692696
BytebuddyAgent [candidate] (697.23 ms) : 0, 697230
GlobalTracer [baseline] (242.801 ms) : 0, 242801
GlobalTracer [candidate] (243.445 ms) : 0, 243445
AppSec [baseline] (32.403 ms) : 0, 32403
AppSec [candidate] (32.374 ms) : 0, 32374
Debugger [baseline] (6.371 ms) : 0, 6371
Debugger [candidate] (6.488 ms) : 0, 6488
Remote Config [baseline] (671.494 µs) : 0, 671
Remote Config [candidate] (700.351 µs) : 0, 700
Telemetry [baseline] (9.504 ms) : 0, 9504
Telemetry [candidate] (9.375 ms) : 0, 9375
Flare Poller [baseline] (11.684 ms) : 0, 11684
Flare Poller [candidate] (11.394 ms) : 0, 11394
section appsec
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (718.671 ms) : 0, 718671
BytebuddyAgent [candidate] (715.953 ms) : 0, 715953
GlobalTracer [baseline] (236.338 ms) : 0, 236338
GlobalTracer [candidate] (233.912 ms) : 0, 233912
AppSec [baseline] (176.159 ms) : 0, 176159
AppSec [candidate] (175.199 ms) : 0, 175199
Debugger [baseline] (6.211 ms) : 0, 6211
Debugger [candidate] (6.087 ms) : 0, 6087
Remote Config [baseline] (642.784 µs) : 0, 643
Remote Config [candidate] (634.489 µs) : 0, 634
Telemetry [baseline] (8.618 ms) : 0, 8618
Telemetry [candidate] (8.452 ms) : 0, 8452
Flare Poller [baseline] (3.965 ms) : 0, 3965
Flare Poller [candidate] (3.906 ms) : 0, 3906
IAST [baseline] (24.999 ms) : 0, 24999
IAST [candidate] (24.724 ms) : 0, 24724
section iast
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (816.814 ms) : 0, 816814
BytebuddyAgent [candidate] (814.157 ms) : 0, 814157
GlobalTracer [baseline] (232.345 ms) : 0, 232345
GlobalTracer [candidate] (231.233 ms) : 0, 231233
AppSec [baseline] (34.978 ms) : 0, 34978
AppSec [candidate] (34.988 ms) : 0, 34988
Debugger [baseline] (6.179 ms) : 0, 6179
Debugger [candidate] (6.183 ms) : 0, 6183
Remote Config [baseline] (598.942 µs) : 0, 599
Remote Config [candidate] (609.582 µs) : 0, 610
Telemetry [baseline] (8.685 ms) : 0, 8685
Telemetry [candidate] (8.69 ms) : 0, 8690
Flare Poller [baseline] (4.263 ms) : 0, 4263
Flare Poller [candidate] (4.178 ms) : 0, 4178
IAST [baseline] (26.384 ms) : 0, 26384
IAST [candidate] (26.359 ms) : 0, 26359
section profiling
crashtracking [baseline] (1.42 ms) : 0, 1420
crashtracking [candidate] (1.416 ms) : 0, 1416
BytebuddyAgent [baseline] (718.598 ms) : 0, 718598
BytebuddyAgent [candidate] (719.561 ms) : 0, 719561
GlobalTracer [baseline] (218.156 ms) : 0, 218156
GlobalTracer [candidate] (217.234 ms) : 0, 217234
AppSec [baseline] (32.26 ms) : 0, 32260
AppSec [candidate] (32.192 ms) : 0, 32192
Debugger [baseline] (6.671 ms) : 0, 6671
Debugger [candidate] (6.462 ms) : 0, 6462
Remote Config [baseline] (717.611 µs) : 0, 718
Remote Config [candidate] (732.106 µs) : 0, 732
Telemetry [baseline] (15.097 ms) : 0, 15097
Telemetry [candidate] (16.071 ms) : 0, 16071
Flare Poller [baseline] (4.985 ms) : 0, 4985
Flare Poller [candidate] (4.126 ms) : 0, 4126
ProfilingAgent [baseline] (108.307 ms) : 0, 108307
ProfilingAgent [candidate] (107.691 ms) : 0, 107691
Profiling [baseline] (110.156 ms) : 0, 110156
Profiling [candidate] (108.417 ms) : 0, 108417
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 5 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b416a4eebf, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section baseline
no_agent (37.675 ms) : 37366, 37984
. : milestone, 37675,
appsec (46.468 ms) : 46063, 46872
. : milestone, 46468,
code_origins (43.859 ms) : 43478, 44241
. : milestone, 43859,
iast (44.944 ms) : 44581, 45307
. : milestone, 44944,
profiling (50.243 ms) : 49790, 50695
. : milestone, 50243,
tracing (43.968 ms) : 43589, 44348
. : milestone, 43968,
section candidate
no_agent (36.912 ms) : 36617, 37207
. : milestone, 36912,
appsec (45.763 ms) : 45365, 46162
. : milestone, 45763,
code_origins (45.207 ms) : 44815, 45598
. : milestone, 45207,
iast (46.297 ms) : 45889, 46706
. : milestone, 46297,
profiling (48.485 ms) : 48050, 48921
. : milestone, 48485,
tracing (44.808 ms) : 44421, 45195
. : milestone, 44808,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b416a4eebf, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section baseline
no_agent (4.41 ms) : 4358, 4463
. : milestone, 4410,
iast (9.684 ms) : 9514, 9854
. : milestone, 9684,
iast_FULL (14.354 ms) : 14066, 14642
. : milestone, 14354,
iast_GLOBAL (10.823 ms) : 10625, 11022
. : milestone, 10823,
profiling (8.789 ms) : 8641, 8936
. : milestone, 8789,
tracing (7.907 ms) : 7793, 8020
. : milestone, 7907,
section candidate
no_agent (4.399 ms) : 4349, 4448
. : milestone, 4399,
iast (10.277 ms) : 10103, 10450
. : milestone, 10277,
iast_FULL (14.19 ms) : 13907, 14473
. : milestone, 14190,
iast_GLOBAL (11.278 ms) : 11078, 11478
. : milestone, 11278,
profiling (8.575 ms) : 8441, 8709
. : milestone, 8575,
tracing (8.229 ms) : 8105, 8353
. : milestone, 8229,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b416a4eebf, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1486
. : milestone, 1474,
appsec (2.51 ms) : 2456, 2564
. : milestone, 2510,
iast (2.205 ms) : 2141, 2269
. : milestone, 2205,
iast_GLOBAL (2.255 ms) : 2191, 2319
. : milestone, 2255,
profiling (2.498 ms) : 2331, 2665
. : milestone, 2498,
tracing (2.034 ms) : 1984, 2084
. : milestone, 2034,
section candidate
no_agent (1.476 ms) : 1464, 1488
. : milestone, 1476,
appsec (3.701 ms) : 3484, 3918
. : milestone, 3701,
iast (2.208 ms) : 2145, 2272
. : milestone, 2208,
iast_GLOBAL (2.255 ms) : 2191, 2320
. : milestone, 2255,
profiling (2.069 ms) : 2016, 2122
. : milestone, 2069,
tracing (2.032 ms) : 1982, 2082
. : milestone, 2032,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b416a4eebf, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section baseline
no_agent (15.219 s) : 15219000, 15219000
. : milestone, 15219000,
appsec (15.012 s) : 15012000, 15012000
. : milestone, 15012000,
iast (18.897 s) : 18897000, 18897000
. : milestone, 18897000,
iast_GLOBAL (17.74 s) : 17740000, 17740000
. : milestone, 17740000,
profiling (15.137 s) : 15137000, 15137000
. : milestone, 15137000,
tracing (15.303 s) : 15303000, 15303000
. : milestone, 15303000,
section candidate
no_agent (14.735 s) : 14735000, 14735000
. : milestone, 14735000,
appsec (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
iast (18.437 s) : 18437000, 18437000
. : milestone, 18437000,
iast_GLOBAL (17.908 s) : 17908000, 17908000
. : milestone, 17908000,
profiling (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
tracing (15.228 s) : 15228000, 15228000
. : milestone, 15228000,
|
dd-java-agent/agent-crashtracking/src/main/java/datadog/crashtracking/dto/SemanticVersion.java
Outdated
Show resolved
Hide resolved
5f13aa0 to
b416a4e
Compare
What Does This Do
Fixes the OS parsing by accepting in best effort any groups of digits. While this technically can be wrong, the important thing is to be able to pull out what we can understand in term of numbers from
os.versionAlso, it returns a sane default when the os versions is not parseable in order to not throw an exception and risk to not send the crash report.
Motivation
solves #9772
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]