Skip to content

Protect exception advices from NoClassDefFound #9769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amarziali merged 2 commits into from
Oct 17, 2025
Merged

Protect exception advices from NoClassDefFound #9769

amarziali merged 2 commits into from
Oct 17, 2025

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Oct 16, 2025

What Does This Do

Protect against No Class Def Found.

java.lang.NoClassDefFoundError
  at datadog.trace.bootstrap.instrumentation.jfr.exceptions.ExceptionProfiling.getInstance(ExceptionProfiling.java:41)

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner October 16, 2025 06:44
@amarziali amarziali added type: bug Bug report and fix comp: profiling Profiling labels Oct 16, 2025
@datadog-official
Copy link

datadog-official bot commented Oct 16, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 63.31% (+3.54%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d2460a2 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 16, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/fix-exception-profiling
git_commit_date 1760639037 1760684340
git_commit_sha 33e27c7 d2460a2
release_version 1.55.0-SNAPSHOT~33e27c7cea 1.55.0-SNAPSHOT~d2460a24e5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1760686140 1760686140
ci_job_id 1184316296 1184316296
ci_pipeline_id 79589328 79589328
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-ll7uwq5l 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-ll7uwq5l 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~d2460a24e5, baseline=1.55.0-SNAPSHOT~33e27c7cea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1030135
Total [baseline] (8.747 s) : 0, 8747326
Agent [candidate] (1.021 s) : 0, 1020710
Total [candidate] (8.697 s) : 0, 8696811
section iast
Agent [baseline] (1.151 s) : 0, 1151011
Total [baseline] (9.292 s) : 0, 9292054
Agent [candidate] (1.152 s) : 0, 1152409
Total [candidate] (9.328 s) : 0, 9328153
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.03 s -
Agent iast 1.151 s 120.876 ms (11.7%)
Total tracing 8.747 s -
Total iast 9.292 s 544.728 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.021 s -
Agent iast 1.152 s 131.699 ms (12.9%)
Total tracing 8.697 s -
Total iast 9.328 s 631.342 ms (7.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~d2460a24e5, baseline=1.55.0-SNAPSHOT~33e27c7cea

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.502 ms) : 0, 1502
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (702.639 ms) : 0, 702639
BytebuddyAgent [candidate] (694.401 ms) : 0, 694401
GlobalTracer [baseline] (245.829 ms) : 0, 245829
GlobalTracer [candidate] (244.387 ms) : 0, 244387
AppSec [baseline] (33.088 ms) : 0, 33088
AppSec [candidate] (32.668 ms) : 0, 32668
Debugger [baseline] (6.5 ms) : 0, 6500
Debugger [candidate] (6.407 ms) : 0, 6407
Remote Config [baseline] (693.755 µs) : 0, 694
Remote Config [candidate] (708.99 µs) : 0, 709
Telemetry [baseline] (9.534 ms) : 0, 9534
Telemetry [candidate] (9.376 ms) : 0, 9376
Flare Poller [baseline] (8.932 ms) : 0, 8932
Flare Poller [candidate] (10.158 ms) : 0, 10158
section iast
crashtracking [baseline] (1.501 ms) : 0, 1501
crashtracking [candidate] (1.493 ms) : 0, 1493
BytebuddyAgent [baseline] (814.361 ms) : 0, 814361
BytebuddyAgent [candidate] (815.852 ms) : 0, 815852
GlobalTracer [baseline] (232.34 ms) : 0, 232340
GlobalTracer [candidate] (232.55 ms) : 0, 232550
AppSec [baseline] (35.128 ms) : 0, 35128
AppSec [candidate] (34.867 ms) : 0, 34867
Debugger [baseline] (6.138 ms) : 0, 6138
Debugger [candidate] (6.172 ms) : 0, 6172
Remote Config [baseline] (610.026 µs) : 0, 610
Remote Config [candidate] (606.938 µs) : 0, 607
Telemetry [baseline] (8.603 ms) : 0, 8603
Telemetry [candidate] (8.716 ms) : 0, 8716
Flare Poller [baseline] (4.268 ms) : 0, 4268
Flare Poller [candidate] (4.235 ms) : 0, 4235
IAST [baseline] (26.498 ms) : 0, 26498
IAST [candidate] (26.44 ms) : 0, 26440
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~d2460a24e5, baseline=1.55.0-SNAPSHOT~33e27c7cea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018902
Total [baseline] (10.687 s) : 0, 10687300
Agent [candidate] (1.014 s) : 0, 1014135
Total [candidate] (10.683 s) : 0, 10683256
section appsec
Agent [baseline] (1.196 s) : 0, 1195987
Total [baseline] (10.85 s) : 0, 10850065
Agent [candidate] (1.208 s) : 0, 1207517
Total [candidate] (10.914 s) : 0, 10914112
section iast
Agent [baseline] (1.152 s) : 0, 1152232
Total [baseline] (11.06 s) : 0, 11060482
Agent [candidate] (1.159 s) : 0, 1158535
Total [candidate] (11.112 s) : 0, 11112468
section profiling
Agent [baseline] (1.162 s) : 0, 1162073
Total [baseline] (10.846 s) : 0, 10846495
Agent [candidate] (1.162 s) : 0, 1162250
Total [candidate] (10.859 s) : 0, 10858686
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent appsec 1.196 s 177.084 ms (17.4%)
Agent iast 1.152 s 133.33 ms (13.1%)
Agent profiling 1.162 s 143.171 ms (14.1%)
Total tracing 10.687 s -
Total appsec 10.85 s 162.765 ms (1.5%)
Total iast 11.06 s 373.182 ms (3.5%)
Total profiling 10.846 s 159.195 ms (1.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent appsec 1.208 s 193.383 ms (19.1%)
Agent iast 1.159 s 144.4 ms (14.2%)
Agent profiling 1.162 s 148.115 ms (14.6%)
Total tracing 10.683 s -
Total appsec 10.914 s 230.856 ms (2.2%)
Total iast 11.112 s 429.212 ms (4.0%)
Total profiling 10.859 s 175.43 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~d2460a24e5, baseline=1.55.0-SNAPSHOT~33e27c7cea

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (694.089 ms) : 0, 694089
BytebuddyAgent [candidate] (692.193 ms) : 0, 692193
GlobalTracer [baseline] (242.969 ms) : 0, 242969
GlobalTracer [candidate] (242.925 ms) : 0, 242925
AppSec [baseline] (32.423 ms) : 0, 32423
AppSec [candidate] (32.229 ms) : 0, 32229
Debugger [baseline] (6.387 ms) : 0, 6387
Debugger [candidate] (6.349 ms) : 0, 6349
Remote Config [baseline] (689.282 µs) : 0, 689
Remote Config [candidate] (667.51 µs) : 0, 668
Telemetry [baseline] (9.376 ms) : 0, 9376
Telemetry [candidate] (9.382 ms) : 0, 9382
Flare Poller [baseline] (10.216 ms) : 0, 10216
Flare Poller [candidate] (7.856 ms) : 0, 7856
section appsec
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (717.49 ms) : 0, 717490
BytebuddyAgent [candidate] (727.006 ms) : 0, 727006
GlobalTracer [baseline] (235.836 ms) : 0, 235836
GlobalTracer [candidate] (238.013 ms) : 0, 238013
AppSec [baseline] (175.893 ms) : 0, 175893
AppSec [candidate] (175.73 ms) : 0, 175730
Debugger [baseline] (6.073 ms) : 0, 6073
Debugger [candidate] (6.04 ms) : 0, 6040
Remote Config [baseline] (633.1 µs) : 0, 633
Remote Config [candidate] (632.492 µs) : 0, 632
Telemetry [baseline] (8.545 ms) : 0, 8545
Telemetry [candidate] (8.418 ms) : 0, 8418
Flare Poller [baseline] (3.962 ms) : 0, 3962
Flare Poller [candidate] (3.86 ms) : 0, 3860
IAST [baseline] (24.845 ms) : 0, 24845
IAST [candidate] (24.999 ms) : 0, 24999
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (815.558 ms) : 0, 815558
BytebuddyAgent [candidate] (819.341 ms) : 0, 819341
GlobalTracer [baseline] (232.477 ms) : 0, 232477
GlobalTracer [candidate] (233.471 ms) : 0, 233471
AppSec [baseline] (34.078 ms) : 0, 34078
AppSec [candidate] (35.848 ms) : 0, 35848
Debugger [baseline] (7.082 ms) : 0, 7082
Debugger [candidate] (6.265 ms) : 0, 6265
Remote Config [baseline] (604.277 µs) : 0, 604
Remote Config [candidate] (616.06 µs) : 0, 616
Telemetry [baseline] (8.778 ms) : 0, 8778
Telemetry [candidate] (8.784 ms) : 0, 8784
Flare Poller [baseline] (4.254 ms) : 0, 4254
Flare Poller [candidate] (4.242 ms) : 0, 4242
IAST [baseline] (26.395 ms) : 0, 26395
IAST [candidate] (26.826 ms) : 0, 26826
section profiling
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (719.887 ms) : 0, 719887
BytebuddyAgent [candidate] (720.877 ms) : 0, 720877
GlobalTracer [baseline] (218.786 ms) : 0, 218786
GlobalTracer [candidate] (218.493 ms) : 0, 218493
AppSec [baseline] (32.198 ms) : 0, 32198
AppSec [candidate] (32.203 ms) : 0, 32203
Debugger [baseline] (6.724 ms) : 0, 6724
Debugger [candidate] (7.491 ms) : 0, 7491
Remote Config [baseline] (712.521 µs) : 0, 713
Remote Config [candidate] (701.584 µs) : 0, 702
Telemetry [baseline] (15.157 ms) : 0, 15157
Telemetry [candidate] (14.413 ms) : 0, 14413
Flare Poller [baseline] (4.913 ms) : 0, 4913
Flare Poller [candidate] (5.011 ms) : 0, 5011
ProfilingAgent [baseline] (108.795 ms) : 0, 108795
ProfilingAgent [candidate] (108.749 ms) : 0, 108749
Profiling [baseline] (110.253 ms) : 0, 110253
Profiling [candidate] (109.611 ms) : 0, 109611
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/fix-exception-profiling
git_commit_date 1760639037 1760684340
git_commit_sha 33e27c7 d2460a2
release_version 1.55.0-SNAPSHOT~33e27c7cea 1.55.0-SNAPSHOT~d2460a24e5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1760685895 1760685895
ci_job_id 1184316297 1184316297
ci_pipeline_id 79589328 79589328
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-djpzhzm5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-djpzhzm5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:tracing:high_load worse
[+1.616ms; +2.404ms] or [+3.861%; +5.746%]		 unstable
[-13.824op/s; +0.869op/s] or [-12.211%; +0.768%]		 43.853ms 106.737op/s 41.843ms 113.215op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d2460a24e5, baseline=1.55.0-SNAPSHOT~33e27c7cea
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.593 ms) : 36293, 36893
.   : milestone, 36593,
appsec (49.993 ms) : 49541, 50446
.   : milestone, 49993,
code_origins (43.224 ms) : 42860, 43588
.   : milestone, 43224,
iast (44.227 ms) : 43826, 44628
.   : milestone, 44227,
profiling (48.635 ms) : 48184, 49085
.   : milestone, 48635,
tracing (41.843 ms) : 41485, 42201
.   : milestone, 41843,
section candidate
no_agent (35.687 ms) : 35398, 35975
.   : milestone, 35687,
appsec (49.441 ms) : 48996, 49885
.   : milestone, 49441,
code_origins (42.645 ms) : 42288, 43002
.   : milestone, 42645,
iast (43.596 ms) : 43212, 43979
.   : milestone, 43596,
profiling (49.163 ms) : 48706, 49620
.   : milestone, 49163,
tracing (43.853 ms) : 43478, 44227
.   : milestone, 43853,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.593 ms [36.293 ms, 36.893 ms] -
appsec 49.993 ms [49.541 ms, 50.446 ms] 13.4 ms (36.6%)
code_origins 43.224 ms [42.86 ms, 43.588 ms] 6.631 ms (18.1%)
iast 44.227 ms [43.826 ms, 44.628 ms] 7.634 ms (20.9%)
profiling 48.635 ms [48.184 ms, 49.085 ms] 12.042 ms (32.9%)
tracing 41.843 ms [41.485 ms, 42.201 ms] 5.25 ms (14.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 35.687 ms [35.398 ms, 35.975 ms] -
appsec 49.441 ms [48.996 ms, 49.885 ms] 13.754 ms (38.5%)
code_origins 42.645 ms [42.288 ms, 43.002 ms] 6.958 ms (19.5%)
iast 43.596 ms [43.212 ms, 43.979 ms] 7.909 ms (22.2%)
profiling 49.163 ms [48.706 ms, 49.62 ms] 13.477 ms (37.8%)
tracing 43.853 ms [43.478 ms, 44.227 ms] 8.166 ms (22.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d2460a24e5, baseline=1.55.0-SNAPSHOT~33e27c7cea
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.404 ms) : 4354, 4455
.   : milestone, 4404,
iast (9.938 ms) : 9772, 10105
.   : milestone, 9938,
iast_FULL (14.121 ms) : 13838, 14403
.   : milestone, 14121,
iast_GLOBAL (10.826 ms) : 10632, 11019
.   : milestone, 10826,
profiling (8.949 ms) : 8808, 9091
.   : milestone, 8949,
tracing (7.871 ms) : 7749, 7993
.   : milestone, 7871,
section candidate
no_agent (4.383 ms) : 4333, 4432
.   : milestone, 4383,
iast (9.6 ms) : 9438, 9761
.   : milestone, 9600,
iast_FULL (14.649 ms) : 14356, 14942
.   : milestone, 14649,
iast_GLOBAL (10.785 ms) : 10592, 10978
.   : milestone, 10785,
profiling (8.752 ms) : 8616, 8888
.   : milestone, 8752,
tracing (7.685 ms) : 7576, 7793
.   : milestone, 7685,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.404 ms [4.354 ms, 4.455 ms] -
iast 9.938 ms [9.772 ms, 10.105 ms] 5.534 ms (125.6%)
iast_FULL 14.121 ms [13.838 ms, 14.403 ms] 9.716 ms (220.6%)
iast_GLOBAL 10.826 ms [10.632 ms, 11.019 ms] 6.421 ms (145.8%)
profiling 8.949 ms [8.808 ms, 9.091 ms] 4.545 ms (103.2%)
tracing 7.871 ms [7.749 ms, 7.993 ms] 3.467 ms (78.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.383 ms [4.333 ms, 4.432 ms] -
iast 9.6 ms [9.438 ms, 9.761 ms] 5.217 ms (119.0%)
iast_FULL 14.649 ms [14.356 ms, 14.942 ms] 10.266 ms (234.2%)
iast_GLOBAL 10.785 ms [10.592 ms, 10.978 ms] 6.402 ms (146.1%)
profiling 8.752 ms [8.616 ms, 8.888 ms] 4.369 ms (99.7%)
tracing 7.685 ms [7.576 ms, 7.793 ms] 3.302 ms (75.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/fix-exception-profiling
git_commit_date 1760639037 1760684340
git_commit_sha 33e27c7 d2460a2
release_version 1.55.0-SNAPSHOT~33e27c7cea 1.55.0-SNAPSHOT~d2460a24e5
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1760686451 1760686451
ci_job_id 1184316298 1184316298
ci_pipeline_id 79589328 79589328
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-bmd67lw2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-bmd67lw2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d2460a24e5, baseline=1.55.0-SNAPSHOT~33e27c7cea
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.537 s) : 15537000, 15537000
.   : milestone, 15537000,
appsec (15.066 s) : 15066000, 15066000
.   : milestone, 15066000,
iast (18.692 s) : 18692000, 18692000
.   : milestone, 18692000,
iast_GLOBAL (18.115 s) : 18115000, 18115000
.   : milestone, 18115000,
profiling (15.365 s) : 15365000, 15365000
.   : milestone, 15365000,
tracing (15.233 s) : 15233000, 15233000
.   : milestone, 15233000,
section candidate
no_agent (15.203 s) : 15203000, 15203000
.   : milestone, 15203000,
appsec (14.98 s) : 14980000, 14980000
.   : milestone, 14980000,
iast (18.656 s) : 18656000, 18656000
.   : milestone, 18656000,
iast_GLOBAL (18.065 s) : 18065000, 18065000
.   : milestone, 18065000,
profiling (15.13 s) : 15130000, 15130000
.   : milestone, 15130000,
tracing (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.537 s [15.537 s, 15.537 s] -
appsec 15.066 s [15.066 s, 15.066 s] -471.0 ms (-3.0%)
iast 18.692 s [18.692 s, 18.692 s] 3.155 s (20.3%)
iast_GLOBAL 18.115 s [18.115 s, 18.115 s] 2.578 s (16.6%)
profiling 15.365 s [15.365 s, 15.365 s] -172.0 ms (-1.1%)
tracing 15.233 s [15.233 s, 15.233 s] -304.0 ms (-2.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.203 s [15.203 s, 15.203 s] -
appsec 14.98 s [14.98 s, 14.98 s] -223.0 ms (-1.5%)
iast 18.656 s [18.656 s, 18.656 s] 3.453 s (22.7%)
iast_GLOBAL 18.065 s [18.065 s, 18.065 s] 2.862 s (18.8%)
profiling 15.13 s [15.13 s, 15.13 s] -73.0 ms (-0.5%)
tracing 15.019 s [15.019 s, 15.019 s] -184.0 ms (-1.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d2460a24e5, baseline=1.55.0-SNAPSHOT~33e27c7cea
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
.   : milestone, 1483,
appsec (3.702 ms) : 3486, 3918
.   : milestone, 3702,
iast (2.211 ms) : 2148, 2274
.   : milestone, 2211,
iast_GLOBAL (2.259 ms) : 2195, 2323
.   : milestone, 2259,
profiling (2.074 ms) : 2021, 2127
.   : milestone, 2074,
tracing (2.028 ms) : 1978, 2077
.   : milestone, 2028,
section candidate
no_agent (1.486 ms) : 1474, 1497
.   : milestone, 1486,
appsec (3.702 ms) : 3483, 3920
.   : milestone, 3702,
iast (2.226 ms) : 2162, 2290
.   : milestone, 2226,
iast_GLOBAL (2.258 ms) : 2194, 2322
.   : milestone, 2258,
profiling (2.076 ms) : 2023, 2129
.   : milestone, 2076,
tracing (2.041 ms) : 1991, 2091
.   : milestone, 2041,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.483 ms [1.472 ms, 1.495 ms] -
appsec 3.702 ms [3.486 ms, 3.918 ms] 2.219 ms (149.6%)
iast 2.211 ms [2.148 ms, 2.274 ms] 727.661 µs (49.1%)
iast_GLOBAL 2.259 ms [2.195 ms, 2.323 ms] 775.605 µs (52.3%)
profiling 2.074 ms [2.021 ms, 2.127 ms] 590.801 µs (39.8%)
tracing 2.028 ms [1.978 ms, 2.077 ms] 544.376 µs (36.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.486 ms [1.474 ms, 1.497 ms] -
appsec 3.702 ms [3.483 ms, 3.92 ms] 2.216 ms (149.2%)
iast 2.226 ms [2.162 ms, 2.29 ms] 740.544 µs (49.9%)
iast_GLOBAL 2.258 ms [2.194 ms, 2.322 ms] 772.421 µs (52.0%)
profiling 2.076 ms [2.023 ms, 2.129 ms] 590.533 µs (39.8%)
tracing 2.041 ms [1.991 ms, 2.091 ms] 555.743 µs (37.4%)

@amarziali amarziali force-pushed the andrea.marziali/fix-exception-profiling branch from ae9b776 to 3affde0 Compare October 16, 2025 08:57
mcculls
mcculls reviewed Oct 16, 2025
View reviewed changes
...on-profiling/src/main/java11/datadog/exceptions/instrumentation/ThrowableInstanceAdvice.java Outdated
final ExceptionSampleEvent event = ExceptionProfiling.getInstance().process((Throwable) t);
ExceptionSampleEvent event = null;
final ExceptionProfiling exceptionProfiling = ExceptionProfiling.getInstance();
if (exceptionProfiling != null) {
Copy link
Contributor

@mcculls mcculls Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth introducing an interface so we could return a "no-op" implementation when the real implementation can't be loaded? That would avoid all these null-checks... some of which will be checked on every profiled exception.

Copy link
Contributor

@dougqh dougqh Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've been thinking that we should use SPI approaches more often.
I'd really like code to request an implementation of an interface -- and when one isn't available get back a Null/NoOp version in instead.

Copy link
Contributor Author

@amarziali amarziali Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted an interface. done in d2460a2

@amarziali amarziali force-pushed the andrea.marziali/fix-exception-profiling branch from 3affde0 to b838e88 Compare October 17, 2025 06:57
@amarziali amarziali force-pushed the andrea.marziali/fix-exception-profiling branch from b838e88 to d2460a2 Compare October 17, 2025 06:59
@amarziali amarziali requested a review from mcculls October 17, 2025 07:00
@amarziali amarziali merged commit 664b9a4 into master Oct 17, 2025
534 checks passed
@amarziali amarziali deleted the andrea.marziali/fix-exception-profiling branch October 17, 2025 09:42
@github-actions github-actions bot added this to the 1.55.0 milestone Oct 17, 2025
@amarziali amarziali added the tag: telemetry error reported Reported by error telemetry label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougqh dougqh dougqh left review comments

@mcculls mcculls mcculls approved these changes

Assignees

No one assigned

Labels

comp: profiling Profiling tag: telemetry error reported Reported by error telemetry type: bug Bug report and fix

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

4 participants

@amarziali @mcculls @dougqh