-
Notifications
You must be signed in to change notification settings - Fork 320
Fix client stats payload #9743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix client stats payload #9743
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 119d765 | Docs | Was this helpful? Give us feedback! |
4f0bd84 to
07cc529
Compare
07cc529 to
119d765
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~119d76595e, baseline=1.55.0-SNAPSHOT~6dc3f85c93
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017779
Total [baseline] (8.699 s) : 0, 8698783
Agent [candidate] (1.018 s) : 0, 1017942
Total [candidate] (8.678 s) : 0, 8677872
section iast
Agent [baseline] (1.158 s) : 0, 1157687
Total [baseline] (9.41 s) : 0, 9409604
Agent [candidate] (1.151 s) : 0, 1151114
Total [candidate] (9.33 s) : 0, 9329840
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~119d76595e, baseline=1.55.0-SNAPSHOT~6dc3f85c93
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (693.652 ms) : 0, 693652
BytebuddyAgent [candidate] (693.603 ms) : 0, 693603
GlobalTracer [baseline] (241.575 ms) : 0, 241575
GlobalTracer [candidate] (242.61 ms) : 0, 242610
AppSec [baseline] (32.415 ms) : 0, 32415
AppSec [candidate] (32.47 ms) : 0, 32470
Debugger [baseline] (6.403 ms) : 0, 6403
Debugger [candidate] (6.404 ms) : 0, 6404
Remote Config [baseline] (712.857 µs) : 0, 713
Remote Config [candidate] (709.475 µs) : 0, 709
Telemetry [baseline] (9.373 ms) : 0, 9373
Telemetry [candidate] (9.339 ms) : 0, 9339
Flare Poller [baseline] (11.106 ms) : 0, 11106
Flare Poller [candidate] (10.159 ms) : 0, 10159
section iast
crashtracking [baseline] (1.496 ms) : 0, 1496
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (819.209 ms) : 0, 819209
BytebuddyAgent [candidate] (815.66 ms) : 0, 815660
GlobalTracer [baseline] (233.0 ms) : 0, 233000
GlobalTracer [candidate] (231.445 ms) : 0, 231445
IAST [baseline] (26.905 ms) : 0, 26905
IAST [candidate] (26.489 ms) : 0, 26489
AppSec [baseline] (35.526 ms) : 0, 35526
AppSec [candidate] (34.875 ms) : 0, 34875
Debugger [baseline] (6.237 ms) : 0, 6237
Debugger [candidate] (6.158 ms) : 0, 6158
Remote Config [baseline] (630.24 µs) : 0, 630
Remote Config [candidate] (607.404 µs) : 0, 607
Telemetry [baseline] (8.81 ms) : 0, 8810
Telemetry [candidate] (8.671 ms) : 0, 8671
Flare Poller [baseline] (4.297 ms) : 0, 4297
Flare Poller [candidate] (4.256 ms) : 0, 4256
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~119d76595e, baseline=1.55.0-SNAPSHOT~6dc3f85c93
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018033
Total [baseline] (10.681 s) : 0, 10681068
Agent [candidate] (1.025 s) : 0, 1024648
Total [candidate] (10.778 s) : 0, 10777511
section appsec
Agent [baseline] (1.197 s) : 0, 1196949
Total [baseline] (11.032 s) : 0, 11032266
Agent [candidate] (1.197 s) : 0, 1196934
Total [candidate] (11.102 s) : 0, 11102496
section iast
Agent [baseline] (1.153 s) : 0, 1152596
Total [baseline] (10.98 s) : 0, 10980083
Agent [candidate] (1.175 s) : 0, 1175237
Total [candidate] (11.061 s) : 0, 11060895
section profiling
Agent [baseline] (1.163 s) : 0, 1162615
Total [baseline] (11.107 s) : 0, 11107082
Agent [candidate] (1.169 s) : 0, 1168576
Total [candidate] (11.071 s) : 0, 11071383
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~119d76595e, baseline=1.55.0-SNAPSHOT~6dc3f85c93
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (693.336 ms) : 0, 693336
BytebuddyAgent [candidate] (700.595 ms) : 0, 700595
GlobalTracer [baseline] (241.885 ms) : 0, 241885
GlobalTracer [candidate] (242.075 ms) : 0, 242075
AppSec [baseline] (32.637 ms) : 0, 32637
AppSec [candidate] (32.325 ms) : 0, 32325
Debugger [baseline] (6.463 ms) : 0, 6463
Debugger [candidate] (6.379 ms) : 0, 6379
Remote Config [baseline] (704.579 µs) : 0, 705
Remote Config [candidate] (701.123 µs) : 0, 701
Telemetry [baseline] (9.392 ms) : 0, 9392
Telemetry [candidate] (9.364 ms) : 0, 9364
Flare Poller [baseline] (10.922 ms) : 0, 10922
Flare Poller [candidate] (10.325 ms) : 0, 10325
section appsec
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (717.818 ms) : 0, 717818
BytebuddyAgent [candidate] (719.294 ms) : 0, 719294
GlobalTracer [baseline] (236.137 ms) : 0, 236137
GlobalTracer [candidate] (235.106 ms) : 0, 235106
IAST [baseline] (25.091 ms) : 0, 25091
IAST [candidate] (24.908 ms) : 0, 24908
AppSec [baseline] (176.162 ms) : 0, 176162
AppSec [candidate] (175.757 ms) : 0, 175757
Debugger [baseline] (6.132 ms) : 0, 6132
Debugger [candidate] (6.129 ms) : 0, 6129
Remote Config [baseline] (650.572 µs) : 0, 651
Remote Config [candidate] (627.104 µs) : 0, 627
Telemetry [baseline] (8.399 ms) : 0, 8399
Telemetry [candidate] (8.442 ms) : 0, 8442
Flare Poller [baseline] (3.889 ms) : 0, 3889
Flare Poller [candidate] (3.966 ms) : 0, 3966
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (816.34 ms) : 0, 816340
BytebuddyAgent [candidate] (833.54 ms) : 0, 833540
GlobalTracer [baseline] (231.528 ms) : 0, 231528
GlobalTracer [candidate] (235.709 ms) : 0, 235709
IAST [baseline] (26.487 ms) : 0, 26487
IAST [candidate] (26.955 ms) : 0, 26955
AppSec [baseline] (35.469 ms) : 0, 35469
AppSec [candidate] (35.619 ms) : 0, 35619
Debugger [baseline] (6.121 ms) : 0, 6121
Debugger [candidate] (6.242 ms) : 0, 6242
Remote Config [baseline] (610.816 µs) : 0, 611
Remote Config [candidate] (643.422 µs) : 0, 643
Telemetry [baseline] (8.699 ms) : 0, 8699
Telemetry [candidate] (8.909 ms) : 0, 8909
Flare Poller [baseline] (4.295 ms) : 0, 4295
Flare Poller [candidate] (4.213 ms) : 0, 4213
section profiling
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (721.31 ms) : 0, 721310
BytebuddyAgent [candidate] (725.306 ms) : 0, 725306
GlobalTracer [baseline] (217.831 ms) : 0, 217831
GlobalTracer [candidate] (218.555 ms) : 0, 218555
AppSec [baseline] (32.276 ms) : 0, 32276
AppSec [candidate] (32.546 ms) : 0, 32546
Debugger [baseline] (7.203 ms) : 0, 7203
Debugger [candidate] (8.251 ms) : 0, 8251
Remote Config [baseline] (1.606 ms) : 0, 1606
Remote Config [candidate] (874.874 µs) : 0, 875
Telemetry [baseline] (14.559 ms) : 0, 14559
Telemetry [candidate] (14.649 ms) : 0, 14649
Flare Poller [baseline] (4.144 ms) : 0, 4144
Flare Poller [candidate] (4.104 ms) : 0, 4104
ProfilingAgent [baseline] (109.027 ms) : 0, 109027
ProfilingAgent [candidate] (109.702 ms) : 0, 109702
Profiling [baseline] (110.299 ms) : 0, 110299
Profiling [candidate] (110.435 ms) : 0, 110435
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~119d76595e, baseline=1.55.0-SNAPSHOT~6dc3f85c93
dateFormat X
axisFormat %s
section baseline
no_agent (37.071 ms) : 36777, 37364
. : milestone, 37071,
appsec (49.864 ms) : 49404, 50324
. : milestone, 49864,
code_origins (43.992 ms) : 43614, 44369
. : milestone, 43992,
iast (46.76 ms) : 46364, 47156
. : milestone, 46760,
profiling (47.251 ms) : 46804, 47698
. : milestone, 47251,
tracing (45.559 ms) : 45158, 45959
. : milestone, 45559,
section candidate
no_agent (35.887 ms) : 35608, 36167
. : milestone, 35887,
appsec (49.17 ms) : 48742, 49598
. : milestone, 49170,
code_origins (44.284 ms) : 43901, 44668
. : milestone, 44284,
iast (44.291 ms) : 43913, 44670
. : milestone, 44291,
profiling (47.405 ms) : 46982, 47828
. : milestone, 47405,
tracing (45.203 ms) : 44813, 45594
. : milestone, 45203,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~119d76595e, baseline=1.55.0-SNAPSHOT~6dc3f85c93
dateFormat X
axisFormat %s
section baseline
no_agent (4.326 ms) : 4271, 4382
. : milestone, 4326,
iast (10.069 ms) : 9895, 10243
. : milestone, 10069,
iast_FULL (14.127 ms) : 13847, 14408
. : milestone, 14127,
iast_GLOBAL (10.354 ms) : 10162, 10547
. : milestone, 10354,
profiling (8.595 ms) : 8463, 8727
. : milestone, 8595,
tracing (7.843 ms) : 7722, 7964
. : milestone, 7843,
section candidate
no_agent (4.305 ms) : 4255, 4355
. : milestone, 4305,
iast (10.179 ms) : 10010, 10349
. : milestone, 10179,
iast_FULL (13.651 ms) : 13383, 13919
. : milestone, 13651,
iast_GLOBAL (9.85 ms) : 9680, 10019
. : milestone, 9850,
profiling (8.804 ms) : 8670, 8939
. : milestone, 8804,
tracing (7.92 ms) : 7806, 8034
. : milestone, 7920,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~119d76595e, baseline=1.55.0-SNAPSHOT~6dc3f85c93
dateFormat X
axisFormat %s
section baseline
no_agent (15.463 s) : 15463000, 15463000
. : milestone, 15463000,
appsec (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
iast (18.499 s) : 18499000, 18499000
. : milestone, 18499000,
iast_GLOBAL (18.171 s) : 18171000, 18171000
. : milestone, 18171000,
profiling (15.495 s) : 15495000, 15495000
. : milestone, 15495000,
tracing (15.118 s) : 15118000, 15118000
. : milestone, 15118000,
section candidate
no_agent (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
appsec (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
iast (18.422 s) : 18422000, 18422000
. : milestone, 18422000,
iast_GLOBAL (17.8 s) : 17800000, 17800000
. : milestone, 17800000,
profiling (15.939 s) : 15939000, 15939000
. : milestone, 15939000,
tracing (15.277 s) : 15277000, 15277000
. : milestone, 15277000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~119d76595e, baseline=1.55.0-SNAPSHOT~6dc3f85c93
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.684 ms) : 3466, 3902
. : milestone, 3684,
iast (2.203 ms) : 2140, 2267
. : milestone, 2203,
iast_GLOBAL (2.252 ms) : 2188, 2316
. : milestone, 2252,
profiling (2.083 ms) : 2029, 2137
. : milestone, 2083,
tracing (2.021 ms) : 1971, 2071
. : milestone, 2021,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.499 ms) : 2446, 2553
. : milestone, 2499,
iast (2.201 ms) : 2138, 2265
. : milestone, 2201,
iast_GLOBAL (2.241 ms) : 2177, 2305
. : milestone, 2241,
profiling (2.046 ms) : 1995, 2097
. : milestone, 2046,
tracing (2.014 ms) : 1965, 2064
. : milestone, 2014,
|
What Does This Do
Fix the following misses on the tracer stat payload:
Servicefield at top level (service is however repeated at bucket level)Sequence(was sendingSeq)RuntimeID(was sendingRuntimeId)Notes: testing will be enforced on System tests
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]