-
Notifications
You must be signed in to change notification settings - Fork 320
Don't calculate stats if dropping is disabled #9742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 37d02e8 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~37d02e8d30, baseline=1.55.0-SNAPSHOT~74931d1d31
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024419
Total [baseline] (8.68 s) : 0, 8679719
Agent [candidate] (1.026 s) : 0, 1025998
Total [candidate] (8.666 s) : 0, 8665722
section iast
Agent [baseline] (1.15 s) : 0, 1149904
Total [baseline] (9.272 s) : 0, 9271636
Agent [candidate] (1.168 s) : 0, 1168121
Total [candidate] (9.335 s) : 0, 9335337
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~37d02e8d30, baseline=1.55.0-SNAPSHOT~74931d1d31
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (697.957 ms) : 0, 697957
BytebuddyAgent [candidate] (699.545 ms) : 0, 699545
GlobalTracer [baseline] (243.076 ms) : 0, 243076
GlobalTracer [candidate] (243.427 ms) : 0, 243427
AppSec [baseline] (32.915 ms) : 0, 32915
AppSec [candidate] (32.779 ms) : 0, 32779
Debugger [baseline] (6.526 ms) : 0, 6526
Debugger [candidate] (6.441 ms) : 0, 6441
Remote Config [baseline] (707.887 µs) : 0, 708
Remote Config [candidate] (700.752 µs) : 0, 701
Telemetry [baseline] (9.398 ms) : 0, 9398
Telemetry [candidate] (9.364 ms) : 0, 9364
Flare Poller [baseline] (11.142 ms) : 0, 11142
Flare Poller [candidate] (10.903 ms) : 0, 10903
section iast
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.504 ms) : 0, 1504
BytebuddyAgent [baseline] (814.715 ms) : 0, 814715
BytebuddyAgent [candidate] (829.328 ms) : 0, 829328
GlobalTracer [baseline] (230.809 ms) : 0, 230809
GlobalTracer [candidate] (233.576 ms) : 0, 233576
IAST [baseline] (26.412 ms) : 0, 26412
IAST [candidate] (26.756 ms) : 0, 26756
AppSec [baseline] (35.54 ms) : 0, 35540
AppSec [candidate] (35.357 ms) : 0, 35357
Debugger [baseline] (6.122 ms) : 0, 6122
Debugger [candidate] (6.198 ms) : 0, 6198
Remote Config [baseline] (608.197 µs) : 0, 608
Remote Config [candidate] (617.812 µs) : 0, 618
Telemetry [baseline] (8.502 ms) : 0, 8502
Telemetry [candidate] (8.677 ms) : 0, 8677
Flare Poller [baseline] (4.198 ms) : 0, 4198
Flare Poller [candidate] (4.361 ms) : 0, 4361
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~37d02e8d30, baseline=1.55.0-SNAPSHOT~74931d1d31
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1023914
Total [baseline] (10.766 s) : 0, 10766121
Agent [candidate] (1.023 s) : 0, 1022974
Total [candidate] (10.699 s) : 0, 10698775
section appsec
Agent [baseline] (1.197 s) : 0, 1196567
Total [baseline] (11.016 s) : 0, 11016407
Agent [candidate] (1.193 s) : 0, 1193147
Total [candidate] (11.014 s) : 0, 11013693
section iast
Agent [baseline] (1.151 s) : 0, 1151095
Total [baseline] (10.933 s) : 0, 10932861
Agent [candidate] (1.161 s) : 0, 1160825
Total [candidate] (11.07 s) : 0, 11070056
section profiling
Agent [baseline] (1.161 s) : 0, 1161185
Total [baseline] (11.028 s) : 0, 11028488
Agent [candidate] (1.169 s) : 0, 1169383
Total [candidate] (11.135 s) : 0, 11135315
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~37d02e8d30, baseline=1.55.0-SNAPSHOT~74931d1d31
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (698.303 ms) : 0, 698303
BytebuddyAgent [candidate] (697.645 ms) : 0, 697645
GlobalTracer [baseline] (242.71 ms) : 0, 242710
GlobalTracer [candidate] (243.174 ms) : 0, 243174
AppSec [baseline] (32.471 ms) : 0, 32471
AppSec [candidate] (32.578 ms) : 0, 32578
Debugger [baseline] (6.433 ms) : 0, 6433
Debugger [candidate] (6.485 ms) : 0, 6485
Remote Config [baseline] (725.694 µs) : 0, 726
Remote Config [candidate] (716.263 µs) : 0, 716
Telemetry [baseline] (9.417 ms) : 0, 9417
Telemetry [candidate] (9.452 ms) : 0, 9452
Flare Poller [baseline] (10.989 ms) : 0, 10989
Flare Poller [candidate] (10.223 ms) : 0, 10223
section appsec
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (718.142 ms) : 0, 718142
BytebuddyAgent [candidate] (717.777 ms) : 0, 717777
GlobalTracer [baseline] (235.037 ms) : 0, 235037
GlobalTracer [candidate] (234.248 ms) : 0, 234248
IAST [baseline] (25.166 ms) : 0, 25166
IAST [candidate] (24.512 ms) : 0, 24512
AppSec [baseline] (176.433 ms) : 0, 176433
AppSec [candidate] (174.796 ms) : 0, 174796
Debugger [baseline] (6.128 ms) : 0, 6128
Debugger [candidate] (6.123 ms) : 0, 6123
Remote Config [baseline] (650.349 µs) : 0, 650
Remote Config [candidate] (628.939 µs) : 0, 629
Telemetry [baseline] (8.474 ms) : 0, 8474
Telemetry [candidate] (8.536 ms) : 0, 8536
Flare Poller [baseline] (3.938 ms) : 0, 3938
Flare Poller [candidate] (3.94 ms) : 0, 3940
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (815.6 ms) : 0, 815600
BytebuddyAgent [candidate] (823.187 ms) : 0, 823187
GlobalTracer [baseline] (231.319 ms) : 0, 231319
GlobalTracer [candidate] (233.018 ms) : 0, 233018
IAST [baseline] (26.283 ms) : 0, 26283
IAST [candidate] (26.609 ms) : 0, 26609
AppSec [baseline] (35.112 ms) : 0, 35112
AppSec [candidate] (34.969 ms) : 0, 34969
Debugger [baseline] (6.074 ms) : 0, 6074
Debugger [candidate] (6.21 ms) : 0, 6210
Remote Config [baseline] (618.909 µs) : 0, 619
Remote Config [candidate] (613.451 µs) : 0, 613
Telemetry [baseline] (8.75 ms) : 0, 8750
Telemetry [candidate] (8.741 ms) : 0, 8741
Flare Poller [baseline] (4.202 ms) : 0, 4202
Flare Poller [candidate] (4.274 ms) : 0, 4274
section profiling
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (720.221 ms) : 0, 720221
BytebuddyAgent [candidate] (725.408 ms) : 0, 725408
GlobalTracer [baseline] (217.378 ms) : 0, 217378
GlobalTracer [candidate] (219.077 ms) : 0, 219077
AppSec [baseline] (32.212 ms) : 0, 32212
AppSec [candidate] (32.919 ms) : 0, 32919
Debugger [baseline] (6.534 ms) : 0, 6534
Debugger [candidate] (7.345 ms) : 0, 7345
Remote Config [baseline] (734.344 µs) : 0, 734
Remote Config [candidate] (1.46 ms) : 0, 1460
Telemetry [baseline] (16.319 ms) : 0, 16319
Telemetry [candidate] (14.67 ms) : 0, 14670
Flare Poller [baseline] (4.205 ms) : 0, 4205
Flare Poller [candidate] (4.172 ms) : 0, 4172
ProfilingAgent [baseline] (108.932 ms) : 0, 108932
ProfilingAgent [candidate] (109.351 ms) : 0, 109351
Profiling [baseline] (110.077 ms) : 0, 110077
Profiling [candidate] (110.492 ms) : 0, 110492
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~37d02e8d30, baseline=1.55.0-SNAPSHOT~74931d1d31
dateFormat X
axisFormat %s
section baseline
no_agent (4.438 ms) : 4386, 4490
. : milestone, 4438,
iast (9.449 ms) : 9287, 9610
. : milestone, 9449,
iast_FULL (14.678 ms) : 14379, 14977
. : milestone, 14678,
iast_GLOBAL (10.269 ms) : 10087, 10451
. : milestone, 10269,
profiling (8.734 ms) : 8586, 8883
. : milestone, 8734,
tracing (7.716 ms) : 7606, 7826
. : milestone, 7716,
section candidate
no_agent (4.504 ms) : 4453, 4555
. : milestone, 4504,
iast (10.22 ms) : 10042, 10399
. : milestone, 10220,
iast_FULL (14.227 ms) : 13948, 14506
. : milestone, 14227,
iast_GLOBAL (11.025 ms) : 10828, 11222
. : milestone, 11025,
profiling (8.594 ms) : 8463, 8724
. : milestone, 8594,
tracing (7.975 ms) : 7860, 8089
. : milestone, 7975,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~37d02e8d30, baseline=1.55.0-SNAPSHOT~74931d1d31
dateFormat X
axisFormat %s
section baseline
no_agent (36.651 ms) : 36349, 36954
. : milestone, 36651,
appsec (47.929 ms) : 47501, 48356
. : milestone, 47929,
code_origins (43.459 ms) : 43080, 43838
. : milestone, 43459,
iast (45.127 ms) : 44737, 45517
. : milestone, 45127,
profiling (47.423 ms) : 47007, 47840
. : milestone, 47423,
tracing (44.624 ms) : 44231, 45017
. : milestone, 44624,
section candidate
no_agent (37.238 ms) : 36934, 37542
. : milestone, 37238,
appsec (49.691 ms) : 49238, 50145
. : milestone, 49691,
code_origins (43.697 ms) : 43311, 44083
. : milestone, 43697,
iast (46.446 ms) : 46049, 46843
. : milestone, 46446,
profiling (47.433 ms) : 46989, 47877
. : milestone, 47433,
tracing (45.455 ms) : 45061, 45849
. : milestone, 45455,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~37d02e8d30, baseline=1.55.0-SNAPSHOT~74931d1d31
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.734 ms) : 3516, 3952
. : milestone, 3734,
iast (2.213 ms) : 2150, 2277
. : milestone, 2213,
iast_GLOBAL (2.253 ms) : 2189, 2317
. : milestone, 2253,
profiling (2.068 ms) : 2016, 2120
. : milestone, 2068,
tracing (2.033 ms) : 1984, 2083
. : milestone, 2033,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.465 ms) : 2414, 2515
. : milestone, 2465,
iast (2.21 ms) : 2146, 2273
. : milestone, 2210,
iast_GLOBAL (2.256 ms) : 2193, 2320
. : milestone, 2256,
profiling (2.049 ms) : 1998, 2099
. : milestone, 2049,
tracing (2.032 ms) : 1983, 2081
. : milestone, 2032,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~37d02e8d30, baseline=1.55.0-SNAPSHOT~74931d1d31
dateFormat X
axisFormat %s
section baseline
no_agent (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
appsec (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
iast (18.412 s) : 18412000, 18412000
. : milestone, 18412000,
iast_GLOBAL (18.04 s) : 18040000, 18040000
. : milestone, 18040000,
profiling (14.907 s) : 14907000, 14907000
. : milestone, 14907000,
tracing (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
section candidate
no_agent (15.65 s) : 15650000, 15650000
. : milestone, 15650000,
appsec (15.081 s) : 15081000, 15081000
. : milestone, 15081000,
iast (18.797 s) : 18797000, 18797000
. : milestone, 18797000,
iast_GLOBAL (18.339 s) : 18339000, 18339000
. : milestone, 18339000,
profiling (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
tracing (15.305 s) : 15305000, 15305000
. : milestone, 15305000,
|
What Does This Do
Disable client stats if the agent does not support p0 drops. This is an optimisation since, in this case, we're going to calculate the stats AND send everything in any case to the agent. At this point we can just let the agent calculate the stats (since it has all the spans) and avoid an extra overhead on tracer side for the stats calculation
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]