-
Notifications
You must be signed in to change notification settings - Fork 320
Enable client side stats by default #9740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 57524cf | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~57524cf7f9, baseline=1.55.0-SNAPSHOT~ff79486cac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1015624
Total [baseline] (10.618 s) : 0, 10618019
Agent [candidate] (1.016 s) : 0, 1015793
Total [candidate] (10.633 s) : 0, 10632848
section appsec
Agent [baseline] (1.2 s) : 0, 1199897
Total [baseline] (11.059 s) : 0, 11058568
Agent [candidate] (1.193 s) : 0, 1193288
Total [candidate] (11.077 s) : 0, 11077484
section iast
Agent [baseline] (1.152 s) : 0, 1152092
Total [baseline] (11.0 s) : 0, 11000354
Agent [candidate] (1.148 s) : 0, 1148220
Total [candidate] (10.972 s) : 0, 10971642
section profiling
Agent [baseline] (1.163 s) : 0, 1162769
Total [baseline] (11.015 s) : 0, 11014582
Agent [candidate] (1.166 s) : 0, 1166258
Total [candidate] (11.046 s) : 0, 11046129
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~57524cf7f9, baseline=1.55.0-SNAPSHOT~ff79486cac
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (691.946 ms) : 0, 691946
BytebuddyAgent [candidate] (693.115 ms) : 0, 693115
GlobalTracer [baseline] (241.782 ms) : 0, 241782
GlobalTracer [candidate] (242.04 ms) : 0, 242040
AppSec [baseline] (32.51 ms) : 0, 32510
AppSec [candidate] (32.47 ms) : 0, 32470
Debugger [baseline] (6.424 ms) : 0, 6424
Debugger [candidate] (6.402 ms) : 0, 6402
Remote Config [baseline] (708.789 µs) : 0, 709
Remote Config [candidate] (696.419 µs) : 0, 696
Telemetry [baseline] (9.334 ms) : 0, 9334
Telemetry [candidate] (9.214 ms) : 0, 9214
Flare Poller [baseline] (10.304 ms) : 0, 10304
Flare Poller [candidate] (9.354 ms) : 0, 9354
section appsec
crashtracking [baseline] (1.489 ms) : 0, 1489
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (722.018 ms) : 0, 722018
BytebuddyAgent [candidate] (716.751 ms) : 0, 716751
GlobalTracer [baseline] (235.579 ms) : 0, 235579
GlobalTracer [candidate] (234.927 ms) : 0, 234927
IAST [baseline] (24.779 ms) : 0, 24779
IAST [candidate] (24.797 ms) : 0, 24797
AppSec [baseline] (175.758 ms) : 0, 175758
AppSec [candidate] (175.183 ms) : 0, 175183
Debugger [baseline] (6.129 ms) : 0, 6129
Debugger [candidate] (6.182 ms) : 0, 6182
Remote Config [baseline] (636.022 µs) : 0, 636
Remote Config [candidate] (630.123 µs) : 0, 630
Telemetry [baseline] (8.408 ms) : 0, 8408
Telemetry [candidate] (8.442 ms) : 0, 8442
Flare Poller [baseline] (3.955 ms) : 0, 3955
Flare Poller [candidate] (3.937 ms) : 0, 3937
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (815.873 ms) : 0, 815873
BytebuddyAgent [candidate] (813.548 ms) : 0, 813548
GlobalTracer [baseline] (231.783 ms) : 0, 231783
GlobalTracer [candidate] (230.965 ms) : 0, 230965
IAST [baseline] (26.491 ms) : 0, 26491
IAST [candidate] (26.222 ms) : 0, 26222
AppSec [baseline] (35.338 ms) : 0, 35338
AppSec [candidate] (35.123 ms) : 0, 35123
Debugger [baseline] (6.135 ms) : 0, 6135
Debugger [candidate] (6.074 ms) : 0, 6074
Remote Config [baseline] (604.257 µs) : 0, 604
Remote Config [candidate] (593.964 µs) : 0, 594
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.621 ms) : 0, 8621
Flare Poller [baseline] (4.238 ms) : 0, 4238
Flare Poller [candidate] (4.212 ms) : 0, 4212
section profiling
crashtracking [baseline] (1.441 ms) : 0, 1441
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (722.196 ms) : 0, 722196
BytebuddyAgent [candidate] (725.21 ms) : 0, 725210
GlobalTracer [baseline] (217.805 ms) : 0, 217805
GlobalTracer [candidate] (218.735 ms) : 0, 218735
AppSec [baseline] (32.402 ms) : 0, 32402
AppSec [candidate] (32.468 ms) : 0, 32468
Debugger [baseline] (6.527 ms) : 0, 6527
Debugger [candidate] (7.266 ms) : 0, 7266
Remote Config [baseline] (791.351 µs) : 0, 791
Remote Config [candidate] (754.705 µs) : 0, 755
Telemetry [baseline] (16.346 ms) : 0, 16346
Telemetry [candidate] (15.263 ms) : 0, 15263
Flare Poller [baseline] (4.155 ms) : 0, 4155
Flare Poller [candidate] (4.135 ms) : 0, 4135
ProfilingAgent [baseline] (108.469 ms) : 0, 108469
ProfilingAgent [candidate] (107.675 ms) : 0, 107675
Profiling [baseline] (109.184 ms) : 0, 109184
Profiling [candidate] (108.657 ms) : 0, 108657
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~57524cf7f9, baseline=1.55.0-SNAPSHOT~ff79486cac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018831
Total [baseline] (8.66 s) : 0, 8660344
Agent [candidate] (1.017 s) : 0, 1017024
Total [candidate] (8.674 s) : 0, 8673550
section iast
Agent [baseline] (1.153 s) : 0, 1152780
Total [baseline] (9.309 s) : 0, 9309243
Agent [candidate] (1.155 s) : 0, 1154650
Total [candidate] (9.304 s) : 0, 9304401
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~57524cf7f9, baseline=1.55.0-SNAPSHOT~ff79486cac
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (694.045 ms) : 0, 694045
BytebuddyAgent [candidate] (692.766 ms) : 0, 692766
GlobalTracer [baseline] (242.158 ms) : 0, 242158
GlobalTracer [candidate] (241.828 ms) : 0, 241828
AppSec [baseline] (32.658 ms) : 0, 32658
AppSec [candidate] (32.539 ms) : 0, 32539
Debugger [baseline] (6.422 ms) : 0, 6422
Debugger [candidate] (6.481 ms) : 0, 6481
Remote Config [baseline] (704.17 µs) : 0, 704
Remote Config [candidate] (699.809 µs) : 0, 700
Telemetry [baseline] (9.232 ms) : 0, 9232
Telemetry [candidate] (9.283 ms) : 0, 9283
Flare Poller [baseline] (11.034 ms) : 0, 11034
Flare Poller [candidate] (10.893 ms) : 0, 10893
section iast
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (816.618 ms) : 0, 816618
BytebuddyAgent [candidate] (817.607 ms) : 0, 817607
GlobalTracer [baseline] (231.774 ms) : 0, 231774
GlobalTracer [candidate] (232.094 ms) : 0, 232094
IAST [baseline] (26.63 ms) : 0, 26630
IAST [candidate] (26.725 ms) : 0, 26725
AppSec [baseline] (35.046 ms) : 0, 35046
AppSec [candidate] (35.307 ms) : 0, 35307
Debugger [baseline] (6.152 ms) : 0, 6152
Debugger [candidate] (6.196 ms) : 0, 6196
Remote Config [baseline] (613.011 µs) : 0, 613
Remote Config [candidate] (652.347 µs) : 0, 652
Telemetry [baseline] (8.691 ms) : 0, 8691
Telemetry [candidate] (8.815 ms) : 0, 8815
Flare Poller [baseline] (4.218 ms) : 0, 4218
Flare Poller [candidate] (4.268 ms) : 0, 4268
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~57524cf7f9, baseline=1.55.0-SNAPSHOT~ff79486cac
dateFormat X
axisFormat %s
section baseline
no_agent (4.233 ms) : 4180, 4286
. : milestone, 4233,
iast (9.333 ms) : 9172, 9495
. : milestone, 9333,
iast_FULL (14.088 ms) : 13809, 14366
. : milestone, 14088,
iast_GLOBAL (10.3 ms) : 10118, 10482
. : milestone, 10300,
profiling (8.872 ms) : 8723, 9021
. : milestone, 8872,
tracing (7.734 ms) : 7624, 7843
. : milestone, 7734,
section candidate
no_agent (4.442 ms) : 4393, 4492
. : milestone, 4442,
iast (9.808 ms) : 9645, 9971
. : milestone, 9808,
iast_FULL (13.734 ms) : 13462, 14006
. : milestone, 13734,
iast_GLOBAL (10.12 ms) : 9939, 10301
. : milestone, 10120,
profiling (8.936 ms) : 8785, 9086
. : milestone, 8936,
tracing (7.901 ms) : 7784, 8018
. : milestone, 7901,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~57524cf7f9, baseline=1.55.0-SNAPSHOT~ff79486cac
dateFormat X
axisFormat %s
section baseline
no_agent (37.261 ms) : 36970, 37552
. : milestone, 37261,
appsec (49.378 ms) : 48946, 49809
. : milestone, 49378,
code_origins (42.546 ms) : 42176, 42916
. : milestone, 42546,
iast (43.29 ms) : 42925, 43655
. : milestone, 43290,
profiling (48.727 ms) : 48275, 49179
. : milestone, 48727,
tracing (45.48 ms) : 45095, 45866
. : milestone, 45480,
section candidate
no_agent (36.509 ms) : 36215, 36804
. : milestone, 36509,
appsec (48.836 ms) : 48408, 49264
. : milestone, 48836,
code_origins (43.777 ms) : 43383, 44172
. : milestone, 43777,
iast (44.782 ms) : 44390, 45174
. : milestone, 44782,
profiling (49.611 ms) : 49168, 50055
. : milestone, 49611,
tracing (44.806 ms) : 44417, 45195
. : milestone, 44806,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~57524cf7f9, baseline=1.55.0-SNAPSHOT~ff79486cac
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.726 ms) : 3507, 3945
. : milestone, 3726,
iast (2.21 ms) : 2146, 2274
. : milestone, 2210,
iast_GLOBAL (2.255 ms) : 2191, 2320
. : milestone, 2255,
profiling (2.073 ms) : 2020, 2126
. : milestone, 2073,
tracing (2.03 ms) : 1980, 2080
. : milestone, 2030,
section candidate
no_agent (1.472 ms) : 1461, 1483
. : milestone, 1472,
appsec (2.454 ms) : 2403, 2505
. : milestone, 2454,
iast (2.205 ms) : 2140, 2270
. : milestone, 2205,
iast_GLOBAL (2.252 ms) : 2188, 2317
. : milestone, 2252,
profiling (2.044 ms) : 1992, 2096
. : milestone, 2044,
tracing (2.03 ms) : 1980, 2081
. : milestone, 2030,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~57524cf7f9, baseline=1.55.0-SNAPSHOT~ff79486cac
dateFormat X
axisFormat %s
section baseline
no_agent (14.726 s) : 14726000, 14726000
. : milestone, 14726000,
appsec (15.11 s) : 15110000, 15110000
. : milestone, 15110000,
iast (18.273 s) : 18273000, 18273000
. : milestone, 18273000,
iast_GLOBAL (17.962 s) : 17962000, 17962000
. : milestone, 17962000,
profiling (14.835 s) : 14835000, 14835000
. : milestone, 14835000,
tracing (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
section candidate
no_agent (15.018 s) : 15018000, 15018000
. : milestone, 15018000,
appsec (14.886 s) : 14886000, 14886000
. : milestone, 14886000,
iast (18.347 s) : 18347000, 18347000
. : milestone, 18347000,
iast_GLOBAL (17.96 s) : 17960000, 17960000
. : milestone, 17960000,
profiling (15.555 s) : 15555000, 15555000
. : milestone, 15555000,
tracing (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
|
What Does This Do
Enable trace stats computation on client side instead that on the agent.
It can be still disabled by setting
DD_TRACE_STATS_COMPUTATION_ENABLED=falseMotivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]