-
Notifications
You must be signed in to change notification settings - Fork 320
Use 'vm' stackwalker as default for java profiler #9722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: a704a38 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 3 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~a704a38926, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019936
Total [baseline] (10.75 s) : 0, 10750459
Agent [candidate] (1.014 s) : 0, 1013845
Total [candidate] (10.728 s) : 0, 10727741
section appsec
Agent [baseline] (1.191 s) : 0, 1191094
Total [baseline] (11.044 s) : 0, 11044093
Agent [candidate] (1.193 s) : 0, 1192871
Total [candidate] (11.14 s) : 0, 11139717
section iast
Agent [baseline] (1.149 s) : 0, 1148533
Total [baseline] (11.01 s) : 0, 11009708
Agent [candidate] (1.15 s) : 0, 1150437
Total [candidate] (11.0 s) : 0, 11000073
section profiling
Agent [baseline] (1.166 s) : 0, 1165509
Total [baseline] (11.077 s) : 0, 11076691
Agent [candidate] (1.165 s) : 0, 1165193
Total [candidate] (11.103 s) : 0, 11102640
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~a704a38926, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (695.435 ms) : 0, 695435
BytebuddyAgent [candidate] (692.066 ms) : 0, 692066
GlobalTracer [baseline] (242.764 ms) : 0, 242764
GlobalTracer [candidate] (241.647 ms) : 0, 241647
AppSec [baseline] (32.384 ms) : 0, 32384
AppSec [candidate] (32.434 ms) : 0, 32434
Debugger [baseline] (6.414 ms) : 0, 6414
Debugger [candidate] (6.391 ms) : 0, 6391
Remote Config [baseline] (711.215 µs) : 0, 711
Remote Config [candidate] (703.764 µs) : 0, 704
Telemetry [baseline] (9.339 ms) : 0, 9339
Telemetry [candidate] (9.225 ms) : 0, 9225
Flare Poller [baseline] (10.126 ms) : 0, 10126
Flare Poller [candidate] (8.615 ms) : 0, 8615
section appsec
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (714.977 ms) : 0, 714977
BytebuddyAgent [candidate] (716.71 ms) : 0, 716710
GlobalTracer [baseline] (233.728 ms) : 0, 233728
GlobalTracer [candidate] (234.191 ms) : 0, 234191
AppSec [baseline] (175.02 ms) : 0, 175020
AppSec [candidate] (174.82 ms) : 0, 174820
Debugger [baseline] (6.181 ms) : 0, 6181
Debugger [candidate] (6.103 ms) : 0, 6103
Remote Config [baseline] (639.421 µs) : 0, 639
Remote Config [candidate] (631.744 µs) : 0, 632
Telemetry [baseline] (9.24 ms) : 0, 9240
Telemetry [candidate] (9.208 ms) : 0, 9208
Flare Poller [baseline] (3.949 ms) : 0, 3949
Flare Poller [candidate] (3.946 ms) : 0, 3946
IAST [baseline] (24.876 ms) : 0, 24876
IAST [candidate] (24.727 ms) : 0, 24727
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (813.688 ms) : 0, 813688
BytebuddyAgent [candidate] (815.022 ms) : 0, 815022
GlobalTracer [baseline] (231.277 ms) : 0, 231277
GlobalTracer [candidate] (231.525 ms) : 0, 231525
AppSec [baseline] (35.064 ms) : 0, 35064
AppSec [candidate] (35.026 ms) : 0, 35026
Debugger [baseline] (6.12 ms) : 0, 6120
Debugger [candidate] (6.116 ms) : 0, 6116
Remote Config [baseline] (607.851 µs) : 0, 608
Remote Config [candidate] (609.372 µs) : 0, 609
Telemetry [baseline] (8.496 ms) : 0, 8496
Telemetry [candidate] (8.597 ms) : 0, 8597
Flare Poller [baseline] (4.223 ms) : 0, 4223
Flare Poller [candidate] (4.261 ms) : 0, 4261
IAST [baseline] (26.276 ms) : 0, 26276
IAST [candidate] (26.416 ms) : 0, 26416
section profiling
ProfilingAgent [baseline] (108.158 ms) : 0, 108158
ProfilingAgent [candidate] (107.11 ms) : 0, 107110
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (722.806 ms) : 0, 722806
BytebuddyAgent [candidate] (724.109 ms) : 0, 724109
GlobalTracer [baseline] (219.164 ms) : 0, 219164
GlobalTracer [candidate] (218.291 ms) : 0, 218291
AppSec [baseline] (32.98 ms) : 0, 32980
AppSec [candidate] (32.907 ms) : 0, 32907
Debugger [baseline] (6.538 ms) : 0, 6538
Debugger [candidate] (6.52 ms) : 0, 6520
Remote Config [baseline] (702.05 µs) : 0, 702
Remote Config [candidate] (711.044 µs) : 0, 711
Telemetry [baseline] (16.691 ms) : 0, 16691
Telemetry [candidate] (16.514 ms) : 0, 16514
Flare Poller [baseline] (4.253 ms) : 0, 4253
Flare Poller [candidate] (4.186 ms) : 0, 4186
Profiling [baseline] (109.018 ms) : 0, 109018
Profiling [candidate] (108.408 ms) : 0, 108408
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~a704a38926, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018010
Total [baseline] (8.675 s) : 0, 8675241
Agent [candidate] (1.022 s) : 0, 1021620
Total [candidate] (8.672 s) : 0, 8671648
section iast
Agent [baseline] (1.152 s) : 0, 1152486
Total [baseline] (9.331 s) : 0, 9330944
Agent [candidate] (1.146 s) : 0, 1145749
Total [candidate] (9.301 s) : 0, 9300906
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~a704a38926, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.495 ms) : 0, 1495
BytebuddyAgent [baseline] (694.284 ms) : 0, 694284
BytebuddyAgent [candidate] (696.689 ms) : 0, 696689
GlobalTracer [baseline] (241.836 ms) : 0, 241836
GlobalTracer [candidate] (241.846 ms) : 0, 241846
AppSec [baseline] (32.372 ms) : 0, 32372
AppSec [candidate] (32.315 ms) : 0, 32315
Debugger [baseline] (6.456 ms) : 0, 6456
Debugger [candidate] (6.446 ms) : 0, 6446
Remote Config [baseline] (697.577 µs) : 0, 698
Remote Config [candidate] (704.849 µs) : 0, 705
Telemetry [baseline] (9.397 ms) : 0, 9397
Telemetry [candidate] (9.321 ms) : 0, 9321
Flare Poller [baseline] (10.342 ms) : 0, 10342
Flare Poller [candidate] (11.594 ms) : 0, 11594
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (816.716 ms) : 0, 816716
BytebuddyAgent [candidate] (811.983 ms) : 0, 811983
GlobalTracer [baseline] (231.688 ms) : 0, 231688
GlobalTracer [candidate] (230.525 ms) : 0, 230525
AppSec [baseline] (35.165 ms) : 0, 35165
AppSec [candidate] (34.987 ms) : 0, 34987
Debugger [baseline] (6.102 ms) : 0, 6102
Debugger [candidate] (6.074 ms) : 0, 6074
Remote Config [baseline] (604.094 µs) : 0, 604
Remote Config [candidate] (602.788 µs) : 0, 603
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.489 ms) : 0, 8489
Flare Poller [baseline] (4.243 ms) : 0, 4243
Flare Poller [candidate] (4.284 ms) : 0, 4284
IAST [baseline] (26.608 ms) : 0, 26608
IAST [candidate] (26.112 ms) : 0, 26112
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~a704a38926, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (37.46 ms) : 37152, 37767
. : milestone, 37460,
appsec (48.175 ms) : 47741, 48608
. : milestone, 48175,
code_origins (46.023 ms) : 45624, 46422
. : milestone, 46023,
iast (44.574 ms) : 44180, 44969
. : milestone, 44574,
profiling (52.244 ms) : 51724, 52764
. : milestone, 52244,
tracing (45.395 ms) : 44998, 45792
. : milestone, 45395,
section candidate
no_agent (37.997 ms) : 37692, 38301
. : milestone, 37997,
appsec (50.224 ms) : 49779, 50670
. : milestone, 50224,
code_origins (42.807 ms) : 42444, 43170
. : milestone, 42807,
iast (44.751 ms) : 44360, 45142
. : milestone, 44751,
profiling (47.561 ms) : 47111, 48010
. : milestone, 47561,
tracing (45.244 ms) : 44854, 45634
. : milestone, 45244,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~a704a38926, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (4.434 ms) : 4383, 4484
. : milestone, 4434,
iast (10.067 ms) : 9898, 10236
. : milestone, 10067,
iast_FULL (14.759 ms) : 14457, 15062
. : milestone, 14759,
iast_GLOBAL (10.907 ms) : 10710, 11104
. : milestone, 10907,
profiling (8.966 ms) : 8823, 9109
. : milestone, 8966,
tracing (7.761 ms) : 7650, 7872
. : milestone, 7761,
section candidate
no_agent (4.3 ms) : 4247, 4353
. : milestone, 4300,
iast (9.86 ms) : 9696, 10024
. : milestone, 9860,
iast_FULL (14.252 ms) : 13966, 14538
. : milestone, 14252,
iast_GLOBAL (10.433 ms) : 10249, 10618
. : milestone, 10433,
profiling (9.452 ms) : 9276, 9629
. : milestone, 9452,
tracing (7.688 ms) : 7571, 7805
. : milestone, 7688,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~a704a38926, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
appsec (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
iast (18.695 s) : 18695000, 18695000
. : milestone, 18695000,
iast_GLOBAL (18.018 s) : 18018000, 18018000
. : milestone, 18018000,
profiling (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
tracing (15.046 s) : 15046000, 15046000
. : milestone, 15046000,
section candidate
no_agent (15.285 s) : 15285000, 15285000
. : milestone, 15285000,
appsec (15.118 s) : 15118000, 15118000
. : milestone, 15118000,
iast (18.683 s) : 18683000, 18683000
. : milestone, 18683000,
iast_GLOBAL (18.068 s) : 18068000, 18068000
. : milestone, 18068000,
profiling (15.361 s) : 15361000, 15361000
. : milestone, 15361000,
tracing (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~a704a38926, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.718 ms) : 3501, 3936
. : milestone, 3718,
iast (2.207 ms) : 2144, 2270
. : milestone, 2207,
iast_GLOBAL (2.254 ms) : 2191, 2318
. : milestone, 2254,
profiling (2.053 ms) : 2002, 2104
. : milestone, 2053,
tracing (2.02 ms) : 1970, 2069
. : milestone, 2020,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.668 ms) : 3454, 3883
. : milestone, 3668,
iast (2.218 ms) : 2154, 2282
. : milestone, 2218,
iast_GLOBAL (2.245 ms) : 2181, 2309
. : milestone, 2245,
profiling (2.075 ms) : 2023, 2128
. : milestone, 2075,
tracing (2.042 ms) : 1992, 2092
. : milestone, 2042,
|
db279bc to
a704a38
Compare
|
Woohoo! This is great! We had a weird JVM crash with the previous default (fp) when using Tensorflow Java through JNI (support ticket 2214245). |
What Does This Do
Bumps the ddprof version and sets the java profiler stackwalker default to 'vm' (vmstructs)
Motivation
The VM stackwalker got into quite good condition so it can be used as the default implementation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-11264