-
Notifications
You must be signed in to change notification settings - Fork 320
Extract library name and address from native error reports #9721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: f6e9a0a | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~f6e9a0a2d3, baseline=1.55.0-SNAPSHOT~f3999b7c6d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1040029
Total [baseline] (8.75 s) : 0, 8750484
Agent [candidate] (1.02 s) : 0, 1019686
Total [candidate] (8.685 s) : 0, 8685255
section iast
Agent [baseline] (1.153 s) : 0, 1152541
Total [baseline] (9.282 s) : 0, 9282451
Agent [candidate] (1.163 s) : 0, 1162541
Total [candidate] (9.327 s) : 0, 9327255
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~f6e9a0a2d3, baseline=1.55.0-SNAPSHOT~f3999b7c6d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.508 ms) : 0, 1508
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (713.076 ms) : 0, 713076
BytebuddyAgent [candidate] (695.119 ms) : 0, 695119
GlobalTracer [baseline] (245.2 ms) : 0, 245200
GlobalTracer [candidate] (242.1 ms) : 0, 242100
AppSec [baseline] (33.046 ms) : 0, 33046
AppSec [candidate] (32.404 ms) : 0, 32404
Debugger [baseline] (6.584 ms) : 0, 6584
Debugger [candidate] (6.415 ms) : 0, 6415
Remote Config [baseline] (716.332 µs) : 0, 716
Remote Config [candidate] (702.416 µs) : 0, 702
Telemetry [baseline] (9.419 ms) : 0, 9419
Telemetry [candidate] (9.359 ms) : 0, 9359
Flare Poller [baseline] (8.926 ms) : 0, 8926
Flare Poller [candidate] (10.922 ms) : 0, 10922
section iast
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (815.921 ms) : 0, 815921
BytebuddyAgent [candidate] (823.7 ms) : 0, 823700
GlobalTracer [baseline] (232.464 ms) : 0, 232464
GlobalTracer [candidate] (233.992 ms) : 0, 233992
IAST [baseline] (26.521 ms) : 0, 26521
IAST [candidate] (26.906 ms) : 0, 26906
AppSec [baseline] (35.295 ms) : 0, 35295
AppSec [candidate] (35.176 ms) : 0, 35176
Debugger [baseline] (6.096 ms) : 0, 6096
Debugger [candidate] (6.16 ms) : 0, 6160
Remote Config [baseline] (605.64 µs) : 0, 606
Remote Config [candidate] (618.526 µs) : 0, 619
Telemetry [baseline] (8.603 ms) : 0, 8603
Telemetry [candidate] (8.853 ms) : 0, 8853
Flare Poller [baseline] (4.235 ms) : 0, 4235
Flare Poller [candidate] (4.235 ms) : 0, 4235
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~f6e9a0a2d3, baseline=1.55.0-SNAPSHOT~f3999b7c6d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021164
Total [baseline] (10.729 s) : 0, 10729122
Agent [candidate] (1.017 s) : 0, 1016773
Total [candidate] (10.725 s) : 0, 10724866
section appsec
Agent [baseline] (1.197 s) : 0, 1197446
Total [baseline] (11.059 s) : 0, 11059334
Agent [candidate] (1.196 s) : 0, 1196413
Total [candidate] (11.116 s) : 0, 11116395
section iast
Agent [baseline] (1.152 s) : 0, 1151870
Total [baseline] (11.034 s) : 0, 11033561
Agent [candidate] (1.161 s) : 0, 1160904
Total [candidate] (10.962 s) : 0, 10962242
section profiling
Agent [baseline] (1.161 s) : 0, 1161241
Total [baseline] (11.071 s) : 0, 11070925
Agent [candidate] (1.172 s) : 0, 1171620
Total [candidate] (11.104 s) : 0, 11104391
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~f6e9a0a2d3, baseline=1.55.0-SNAPSHOT~f3999b7c6d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (696.356 ms) : 0, 696356
BytebuddyAgent [candidate] (692.97 ms) : 0, 692970
GlobalTracer [baseline] (242.784 ms) : 0, 242784
GlobalTracer [candidate] (241.594 ms) : 0, 241594
AppSec [baseline] (32.302 ms) : 0, 32302
AppSec [candidate] (32.137 ms) : 0, 32137
Debugger [baseline] (6.426 ms) : 0, 6426
Debugger [candidate] (6.472 ms) : 0, 6472
Remote Config [baseline] (725.22 µs) : 0, 725
Remote Config [candidate] (710.479 µs) : 0, 710
Telemetry [baseline] (9.36 ms) : 0, 9360
Telemetry [candidate] (9.412 ms) : 0, 9412
Flare Poller [baseline] (10.405 ms) : 0, 10405
Flare Poller [candidate] (10.845 ms) : 0, 10845
section appsec
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (719.856 ms) : 0, 719856
BytebuddyAgent [candidate] (718.569 ms) : 0, 718569
GlobalTracer [baseline] (235.143 ms) : 0, 235143
GlobalTracer [candidate] (235.0 ms) : 0, 235000
AppSec [baseline] (175.398 ms) : 0, 175398
AppSec [candidate] (176.224 ms) : 0, 176224
Debugger [baseline] (6.193 ms) : 0, 6193
Debugger [candidate] (6.173 ms) : 0, 6173
Remote Config [baseline] (646.996 µs) : 0, 647
Remote Config [candidate] (636.401 µs) : 0, 636
Telemetry [baseline] (8.549 ms) : 0, 8549
Telemetry [candidate] (8.522 ms) : 0, 8522
Flare Poller [baseline] (4.051 ms) : 0, 4051
Flare Poller [candidate] (3.92 ms) : 0, 3920
IAST [baseline] (24.971 ms) : 0, 24971
IAST [candidate] (24.786 ms) : 0, 24786
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (815.316 ms) : 0, 815316
BytebuddyAgent [candidate] (822.752 ms) : 0, 822752
GlobalTracer [baseline] (231.817 ms) : 0, 231817
GlobalTracer [candidate] (233.42 ms) : 0, 233420
AppSec [baseline] (35.795 ms) : 0, 35795
AppSec [candidate] (35.353 ms) : 0, 35353
Debugger [baseline] (6.148 ms) : 0, 6148
Debugger [candidate] (6.16 ms) : 0, 6160
Remote Config [baseline] (613.283 µs) : 0, 613
Remote Config [candidate] (628.768 µs) : 0, 629
Telemetry [baseline] (8.647 ms) : 0, 8647
Telemetry [candidate] (8.709 ms) : 0, 8709
Flare Poller [baseline] (4.32 ms) : 0, 4320
Flare Poller [candidate] (4.202 ms) : 0, 4202
IAST [baseline] (26.388 ms) : 0, 26388
IAST [candidate] (26.64 ms) : 0, 26640
section profiling
ProfilingAgent [baseline] (107.682 ms) : 0, 107682
ProfilingAgent [candidate] (109.5 ms) : 0, 109500
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (721.089 ms) : 0, 721089
BytebuddyAgent [candidate] (727.162 ms) : 0, 727162
GlobalTracer [baseline] (217.513 ms) : 0, 217513
GlobalTracer [candidate] (219.621 ms) : 0, 219621
AppSec [baseline] (32.331 ms) : 0, 32331
AppSec [candidate] (32.653 ms) : 0, 32653
Debugger [baseline] (6.468 ms) : 0, 6468
Debugger [candidate] (8.156 ms) : 0, 8156
Remote Config [baseline] (751.045 µs) : 0, 751
Remote Config [candidate] (1.575 ms) : 0, 1575
Telemetry [baseline] (15.356 ms) : 0, 15356
Telemetry [candidate] (13.791 ms) : 0, 13791
Flare Poller [baseline] (4.899 ms) : 0, 4899
Flare Poller [candidate] (4.145 ms) : 0, 4145
Profiling [baseline] (109.21 ms) : 0, 109210
Profiling [candidate] (110.63 ms) : 0, 110630
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~f6e9a0a2d3, baseline=1.55.0-SNAPSHOT~f3999b7c6d
dateFormat X
axisFormat %s
section baseline
no_agent (37.392 ms) : 37089, 37696
. : milestone, 37392,
appsec (47.17 ms) : 46751, 47588
. : milestone, 47170,
code_origins (44.176 ms) : 43805, 44547
. : milestone, 44176,
iast (45.007 ms) : 44626, 45387
. : milestone, 45007,
profiling (49.49 ms) : 49046, 49934
. : milestone, 49490,
tracing (45.855 ms) : 45451, 46259
. : milestone, 45855,
section candidate
no_agent (36.714 ms) : 36416, 37013
. : milestone, 36714,
appsec (49.291 ms) : 48841, 49742
. : milestone, 49291,
code_origins (43.712 ms) : 43332, 44093
. : milestone, 43712,
iast (43.889 ms) : 43519, 44260
. : milestone, 43889,
profiling (48.079 ms) : 47596, 48562
. : milestone, 48079,
tracing (44.665 ms) : 44276, 45054
. : milestone, 44665,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~f6e9a0a2d3, baseline=1.55.0-SNAPSHOT~f3999b7c6d
dateFormat X
axisFormat %s
section baseline
no_agent (4.359 ms) : 4311, 4408
. : milestone, 4359,
iast (9.998 ms) : 9831, 10164
. : milestone, 9998,
iast_FULL (14.381 ms) : 14092, 14669
. : milestone, 14381,
iast_GLOBAL (10.05 ms) : 9864, 10236
. : milestone, 10050,
profiling (8.773 ms) : 8631, 8916
. : milestone, 8773,
tracing (7.805 ms) : 7695, 7915
. : milestone, 7805,
section candidate
no_agent (4.253 ms) : 4197, 4308
. : milestone, 4253,
iast (9.558 ms) : 9397, 9719
. : milestone, 9558,
iast_FULL (13.675 ms) : 13407, 13944
. : milestone, 13675,
iast_GLOBAL (10.981 ms) : 10784, 11178
. : milestone, 10981,
profiling (8.553 ms) : 8419, 8686
. : milestone, 8553,
tracing (7.803 ms) : 7683, 7922
. : milestone, 7803,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~f6e9a0a2d3, baseline=1.55.0-SNAPSHOT~f3999b7c6d
dateFormat X
axisFormat %s
section baseline
no_agent (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
appsec (15.226 s) : 15226000, 15226000
. : milestone, 15226000,
iast (18.607 s) : 18607000, 18607000
. : milestone, 18607000,
iast_GLOBAL (18.28 s) : 18280000, 18280000
. : milestone, 18280000,
profiling (14.816 s) : 14816000, 14816000
. : milestone, 14816000,
tracing (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
section candidate
no_agent (15.616 s) : 15616000, 15616000
. : milestone, 15616000,
appsec (15.183 s) : 15183000, 15183000
. : milestone, 15183000,
iast (18.487 s) : 18487000, 18487000
. : milestone, 18487000,
iast_GLOBAL (17.784 s) : 17784000, 17784000
. : milestone, 17784000,
profiling (15.382 s) : 15382000, 15382000
. : milestone, 15382000,
tracing (15.214 s) : 15214000, 15214000
. : milestone, 15214000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~f6e9a0a2d3, baseline=1.55.0-SNAPSHOT~f3999b7c6d
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.705 ms) : 3488, 3922
. : milestone, 3705,
iast (2.198 ms) : 2134, 2261
. : milestone, 2198,
iast_GLOBAL (2.232 ms) : 2168, 2295
. : milestone, 2232,
profiling (2.064 ms) : 2011, 2117
. : milestone, 2064,
tracing (2.019 ms) : 1969, 2068
. : milestone, 2019,
section candidate
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (3.702 ms) : 3484, 3920
. : milestone, 3702,
iast (2.197 ms) : 2133, 2261
. : milestone, 2197,
iast_GLOBAL (2.249 ms) : 2185, 2313
. : milestone, 2249,
profiling (2.076 ms) : 2022, 2129
. : milestone, 2076,
tracing (2.033 ms) : 1983, 2083
. : milestone, 2033,
|
59e1726 to
74ea2f3
Compare
jbachorik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM!
What Does This Do
Improves the way crashtracking parses the error log. Today, for stack frames type
CandVwe're not extracting the library name that's a good hint for further tagging.This PR is enriching the parsed data by pulling the library name for VM and native code.
Samples of frames (taken from https://docs.oracle.com/javase/10/troubleshoot/fatal-error-log.htm)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]