-
Notifications
You must be signed in to change notification settings - Fork 320
Forward wellknown, runtime and process tags in crash reports #9719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7795b1f to
d84aeb0
Compare
| newHashMap( | ||
| getGlobalTags().size() | ||
| + crashTrackingTags.size() | ||
| + jmxTags.size() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method was unused but I think it was done for crashtracking initially. Since today is taking the merged jmx tags I added jmx tags also to that method so that we won't have regressions
|
🎯 Code Coverage 🔗 Commit SHA: c17ee0e | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~c17ee0ea25, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017242
Total [baseline] (10.661 s) : 0, 10661135
Agent [candidate] (1.016 s) : 0, 1016406
Total [candidate] (10.657 s) : 0, 10656803
section appsec
Agent [baseline] (1.194 s) : 0, 1194313
Total [baseline] (11.118 s) : 0, 11118110
Agent [candidate] (1.196 s) : 0, 1196239
Total [candidate] (11.079 s) : 0, 11079348
section iast
Agent [baseline] (1.148 s) : 0, 1148146
Total [baseline] (11.022 s) : 0, 11022090
Agent [candidate] (1.159 s) : 0, 1159141
Total [candidate] (10.991 s) : 0, 10991485
section profiling
Agent [baseline] (1.161 s) : 0, 1161098
Total [baseline] (11.052 s) : 0, 11052492
Agent [candidate] (1.16 s) : 0, 1160202
Total [candidate] (11.067 s) : 0, 11067029
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~c17ee0ea25, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (693.315 ms) : 0, 693315
BytebuddyAgent [candidate] (692.736 ms) : 0, 692736
GlobalTracer [baseline] (241.912 ms) : 0, 241912
GlobalTracer [candidate] (241.625 ms) : 0, 241625
AppSec [baseline] (32.268 ms) : 0, 32268
AppSec [candidate] (32.357 ms) : 0, 32357
Debugger [baseline] (6.426 ms) : 0, 6426
Debugger [candidate] (6.378 ms) : 0, 6378
Remote Config [baseline] (694.226 µs) : 0, 694
Remote Config [candidate] (689.873 µs) : 0, 690
Telemetry [baseline] (9.244 ms) : 0, 9244
Telemetry [candidate] (9.229 ms) : 0, 9229
Flare Poller [baseline] (10.745 ms) : 0, 10745
Flare Poller [candidate] (10.863 ms) : 0, 10863
section appsec
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (718.039 ms) : 0, 718039
BytebuddyAgent [candidate] (719.361 ms) : 0, 719361
GlobalTracer [baseline] (234.135 ms) : 0, 234135
GlobalTracer [candidate] (234.591 ms) : 0, 234591
AppSec [baseline] (175.429 ms) : 0, 175429
AppSec [candidate] (175.474 ms) : 0, 175474
Debugger [baseline] (6.266 ms) : 0, 6266
Debugger [candidate] (6.15 ms) : 0, 6150
Remote Config [baseline] (637.699 µs) : 0, 638
Remote Config [candidate] (657.333 µs) : 0, 657
Telemetry [baseline] (8.528 ms) : 0, 8528
Telemetry [candidate] (8.602 ms) : 0, 8602
Flare Poller [baseline] (3.937 ms) : 0, 3937
Flare Poller [candidate] (4.03 ms) : 0, 4030
IAST [baseline] (24.786 ms) : 0, 24786
IAST [candidate] (24.769 ms) : 0, 24769
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (812.933 ms) : 0, 812933
BytebuddyAgent [candidate] (820.888 ms) : 0, 820888
GlobalTracer [baseline] (231.209 ms) : 0, 231209
GlobalTracer [candidate] (233.521 ms) : 0, 233521
AppSec [baseline] (35.17 ms) : 0, 35170
AppSec [candidate] (35.422 ms) : 0, 35422
Debugger [baseline] (6.133 ms) : 0, 6133
Debugger [candidate] (6.163 ms) : 0, 6163
Remote Config [baseline] (609.666 µs) : 0, 610
Remote Config [candidate] (606.584 µs) : 0, 607
Telemetry [baseline] (8.646 ms) : 0, 8646
Telemetry [candidate] (8.635 ms) : 0, 8635
Flare Poller [baseline] (4.196 ms) : 0, 4196
Flare Poller [candidate] (4.278 ms) : 0, 4278
IAST [baseline] (26.518 ms) : 0, 26518
IAST [candidate] (26.786 ms) : 0, 26786
section profiling
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (721.499 ms) : 0, 721499
BytebuddyAgent [candidate] (721.007 ms) : 0, 721007
GlobalTracer [baseline] (217.363 ms) : 0, 217363
GlobalTracer [candidate] (217.346 ms) : 0, 217346
AppSec [baseline] (32.713 ms) : 0, 32713
AppSec [candidate] (32.319 ms) : 0, 32319
Debugger [baseline] (6.438 ms) : 0, 6438
Debugger [candidate] (7.951 ms) : 0, 7951
Remote Config [baseline] (702.378 µs) : 0, 702
Remote Config [candidate] (787.527 µs) : 0, 788
Telemetry [baseline] (16.873 ms) : 0, 16873
Telemetry [candidate] (14.532 ms) : 0, 14532
Flare Poller [baseline] (4.195 ms) : 0, 4195
Flare Poller [candidate] (4.112 ms) : 0, 4112
ProfilingAgent [baseline] (107.47 ms) : 0, 107470
ProfilingAgent [candidate] (107.852 ms) : 0, 107852
Profiling [baseline] (108.055 ms) : 0, 108055
Profiling [candidate] (108.709 ms) : 0, 108709
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~c17ee0ea25, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020394
Total [baseline] (8.666 s) : 0, 8666282
Agent [candidate] (1.02 s) : 0, 1020439
Total [candidate] (8.662 s) : 0, 8661731
section iast
Agent [baseline] (1.152 s) : 0, 1152179
Total [baseline] (9.293 s) : 0, 9292732
Agent [candidate] (1.154 s) : 0, 1154474
Total [candidate] (9.304 s) : 0, 9303713
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~c17ee0ea25, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (694.578 ms) : 0, 694578
BytebuddyAgent [candidate] (694.77 ms) : 0, 694770
GlobalTracer [baseline] (242.199 ms) : 0, 242199
GlobalTracer [candidate] (242.188 ms) : 0, 242188
AppSec [baseline] (32.53 ms) : 0, 32530
AppSec [candidate] (32.717 ms) : 0, 32717
Debugger [baseline] (6.443 ms) : 0, 6443
Debugger [candidate] (6.435 ms) : 0, 6435
Remote Config [baseline] (696.478 µs) : 0, 696
Remote Config [candidate] (695.323 µs) : 0, 695
Telemetry [baseline] (9.268 ms) : 0, 9268
Telemetry [candidate] (9.215 ms) : 0, 9215
Flare Poller [baseline] (12.037 ms) : 0, 12037
Flare Poller [candidate] (11.811 ms) : 0, 11811
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (814.797 ms) : 0, 814797
BytebuddyAgent [candidate] (816.172 ms) : 0, 816172
GlobalTracer [baseline] (232.711 ms) : 0, 232711
GlobalTracer [candidate] (233.61 ms) : 0, 233610
AppSec [baseline] (35.326 ms) : 0, 35326
AppSec [candidate] (35.439 ms) : 0, 35439
Debugger [baseline] (6.229 ms) : 0, 6229
Debugger [candidate] (6.196 ms) : 0, 6196
Remote Config [baseline] (605.886 µs) : 0, 606
Remote Config [candidate] (617.964 µs) : 0, 618
Telemetry [baseline] (8.69 ms) : 0, 8690
Telemetry [candidate] (8.621 ms) : 0, 8621
Flare Poller [baseline] (4.32 ms) : 0, 4320
Flare Poller [candidate] (4.233 ms) : 0, 4233
IAST [baseline] (26.751 ms) : 0, 26751
IAST [candidate] (26.847 ms) : 0, 26847
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~c17ee0ea25, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (4.298 ms) : 4251, 4345
. : milestone, 4298,
iast (9.811 ms) : 9641, 9982
. : milestone, 9811,
iast_FULL (15.386 ms) : 15079, 15694
. : milestone, 15386,
iast_GLOBAL (11.083 ms) : 10877, 11289
. : milestone, 11083,
profiling (8.542 ms) : 8393, 8692
. : milestone, 8542,
tracing (7.622 ms) : 7506, 7738
. : milestone, 7622,
section candidate
no_agent (4.313 ms) : 4257, 4368
. : milestone, 4313,
iast (10.335 ms) : 10160, 10509
. : milestone, 10335,
iast_FULL (15.254 ms) : 14947, 15561
. : milestone, 15254,
iast_GLOBAL (10.567 ms) : 10378, 10755
. : milestone, 10567,
profiling (8.713 ms) : 8572, 8855
. : milestone, 8713,
tracing (7.601 ms) : 7493, 7709
. : milestone, 7601,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~c17ee0ea25, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (36.989 ms) : 36685, 37293
. : milestone, 36989,
appsec (49.128 ms) : 48708, 49547
. : milestone, 49128,
code_origins (44.453 ms) : 44070, 44836
. : milestone, 44453,
iast (45.03 ms) : 44642, 45417
. : milestone, 45030,
profiling (47.468 ms) : 47019, 47916
. : milestone, 47468,
tracing (44.353 ms) : 43968, 44737
. : milestone, 44353,
section candidate
no_agent (36.945 ms) : 36647, 37244
. : milestone, 36945,
appsec (47.743 ms) : 47327, 48159
. : milestone, 47743,
code_origins (43.969 ms) : 43611, 44327
. : milestone, 43969,
iast (45.016 ms) : 44623, 45408
. : milestone, 45016,
profiling (48.945 ms) : 48495, 49395
. : milestone, 48945,
tracing (43.561 ms) : 43196, 43927
. : milestone, 43561,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~c17ee0ea25, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.672 ms) : 3458, 3887
. : milestone, 3672,
iast (2.213 ms) : 2149, 2276
. : milestone, 2213,
iast_GLOBAL (2.251 ms) : 2188, 2315
. : milestone, 2251,
profiling (2.072 ms) : 2020, 2125
. : milestone, 2072,
tracing (2.029 ms) : 1979, 2078
. : milestone, 2029,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.705 ms) : 3486, 3924
. : milestone, 3705,
iast (2.218 ms) : 2154, 2281
. : milestone, 2218,
iast_GLOBAL (2.249 ms) : 2185, 2313
. : milestone, 2249,
profiling (2.067 ms) : 2016, 2119
. : milestone, 2067,
tracing (2.039 ms) : 1990, 2089
. : milestone, 2039,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~c17ee0ea25, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
appsec (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
iast (18.494 s) : 18494000, 18494000
. : milestone, 18494000,
iast_GLOBAL (17.826 s) : 17826000, 17826000
. : milestone, 17826000,
profiling (15.543 s) : 15543000, 15543000
. : milestone, 15543000,
tracing (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
section candidate
no_agent (15.439 s) : 15439000, 15439000
. : milestone, 15439000,
appsec (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
iast (18.389 s) : 18389000, 18389000
. : milestone, 18389000,
iast_GLOBAL (17.7 s) : 17700000, 17700000
. : milestone, 17700000,
profiling (15.645 s) : 15645000, 15645000
. : milestone, 15645000,
tracing (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
|
What Does This Do
This PR basically write more data on the config when the crashtracker initialises:
That config is then deserialised when the crash occours in order to send the original data of the crashed process and not the one of the crashtracker being forked.
Note: I used
Configin the initialiser that is quite costly to build up. However, the crashtracker is usually initialised in a delayed mode (i.e. either in a separate thread either delayed after jmx) so that the startup time should not be impacted.I also took the time to do some cleanup of unused stuff
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]