-
Notifications
You must be signed in to change notification settings - Fork 320
Upgrade asm to 9.9 #9684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade asm to 9.9 #9684
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: 8ae3b5b | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~8ae3b5b2b9, baseline=1.55.0-SNAPSHOT~362e7420b7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018930
Total [baseline] (10.816 s) : 0, 10816310
Agent [candidate] (1.019 s) : 0, 1018986
Total [candidate] (10.669 s) : 0, 10669388
section appsec
Agent [baseline] (1.199 s) : 0, 1198507
Total [baseline] (11.081 s) : 0, 11081133
Agent [candidate] (1.203 s) : 0, 1203395
Total [candidate] (10.984 s) : 0, 10983607
section iast
Agent [baseline] (1.152 s) : 0, 1152420
Total [baseline] (10.871 s) : 0, 10871144
Agent [candidate] (1.149 s) : 0, 1149065
Total [candidate] (10.966 s) : 0, 10965596
section profiling
Agent [baseline] (1.171 s) : 0, 1170728
Total [baseline] (11.047 s) : 0, 11047399
Agent [candidate] (1.176 s) : 0, 1175717
Total [candidate] (11.038 s) : 0, 11038119
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~8ae3b5b2b9, baseline=1.55.0-SNAPSHOT~362e7420b7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (694.533 ms) : 0, 694533
BytebuddyAgent [candidate] (695.341 ms) : 0, 695341
GlobalTracer [baseline] (241.938 ms) : 0, 241938
GlobalTracer [candidate] (241.949 ms) : 0, 241949
AppSec [baseline] (32.579 ms) : 0, 32579
AppSec [candidate] (32.566 ms) : 0, 32566
Debugger [baseline] (6.365 ms) : 0, 6365
Debugger [candidate] (6.418 ms) : 0, 6418
Remote Config [baseline] (697.726 µs) : 0, 698
Remote Config [candidate] (698.221 µs) : 0, 698
Telemetry [baseline] (9.253 ms) : 0, 9253
Telemetry [candidate] (9.218 ms) : 0, 9218
Flare Poller [baseline] (10.931 ms) : 0, 10931
Flare Poller [candidate] (10.169 ms) : 0, 10169
section appsec
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (719.111 ms) : 0, 719111
BytebuddyAgent [candidate] (724.604 ms) : 0, 724604
GlobalTracer [baseline] (236.13 ms) : 0, 236130
GlobalTracer [candidate] (236.184 ms) : 0, 236184
IAST [baseline] (25.073 ms) : 0, 25073
IAST [candidate] (24.987 ms) : 0, 24987
AppSec [baseline] (176.117 ms) : 0, 176117
AppSec [candidate] (175.683 ms) : 0, 175683
Debugger [baseline] (6.129 ms) : 0, 6129
Debugger [candidate] (6.179 ms) : 0, 6179
Remote Config [baseline] (657.163 µs) : 0, 657
Remote Config [candidate] (647.592 µs) : 0, 648
Telemetry [baseline] (8.57 ms) : 0, 8570
Telemetry [candidate] (8.432 ms) : 0, 8432
Flare Poller [baseline] (4.027 ms) : 0, 4027
Flare Poller [candidate] (3.923 ms) : 0, 3923
section iast
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (815.286 ms) : 0, 815286
BytebuddyAgent [candidate] (813.711 ms) : 0, 813711
GlobalTracer [baseline] (232.211 ms) : 0, 232211
GlobalTracer [candidate] (231.72 ms) : 0, 231720
IAST [baseline] (26.78 ms) : 0, 26780
IAST [candidate] (26.434 ms) : 0, 26434
AppSec [baseline] (35.65 ms) : 0, 35650
AppSec [candidate] (35.111 ms) : 0, 35111
Debugger [baseline] (6.1 ms) : 0, 6100
Debugger [candidate] (6.069 ms) : 0, 6069
Remote Config [baseline] (608.655 µs) : 0, 609
Remote Config [candidate] (608.635 µs) : 0, 609
Telemetry [baseline] (8.6 ms) : 0, 8600
Telemetry [candidate] (8.491 ms) : 0, 8491
Flare Poller [baseline] (4.296 ms) : 0, 4296
Flare Poller [candidate] (4.205 ms) : 0, 4205
section profiling
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (726.006 ms) : 0, 726006
BytebuddyAgent [candidate] (730.289 ms) : 0, 730289
GlobalTracer [baseline] (218.327 ms) : 0, 218327
GlobalTracer [candidate] (219.958 ms) : 0, 219958
AppSec [baseline] (33.603 ms) : 0, 33603
AppSec [candidate] (33.561 ms) : 0, 33561
Debugger [baseline] (6.542 ms) : 0, 6542
Debugger [candidate] (8.073 ms) : 0, 8073
Remote Config [baseline] (707.26 µs) : 0, 707
Remote Config [candidate] (715.566 µs) : 0, 716
Telemetry [baseline] (16.169 ms) : 0, 16169
Telemetry [candidate] (15.119 ms) : 0, 15119
Flare Poller [baseline] (4.993 ms) : 0, 4993
Flare Poller [candidate] (4.216 ms) : 0, 4216
ProfilingAgent [baseline] (109.323 ms) : 0, 109323
ProfilingAgent [candidate] (108.906 ms) : 0, 108906
Profiling [baseline] (110.741 ms) : 0, 110741
Profiling [candidate] (109.767 ms) : 0, 109767
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~8ae3b5b2b9, baseline=1.55.0-SNAPSHOT~362e7420b7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019879
Total [baseline] (8.681 s) : 0, 8680969
Agent [candidate] (1.027 s) : 0, 1027298
Total [candidate] (8.66 s) : 0, 8660288
section iast
Agent [baseline] (1.153 s) : 0, 1152722
Total [baseline] (9.253 s) : 0, 9252542
Agent [candidate] (1.15 s) : 0, 1149639
Total [candidate] (9.293 s) : 0, 9292523
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~8ae3b5b2b9, baseline=1.55.0-SNAPSHOT~362e7420b7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (694.777 ms) : 0, 694777
BytebuddyAgent [candidate] (700.5 ms) : 0, 700500
GlobalTracer [baseline] (242.739 ms) : 0, 242739
GlobalTracer [candidate] (243.805 ms) : 0, 243805
AppSec [baseline] (33.006 ms) : 0, 33006
AppSec [candidate] (33.096 ms) : 0, 33096
Debugger [baseline] (6.452 ms) : 0, 6452
Debugger [candidate] (6.429 ms) : 0, 6429
Remote Config [baseline] (720.609 µs) : 0, 721
Remote Config [candidate] (718.636 µs) : 0, 719
Telemetry [baseline] (9.179 ms) : 0, 9179
Telemetry [candidate] (9.225 ms) : 0, 9225
Flare Poller [baseline] (10.425 ms) : 0, 10425
Flare Poller [candidate] (10.814 ms) : 0, 10814
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (816.188 ms) : 0, 816188
BytebuddyAgent [candidate] (813.624 ms) : 0, 813624
GlobalTracer [baseline] (232.251 ms) : 0, 232251
GlobalTracer [candidate] (231.431 ms) : 0, 231431
IAST [baseline] (26.346 ms) : 0, 26346
IAST [candidate] (26.653 ms) : 0, 26653
AppSec [baseline] (35.608 ms) : 0, 35608
AppSec [candidate] (35.47 ms) : 0, 35470
Debugger [baseline] (6.198 ms) : 0, 6198
Debugger [candidate] (6.179 ms) : 0, 6179
Remote Config [baseline] (606.754 µs) : 0, 607
Remote Config [candidate] (600.389 µs) : 0, 600
Telemetry [baseline] (8.558 ms) : 0, 8558
Telemetry [candidate] (8.751 ms) : 0, 8751
Flare Poller [baseline] (4.186 ms) : 0, 4186
Flare Poller [candidate] (4.269 ms) : 0, 4269
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~8ae3b5b2b9, baseline=1.55.0-SNAPSHOT~362e7420b7
dateFormat X
axisFormat %s
section baseline
no_agent (4.517 ms) : 4465, 4569
. : milestone, 4517,
iast (10.168 ms) : 9993, 10343
. : milestone, 10168,
iast_FULL (13.849 ms) : 13574, 14125
. : milestone, 13849,
iast_GLOBAL (10.824 ms) : 10627, 11020
. : milestone, 10824,
profiling (8.599 ms) : 8459, 8739
. : milestone, 8599,
tracing (8.01 ms) : 7892, 8127
. : milestone, 8010,
section candidate
no_agent (4.408 ms) : 4351, 4464
. : milestone, 4408,
iast (9.975 ms) : 9804, 10145
. : milestone, 9975,
iast_FULL (14.874 ms) : 14572, 15175
. : milestone, 14874,
iast_GLOBAL (10.305 ms) : 10108, 10502
. : milestone, 10305,
profiling (8.585 ms) : 8446, 8723
. : milestone, 8585,
tracing (8.143 ms) : 8025, 8262
. : milestone, 8143,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~8ae3b5b2b9, baseline=1.55.0-SNAPSHOT~362e7420b7
dateFormat X
axisFormat %s
section baseline
no_agent (36.388 ms) : 36097, 36678
. : milestone, 36388,
appsec (47.887 ms) : 47446, 48327
. : milestone, 47887,
code_origins (43.416 ms) : 43042, 43789
. : milestone, 43416,
iast (44.107 ms) : 43739, 44474
. : milestone, 44107,
profiling (47.786 ms) : 47352, 48220
. : milestone, 47786,
tracing (44.678 ms) : 44302, 45054
. : milestone, 44678,
section candidate
no_agent (36.833 ms) : 36531, 37135
. : milestone, 36833,
appsec (48.348 ms) : 47910, 48786
. : milestone, 48348,
code_origins (44.262 ms) : 43889, 44634
. : milestone, 44262,
iast (45.593 ms) : 45184, 46002
. : milestone, 45593,
profiling (47.505 ms) : 47065, 47944
. : milestone, 47505,
tracing (45.09 ms) : 44697, 45483
. : milestone, 45090,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~8ae3b5b2b9, baseline=1.55.0-SNAPSHOT~362e7420b7
dateFormat X
axisFormat %s
section baseline
no_agent (15.549 s) : 15549000, 15549000
. : milestone, 15549000,
appsec (15.127 s) : 15127000, 15127000
. : milestone, 15127000,
iast (18.56 s) : 18560000, 18560000
. : milestone, 18560000,
iast_GLOBAL (18.01 s) : 18010000, 18010000
. : milestone, 18010000,
profiling (15.348 s) : 15348000, 15348000
. : milestone, 15348000,
tracing (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
section candidate
no_agent (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
appsec (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
iast (18.629 s) : 18629000, 18629000
. : milestone, 18629000,
iast_GLOBAL (18.262 s) : 18262000, 18262000
. : milestone, 18262000,
profiling (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
tracing (14.912 s) : 14912000, 14912000
. : milestone, 14912000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~8ae3b5b2b9, baseline=1.55.0-SNAPSHOT~362e7420b7
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.752 ms) : 3534, 3969
. : milestone, 3752,
iast (2.223 ms) : 2160, 2287
. : milestone, 2223,
iast_GLOBAL (2.257 ms) : 2193, 2321
. : milestone, 2257,
profiling (2.073 ms) : 2020, 2126
. : milestone, 2073,
tracing (2.032 ms) : 1983, 2082
. : milestone, 2032,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.744 ms) : 3524, 3965
. : milestone, 3744,
iast (2.214 ms) : 2150, 2278
. : milestone, 2214,
iast_GLOBAL (2.26 ms) : 2196, 2324
. : milestone, 2260,
profiling (2.077 ms) : 2024, 2130
. : milestone, 2077,
tracing (2.028 ms) : 1978, 2077
. : milestone, 2028,
|
What Does This Do
Changelog:
Opcodes.V26constant for Java 26mapInvokeDynamicMethodNamemethod inRemapper. Old method deprecated. NewRemapperconstructor, with an api parameter.TextifiermisinterpretsACC_SUPERof inner classes asACC_SYNCHRONIZEDSerialVersionUIDAdder's SHA-1 UseWe had
Opcodes.V25constant for Java 25CheckClassAdapter.ASMifiershould print calls tovalueOfinstead of deprecated constructors of primitive wrappershttps://asm.ow2.io/versions.html
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]