Version file was not always generated on first jar generation#9651
Version file was not always generated on first jar generation#9651
Conversation
This was mostly due to the fact that this task was writing directly to the output dir which is replaced by a later task. This change makes this task generate the file in another location and makes the sourceSet use this task output as source dir.
c7bad3f to
b3225f8
Compare
|
🎯 Code Coverage 🔗 Commit SHA: b3225f8 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~b3225f8e653, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018443
Total [baseline] (10.836 s) : 0, 10835509
Agent [candidate] (1.015 s) : 0, 1015056
Total [candidate] (10.694 s) : 0, 10693706
section appsec
Agent [baseline] (1.194 s) : 0, 1194021
Total [baseline] (11.132 s) : 0, 11131847
Agent [candidate] (1.202 s) : 0, 1202135
Total [candidate] (11.181 s) : 0, 11181213
section iast
Agent [baseline] (1.156 s) : 0, 1156234
Total [baseline] (11.007 s) : 0, 11006707
Agent [candidate] (1.151 s) : 0, 1150633
Total [candidate] (10.912 s) : 0, 10911693
section profiling
Agent [baseline] (1.173 s) : 0, 1172678
Total [baseline] (11.154 s) : 0, 11153953
Agent [candidate] (1.166 s) : 0, 1165684
Total [candidate] (11.103 s) : 0, 11103398
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~b3225f8e653, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (692.745 ms) : 0, 692745
BytebuddyAgent [candidate] (691.295 ms) : 0, 691295
GlobalTracer [baseline] (242.929 ms) : 0, 242929
GlobalTracer [candidate] (242.345 ms) : 0, 242345
AppSec [baseline] (32.879 ms) : 0, 32879
AppSec [candidate] (32.605 ms) : 0, 32605
Debugger [baseline] (6.431 ms) : 0, 6431
Debugger [candidate] (6.377 ms) : 0, 6377
Remote Config [baseline] (678.55 µs) : 0, 679
Remote Config [candidate] (679.123 µs) : 0, 679
Telemetry [baseline] (9.128 ms) : 0, 9128
Telemetry [candidate] (8.956 ms) : 0, 8956
Flare Poller [baseline] (10.982 ms) : 0, 10982
Flare Poller [candidate] (10.114 ms) : 0, 10114
section appsec
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (716.195 ms) : 0, 716195
BytebuddyAgent [candidate] (721.775 ms) : 0, 721775
GlobalTracer [baseline] (235.478 ms) : 0, 235478
GlobalTracer [candidate] (236.987 ms) : 0, 236987
AppSec [baseline] (176.098 ms) : 0, 176098
AppSec [candidate] (172.988 ms) : 0, 172988
Debugger [baseline] (6.068 ms) : 0, 6068
Debugger [candidate] (6.142 ms) : 0, 6142
Remote Config [baseline] (648.519 µs) : 0, 649
Remote Config [candidate] (661.674 µs) : 0, 662
Telemetry [baseline] (8.178 ms) : 0, 8178
Telemetry [candidate] (10.702 ms) : 0, 10702
Flare Poller [baseline] (3.928 ms) : 0, 3928
Flare Poller [candidate] (4.848 ms) : 0, 4848
IAST [baseline] (24.831 ms) : 0, 24831
IAST [candidate] (25.274 ms) : 0, 25274
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (817.857 ms) : 0, 817857
BytebuddyAgent [candidate] (813.874 ms) : 0, 813874
GlobalTracer [baseline] (234.37 ms) : 0, 234370
GlobalTracer [candidate] (233.278 ms) : 0, 233278
AppSec [baseline] (35.256 ms) : 0, 35256
AppSec [candidate] (35.171 ms) : 0, 35171
Debugger [baseline] (6.169 ms) : 0, 6169
Debugger [candidate] (6.044 ms) : 0, 6044
Remote Config [baseline] (603.369 µs) : 0, 603
Remote Config [candidate] (604.948 µs) : 0, 605
Telemetry [baseline] (8.314 ms) : 0, 8314
Telemetry [candidate] (8.178 ms) : 0, 8178
Flare Poller [baseline] (4.335 ms) : 0, 4335
Flare Poller [candidate] (4.245 ms) : 0, 4245
IAST [baseline] (26.331 ms) : 0, 26331
IAST [candidate] (26.336 ms) : 0, 26336
section profiling
ProfilingAgent [baseline] (105.848 ms) : 0, 105848
ProfilingAgent [candidate] (104.16 ms) : 0, 104160
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (728.066 ms) : 0, 728066
BytebuddyAgent [candidate] (723.234 ms) : 0, 723234
GlobalTracer [baseline] (220.902 ms) : 0, 220902
GlobalTracer [candidate] (219.927 ms) : 0, 219927
AppSec [baseline] (33.154 ms) : 0, 33154
AppSec [candidate] (32.641 ms) : 0, 32641
Debugger [baseline] (7.426 ms) : 0, 7426
Debugger [candidate] (6.617 ms) : 0, 6617
Remote Config [baseline] (820.646 µs) : 0, 821
Remote Config [candidate] (801.657 µs) : 0, 802
Telemetry [baseline] (14.907 ms) : 0, 14907
Telemetry [candidate] (16.303 ms) : 0, 16303
Flare Poller [baseline] (4.961 ms) : 0, 4961
Flare Poller [candidate] (4.199 ms) : 0, 4199
Profiling [baseline] (108.725 ms) : 0, 108725
Profiling [candidate] (108.339 ms) : 0, 108339
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~b3225f8e653, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017178
Total [baseline] (8.687 s) : 0, 8687200
Agent [candidate] (1.017 s) : 0, 1017155
Total [candidate] (8.674 s) : 0, 8673826
section iast
Agent [baseline] (1.151 s) : 0, 1150967
Total [baseline] (9.265 s) : 0, 9264829
Agent [candidate] (1.151 s) : 0, 1150758
Total [candidate] (9.296 s) : 0, 9296188
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~b3225f8e653, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (692.03 ms) : 0, 692030
BytebuddyAgent [candidate] (693.223 ms) : 0, 693223
GlobalTracer [baseline] (243.43 ms) : 0, 243430
GlobalTracer [candidate] (243.208 ms) : 0, 243208
AppSec [baseline] (32.8 ms) : 0, 32800
AppSec [candidate] (32.571 ms) : 0, 32571
Debugger [baseline] (6.374 ms) : 0, 6374
Debugger [candidate] (6.339 ms) : 0, 6339
Remote Config [baseline] (671.323 µs) : 0, 671
Remote Config [candidate] (671.921 µs) : 0, 672
Telemetry [baseline] (9.108 ms) : 0, 9108
Telemetry [candidate] (9.03 ms) : 0, 9030
Flare Poller [baseline] (10.177 ms) : 0, 10177
Flare Poller [candidate] (9.442 ms) : 0, 9442
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (813.606 ms) : 0, 813606
BytebuddyAgent [candidate] (813.482 ms) : 0, 813482
GlobalTracer [baseline] (233.503 ms) : 0, 233503
GlobalTracer [candidate] (233.294 ms) : 0, 233294
IAST [baseline] (26.376 ms) : 0, 26376
IAST [candidate] (26.442 ms) : 0, 26442
AppSec [baseline] (35.37 ms) : 0, 35370
AppSec [candidate] (35.499 ms) : 0, 35499
Debugger [baseline] (6.077 ms) : 0, 6077
Debugger [candidate] (6.112 ms) : 0, 6112
Remote Config [baseline] (595.811 µs) : 0, 596
Remote Config [candidate] (593.32 µs) : 0, 593
Telemetry [baseline] (8.342 ms) : 0, 8342
Telemetry [candidate] (8.306 ms) : 0, 8306
Flare Poller [baseline] (4.316 ms) : 0, 4316
Flare Poller [candidate] (4.232 ms) : 0, 4232
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b3225f8e653, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section baseline
no_agent (38.267 ms) : 37963, 38572
. : milestone, 38267,
appsec (48.428 ms) : 48003, 48852
. : milestone, 48428,
code_origins (44.536 ms) : 44150, 44923
. : milestone, 44536,
iast (47.352 ms) : 46939, 47765
. : milestone, 47352,
profiling (47.535 ms) : 47108, 47961
. : milestone, 47535,
tracing (44.75 ms) : 44364, 45136
. : milestone, 44750,
section candidate
no_agent (37.181 ms) : 36883, 37478
. : milestone, 37181,
appsec (49.025 ms) : 48598, 49453
. : milestone, 49025,
code_origins (43.273 ms) : 42897, 43649
. : milestone, 43273,
iast (44.747 ms) : 44369, 45126
. : milestone, 44747,
profiling (49.668 ms) : 49205, 50131
. : milestone, 49668,
tracing (44.163 ms) : 43787, 44540
. : milestone, 44163,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b3225f8e653, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section baseline
no_agent (4.288 ms) : 4240, 4337
. : milestone, 4288,
iast (9.636 ms) : 9470, 9802
. : milestone, 9636,
iast_FULL (13.918 ms) : 13647, 14189
. : milestone, 13918,
iast_GLOBAL (10.587 ms) : 10402, 10772
. : milestone, 10587,
profiling (9.809 ms) : 9633, 9986
. : milestone, 9809,
tracing (8.052 ms) : 7926, 8177
. : milestone, 8052,
section candidate
no_agent (4.296 ms) : 4241, 4351
. : milestone, 4296,
iast (10.147 ms) : 9975, 10320
. : milestone, 10147,
iast_FULL (14.776 ms) : 14481, 15070
. : milestone, 14776,
iast_GLOBAL (10.658 ms) : 10452, 10863
. : milestone, 10658,
profiling (8.749 ms) : 8615, 8883
. : milestone, 8749,
tracing (7.673 ms) : 7562, 7784
. : milestone, 7673,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b3225f8e653, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.668 ms) : 3453, 3882
. : milestone, 3668,
iast (2.208 ms) : 2145, 2272
. : milestone, 2208,
iast_GLOBAL (2.253 ms) : 2189, 2316
. : milestone, 2253,
profiling (2.075 ms) : 2022, 2128
. : milestone, 2075,
tracing (2.026 ms) : 1977, 2076
. : milestone, 2026,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.733 ms) : 3511, 3955
. : milestone, 3733,
iast (2.208 ms) : 2145, 2272
. : milestone, 2208,
iast_GLOBAL (2.257 ms) : 2194, 2321
. : milestone, 2257,
profiling (2.046 ms) : 1995, 2097
. : milestone, 2046,
tracing (2.022 ms) : 1973, 2071
. : milestone, 2022,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b3225f8e653, baseline=1.54.0-SNAPSHOT~088156e595
dateFormat X
axisFormat %s
section baseline
no_agent (15.012 s) : 15012000, 15012000
. : milestone, 15012000,
appsec (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
iast (18.3 s) : 18300000, 18300000
. : milestone, 18300000,
iast_GLOBAL (18.015 s) : 18015000, 18015000
. : milestone, 18015000,
profiling (15.267 s) : 15267000, 15267000
. : milestone, 15267000,
tracing (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
section candidate
no_agent (15.25 s) : 15250000, 15250000
. : milestone, 15250000,
appsec (15.293 s) : 15293000, 15293000
. : milestone, 15293000,
iast (18.569 s) : 18569000, 18569000
. : milestone, 18569000,
iast_GLOBAL (17.987 s) : 17987000, 17987000
. : milestone, 17987000,
profiling (15.208 s) : 15208000, 15208000
. : milestone, 15208000,
tracing (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Looking good.
Do we know why so many modules imports this version task while we should only need it for the modules related publish artifacts?
@PerfectSlayer That I don't know. Further analysis is needed. |
What Does This Do
The current version generation was writing directly to the output dir which could be replaced by a another tasks that runs later. This change makes this task generate the file in another location and makes the sourceSet use this task output as source dir.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]