Remove tracing requirement to be enabled to generate a flare#9579
Remove tracing requirement to be enabled to generate a flare#9579
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 0802108 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1008045
Total [baseline] (8.73 s) : 0, 8729563
Agent [candidate] (1.012 s) : 0, 1011757
Total [candidate] (8.647 s) : 0, 8646503
section iast
Agent [baseline] (1.162 s) : 0, 1162353
Total [baseline] (9.353 s) : 0, 9352972
Agent [candidate] (1.145 s) : 0, 1145498
Total [candidate] (9.324 s) : 0, 9324000
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (690.487 ms) : 0, 690487
BytebuddyAgent [candidate] (688.94 ms) : 0, 688940
GlobalTracer [baseline] (248.111 ms) : 0, 248111
GlobalTracer [candidate] (242.544 ms) : 0, 242544
AppSec [baseline] (30.92 ms) : 0, 30920
AppSec [candidate] (30.991 ms) : 0, 30991
Debugger [baseline] (6.368 ms) : 0, 6368
Debugger [candidate] (6.221 ms) : 0, 6221
Remote Config [baseline] (687.562 µs) : 0, 688
Remote Config [candidate] (667.304 µs) : 0, 667
Telemetry [baseline] (8.856 ms) : 0, 8856
Telemetry [candidate] (9.03 ms) : 0, 9030
Flare Poller [candidate] (10.775 ms) : 0, 10775
section iast
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (823.551 ms) : 0, 823551
BytebuddyAgent [candidate] (810.393 ms) : 0, 810393
GlobalTracer [baseline] (240.288 ms) : 0, 240288
GlobalTracer [candidate] (233.568 ms) : 0, 233568
IAST [baseline] (26.291 ms) : 0, 26291
IAST [candidate] (26.312 ms) : 0, 26312
AppSec [baseline] (34.274 ms) : 0, 34274
AppSec [candidate] (33.581 ms) : 0, 33581
Debugger [baseline] (6.132 ms) : 0, 6132
Debugger [candidate] (6.032 ms) : 0, 6032
Remote Config [baseline] (594.302 µs) : 0, 594
Remote Config [candidate] (579.674 µs) : 0, 580
Telemetry [baseline] (8.301 ms) : 0, 8301
Telemetry [candidate] (8.111 ms) : 0, 8111
Flare Poller [candidate] (4.183 ms) : 0, 4183
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022028
Total [baseline] (10.728 s) : 0, 10727699
Agent [candidate] (1.011 s) : 0, 1010608
Total [candidate] (10.654 s) : 0, 10654364
section appsec
Agent [baseline] (1.199 s) : 0, 1198659
Total [baseline] (11.048 s) : 0, 11047994
Agent [candidate] (1.193 s) : 0, 1193022
Total [candidate] (10.926 s) : 0, 10925780
section iast
Agent [baseline] (1.146 s) : 0, 1145639
Total [baseline] (11.003 s) : 0, 11003147
Agent [candidate] (1.152 s) : 0, 1152359
Total [candidate] (10.985 s) : 0, 10984839
section profiling
Agent [baseline] (1.166 s) : 0, 1166023
Total [baseline] (11.096 s) : 0, 11096151
Agent [candidate] (1.163 s) : 0, 1162657
Total [candidate] (11.144 s) : 0, 11143969
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (701.901 ms) : 0, 701901
BytebuddyAgent [candidate] (686.589 ms) : 0, 686589
GlobalTracer [baseline] (249.911 ms) : 0, 249911
GlobalTracer [candidate] (243.482 ms) : 0, 243482
AppSec [baseline] (31.15 ms) : 0, 31150
AppSec [candidate] (31.149 ms) : 0, 31149
Debugger [baseline] (6.385 ms) : 0, 6385
Debugger [candidate] (6.326 ms) : 0, 6326
Remote Config [baseline] (725.539 µs) : 0, 726
Remote Config [candidate] (677.625 µs) : 0, 678
Telemetry [baseline] (9.006 ms) : 0, 9006
Telemetry [candidate] (8.936 ms) : 0, 8936
Flare Poller [candidate] (10.733 ms) : 0, 10733
section appsec
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (719.64 ms) : 0, 719640
BytebuddyAgent [candidate] (715.654 ms) : 0, 715654
GlobalTracer [baseline] (242.438 ms) : 0, 242438
GlobalTracer [candidate] (236.636 ms) : 0, 236636
AppSec [baseline] (172.204 ms) : 0, 172204
AppSec [candidate] (172.994 ms) : 0, 172994
Debugger [baseline] (6.031 ms) : 0, 6031
Debugger [candidate] (6.812 ms) : 0, 6812
Remote Config [baseline] (643.096 µs) : 0, 643
Remote Config [candidate] (652.31 µs) : 0, 652
Telemetry [baseline] (9.979 ms) : 0, 9979
Telemetry [candidate] (8.303 ms) : 0, 8303
Flare Poller [candidate] (3.941 ms) : 0, 3941
IAST [baseline] (24.911 ms) : 0, 24911
IAST [candidate] (25.254 ms) : 0, 25254
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.495 ms) : 0, 1495
BytebuddyAgent [baseline] (810.395 ms) : 0, 810395
BytebuddyAgent [candidate] (814.241 ms) : 0, 814241
GlobalTracer [baseline] (237.464 ms) : 0, 237464
GlobalTracer [candidate] (235.089 ms) : 0, 235089
AppSec [baseline] (34.096 ms) : 0, 34096
AppSec [candidate] (34.055 ms) : 0, 34055
Debugger [baseline] (6.003 ms) : 0, 6003
Debugger [candidate] (6.108 ms) : 0, 6108
Remote Config [baseline] (592.451 µs) : 0, 592
Remote Config [candidate] (591.368 µs) : 0, 591
Telemetry [baseline] (8.29 ms) : 0, 8290
Telemetry [candidate] (8.388 ms) : 0, 8388
Flare Poller [candidate] (4.266 ms) : 0, 4266
IAST [baseline] (25.956 ms) : 0, 25956
IAST [candidate] (26.693 ms) : 0, 26693
section profiling
ProfilingAgent [baseline] (102.117 ms) : 0, 102117
ProfilingAgent [candidate] (103.088 ms) : 0, 103088
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (727.851 ms) : 0, 727851
BytebuddyAgent [candidate] (725.241 ms) : 0, 725241
GlobalTracer [baseline] (225.434 ms) : 0, 225434
GlobalTracer [candidate] (221.26 ms) : 0, 221260
AppSec [baseline] (31.605 ms) : 0, 31605
AppSec [candidate] (32.099 ms) : 0, 32099
Debugger [baseline] (7.367 ms) : 0, 7367
Debugger [candidate] (7.344 ms) : 0, 7344
Remote Config [baseline] (728.551 µs) : 0, 729
Remote Config [candidate] (697.127 µs) : 0, 697
Telemetry [baseline] (15.704 ms) : 0, 15704
Telemetry [candidate] (14.905 ms) : 0, 14905
Flare Poller [candidate] (5.012 ms) : 0, 5012
Profiling [baseline] (103.376 ms) : 0, 103376
Profiling [candidate] (103.699 ms) : 0, 103699
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section baseline
no_agent (38.216 ms) : 37902, 38530
. : milestone, 38216,
appsec (49.268 ms) : 48833, 49703
. : milestone, 49268,
code_origins (43.593 ms) : 43220, 43966
. : milestone, 43593,
iast (45.596 ms) : 45202, 45990
. : milestone, 45596,
profiling (48.581 ms) : 48131, 49031
. : milestone, 48581,
tracing (45.255 ms) : 44850, 45661
. : milestone, 45255,
section candidate
no_agent (36.147 ms) : 35862, 36433
. : milestone, 36147,
appsec (49.865 ms) : 49418, 50312
. : milestone, 49865,
code_origins (43.794 ms) : 43433, 44155
. : milestone, 43794,
iast (46.14 ms) : 45747, 46534
. : milestone, 46140,
profiling (47.862 ms) : 47419, 48305
. : milestone, 47862,
tracing (45.497 ms) : 45111, 45882
. : milestone, 45497,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section baseline
no_agent (4.336 ms) : 4282, 4391
. : milestone, 4336,
iast (10.502 ms) : 10324, 10681
. : milestone, 10502,
iast_FULL (14.787 ms) : 14490, 15084
. : milestone, 14787,
iast_GLOBAL (10.62 ms) : 10430, 10809
. : milestone, 10620,
profiling (8.807 ms) : 8663, 8951
. : milestone, 8807,
tracing (7.539 ms) : 7432, 7646
. : milestone, 7539,
section candidate
no_agent (4.266 ms) : 4219, 4312
. : milestone, 4266,
iast (10.474 ms) : 10293, 10655
. : milestone, 10474,
iast_FULL (13.802 ms) : 13523, 14082
. : milestone, 13802,
iast_GLOBAL (11.402 ms) : 11197, 11608
. : milestone, 11402,
profiling (8.588 ms) : 8456, 8719
. : milestone, 8588,
tracing (7.835 ms) : 7724, 7946
. : milestone, 7835,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1487
. : milestone, 1475,
appsec (3.655 ms) : 3440, 3869
. : milestone, 3655,
iast (2.204 ms) : 2141, 2267
. : milestone, 2204,
iast_GLOBAL (2.245 ms) : 2182, 2308
. : milestone, 2245,
profiling (2.483 ms) : 2310, 2657
. : milestone, 2483,
tracing (2.016 ms) : 1967, 2065
. : milestone, 2016,
section candidate
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.65 ms) : 3435, 3864
. : milestone, 3650,
iast (2.21 ms) : 2147, 2273
. : milestone, 2210,
iast_GLOBAL (2.253 ms) : 2190, 2317
. : milestone, 2253,
profiling (2.079 ms) : 2026, 2131
. : milestone, 2079,
tracing (2.032 ms) : 1982, 2082
. : milestone, 2032,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section baseline
no_agent (15.381 s) : 15381000, 15381000
. : milestone, 15381000,
appsec (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
iast (18.492 s) : 18492000, 18492000
. : milestone, 18492000,
iast_GLOBAL (17.651 s) : 17651000, 17651000
. : milestone, 17651000,
profiling (15.324 s) : 15324000, 15324000
. : milestone, 15324000,
tracing (15.177 s) : 15177000, 15177000
. : milestone, 15177000,
section candidate
no_agent (15.521 s) : 15521000, 15521000
. : milestone, 15521000,
appsec (14.91 s) : 14910000, 14910000
. : milestone, 14910000,
iast (18.593 s) : 18593000, 18593000
. : milestone, 18593000,
iast_GLOBAL (18.052 s) : 18052000, 18052000
. : milestone, 18052000,
profiling (15.454 s) : 15454000, 15454000
. : milestone, 15454000,
tracing (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
|
amarziali
left a comment
There was a problem hiding this comment.
Thanks for having extracted this part. The proposed change looks ok. I left some comments. I'd particularly like to flesh out the part around the CoreTracerBuilder since we might still want to disable the flare
amarziali
left a comment
There was a problem hiding this comment.
Thanks for having improved the flare and for having addressed the comments
What Does This Do
Allow the generation of a tracer flare even when tracing is disabled.
Technically: Move the generic tracer flare code out of dd-tracer-core.
Changes in the tracer flare: tracer_health.txt, dynamic_config.txt and span_metrics.txt will be present only if tracing is enabled.
Motivation
We should be able to get a flare even when tracing is not enabled
Additional Notes
APMAPI-1591