-
Notifications
You must be signed in to change notification settings - Fork 320
Set correct subdomain when sending intake requests via EVP proxy #9517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set correct subdomain when sending intake requests via EVP proxy #9517
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 95860e0 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~95860e0d8e, baseline=1.54.0-SNAPSHOT~12c02b6d92
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063255
Total [baseline] (10.788 s) : 0, 10788109
Agent [candidate] (1.067 s) : 0, 1066841
Total [candidate] (10.74 s) : 0, 10739862
section appsec
Agent [baseline] (1.229 s) : 0, 1229455
Total [baseline] (10.976 s) : 0, 10976154
Agent [candidate] (1.233 s) : 0, 1233276
Total [candidate] (10.945 s) : 0, 10945458
section iast
Agent [baseline] (1.191 s) : 0, 1190954
Total [baseline] (11.014 s) : 0, 11013790
Agent [candidate] (1.188 s) : 0, 1188272
Total [candidate] (10.979 s) : 0, 10978647
section profiling
Agent [baseline] (1.209 s) : 0, 1209220
Total [baseline] (11.017 s) : 0, 11016578
Agent [candidate] (1.207 s) : 0, 1206582
Total [candidate] (10.942 s) : 0, 10941848
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~95860e0d8e, baseline=1.54.0-SNAPSHOT~12c02b6d92
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (733.239 ms) : 0, 733239
BytebuddyAgent [candidate] (737.557 ms) : 0, 737557
GlobalTracer [baseline] (253.126 ms) : 0, 253126
GlobalTracer [candidate] (252.591 ms) : 0, 252591
AppSec [baseline] (30.727 ms) : 0, 30727
AppSec [candidate] (30.525 ms) : 0, 30525
Debugger [baseline] (6.412 ms) : 0, 6412
Debugger [candidate] (6.381 ms) : 0, 6381
Remote Config [baseline] (691.779 µs) : 0, 692
Remote Config [candidate] (704.363 µs) : 0, 704
Telemetry [baseline] (16.419 ms) : 0, 16419
Telemetry [candidate] (16.305 ms) : 0, 16305
section appsec
crashtracking [baseline] (1.441 ms) : 0, 1441
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (752.26 ms) : 0, 752260
BytebuddyAgent [candidate] (755.125 ms) : 0, 755125
GlobalTracer [baseline] (244.705 ms) : 0, 244705
GlobalTracer [candidate] (245.498 ms) : 0, 245498
IAST [baseline] (23.747 ms) : 0, 23747
IAST [candidate] (23.82 ms) : 0, 23820
AppSec [baseline] (171.073 ms) : 0, 171073
AppSec [candidate] (171.062 ms) : 0, 171062
Debugger [baseline] (6.056 ms) : 0, 6056
Debugger [candidate] (6.034 ms) : 0, 6034
Remote Config [baseline] (619.118 µs) : 0, 619
Remote Config [candidate] (667.818 µs) : 0, 668
Telemetry [baseline] (8.397 ms) : 0, 8397
Telemetry [candidate] (8.409 ms) : 0, 8409
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (852.566 ms) : 0, 852566
BytebuddyAgent [candidate] (851.184 ms) : 0, 851184
GlobalTracer [baseline] (247.701 ms) : 0, 247701
GlobalTracer [candidate] (246.746 ms) : 0, 246746
IAST [baseline] (27.919 ms) : 0, 27919
IAST [candidate] (28.598 ms) : 0, 28598
AppSec [baseline] (25.497 ms) : 0, 25497
AppSec [candidate] (24.538 ms) : 0, 24538
Debugger [baseline] (6.014 ms) : 0, 6014
Debugger [candidate] (6.037 ms) : 0, 6037
Remote Config [baseline] (598.46 µs) : 0, 598
Remote Config [candidate] (593.427 µs) : 0, 593
Telemetry [baseline] (8.125 ms) : 0, 8125
Telemetry [candidate] (8.115 ms) : 0, 8115
section profiling
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (761.575 ms) : 0, 761575
BytebuddyAgent [candidate] (760.44 ms) : 0, 760440
GlobalTracer [baseline] (233.315 ms) : 0, 233315
GlobalTracer [candidate] (232.647 ms) : 0, 232647
AppSec [baseline] (30.466 ms) : 0, 30466
AppSec [candidate] (30.421 ms) : 0, 30421
Debugger [baseline] (8.981 ms) : 0, 8981
Debugger [candidate] (7.422 ms) : 0, 7422
Remote Config [baseline] (734.603 µs) : 0, 735
Remote Config [candidate] (694.042 µs) : 0, 694
Telemetry [baseline] (14.144 ms) : 0, 14144
Telemetry [candidate] (15.487 ms) : 0, 15487
ProfilingAgent [baseline] (107.473 ms) : 0, 107473
ProfilingAgent [candidate] (107.101 ms) : 0, 107101
Profiling [baseline] (108.125 ms) : 0, 108125
Profiling [candidate] (107.771 ms) : 0, 107771
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~95860e0d8e, baseline=1.54.0-SNAPSHOT~12c02b6d92
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064523
Total [baseline] (8.658 s) : 0, 8657762
Agent [candidate] (1.064 s) : 0, 1063749
Total [candidate] (8.638 s) : 0, 8638281
section iast
Agent [baseline] (1.191 s) : 0, 1191347
Total [baseline] (9.334 s) : 0, 9334044
Agent [candidate] (1.188 s) : 0, 1188329
Total [candidate] (9.319 s) : 0, 9318691
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~95860e0d8e, baseline=1.54.0-SNAPSHOT~12c02b6d92
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (735.529 ms) : 0, 735529
BytebuddyAgent [candidate] (734.373 ms) : 0, 734373
GlobalTracer [baseline] (253.091 ms) : 0, 253091
GlobalTracer [candidate] (253.076 ms) : 0, 253076
AppSec [baseline] (30.586 ms) : 0, 30586
AppSec [candidate] (30.627 ms) : 0, 30627
Debugger [baseline] (6.372 ms) : 0, 6372
Debugger [candidate] (6.37 ms) : 0, 6370
Remote Config [baseline] (698.973 µs) : 0, 699
Remote Config [candidate] (694.491 µs) : 0, 694
Telemetry [baseline] (15.632 ms) : 0, 15632
Telemetry [candidate] (16.017 ms) : 0, 16017
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (852.778 ms) : 0, 852778
BytebuddyAgent [candidate] (850.889 ms) : 0, 850889
GlobalTracer [baseline] (244.262 ms) : 0, 244262
GlobalTracer [candidate] (244.417 ms) : 0, 244417
IAST [baseline] (30.791 ms) : 0, 30791
IAST [candidate] (31.285 ms) : 0, 31285
AppSec [baseline] (25.889 ms) : 0, 25889
AppSec [candidate] (24.536 ms) : 0, 24536
Debugger [baseline] (6.161 ms) : 0, 6161
Debugger [candidate] (6.036 ms) : 0, 6036
Remote Config [baseline] (604.243 µs) : 0, 604
Remote Config [candidate] (615.534 µs) : 0, 616
Telemetry [baseline] (8.481 ms) : 0, 8481
Telemetry [candidate] (8.079 ms) : 0, 8079
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~95860e0d8e, baseline=1.54.0-SNAPSHOT~12c02b6d92
dateFormat X
axisFormat %s
section baseline
no_agent (4.494 ms) : 4437, 4550
. : milestone, 4494,
iast (9.624 ms) : 9464, 9784
. : milestone, 9624,
iast_FULL (14.717 ms) : 14423, 15012
. : milestone, 14717,
iast_GLOBAL (10.71 ms) : 10518, 10903
. : milestone, 10710,
profiling (9.151 ms) : 9006, 9295
. : milestone, 9151,
tracing (7.861 ms) : 7749, 7973
. : milestone, 7861,
section candidate
no_agent (4.535 ms) : 4478, 4593
. : milestone, 4535,
iast (9.952 ms) : 9783, 10120
. : milestone, 9952,
iast_FULL (14.766 ms) : 14473, 15060
. : milestone, 14766,
iast_GLOBAL (10.505 ms) : 10321, 10688
. : milestone, 10505,
profiling (9.048 ms) : 8898, 9198
. : milestone, 9048,
tracing (7.641 ms) : 7531, 7751
. : milestone, 7641,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~95860e0d8e, baseline=1.54.0-SNAPSHOT~12c02b6d92
dateFormat X
axisFormat %s
section baseline
no_agent (36.438 ms) : 36147, 36729
. : milestone, 36438,
appsec (49.771 ms) : 49338, 50204
. : milestone, 49771,
code_origins (45.881 ms) : 45487, 46275
. : milestone, 45881,
iast (44.969 ms) : 44567, 45370
. : milestone, 44969,
profiling (49.271 ms) : 48792, 49751
. : milestone, 49271,
tracing (44.751 ms) : 44368, 45133
. : milestone, 44751,
section candidate
no_agent (37.569 ms) : 37259, 37880
. : milestone, 37569,
appsec (47.7 ms) : 47302, 48098
. : milestone, 47700,
code_origins (45.014 ms) : 44644, 45383
. : milestone, 45014,
iast (46.847 ms) : 46433, 47261
. : milestone, 46847,
profiling (48.202 ms) : 47719, 48686
. : milestone, 48202,
tracing (43.732 ms) : 43363, 44101
. : milestone, 43732,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~95860e0d8e, baseline=1.54.0-SNAPSHOT~12c02b6d92
dateFormat X
axisFormat %s
section baseline
no_agent (14.786 s) : 14786000, 14786000
. : milestone, 14786000,
appsec (14.745 s) : 14745000, 14745000
. : milestone, 14745000,
iast (18.307 s) : 18307000, 18307000
. : milestone, 18307000,
iast_GLOBAL (17.844 s) : 17844000, 17844000
. : milestone, 17844000,
profiling (15.351 s) : 15351000, 15351000
. : milestone, 15351000,
tracing (14.739 s) : 14739000, 14739000
. : milestone, 14739000,
section candidate
no_agent (15.566 s) : 15566000, 15566000
. : milestone, 15566000,
appsec (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
iast (18.444 s) : 18444000, 18444000
. : milestone, 18444000,
iast_GLOBAL (18.111 s) : 18111000, 18111000
. : milestone, 18111000,
profiling (15.97 s) : 15970000, 15970000
. : milestone, 15970000,
tracing (15.155 s) : 15155000, 15155000
. : milestone, 15155000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~95860e0d8e, baseline=1.54.0-SNAPSHOT~12c02b6d92
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.73 ms) : 3512, 3948
. : milestone, 3730,
iast (2.222 ms) : 2159, 2285
. : milestone, 2222,
iast_GLOBAL (2.263 ms) : 2199, 2327
. : milestone, 2263,
profiling (2.078 ms) : 2026, 2130
. : milestone, 2078,
tracing (2.029 ms) : 1980, 2078
. : milestone, 2029,
section candidate
no_agent (1.486 ms) : 1474, 1498
. : milestone, 1486,
appsec (2.474 ms) : 2424, 2525
. : milestone, 2474,
iast (2.214 ms) : 2151, 2277
. : milestone, 2214,
iast_GLOBAL (2.264 ms) : 2201, 2327
. : milestone, 2264,
profiling (2.063 ms) : 2012, 2115
. : milestone, 2063,
tracing (2.026 ms) : 1977, 2074
. : milestone, 2026,
|
What Does This Do
Sets correct
X-Datadog-EVP-Subdomainwhen sending requests through EVP proxy.Motivation
Previously the subdomain was hardcoded to
api, which didn't work when sending requests to intake.Code coverage report uploading was affected.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]