Skip to content

Fix ClassCastException in SynapseServerInstrumentation #9513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcculls merged 1 commit into from
Sep 11, 2025
Merged

Fix ClassCastException in SynapseServerInstrumentation #9513

mcculls merged 1 commit into from
Sep 11, 2025

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Sep 11, 2025 •
edited by atlassian bot
Loading

What Does This Do

SynapseServerInstrumentation should pass parentContext to HttpServerDecorator.onRequest because the decorator will attempt to extract the incoming AgentSpanContext.Extracted from it.

Motivation

HttpServerDecorator.onRequest expects to be passed the parent context containing the extracted trace data.

Additional Notes

Updated the parameter name to make clear this method expects the incoming parentContext.

Also updated getExtractedSpanContext to report a clear warning if we find the given context contains an incompatible span context, rather than attempt the cast and cause a ClassCastException which is harder to debug and could cause other side-effects in instrumentation.

Contributor Checklist

Jira ticket: APMS-17143

@mcculls mcculls added the type: bug Bug report and fix label Sep 11, 2025
@mcculls mcculls requested a review from a team as a code owner September 11, 2025 08:45
@mcculls mcculls added the inst: others All other instrumentations label Sep 11, 2025
amarziali
amarziali approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and for having clarified the method argument name. I left a little comment on the logging

@datadog-official
Copy link

datadog-official bot commented Sep 11, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 90.91%
• Total Coverage: 62.86% (+2.71%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d521efa | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 11, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/check-context-span-is-extracted
git_commit_date 1757580581 1757584715
git_commit_sha b84c018 d521efa
release_version 1.54.0-SNAPSHOT~b84c0183bc 1.54.0-SNAPSHOT~d521efab5f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757586439 1757586439
ci_job_id 1124166851 1124166851
ci_pipeline_id 76170320 76170320
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-7hiqwr9n 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-7hiqwr9n 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~d521efab5f, baseline=1.54.0-SNAPSHOT~b84c0183bc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048210
Total [baseline] (8.644 s) : 0, 8643990
Agent [candidate] (1.051 s) : 0, 1050926
Total [candidate] (8.666 s) : 0, 8665824
section iast
Agent [baseline] (1.181 s) : 0, 1181207
Total [baseline] (9.404 s) : 0, 9404212
Agent [candidate] (1.182 s) : 0, 1182496
Total [candidate] (9.387 s) : 0, 9387019
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.181 s 132.997 ms (12.7%)
Total tracing 8.644 s -
Total iast 9.404 s 760.222 ms (8.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.182 s 131.569 ms (12.5%)
Total tracing 8.666 s -
Total iast 9.387 s 721.195 ms (8.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~d521efab5f, baseline=1.54.0-SNAPSHOT~b84c0183bc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (731.66 ms) : 0, 731660
BytebuddyAgent [candidate] (734.453 ms) : 0, 734453
GlobalTracer [baseline] (242.564 ms) : 0, 242564
GlobalTracer [candidate] (244.142 ms) : 0, 244142
AppSec [baseline] (30.514 ms) : 0, 30514
AppSec [candidate] (30.862 ms) : 0, 30862
Debugger [baseline] (6.423 ms) : 0, 6423
Debugger [candidate] (6.54 ms) : 0, 6540
Remote Config [baseline] (678.821 µs) : 0, 679
Remote Config [candidate] (700.211 µs) : 0, 700
Telemetry [baseline] (13.863 ms) : 0, 13863
Telemetry [candidate] (11.583 ms) : 0, 11583
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (851.709 ms) : 0, 851709
BytebuddyAgent [candidate] (853.097 ms) : 0, 853097
GlobalTracer [baseline] (233.264 ms) : 0, 233264
GlobalTracer [candidate] (233.611 ms) : 0, 233611
IAST [baseline] (31.417 ms) : 0, 31417
IAST [candidate] (31.283 ms) : 0, 31283
AppSec [baseline] (27.385 ms) : 0, 27385
AppSec [candidate] (26.185 ms) : 0, 26185
Debugger [baseline] (6.13 ms) : 0, 6130
Debugger [candidate] (6.916 ms) : 0, 6916
Remote Config [baseline] (609.718 µs) : 0, 610
Remote Config [candidate] (624.286 µs) : 0, 624
Telemetry [baseline] (8.244 ms) : 0, 8244
Telemetry [candidate] (8.295 ms) : 0, 8295
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~d521efab5f, baseline=1.54.0-SNAPSHOT~b84c0183bc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055225
Total [baseline] (10.838 s) : 0, 10837504
Agent [candidate] (1.05 s) : 0, 1049622
Total [candidate] (10.734 s) : 0, 10734488
section appsec
Agent [baseline] (1.235 s) : 0, 1235391
Total [baseline] (10.946 s) : 0, 10945579
Agent [candidate] (1.231 s) : 0, 1230863
Total [candidate] (10.884 s) : 0, 10884421
section iast
Agent [baseline] (1.178 s) : 0, 1177918
Total [baseline] (10.881 s) : 0, 10880505
Agent [candidate] (1.187 s) : 0, 1187007
Total [candidate] (10.95 s) : 0, 10950024
section profiling
Agent [baseline] (1.201 s) : 0, 1200857
Total [baseline] (10.837 s) : 0, 10836515
Agent [candidate] (1.207 s) : 0, 1207236
Total [candidate] (10.885 s) : 0, 10885476
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.235 s 180.166 ms (17.1%)
Agent iast 1.178 s 122.694 ms (11.6%)
Agent profiling 1.201 s 145.632 ms (13.8%)
Total tracing 10.838 s -
Total appsec 10.946 s 108.074 ms (1.0%)
Total iast 10.881 s 43.001 ms (0.4%)
Total profiling 10.837 s -989.405 µs (-0.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.231 s 181.241 ms (17.3%)
Agent iast 1.187 s 137.385 ms (13.1%)
Agent profiling 1.207 s 157.614 ms (15.0%)
Total tracing 10.734 s -
Total appsec 10.884 s 149.933 ms (1.4%)
Total iast 10.95 s 215.536 ms (2.0%)
Total profiling 10.885 s 150.988 ms (1.4%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~d521efab5f, baseline=1.54.0-SNAPSHOT~b84c0183bc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (736.624 ms) : 0, 736624
BytebuddyAgent [candidate] (732.125 ms) : 0, 732125
GlobalTracer [baseline] (244.517 ms) : 0, 244517
GlobalTracer [candidate] (242.868 ms) : 0, 242868
AppSec [baseline] (30.935 ms) : 0, 30935
AppSec [candidate] (30.469 ms) : 0, 30469
Debugger [baseline] (6.564 ms) : 0, 6564
Debugger [candidate] (6.417 ms) : 0, 6417
Remote Config [baseline] (702.744 µs) : 0, 703
Remote Config [candidate] (671.035 µs) : 0, 671
Telemetry [baseline] (13.149 ms) : 0, 13149
Telemetry [candidate] (14.478 ms) : 0, 14478
section appsec
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (762.941 ms) : 0, 762941
BytebuddyAgent [candidate] (759.714 ms) : 0, 759714
GlobalTracer [baseline] (237.567 ms) : 0, 237567
GlobalTracer [candidate] (237.02 ms) : 0, 237020
AppSec [baseline] (169.137 ms) : 0, 169137
AppSec [candidate] (171.135 ms) : 0, 171135
Debugger [baseline] (9.998 ms) : 0, 9998
Debugger [candidate] (7.547 ms) : 0, 7547
Remote Config [baseline] (650.087 µs) : 0, 650
Remote Config [candidate] (640.355 µs) : 0, 640
Telemetry [baseline] (8.501 ms) : 0, 8501
Telemetry [candidate] (8.45 ms) : 0, 8450
IAST [baseline] (23.826 ms) : 0, 23826
IAST [candidate] (23.697 ms) : 0, 23697
section iast
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (849.551 ms) : 0, 849551
BytebuddyAgent [candidate] (856.676 ms) : 0, 856676
GlobalTracer [baseline] (233.668 ms) : 0, 233668
GlobalTracer [candidate] (233.753 ms) : 0, 233753
AppSec [baseline] (26.114 ms) : 0, 26114
AppSec [candidate] (26.593 ms) : 0, 26593
Debugger [baseline] (6.156 ms) : 0, 6156
Debugger [candidate] (7.061 ms) : 0, 7061
Remote Config [baseline] (618.237 µs) : 0, 618
Remote Config [candidate] (615.224 µs) : 0, 615
Telemetry [baseline] (8.333 ms) : 0, 8333
Telemetry [candidate] (9.159 ms) : 0, 9159
IAST [baseline] (30.989 ms) : 0, 30989
IAST [candidate] (30.541 ms) : 0, 30541
section profiling
ProfilingAgent [baseline] (108.126 ms) : 0, 108126
ProfilingAgent [candidate] (108.502 ms) : 0, 108502
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (763.355 ms) : 0, 763355
BytebuddyAgent [candidate] (766.832 ms) : 0, 766832
GlobalTracer [baseline] (222.695 ms) : 0, 222695
GlobalTracer [candidate] (224.491 ms) : 0, 224491
AppSec [baseline] (30.753 ms) : 0, 30753
AppSec [candidate] (32.703 ms) : 0, 32703
Debugger [baseline] (6.782 ms) : 0, 6782
Debugger [candidate] (6.734 ms) : 0, 6734
Remote Config [baseline] (732.311 µs) : 0, 732
Remote Config [candidate] (686.455 µs) : 0, 686
Telemetry [baseline] (16.375 ms) : 0, 16375
Telemetry [candidate] (15.073 ms) : 0, 15073
Profiling [baseline] (108.827 ms) : 0, 108827
Profiling [candidate] (109.23 ms) : 0, 109230
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/check-context-span-is-extracted
git_commit_date 1757580581 1757584715
git_commit_sha b84c018 d521efa
release_version 1.54.0-SNAPSHOT~b84c0183bc 1.54.0-SNAPSHOT~d521efab5f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757586110 1757586110
ci_job_id 1124166852 1124166852
ci_pipeline_id 76170320 76170320
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-flyz1etc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-flyz1etc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:iast:high_load worse
[+226.987µs; +582.656µs] or [+2.392%; +6.141%]		 unstable
[-71.862op/s; +32.299op/s] or [-14.687%; +6.601%]		 9.894ms 469.500op/s 9.489ms 489.281op/s
scenario:load:petclinic:appsec:high_load worse
[+2.223ms; +3.159ms] or [+4.728%; +6.719%]		 unstable
[-11.079op/s; +2.663op/s] or [-11.129%; +2.675%]		 49.704ms 95.342op/s 47.013ms 99.550op/s
scenario:load:petclinic:no_agent:high_load better
[-1.609ms; -0.965ms] or [-4.243%; -2.544%]		 unstable
[-2.390op/s; +14.246op/s] or [-1.939%; +11.555%]		 36.648ms 129.215op/s 37.935ms 123.287op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d521efab5f, baseline=1.54.0-SNAPSHOT~b84c0183bc
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.935 ms) : 37630, 38240
.   : milestone, 37935,
appsec (47.013 ms) : 46605, 47420
.   : milestone, 47013,
code_origins (45.289 ms) : 44889, 45689
.   : milestone, 45289,
iast (44.646 ms) : 44249, 45044
.   : milestone, 44646,
profiling (48.547 ms) : 48116, 48978
.   : milestone, 48547,
tracing (45.301 ms) : 44908, 45693
.   : milestone, 45301,
section candidate
no_agent (36.648 ms) : 36354, 36941
.   : milestone, 36648,
appsec (49.704 ms) : 49243, 50165
.   : milestone, 49704,
code_origins (44.863 ms) : 44474, 45251
.   : milestone, 44863,
iast (45.017 ms) : 44622, 45413
.   : milestone, 45017,
profiling (49.163 ms) : 48688, 49637
.   : milestone, 49163,
tracing (44.361 ms) : 43973, 44749
.   : milestone, 44361,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.935 ms [37.63 ms, 38.24 ms] -
appsec 47.013 ms [46.605 ms, 47.42 ms] 9.078 ms (23.9%)
code_origins 45.289 ms [44.889 ms, 45.689 ms] 7.354 ms (19.4%)
iast 44.646 ms [44.249 ms, 45.044 ms] 6.712 ms (17.7%)
profiling 48.547 ms [48.116 ms, 48.978 ms] 10.612 ms (28.0%)
tracing 45.301 ms [44.908 ms, 45.693 ms] 7.366 ms (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.648 ms [36.354 ms, 36.941 ms] -
appsec 49.704 ms [49.243 ms, 50.165 ms] 13.056 ms (35.6%)
code_origins 44.863 ms [44.474 ms, 45.251 ms] 8.215 ms (22.4%)
iast 45.017 ms [44.622 ms, 45.413 ms] 8.37 ms (22.8%)
profiling 49.163 ms [48.688 ms, 49.637 ms] 12.515 ms (34.1%)
tracing 44.361 ms [43.973 ms, 44.749 ms] 7.714 ms (21.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d521efab5f, baseline=1.54.0-SNAPSHOT~b84c0183bc
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.495 ms) : 4439, 4550
.   : milestone, 4495,
iast (9.489 ms) : 9326, 9652
.   : milestone, 9489,
iast_FULL (14.271 ms) : 13985, 14557
.   : milestone, 14271,
iast_GLOBAL (10.418 ms) : 10232, 10604
.   : milestone, 10418,
profiling (8.816 ms) : 8677, 8955
.   : milestone, 8816,
tracing (8.004 ms) : 7888, 8120
.   : milestone, 8004,
section candidate
no_agent (4.378 ms) : 4323, 4432
.   : milestone, 4378,
iast (9.894 ms) : 9726, 10061
.   : milestone, 9894,
iast_FULL (14.516 ms) : 14230, 14802
.   : milestone, 14516,
iast_GLOBAL (10.662 ms) : 10468, 10856
.   : milestone, 10662,
profiling (9.056 ms) : 8901, 9210
.   : milestone, 9056,
tracing (7.768 ms) : 7656, 7881
.   : milestone, 7768,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.495 ms [4.439 ms, 4.55 ms] -
iast 9.489 ms [9.326 ms, 9.652 ms] 4.994 ms (111.1%)
iast_FULL 14.271 ms [13.985 ms, 14.557 ms] 9.777 ms (217.5%)
iast_GLOBAL 10.418 ms [10.232 ms, 10.604 ms] 5.923 ms (131.8%)
profiling 8.816 ms [8.677 ms, 8.955 ms] 4.321 ms (96.1%)
tracing 8.004 ms [7.888 ms, 8.12 ms] 3.509 ms (78.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.378 ms [4.323 ms, 4.432 ms] -
iast 9.894 ms [9.726 ms, 10.061 ms] 5.516 ms (126.0%)
iast_FULL 14.516 ms [14.23 ms, 14.802 ms] 10.138 ms (231.6%)
iast_GLOBAL 10.662 ms [10.468 ms, 10.856 ms] 6.284 ms (143.6%)
profiling 9.056 ms [8.901 ms, 9.21 ms] 4.678 ms (106.9%)
tracing 7.768 ms [7.656 ms, 7.881 ms] 3.39 ms (77.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/check-context-span-is-extracted
git_commit_date 1757580581 1757584715
git_commit_sha b84c018 d521efa
release_version 1.54.0-SNAPSHOT~b84c0183bc 1.54.0-SNAPSHOT~d521efab5f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1757586740 1757586740
ci_job_id 1124166853 1124166853
ci_pipeline_id 76170320 76170320
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-jbybp3k0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-jbybp3k0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d521efab5f, baseline=1.54.0-SNAPSHOT~b84c0183bc
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.867 s) : 14867000, 14867000
.   : milestone, 14867000,
appsec (15.029 s) : 15029000, 15029000
.   : milestone, 15029000,
iast (18.305 s) : 18305000, 18305000
.   : milestone, 18305000,
iast_GLOBAL (18.096 s) : 18096000, 18096000
.   : milestone, 18096000,
profiling (16.029 s) : 16029000, 16029000
.   : milestone, 16029000,
tracing (14.876 s) : 14876000, 14876000
.   : milestone, 14876000,
section candidate
no_agent (15.338 s) : 15338000, 15338000
.   : milestone, 15338000,
appsec (14.845 s) : 14845000, 14845000
.   : milestone, 14845000,
iast (18.598 s) : 18598000, 18598000
.   : milestone, 18598000,
iast_GLOBAL (18.153 s) : 18153000, 18153000
.   : milestone, 18153000,
profiling (15.45 s) : 15450000, 15450000
.   : milestone, 15450000,
tracing (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.867 s [14.867 s, 14.867 s] -
appsec 15.029 s [15.029 s, 15.029 s] 162.0 ms (1.1%)
iast 18.305 s [18.305 s, 18.305 s] 3.438 s (23.1%)
iast_GLOBAL 18.096 s [18.096 s, 18.096 s] 3.229 s (21.7%)
profiling 16.029 s [16.029 s, 16.029 s] 1.162 s (7.8%)
tracing 14.876 s [14.876 s, 14.876 s] 9.0 ms (0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.338 s [15.338 s, 15.338 s] -
appsec 14.845 s [14.845 s, 14.845 s] -493.0 ms (-3.2%)
iast 18.598 s [18.598 s, 18.598 s] 3.26 s (21.3%)
iast_GLOBAL 18.153 s [18.153 s, 18.153 s] 2.815 s (18.4%)
profiling 15.45 s [15.45 s, 15.45 s] 112.0 ms (0.7%)
tracing 15.075 s [15.075 s, 15.075 s] -263.0 ms (-1.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d521efab5f, baseline=1.54.0-SNAPSHOT~b84c0183bc
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (3.699 ms) : 3481, 3917
.   : milestone, 3699,
iast (2.198 ms) : 2135, 2261
.   : milestone, 2198,
iast_GLOBAL (2.241 ms) : 2178, 2305
.   : milestone, 2241,
profiling (2.056 ms) : 2004, 2108
.   : milestone, 2056,
tracing (2.012 ms) : 1963, 2061
.   : milestone, 2012,
section candidate
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (3.726 ms) : 3508, 3943
.   : milestone, 3726,
iast (2.186 ms) : 2124, 2249
.   : milestone, 2186,
iast_GLOBAL (2.232 ms) : 2169, 2295
.   : milestone, 2232,
profiling (2.022 ms) : 1972, 2071
.   : milestone, 2022,
tracing (2.011 ms) : 1963, 2060
.   : milestone, 2011,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 3.699 ms [3.481 ms, 3.917 ms] 2.231 ms (151.9%)
iast 2.198 ms [2.135 ms, 2.261 ms] 729.418 µs (49.7%)
iast_GLOBAL 2.241 ms [2.178 ms, 2.305 ms] 772.489 µs (52.6%)
profiling 2.056 ms [2.004 ms, 2.108 ms] 587.189 µs (40.0%)
tracing 2.012 ms [1.963 ms, 2.061 ms] 543.368 µs (37.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 3.726 ms [3.508 ms, 3.943 ms] 2.246 ms (151.9%)
iast 2.186 ms [2.124 ms, 2.249 ms] 707.279 µs (47.8%)
iast_GLOBAL 2.232 ms [2.169 ms, 2.295 ms] 753.239 µs (50.9%)
profiling 2.022 ms [1.972 ms, 2.071 ms] 542.664 µs (36.7%)
tracing 2.011 ms [1.963 ms, 2.06 ms] 532.181 µs (36.0%)

@mcculls mcculls force-pushed the mcculls/check-context-span-is-extracted branch from c711f72 to d521efa Compare September 11, 2025 09:59
@mcculls mcculls merged commit 2349c6e into master Sep 11, 2025
503 checks passed
@mcculls mcculls deleted the mcculls/check-context-span-is-extracted branch September 11, 2025 12:42
@github-actions github-actions bot added this to the 1.54.0 milestone Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarziali amarziali amarziali approved these changes

Assignees

No one assigned

Labels

inst: others All other instrumentations type: bug Bug report and fix

Projects

None yet

Milestone

1.54.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @amarziali