-
Notifications
You must be signed in to change notification settings - Fork 320
Avoid direct casting of base service tag to string #9489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 2f91404 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~2f91404631, baseline=1.54.0-SNAPSHOT~6e135e5b47
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050182
Total [baseline] (10.783 s) : 0, 10782827
Agent [candidate] (1.054 s) : 0, 1054063
Total [candidate] (10.74 s) : 0, 10740352
section appsec
Agent [baseline] (1.228 s) : 0, 1227739
Total [baseline] (10.926 s) : 0, 10925637
Agent [candidate] (1.239 s) : 0, 1238975
Total [candidate] (10.895 s) : 0, 10894556
section iast
Agent [baseline] (1.181 s) : 0, 1181249
Total [baseline] (10.928 s) : 0, 10927865
Agent [candidate] (1.181 s) : 0, 1180758
Total [candidate] (10.937 s) : 0, 10936739
section profiling
Agent [baseline] (1.218 s) : 0, 1217687
Total [baseline] (11.027 s) : 0, 11027483
Agent [candidate] (1.199 s) : 0, 1199250
Total [candidate] (10.91 s) : 0, 10910271
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~2f91404631, baseline=1.54.0-SNAPSHOT~6e135e5b47
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (735.382 ms) : 0, 735382
BytebuddyAgent [candidate] (736.491 ms) : 0, 736491
GlobalTracer [baseline] (243.453 ms) : 0, 243453
GlobalTracer [candidate] (242.915 ms) : 0, 242915
AppSec [baseline] (30.304 ms) : 0, 30304
AppSec [candidate] (30.142 ms) : 0, 30142
Debugger [baseline] (6.088 ms) : 0, 6088
Debugger [candidate] (6.088 ms) : 0, 6088
Remote Config [baseline] (706.2 µs) : 0, 706
Remote Config [candidate] (688.002 µs) : 0, 688
Telemetry [baseline] (11.586 ms) : 0, 11586
Telemetry [candidate] (15.082 ms) : 0, 15082
section appsec
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (757.722 ms) : 0, 757722
BytebuddyAgent [candidate] (765.088 ms) : 0, 765088
GlobalTracer [baseline] (236.737 ms) : 0, 236737
GlobalTracer [candidate] (238.377 ms) : 0, 238377
AppSec [baseline] (170.517 ms) : 0, 170517
AppSec [candidate] (170.949 ms) : 0, 170949
Debugger [baseline] (7.241 ms) : 0, 7241
Debugger [candidate] (6.652 ms) : 0, 6652
Remote Config [baseline] (633.201 µs) : 0, 633
Remote Config [candidate] (639.946 µs) : 0, 640
Telemetry [baseline] (8.609 ms) : 0, 8609
Telemetry [candidate] (10.25 ms) : 0, 10250
IAST [baseline] (23.67 ms) : 0, 23670
IAST [candidate] (24.183 ms) : 0, 24183
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (851.766 ms) : 0, 851766
BytebuddyAgent [candidate] (852.43 ms) : 0, 852430
GlobalTracer [baseline] (233.798 ms) : 0, 233798
GlobalTracer [candidate] (234.146 ms) : 0, 234146
AppSec [baseline] (26.174 ms) : 0, 26174
AppSec [candidate] (27.039 ms) : 0, 27039
Debugger [baseline] (7.638 ms) : 0, 7638
Debugger [candidate] (6.592 ms) : 0, 6592
Remote Config [baseline] (608.513 µs) : 0, 609
Remote Config [candidate] (590.3 µs) : 0, 590
Telemetry [baseline] (8.411 ms) : 0, 8411
Telemetry [candidate] (8.207 ms) : 0, 8207
IAST [baseline] (30.236 ms) : 0, 30236
IAST [candidate] (29.139 ms) : 0, 29139
section profiling
ProfilingAgent [baseline] (109.693 ms) : 0, 109693
ProfilingAgent [candidate] (107.878 ms) : 0, 107878
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (774.37 ms) : 0, 774370
BytebuddyAgent [candidate] (762.094 ms) : 0, 762094
GlobalTracer [baseline] (226.089 ms) : 0, 226089
GlobalTracer [candidate] (223.333 ms) : 0, 223333
AppSec [baseline] (31.107 ms) : 0, 31107
AppSec [candidate] (30.51 ms) : 0, 30510
Debugger [baseline] (6.381 ms) : 0, 6381
Debugger [candidate] (7.06 ms) : 0, 7060
Remote Config [baseline] (703.185 µs) : 0, 703
Remote Config [candidate] (698.955 µs) : 0, 699
Telemetry [baseline] (16.577 ms) : 0, 16577
Telemetry [candidate] (14.939 ms) : 0, 14939
Profiling [baseline] (110.359 ms) : 0, 110359
Profiling [candidate] (108.538 ms) : 0, 108538
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~2f91404631, baseline=1.54.0-SNAPSHOT~6e135e5b47
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054669
Total [baseline] (8.692 s) : 0, 8692028
Agent [candidate] (1.05 s) : 0, 1050036
Total [candidate] (8.674 s) : 0, 8674203
section iast
Agent [baseline] (1.189 s) : 0, 1189062
Total [baseline] (9.399 s) : 0, 9398527
Agent [candidate] (1.181 s) : 0, 1180871
Total [candidate] (9.376 s) : 0, 9376140
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~2f91404631, baseline=1.54.0-SNAPSHOT~6e135e5b47
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (738.196 ms) : 0, 738196
BytebuddyAgent [candidate] (733.857 ms) : 0, 733857
GlobalTracer [baseline] (244.173 ms) : 0, 244173
GlobalTracer [candidate] (242.637 ms) : 0, 242637
AppSec [baseline] (30.407 ms) : 0, 30407
AppSec [candidate] (30.398 ms) : 0, 30398
Debugger [baseline] (6.116 ms) : 0, 6116
Debugger [candidate] (6.125 ms) : 0, 6125
Remote Config [baseline] (699.951 µs) : 0, 700
Remote Config [candidate] (690.64 µs) : 0, 691
Telemetry [baseline] (12.401 ms) : 0, 12401
Telemetry [candidate] (13.74 ms) : 0, 13740
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (858.84 ms) : 0, 858840
BytebuddyAgent [candidate] (852.211 ms) : 0, 852211
GlobalTracer [baseline] (235.407 ms) : 0, 235407
GlobalTracer [candidate] (233.424 ms) : 0, 233424
AppSec [baseline] (28.821 ms) : 0, 28821
AppSec [candidate] (26.764 ms) : 0, 26764
Debugger [baseline] (5.834 ms) : 0, 5834
Debugger [candidate] (6.685 ms) : 0, 6685
Remote Config [baseline] (607.488 µs) : 0, 607
Remote Config [candidate] (595.741 µs) : 0, 596
Telemetry [baseline] (8.294 ms) : 0, 8294
Telemetry [candidate] (8.225 ms) : 0, 8225
IAST [baseline] (28.666 ms) : 0, 28666
IAST [candidate] (30.415 ms) : 0, 30415
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2f91404631, baseline=1.54.0-SNAPSHOT~6e135e5b47
dateFormat X
axisFormat %s
section baseline
no_agent (4.535 ms) : 4483, 4587
. : milestone, 4535,
iast (9.496 ms) : 9338, 9654
. : milestone, 9496,
iast_FULL (14.046 ms) : 13763, 14328
. : milestone, 14046,
iast_GLOBAL (10.254 ms) : 10074, 10433
. : milestone, 10254,
profiling (8.71 ms) : 8567, 8852
. : milestone, 8710,
tracing (7.683 ms) : 7574, 7792
. : milestone, 7683,
section candidate
no_agent (4.37 ms) : 4319, 4420
. : milestone, 4370,
iast (9.668 ms) : 9506, 9829
. : milestone, 9668,
iast_FULL (14.169 ms) : 13884, 14455
. : milestone, 14169,
iast_GLOBAL (10.565 ms) : 10363, 10767
. : milestone, 10565,
profiling (9.295 ms) : 9151, 9439
. : milestone, 9295,
tracing (7.579 ms) : 7466, 7693
. : milestone, 7579,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2f91404631, baseline=1.54.0-SNAPSHOT~6e135e5b47
dateFormat X
axisFormat %s
section baseline
no_agent (38.226 ms) : 37921, 38532
. : milestone, 38226,
appsec (47.201 ms) : 46787, 47616
. : milestone, 47201,
code_origins (45.333 ms) : 44931, 45735
. : milestone, 45333,
iast (45.685 ms) : 45290, 46079
. : milestone, 45685,
profiling (48.486 ms) : 48026, 48946
. : milestone, 48486,
tracing (44.312 ms) : 43929, 44695
. : milestone, 44312,
section candidate
no_agent (36.347 ms) : 36057, 36637
. : milestone, 36347,
appsec (48.605 ms) : 48184, 49025
. : milestone, 48605,
code_origins (45.72 ms) : 45331, 46110
. : milestone, 45720,
iast (46.349 ms) : 45954, 46744
. : milestone, 46349,
profiling (50.345 ms) : 49898, 50791
. : milestone, 50345,
tracing (44.745 ms) : 44355, 45134
. : milestone, 44745,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2f91404631, baseline=1.54.0-SNAPSHOT~6e135e5b47
dateFormat X
axisFormat %s
section baseline
no_agent (15.603 s) : 15603000, 15603000
. : milestone, 15603000,
appsec (14.852 s) : 14852000, 14852000
. : milestone, 14852000,
iast (18.284 s) : 18284000, 18284000
. : milestone, 18284000,
iast_GLOBAL (18.36 s) : 18360000, 18360000
. : milestone, 18360000,
profiling (15.437 s) : 15437000, 15437000
. : milestone, 15437000,
tracing (14.81 s) : 14810000, 14810000
. : milestone, 14810000,
section candidate
no_agent (15.347 s) : 15347000, 15347000
. : milestone, 15347000,
appsec (14.84 s) : 14840000, 14840000
. : milestone, 14840000,
iast (18.344 s) : 18344000, 18344000
. : milestone, 18344000,
iast_GLOBAL (17.736 s) : 17736000, 17736000
. : milestone, 17736000,
profiling (15.24 s) : 15240000, 15240000
. : milestone, 15240000,
tracing (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2f91404631, baseline=1.54.0-SNAPSHOT~6e135e5b47
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.457 ms) : 2404, 2510
. : milestone, 2457,
iast (2.207 ms) : 2143, 2270
. : milestone, 2207,
iast_GLOBAL (2.238 ms) : 2174, 2302
. : milestone, 2238,
profiling (2.061 ms) : 2009, 2113
. : milestone, 2061,
tracing (2.022 ms) : 1973, 2071
. : milestone, 2022,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.651 ms) : 3436, 3867
. : milestone, 3651,
iast (2.2 ms) : 2137, 2263
. : milestone, 2200,
iast_GLOBAL (2.234 ms) : 2171, 2297
. : milestone, 2234,
profiling (2.076 ms) : 2022, 2129
. : milestone, 2076,
tracing (2.011 ms) : 1962, 2060
. : milestone, 2011,
|
What Does This Do
Might throw a classcastexception if not set as string
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]