Skip to content

Refactor spring instrumentation folders#9485

Merged
amarziali merged 1 commit intomasterfrom
andrea.marziali/spring
Sep 8, 2025
Merged

Refactor spring instrumentation folders#9485
amarziali merged 1 commit intomasterfrom
andrea.marziali/spring

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

@amarziali amarziali commented Sep 8, 2025

What Does This Do

Moves spring instrumentations under a spring top folder. It also regroup spring webmv, security and webflux in top folders

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested review from a team as code owners September 8, 2025 08:21
@amarziali amarziali requested review from AlexeyKuznetsov-DD, manuel-alvarez-alvarez and smola and removed request for a team September 8, 2025 08:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 8, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@amarziali amarziali added tag: no release notes Changes to exclude from release notes type: refactoring inst: spring Spring instrumentation labels Sep 8, 2025
@amarziali amarziali enabled auto-merge (squash) September 8, 2025 08:21
@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official Bot commented Sep 8, 2025 •
edited by datadog-datadog-prod-us1 Bot
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 57.78% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9afeb71 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Sep 8, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/spring
git_commit_date 1757318317 1757319614
git_commit_sha 67f94ae 9afeb71
release_version 1.54.0-SNAPSHOT~67f94aed97 1.54.0-SNAPSHOT~9afeb717c3
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757321312 1757321312
ci_job_id 1117533919 1117533919
ci_pipeline_id 75789028 75789028
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-4zvj2b54 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-4zvj2b54 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~9afeb717c3, baseline=1.54.0-SNAPSHOT~67f94aed97

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045258
Total [baseline] (8.627 s) : 0, 8627448
Agent [candidate] (1.051 s) : 0, 1051282
Total [candidate] (8.623 s) : 0, 8622750
section iast
Agent [baseline] (1.18 s) : 0, 1179821
Total [baseline] (9.333 s) : 0, 9332976
Agent [candidate] (1.189 s) : 0, 1188893
Total [candidate] (9.321 s) : 0, 9321196
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.18 s 134.563 ms (12.9%)
Total tracing 8.627 s -
Total iast 9.333 s 705.529 ms (8.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.189 s 137.61 ms (13.1%)
Total tracing 8.623 s -
Total iast 9.321 s 698.446 ms (8.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~9afeb717c3, baseline=1.54.0-SNAPSHOT~67f94aed97

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (730.055 ms) : 0, 730055
BytebuddyAgent [candidate] (735.518 ms) : 0, 735518
GlobalTracer [baseline] (241.544 ms) : 0, 241544
GlobalTracer [candidate] (243.184 ms) : 0, 243184
AppSec [baseline] (30.09 ms) : 0, 30090
AppSec [candidate] (30.246 ms) : 0, 30246
Debugger [baseline] (6.04 ms) : 0, 6040
Debugger [candidate] (6.069 ms) : 0, 6069
Remote Config [baseline] (689.679 µs) : 0, 690
Remote Config [candidate] (687.029 µs) : 0, 687
Telemetry [baseline] (14.411 ms) : 0, 14411
Telemetry [candidate] (13.045 ms) : 0, 13045
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (851.604 ms) : 0, 851604
BytebuddyAgent [candidate] (858.623 ms) : 0, 858623
GlobalTracer [baseline] (232.851 ms) : 0, 232851
GlobalTracer [candidate] (234.326 ms) : 0, 234326
IAST [baseline] (31.322 ms) : 0, 31322
IAST [candidate] (29.511 ms) : 0, 29511
AppSec [baseline] (25.994 ms) : 0, 25994
AppSec [candidate] (27.184 ms) : 0, 27184
Debugger [baseline] (6.713 ms) : 0, 6713
Debugger [candidate] (7.647 ms) : 0, 7647
Remote Config [baseline] (608.764 µs) : 0, 609
Remote Config [candidate] (600.118 µs) : 0, 600
Telemetry [baseline] (8.27 ms) : 0, 8270
Telemetry [candidate] (8.345 ms) : 0, 8345
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~9afeb717c3, baseline=1.54.0-SNAPSHOT~67f94aed97

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048237
Total [baseline] (10.609 s) : 0, 10609071
Agent [candidate] (1.054 s) : 0, 1053554
Total [candidate] (10.71 s) : 0, 10710337
section appsec
Agent [baseline] (1.222 s) : 0, 1221903
Total [baseline] (10.774 s) : 0, 10773648
Agent [candidate] (1.222 s) : 0, 1221521
Total [candidate] (10.792 s) : 0, 10792140
section iast
Agent [baseline] (1.19 s) : 0, 1189595
Total [baseline] (10.967 s) : 0, 10967111
Agent [candidate] (1.181 s) : 0, 1180729
Total [candidate] (10.896 s) : 0, 10895919
section profiling
Agent [baseline] (1.202 s) : 0, 1201881
Total [baseline] (10.922 s) : 0, 10921582
Agent [candidate] (1.203 s) : 0, 1203493
Total [candidate] (10.85 s) : 0, 10850445
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.222 s 173.666 ms (16.6%)
Agent iast 1.19 s 141.358 ms (13.5%)
Agent profiling 1.202 s 153.644 ms (14.7%)
Total tracing 10.609 s -
Total appsec 10.774 s 164.577 ms (1.6%)
Total iast 10.967 s 358.039 ms (3.4%)
Total profiling 10.922 s 312.51 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.222 s 167.968 ms (15.9%)
Agent iast 1.181 s 127.175 ms (12.1%)
Agent profiling 1.203 s 149.939 ms (14.2%)
Total tracing 10.71 s -
Total appsec 10.792 s 81.803 ms (0.8%)
Total iast 10.896 s 185.582 ms (1.7%)
Total profiling 10.85 s 140.108 ms (1.3%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~9afeb717c3, baseline=1.54.0-SNAPSHOT~67f94aed97

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (733.537 ms) : 0, 733537
BytebuddyAgent [candidate] (736.568 ms) : 0, 736568
GlobalTracer [baseline] (242.784 ms) : 0, 242784
GlobalTracer [candidate] (244.07 ms) : 0, 244070
AppSec [baseline] (30.27 ms) : 0, 30270
AppSec [candidate] (30.36 ms) : 0, 30360
Debugger [baseline] (6.098 ms) : 0, 6098
Debugger [candidate] (6.141 ms) : 0, 6141
Remote Config [baseline] (695.089 µs) : 0, 695
Remote Config [candidate] (688.324 µs) : 0, 688
Telemetry [baseline] (12.286 ms) : 0, 12286
Telemetry [candidate] (13.031 ms) : 0, 13031
section appsec
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (754.115 ms) : 0, 754115
BytebuddyAgent [candidate] (754.459 ms) : 0, 754459
GlobalTracer [baseline] (235.249 ms) : 0, 235249
GlobalTracer [candidate] (235.151 ms) : 0, 235151
IAST [baseline] (23.618 ms) : 0, 23618
IAST [candidate] (23.628 ms) : 0, 23628
AppSec [baseline] (169.001 ms) : 0, 169001
AppSec [candidate] (168.707 ms) : 0, 168707
Debugger [baseline] (8.148 ms) : 0, 8148
Debugger [candidate] (8.094 ms) : 0, 8094
Remote Config [baseline] (622.552 µs) : 0, 623
Remote Config [candidate] (618.373 µs) : 0, 618
Telemetry [baseline] (8.564 ms) : 0, 8564
Telemetry [candidate] (8.384 ms) : 0, 8384
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (858.889 ms) : 0, 858889
BytebuddyAgent [candidate] (852.411 ms) : 0, 852411
GlobalTracer [baseline] (234.586 ms) : 0, 234586
GlobalTracer [candidate] (233.643 ms) : 0, 233643
IAST [baseline] (29.696 ms) : 0, 29696
IAST [candidate] (31.613 ms) : 0, 31613
AppSec [baseline] (28.096 ms) : 0, 28096
AppSec [candidate] (25.883 ms) : 0, 25883
Debugger [baseline] (6.751 ms) : 0, 6751
Debugger [candidate] (5.78 ms) : 0, 5780
Remote Config [baseline] (620.129 µs) : 0, 620
Remote Config [candidate] (599.323 µs) : 0, 599
Telemetry [baseline] (8.281 ms) : 0, 8281
Telemetry [candidate] (8.264 ms) : 0, 8264
section profiling
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (764.412 ms) : 0, 764412
BytebuddyAgent [candidate] (765.688 ms) : 0, 765688
GlobalTracer [baseline] (223.319 ms) : 0, 223319
GlobalTracer [candidate] (223.748 ms) : 0, 223748
AppSec [baseline] (31.423 ms) : 0, 31423
AppSec [candidate] (30.774 ms) : 0, 30774
Debugger [baseline] (6.246 ms) : 0, 6246
Debugger [candidate] (6.27 ms) : 0, 6270
Remote Config [baseline] (751.45 µs) : 0, 751
Remote Config [candidate] (767.033 µs) : 0, 767
Telemetry [baseline] (15.775 ms) : 0, 15775
Telemetry [candidate] (16.232 ms) : 0, 16232
ProfilingAgent [baseline] (107.996 ms) : 0, 107996
ProfilingAgent [candidate] (107.86 ms) : 0, 107860
Profiling [baseline] (108.645 ms) : 0, 108645
Profiling [candidate] (108.535 ms) : 0, 108535
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/spring
git_commit_date 1757318317 1757319614
git_commit_sha 67f94ae 9afeb71
release_version 1.54.0-SNAPSHOT~67f94aed97 1.54.0-SNAPSHOT~9afeb717c3
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757321084 1757321084
ci_job_id 1117533920 1117533920
ci_pipeline_id 75789028 75789028
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-28dm52z3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-28dm52z3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load worse
[+328.809µs; +642.834µs] or [+3.769%; +7.368%]		 unstable
[-92.493op/s; +36.993op/s] or [-17.400%; +6.959%]		 9.210ms 503.812op/s 8.724ms 531.562op/s
scenario:load:petclinic:appsec:high_load better
[-2.663ms; -1.779ms] or [-5.511%; -3.681%]		 unstable
[-2.229op/s; +11.554op/s] or [-2.302%; +11.934%]		 46.108ms 101.475op/s 48.329ms 96.812op/s
scenario:load:petclinic:tracing:high_load better
[-3.805ms; -2.967ms] or [-8.238%; -6.425%]		 unstable
[+0.439op/s; +15.486op/s] or [+0.433%; +15.284%]		 42.796ms 109.287op/s 46.182ms 101.325op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~9afeb717c3, baseline=1.54.0-SNAPSHOT~67f94aed97
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.903 ms) : 37601, 38206
.   : milestone, 37903,
appsec (48.329 ms) : 47910, 48748
.   : milestone, 48329,
code_origins (46.212 ms) : 45797, 46627
.   : milestone, 46212,
iast (44.94 ms) : 44558, 45323
.   : milestone, 44940,
profiling (48.632 ms) : 48108, 49155
.   : milestone, 48632,
tracing (46.182 ms) : 45779, 46584
.   : milestone, 46182,
section candidate
no_agent (37.328 ms) : 37026, 37630
.   : milestone, 37328,
appsec (46.108 ms) : 45705, 46510
.   : milestone, 46108,
code_origins (46.852 ms) : 46461, 47244
.   : milestone, 46852,
iast (46.03 ms) : 45633, 46427
.   : milestone, 46030,
profiling (47.891 ms) : 47384, 48398
.   : milestone, 47891,
tracing (42.796 ms) : 42421, 43171
.   : milestone, 42796,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.903 ms [37.601 ms, 38.206 ms] -
appsec 48.329 ms [47.91 ms, 48.748 ms] 10.426 ms (27.5%)
code_origins 46.212 ms [45.797 ms, 46.627 ms] 8.309 ms (21.9%)
iast 44.94 ms [44.558 ms, 45.323 ms] 7.037 ms (18.6%)
profiling 48.632 ms [48.108 ms, 49.155 ms] 10.728 ms (28.3%)
tracing 46.182 ms [45.779 ms, 46.584 ms] 8.278 ms (21.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.328 ms [37.026 ms, 37.63 ms] -
appsec 46.108 ms [45.705 ms, 46.51 ms] 8.78 ms (23.5%)
code_origins 46.852 ms [46.461 ms, 47.244 ms] 9.524 ms (25.5%)
iast 46.03 ms [45.633 ms, 46.427 ms] 8.702 ms (23.3%)
profiling 47.891 ms [47.384 ms, 48.398 ms] 10.563 ms (28.3%)
tracing 42.796 ms [42.421 ms, 43.171 ms] 5.468 ms (14.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~9afeb717c3, baseline=1.54.0-SNAPSHOT~67f94aed97
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.43 ms) : 4381, 4480
.   : milestone, 4430,
iast (9.568 ms) : 9409, 9728
.   : milestone, 9568,
iast_FULL (14.128 ms) : 13848, 14409
.   : milestone, 14128,
iast_GLOBAL (10.483 ms) : 10298, 10668
.   : milestone, 10483,
profiling (8.724 ms) : 8587, 8862
.   : milestone, 8724,
tracing (7.785 ms) : 7665, 7905
.   : milestone, 7785,
section candidate
no_agent (4.469 ms) : 4411, 4527
.   : milestone, 4469,
iast (9.449 ms) : 9295, 9603
.   : milestone, 9449,
iast_FULL (14.119 ms) : 13837, 14401
.   : milestone, 14119,
iast_GLOBAL (10.785 ms) : 10590, 10980
.   : milestone, 10785,
profiling (9.21 ms) : 9057, 9364
.   : milestone, 9210,
tracing (7.825 ms) : 7712, 7938
.   : milestone, 7825,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.43 ms [4.381 ms, 4.48 ms] -
iast 9.568 ms [9.409 ms, 9.728 ms] 5.138 ms (116.0%)
iast_FULL 14.128 ms [13.848 ms, 14.409 ms] 9.698 ms (218.9%)
iast_GLOBAL 10.483 ms [10.298 ms, 10.668 ms] 6.052 ms (136.6%)
profiling 8.724 ms [8.587 ms, 8.862 ms] 4.294 ms (96.9%)
tracing 7.785 ms [7.665 ms, 7.905 ms] 3.355 ms (75.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.469 ms [4.411 ms, 4.527 ms] -
iast 9.449 ms [9.295 ms, 9.603 ms] 4.98 ms (111.4%)
iast_FULL 14.119 ms [13.837 ms, 14.401 ms] 9.65 ms (215.9%)
iast_GLOBAL 10.785 ms [10.59 ms, 10.98 ms] 6.315 ms (141.3%)
profiling 9.21 ms [9.057 ms, 9.364 ms] 4.741 ms (106.1%)
tracing 7.825 ms [7.712 ms, 7.938 ms] 3.356 ms (75.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/spring
git_commit_date 1757318317 1757319614
git_commit_sha 67f94ae 9afeb71
release_version 1.54.0-SNAPSHOT~67f94aed97 1.54.0-SNAPSHOT~9afeb717c3
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1757321614 1757321614
ci_job_id 1117533921 1117533921
ci_pipeline_id 75789028 75789028
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-qfahnpgz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-qfahnpgz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~9afeb717c3, baseline=1.54.0-SNAPSHOT~67f94aed97
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.039 s) : 15039000, 15039000
.   : milestone, 15039000,
appsec (14.937 s) : 14937000, 14937000
.   : milestone, 14937000,
iast (19.021 s) : 19021000, 19021000
.   : milestone, 19021000,
iast_GLOBAL (18.169 s) : 18169000, 18169000
.   : milestone, 18169000,
profiling (15.889 s) : 15889000, 15889000
.   : milestone, 15889000,
tracing (14.768 s) : 14768000, 14768000
.   : milestone, 14768000,
section candidate
no_agent (15.382 s) : 15382000, 15382000
.   : milestone, 15382000,
appsec (14.722 s) : 14722000, 14722000
.   : milestone, 14722000,
iast (18.578 s) : 18578000, 18578000
.   : milestone, 18578000,
iast_GLOBAL (17.919 s) : 17919000, 17919000
.   : milestone, 17919000,
profiling (15.473 s) : 15473000, 15473000
.   : milestone, 15473000,
tracing (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.039 s [15.039 s, 15.039 s] -
appsec 14.937 s [14.937 s, 14.937 s] -102.0 ms (-0.7%)
iast 19.021 s [19.021 s, 19.021 s] 3.982 s (26.5%)
iast_GLOBAL 18.169 s [18.169 s, 18.169 s] 3.13 s (20.8%)
profiling 15.889 s [15.889 s, 15.889 s] 850.0 ms (5.7%)
tracing 14.768 s [14.768 s, 14.768 s] -271.0 ms (-1.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.382 s [15.382 s, 15.382 s] -
appsec 14.722 s [14.722 s, 14.722 s] -660.0 ms (-4.3%)
iast 18.578 s [18.578 s, 18.578 s] 3.196 s (20.8%)
iast_GLOBAL 17.919 s [17.919 s, 17.919 s] 2.537 s (16.5%)
profiling 15.473 s [15.473 s, 15.473 s] 91.0 ms (0.6%)
tracing 14.948 s [14.948 s, 14.948 s] -434.0 ms (-2.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~9afeb717c3, baseline=1.54.0-SNAPSHOT~67f94aed97
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
.   : milestone, 1481,
appsec (3.72 ms) : 3503, 3938
.   : milestone, 3720,
iast (2.21 ms) : 2147, 2273
.   : milestone, 2210,
iast_GLOBAL (2.251 ms) : 2188, 2314
.   : milestone, 2251,
profiling (2.08 ms) : 2028, 2132
.   : milestone, 2080,
tracing (2.023 ms) : 1974, 2072
.   : milestone, 2023,
section candidate
no_agent (1.483 ms) : 1471, 1494
.   : milestone, 1483,
appsec (3.691 ms) : 3472, 3910
.   : milestone, 3691,
iast (2.21 ms) : 2147, 2273
.   : milestone, 2210,
iast_GLOBAL (2.25 ms) : 2187, 2313
.   : milestone, 2250,
profiling (2.052 ms) : 2002, 2102
.   : milestone, 2052,
tracing (2.028 ms) : 1979, 2076
.   : milestone, 2028,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.469 ms, 1.492 ms] -
appsec 3.72 ms [3.503 ms, 3.938 ms] 2.24 ms (151.2%)
iast 2.21 ms [2.147 ms, 2.273 ms] 729.223 µs (49.2%)
iast_GLOBAL 2.251 ms [2.188 ms, 2.314 ms] 769.993 µs (52.0%)
profiling 2.08 ms [2.028 ms, 2.132 ms] 598.988 µs (40.5%)
tracing 2.023 ms [1.974 ms, 2.072 ms] 542.058 µs (36.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.483 ms [1.471 ms, 1.494 ms] -
appsec 3.691 ms [3.472 ms, 3.91 ms] 2.208 ms (149.0%)
iast 2.21 ms [2.147 ms, 2.273 ms] 727.473 µs (49.1%)
iast_GLOBAL 2.25 ms [2.187 ms, 2.313 ms] 767.693 µs (51.8%)
profiling 2.052 ms [2.002 ms, 2.102 ms] 569.345 µs (38.4%)
tracing 2.028 ms [1.979 ms, 2.076 ms] 545.16 µs (36.8%)

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Sep 8, 2025

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/spring
git_commit_date 1757283240 1757319614
git_commit_sha 7e0a03a 9afeb71
See matching parameters
Baseline Candidate
ci_job_date 1757320633 1757320633
ci_job_id 1117533924 1117533924
ci_pipeline_id 75789028 75789028
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

manuel-alvarez-alvarez
manuel-alvarez-alvarez approved these changes Sep 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali amarziali merged commit 3ff796a into master Sep 8, 2025
509 of 510 checks passed
@amarziali amarziali deleted the andrea.marziali/spring branch September 8, 2025 11:21
@github-actions github-actions Bot added this to the 1.54.0 milestone Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Awaiting requested review from AlexeyKuznetsov-DD AlexeyKuznetsov-DD is a code owner automatically assigned from DataDog/apm-lang-platform-java

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer

Assignees

No one assigned

Labels

inst: spring Spring instrumentation tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.54.0

Development

Successfully merging this pull request may close these issues.

2 participants

@amarziali @manuel-alvarez-alvarez