Skip to content

Fixing oversight of missing synchronized on long version of recalibrate #9480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dougqh merged 4 commits into from
Sep 8, 2025
Merged

Fixing oversight of missing synchronized on long version of recalibrate #9480

dougqh merged 4 commits into from
Sep 8, 2025

Conversation

@dougqh
Copy link
Contributor

@dougqh dougqh commented Sep 5, 2025 •
edited
Loading

What Does This Do

Fixing oversight in #9434
Made recalibrate() synchronized but not recalibrate(long)

Motivation

Consistency - in this particular case, synchronized isn't strictly needed for correctness,
but does limit raciness with an operation that is doing a bulk update to the cache

@dougqh dougqh requested a review from a team as a code owner September 5, 2025 17:51
@dougqh dougqh requested a review from ygree September 5, 2025 17:51
@dougqh dougqh added type: enhancement Enhancements and improvements comp: core Tracer core tag: performance Performance related changes labels Sep 5, 2025
bric3
bric3 approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dooh missed this

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Sep 5, 2025 •
edited by datadog-official bot
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 59.39% (+1.61%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0522f88 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 5, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master dougqh/utf8-caching-patch
git_commit_date 1757096667 1757099612
git_commit_sha 7528bd7 0522f88
release_version 1.54.0-SNAPSHOT~7528bd70cc 1.54.0-SNAPSHOT~0522f88545
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757101418 1757101418
ci_job_id 1116483808 1116483808
ci_pipeline_id 75697568 75697568
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-x9mi57yw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-x9mi57yw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~0522f88545, baseline=1.54.0-SNAPSHOT~7528bd70cc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056420
Total [baseline] (8.67 s) : 0, 8670483
Agent [candidate] (1.05 s) : 0, 1049731
Total [candidate] (8.637 s) : 0, 8636875
section iast
Agent [baseline] (1.182 s) : 0, 1182212
Total [baseline] (9.317 s) : 0, 9317220
Agent [candidate] (1.191 s) : 0, 1190940
Total [candidate] (9.331 s) : 0, 9330907
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent iast 1.182 s 125.791 ms (11.9%)
Total tracing 8.67 s -
Total iast 9.317 s 646.738 ms (7.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent iast 1.191 s 141.209 ms (13.5%)
Total tracing 8.637 s -
Total iast 9.331 s 694.032 ms (8.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~0522f88545, baseline=1.54.0-SNAPSHOT~7528bd70cc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (739.19 ms) : 0, 739190
BytebuddyAgent [candidate] (734.484 ms) : 0, 734484
GlobalTracer [baseline] (244.146 ms) : 0, 244146
GlobalTracer [candidate] (242.612 ms) : 0, 242612
AppSec [baseline] (30.324 ms) : 0, 30324
AppSec [candidate] (30.286 ms) : 0, 30286
Debugger [baseline] (6.091 ms) : 0, 6091
Debugger [candidate] (6.101 ms) : 0, 6101
Remote Config [baseline] (699.133 µs) : 0, 699
Remote Config [candidate] (694.381 µs) : 0, 694
Telemetry [baseline] (13.262 ms) : 0, 13262
Telemetry [candidate] (12.939 ms) : 0, 12939
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (853.369 ms) : 0, 853369
BytebuddyAgent [candidate] (860.625 ms) : 0, 860625
GlobalTracer [baseline] (233.797 ms) : 0, 233797
GlobalTracer [candidate] (234.704 ms) : 0, 234704
IAST [baseline] (31.876 ms) : 0, 31876
IAST [candidate] (29.391 ms) : 0, 29391
AppSec [baseline] (25.148 ms) : 0, 25148
AppSec [candidate] (26.188 ms) : 0, 26188
Debugger [baseline] (6.756 ms) : 0, 6756
Debugger [candidate] (8.422 ms) : 0, 8422
Remote Config [baseline] (596.848 µs) : 0, 597
Remote Config [candidate] (600.714 µs) : 0, 601
Telemetry [baseline] (8.198 ms) : 0, 8198
Telemetry [candidate] (8.267 ms) : 0, 8267
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~0522f88545, baseline=1.54.0-SNAPSHOT~7528bd70cc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054949
Total [baseline] (10.823 s) : 0, 10823434
Agent [candidate] (1.048 s) : 0, 1048204
Total [candidate] (10.642 s) : 0, 10642160
section appsec
Agent [baseline] (1.232 s) : 0, 1231597
Total [baseline] (10.837 s) : 0, 10837158
Agent [candidate] (1.226 s) : 0, 1225766
Total [candidate] (10.775 s) : 0, 10775354
section iast
Agent [baseline] (1.181 s) : 0, 1181065
Total [baseline] (10.956 s) : 0, 10955819
Agent [candidate] (1.179 s) : 0, 1179193
Total [candidate] (10.926 s) : 0, 10925677
section profiling
Agent [baseline] (1.199 s) : 0, 1199223
Total [baseline] (10.936 s) : 0, 10936229
Agent [candidate] (1.2 s) : 0, 1200076
Total [candidate] (10.854 s) : 0, 10853560
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.232 s 176.648 ms (16.7%)
Agent iast 1.181 s 126.116 ms (12.0%)
Agent profiling 1.199 s 144.274 ms (13.7%)
Total tracing 10.823 s -
Total appsec 10.837 s 13.724 ms (0.1%)
Total iast 10.956 s 132.385 ms (1.2%)
Total profiling 10.936 s 112.794 ms (1.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.226 s 177.562 ms (16.9%)
Agent iast 1.179 s 130.989 ms (12.5%)
Agent profiling 1.2 s 151.872 ms (14.5%)
Total tracing 10.642 s -
Total appsec 10.775 s 133.194 ms (1.3%)
Total iast 10.926 s 283.517 ms (2.7%)
Total profiling 10.854 s 211.4 ms (2.0%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~0522f88545, baseline=1.54.0-SNAPSHOT~7528bd70cc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (737.65 ms) : 0, 737650
BytebuddyAgent [candidate] (733.306 ms) : 0, 733306
GlobalTracer [baseline] (244.148 ms) : 0, 244148
GlobalTracer [candidate] (242.567 ms) : 0, 242567
AppSec [baseline] (30.367 ms) : 0, 30367
AppSec [candidate] (30.157 ms) : 0, 30157
Debugger [baseline] (6.12 ms) : 0, 6120
Debugger [candidate] (6.057 ms) : 0, 6057
Remote Config [baseline] (690.681 µs) : 0, 691
Remote Config [candidate] (683.017 µs) : 0, 683
Telemetry [baseline] (13.124 ms) : 0, 13124
Telemetry [candidate] (12.846 ms) : 0, 12846
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (761.292 ms) : 0, 761292
BytebuddyAgent [candidate] (757.132 ms) : 0, 757132
GlobalTracer [baseline] (236.964 ms) : 0, 236964
GlobalTracer [candidate] (235.881 ms) : 0, 235881
AppSec [baseline] (169.569 ms) : 0, 169569
AppSec [candidate] (169.107 ms) : 0, 169107
Debugger [baseline] (8.141 ms) : 0, 8141
Debugger [candidate] (7.35 ms) : 0, 7350
Remote Config [baseline] (623.885 µs) : 0, 624
Remote Config [candidate] (626.049 µs) : 0, 626
Telemetry [baseline] (8.447 ms) : 0, 8447
Telemetry [candidate] (9.319 ms) : 0, 9319
IAST [baseline] (23.898 ms) : 0, 23898
IAST [candidate] (23.721 ms) : 0, 23721
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (852.375 ms) : 0, 852375
BytebuddyAgent [candidate] (850.917 ms) : 0, 850917
GlobalTracer [baseline] (233.474 ms) : 0, 233474
GlobalTracer [candidate] (233.063 ms) : 0, 233063
AppSec [baseline] (27.759 ms) : 0, 27759
AppSec [candidate] (24.574 ms) : 0, 24574
Debugger [baseline] (7.554 ms) : 0, 7554
Debugger [candidate] (8.46 ms) : 0, 8460
Remote Config [baseline] (593.92 µs) : 0, 594
Remote Config [candidate] (589.531 µs) : 0, 590
Telemetry [baseline] (8.232 ms) : 0, 8232
Telemetry [candidate] (8.212 ms) : 0, 8212
IAST [baseline] (28.417 ms) : 0, 28417
IAST [candidate] (30.882 ms) : 0, 30882
section profiling
ProfilingAgent [baseline] (107.773 ms) : 0, 107773
ProfilingAgent [candidate] (108.499 ms) : 0, 108499
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (763.052 ms) : 0, 763052
BytebuddyAgent [candidate] (762.507 ms) : 0, 762507
GlobalTracer [baseline] (222.455 ms) : 0, 222455
GlobalTracer [candidate] (222.899 ms) : 0, 222899
AppSec [baseline] (30.494 ms) : 0, 30494
AppSec [candidate] (30.685 ms) : 0, 30685
Debugger [baseline] (7.797 ms) : 0, 7797
Debugger [candidate] (6.301 ms) : 0, 6301
Remote Config [baseline] (706.519 µs) : 0, 707
Remote Config [candidate] (693.196 µs) : 0, 693
Telemetry [baseline] (14.787 ms) : 0, 14787
Telemetry [candidate] (16.464 ms) : 0, 16464
Profiling [baseline] (108.455 ms) : 0, 108455
Profiling [candidate] (109.177 ms) : 0, 109177
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master dougqh/utf8-caching-patch
git_commit_date 1757096667 1757099612
git_commit_sha 7528bd7 0522f88
release_version 1.54.0-SNAPSHOT~7528bd70cc 1.54.0-SNAPSHOT~0522f88545
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757101093 1757101093
ci_job_id 1116483810 1116483810
ci_pipeline_id 75697568 75697568
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-8u0xvofo 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-8u0xvofo 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load better
[-223.218µs; -101.618µs] or [-5.026%; -2.288%]		 unstable
[-72.459op/s; +151.209op/s] or [-7.008%; +14.624%]		 4.279ms 1073.344op/s 4.441ms 1033.969op/s
scenario:load:petclinic:code_origins:high_load better
[-2.229ms; -1.350ms] or [-4.715%; -2.856%]		 unstable
[-3.228op/s; +10.853op/s] or [-3.259%; +10.957%]		 45.487ms 102.862op/s 47.276ms 99.050op/s
scenario:load:petclinic:iast:high_load better
[-2.496ms; -1.639ms] or [-5.372%; -3.529%]		 unstable
[-2.612op/s; +11.762op/s] or [-2.592%; +11.669%]		 44.394ms 105.375op/s 46.461ms 100.800op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~0522f88545, baseline=1.54.0-SNAPSHOT~7528bd70cc
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.441 ms) : 4390, 4493
.   : milestone, 4441,
iast (9.345 ms) : 9187, 9503
.   : milestone, 9345,
iast_FULL (14.17 ms) : 13890, 14450
.   : milestone, 14170,
iast_GLOBAL (10.123 ms) : 9939, 10307
.   : milestone, 10123,
profiling (9.297 ms) : 9125, 9470
.   : milestone, 9297,
tracing (7.808 ms) : 7696, 7920
.   : milestone, 7808,
section candidate
no_agent (4.279 ms) : 4218, 4340
.   : milestone, 4279,
iast (9.286 ms) : 9133, 9438
.   : milestone, 9286,
iast_FULL (13.833 ms) : 13559, 14107
.   : milestone, 13833,
iast_GLOBAL (10.275 ms) : 10091, 10459
.   : milestone, 10275,
profiling (9.111 ms) : 8965, 9258
.   : milestone, 9111,
tracing (7.754 ms) : 7631, 7878
.   : milestone, 7754,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.441 ms [4.39 ms, 4.493 ms] -
iast 9.345 ms [9.187 ms, 9.503 ms] 4.904 ms (110.4%)
iast_FULL 14.17 ms [13.89 ms, 14.45 ms] 9.728 ms (219.0%)
iast_GLOBAL 10.123 ms [9.939 ms, 10.307 ms] 5.682 ms (127.9%)
profiling 9.297 ms [9.125 ms, 9.47 ms] 4.856 ms (109.3%)
tracing 7.808 ms [7.696 ms, 7.92 ms] 3.367 ms (75.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.279 ms [4.218 ms, 4.34 ms] -
iast 9.286 ms [9.133 ms, 9.438 ms] 5.007 ms (117.0%)
iast_FULL 13.833 ms [13.559 ms, 14.107 ms] 9.554 ms (223.3%)
iast_GLOBAL 10.275 ms [10.091 ms, 10.459 ms] 5.996 ms (140.1%)
profiling 9.111 ms [8.965 ms, 9.258 ms] 4.832 ms (112.9%)
tracing 7.754 ms [7.631 ms, 7.878 ms] 3.475 ms (81.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~0522f88545, baseline=1.54.0-SNAPSHOT~7528bd70cc
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.266 ms) : 35975, 36557
.   : milestone, 36266,
appsec (47.923 ms) : 47498, 48349
.   : milestone, 47923,
code_origins (47.276 ms) : 46848, 47705
.   : milestone, 47276,
iast (46.461 ms) : 46044, 46878
.   : milestone, 46461,
profiling (48.745 ms) : 48285, 49204
.   : milestone, 48745,
tracing (44.679 ms) : 44298, 45061
.   : milestone, 44679,
section candidate
no_agent (37.195 ms) : 36898, 37491
.   : milestone, 37195,
appsec (48.385 ms) : 47966, 48803
.   : milestone, 48385,
code_origins (45.487 ms) : 45100, 45874
.   : milestone, 45487,
iast (44.394 ms) : 44016, 44771
.   : milestone, 44394,
profiling (49.288 ms) : 48807, 49768
.   : milestone, 49288,
tracing (43.828 ms) : 43459, 44197
.   : milestone, 43828,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.266 ms [35.975 ms, 36.557 ms] -
appsec 47.923 ms [47.498 ms, 48.349 ms] 11.658 ms (32.1%)
code_origins 47.276 ms [46.848 ms, 47.705 ms] 11.011 ms (30.4%)
iast 46.461 ms [46.044 ms, 46.878 ms] 10.196 ms (28.1%)
profiling 48.745 ms [48.285 ms, 49.204 ms] 12.479 ms (34.4%)
tracing 44.679 ms [44.298 ms, 45.061 ms] 8.413 ms (23.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.195 ms [36.898 ms, 37.491 ms] -
appsec 48.385 ms [47.966 ms, 48.803 ms] 11.19 ms (30.1%)
code_origins 45.487 ms [45.1 ms, 45.874 ms] 8.292 ms (22.3%)
iast 44.394 ms [44.016 ms, 44.771 ms] 7.199 ms (19.4%)
profiling 49.288 ms [48.807 ms, 49.768 ms] 12.093 ms (32.5%)
tracing 43.828 ms [43.459 ms, 44.197 ms] 6.634 ms (17.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master dougqh/utf8-caching-patch
git_commit_date 1757096667 1757099612
git_commit_sha 7528bd7 0522f88
release_version 1.54.0-SNAPSHOT~7528bd70cc 1.54.0-SNAPSHOT~0522f88545
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1757101583 1757101583
ci_job_id 1116483812 1116483812
ci_pipeline_id 75697568 75697568
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-y9s06zi5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-y9s06zi5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~0522f88545, baseline=1.54.0-SNAPSHOT~7528bd70cc
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (3.658 ms) : 3442, 3874
.   : milestone, 3658,
iast (2.192 ms) : 2129, 2254
.   : milestone, 2192,
iast_GLOBAL (2.25 ms) : 2187, 2313
.   : milestone, 2250,
profiling (2.046 ms) : 1996, 2097
.   : milestone, 2046,
tracing (2.022 ms) : 1974, 2071
.   : milestone, 2022,
section candidate
no_agent (1.479 ms) : 1467, 1491
.   : milestone, 1479,
appsec (3.586 ms) : 3377, 3796
.   : milestone, 3586,
iast (2.199 ms) : 2137, 2262
.   : milestone, 2199,
iast_GLOBAL (2.244 ms) : 2181, 2308
.   : milestone, 2244,
profiling (2.056 ms) : 2004, 2108
.   : milestone, 2056,
tracing (2.012 ms) : 1963, 2061
.   : milestone, 2012,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 3.658 ms [3.442 ms, 3.874 ms] 2.185 ms (148.3%)
iast 2.192 ms [2.129 ms, 2.254 ms] 718.382 µs (48.8%)
iast_GLOBAL 2.25 ms [2.187 ms, 2.313 ms] 776.097 µs (52.7%)
profiling 2.046 ms [1.996 ms, 2.097 ms] 572.944 µs (38.9%)
tracing 2.022 ms [1.974 ms, 2.071 ms] 548.838 µs (37.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.467 ms, 1.491 ms] -
appsec 3.586 ms [3.377 ms, 3.796 ms] 2.107 ms (142.5%)
iast 2.199 ms [2.137 ms, 2.262 ms] 720.284 µs (48.7%)
iast_GLOBAL 2.244 ms [2.181 ms, 2.308 ms] 765.225 µs (51.7%)
profiling 2.056 ms [2.004 ms, 2.108 ms] 576.882 µs (39.0%)
tracing 2.012 ms [1.963 ms, 2.061 ms] 533.126 µs (36.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~0522f88545, baseline=1.54.0-SNAPSHOT~7528bd70cc
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.432 s) : 15432000, 15432000
.   : milestone, 15432000,
appsec (14.943 s) : 14943000, 14943000
.   : milestone, 14943000,
iast (18.295 s) : 18295000, 18295000
.   : milestone, 18295000,
iast_GLOBAL (17.776 s) : 17776000, 17776000
.   : milestone, 17776000,
profiling (15.985 s) : 15985000, 15985000
.   : milestone, 15985000,
tracing (14.976 s) : 14976000, 14976000
.   : milestone, 14976000,
section candidate
no_agent (15.517 s) : 15517000, 15517000
.   : milestone, 15517000,
appsec (14.901 s) : 14901000, 14901000
.   : milestone, 14901000,
iast (18.411 s) : 18411000, 18411000
.   : milestone, 18411000,
iast_GLOBAL (18.227 s) : 18227000, 18227000
.   : milestone, 18227000,
profiling (15.352 s) : 15352000, 15352000
.   : milestone, 15352000,
tracing (14.936 s) : 14936000, 14936000
.   : milestone, 14936000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.432 s [15.432 s, 15.432 s] -
appsec 14.943 s [14.943 s, 14.943 s] -489.0 ms (-3.2%)
iast 18.295 s [18.295 s, 18.295 s] 2.863 s (18.6%)
iast_GLOBAL 17.776 s [17.776 s, 17.776 s] 2.344 s (15.2%)
profiling 15.985 s [15.985 s, 15.985 s] 553.0 ms (3.6%)
tracing 14.976 s [14.976 s, 14.976 s] -456.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.517 s [15.517 s, 15.517 s] -
appsec 14.901 s [14.901 s, 14.901 s] -616.0 ms (-4.0%)
iast 18.411 s [18.411 s, 18.411 s] 2.894 s (18.7%)
iast_GLOBAL 18.227 s [18.227 s, 18.227 s] 2.71 s (17.5%)
profiling 15.352 s [15.352 s, 15.352 s] -165.0 ms (-1.1%)
tracing 14.936 s [14.936 s, 14.936 s] -581.0 ms (-3.7%)

@dougqh
Adding spotbugs suppression
f4fc788 
The racy updates of cache stat fields is deliberate -- and that's the cause of the inconsistent sync-ing
@dougqh
spotless
497e65f
@dougqh
Removing leftover SIZE variable
0522f88
@dougqh dougqh merged commit 03d997e into master Sep 8, 2025
503 checks passed
@dougqh dougqh deleted the dougqh/utf8-caching-patch branch September 8, 2025 13:42
@github-actions github-actions bot added this to the 1.54.0 milestone Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: core Tracer core tag: performance Performance related changes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.54.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dougqh @bric3