Skip to content

Updated CodeNarc and fixed failed rules.#9421

Merged
AlexeyKuznetsov-DD merged 5 commits intomasterfrom
alexeyk/codenarc-update
Aug 26, 2025
Merged

Updated CodeNarc and fixed failed rules.#9421
AlexeyKuznetsov-DD merged 5 commits intomasterfrom
alexeyk/codenarc-update

Conversation

@AlexeyKuznetsov-DD
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Aug 26, 2025 •
edited
Loading

What Does This Do

Updated CodeNarc to 3.6.0.
Fixed code that violates rules.

Motivation

Keep tooling up-to-date.

Additional Notes

Latest version of CodeNarc is a bit more strict, but not that much.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Aug 26, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added comp: testing Testing tag: no release notes Changes to exclude from release notes labels Aug 26, 2025
@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official Bot commented Aug 26, 2025 •
edited by datadog-datadog-prod-us1 Bot
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 57.58% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eedf11e | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 26, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/codenarc-update
git_commit_date 1756210508 1756225297
git_commit_sha fb836a1 eedf11e
release_version 1.53.0-SNAPSHOT~fb836a13ab 1.53.0-SNAPSHOT~eedf11e792
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1756227074 1756227074
ci_job_id 1099458232 1099458232
ci_pipeline_id 74760321 74760321
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-jmlkzl3n 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-jmlkzl3n 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~eedf11e792, baseline=1.53.0-SNAPSHOT~fb836a13ab

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055786
Total [baseline] (10.642 s) : 0, 10641553
Agent [candidate] (1.055 s) : 0, 1054580
Total [candidate] (10.688 s) : 0, 10687563
section appsec
Agent [baseline] (1.224 s) : 0, 1224496
Total [baseline] (10.715 s) : 0, 10714628
Agent [candidate] (1.229 s) : 0, 1229167
Total [candidate] (10.754 s) : 0, 10754482
section iast
Agent [baseline] (1.18 s) : 0, 1179630
Total [baseline] (10.856 s) : 0, 10856087
Agent [candidate] (1.179 s) : 0, 1178900
Total [candidate] (10.883 s) : 0, 10883101
section profiling
Agent [baseline] (1.194 s) : 0, 1194431
Total [baseline] (10.89 s) : 0, 10890347
Agent [candidate] (1.202 s) : 0, 1201833
Total [candidate] (10.822 s) : 0, 10821671
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.224 s 168.711 ms (16.0%)
Agent iast 1.18 s 123.844 ms (11.7%)
Agent profiling 1.194 s 138.646 ms (13.1%)
Total tracing 10.642 s -
Total appsec 10.715 s 73.074 ms (0.7%)
Total iast 10.856 s 214.533 ms (2.0%)
Total profiling 10.89 s 248.794 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.229 s 174.587 ms (16.6%)
Agent iast 1.179 s 124.32 ms (11.8%)
Agent profiling 1.202 s 147.254 ms (14.0%)
Total tracing 10.688 s -
Total appsec 10.754 s 66.92 ms (0.6%)
Total iast 10.883 s 195.538 ms (1.8%)
Total profiling 10.822 s 134.108 ms (1.3%) 
gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~eedf11e792, baseline=1.53.0-SNAPSHOT~fb836a13ab

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (738.457 ms) : 0, 738457
BytebuddyAgent [candidate] (737.809 ms) : 0, 737809
GlobalTracer [baseline] (244.385 ms) : 0, 244385
GlobalTracer [candidate] (244.319 ms) : 0, 244319
AppSec [baseline] (30.478 ms) : 0, 30478
AppSec [candidate] (30.6 ms) : 0, 30600
Debugger [baseline] (6.086 ms) : 0, 6086
Debugger [candidate] (6.139 ms) : 0, 6139
Remote Config [baseline] (676.667 µs) : 0, 677
Remote Config [candidate] (677.284 µs) : 0, 677
Telemetry [baseline] (13.083 ms) : 0, 13083
Telemetry [candidate] (12.367 ms) : 0, 12367
section appsec
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (756.266 ms) : 0, 756266
BytebuddyAgent [candidate] (759.598 ms) : 0, 759598
GlobalTracer [baseline] (235.567 ms) : 0, 235567
GlobalTracer [candidate] (236.511 ms) : 0, 236511
IAST [baseline] (23.549 ms) : 0, 23549
IAST [candidate] (23.845 ms) : 0, 23845
AppSec [baseline] (170.058 ms) : 0, 170058
AppSec [candidate] (170.944 ms) : 0, 170944
Debugger [baseline] (6.587 ms) : 0, 6587
Debugger [candidate] (6.491 ms) : 0, 6491
Remote Config [baseline] (650.815 µs) : 0, 651
Remote Config [candidate] (628.375 µs) : 0, 628
Telemetry [baseline] (9.245 ms) : 0, 9245
Telemetry [candidate] (8.535 ms) : 0, 8535
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (851.415 ms) : 0, 851415
BytebuddyAgent [candidate] (850.299 ms) : 0, 850299
GlobalTracer [baseline] (232.898 ms) : 0, 232898
GlobalTracer [candidate] (233.363 ms) : 0, 233363
IAST [baseline] (32.978 ms) : 0, 32978
IAST [candidate] (30.296 ms) : 0, 30296
AppSec [baseline] (25.155 ms) : 0, 25155
AppSec [candidate] (27.765 ms) : 0, 27765
Debugger [baseline] (5.785 ms) : 0, 5785
Debugger [candidate] (5.77 ms) : 0, 5770
Remote Config [baseline] (605.46 µs) : 0, 605
Remote Config [candidate] (617.551 µs) : 0, 618
Telemetry [baseline] (8.245 ms) : 0, 8245
Telemetry [candidate] (8.326 ms) : 0, 8326
section profiling
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (761.01 ms) : 0, 761010
BytebuddyAgent [candidate] (765.452 ms) : 0, 765452
GlobalTracer [baseline] (221.593 ms) : 0, 221593
GlobalTracer [candidate] (223.504 ms) : 0, 223504
AppSec [baseline] (30.037 ms) : 0, 30037
AppSec [candidate] (30.186 ms) : 0, 30186
Debugger [baseline] (6.193 ms) : 0, 6193
Debugger [candidate] (6.299 ms) : 0, 6299
Remote Config [baseline] (714.179 µs) : 0, 714
Remote Config [candidate] (705.83 µs) : 0, 706
Telemetry [baseline] (16.502 ms) : 0, 16502
Telemetry [candidate] (16.529 ms) : 0, 16529
ProfilingAgent [baseline] (107.422 ms) : 0, 107422
ProfilingAgent [candidate] (107.899 ms) : 0, 107899
Profiling [baseline] (108.04 ms) : 0, 108040
Profiling [candidate] (108.532 ms) : 0, 108532
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~eedf11e792, baseline=1.53.0-SNAPSHOT~fb836a13ab

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046320
Total [baseline] (8.577 s) : 0, 8577076
Agent [candidate] (1.056 s) : 0, 1055697
Total [candidate] (8.595 s) : 0, 8594913
section iast
Agent [baseline] (1.178 s) : 0, 1177688
Total [baseline] (9.294 s) : 0, 9294050
Agent [candidate] (1.178 s) : 0, 1177506
Total [candidate] (9.318 s) : 0, 9318265
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.178 s 131.368 ms (12.6%)
Total tracing 8.577 s -
Total iast 9.294 s 716.974 ms (8.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent iast 1.178 s 121.809 ms (11.5%)
Total tracing 8.595 s -
Total iast 9.318 s 723.352 ms (8.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~eedf11e792, baseline=1.53.0-SNAPSHOT~fb836a13ab

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (733.072 ms) : 0, 733072
BytebuddyAgent [candidate] (739.136 ms) : 0, 739136
GlobalTracer [baseline] (242.516 ms) : 0, 242516
GlobalTracer [candidate] (244.463 ms) : 0, 244463
AppSec [baseline] (30.108 ms) : 0, 30108
AppSec [candidate] (30.501 ms) : 0, 30501
Debugger [baseline] (6.085 ms) : 0, 6085
Debugger [candidate] (6.127 ms) : 0, 6127
Remote Config [baseline] (669.654 µs) : 0, 670
Remote Config [candidate] (679.561 µs) : 0, 680
Telemetry [baseline] (11.513 ms) : 0, 11513
Telemetry [candidate] (12.225 ms) : 0, 12225
section iast
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (849.809 ms) : 0, 849809
BytebuddyAgent [candidate] (849.401 ms) : 0, 849401
GlobalTracer [baseline] (232.804 ms) : 0, 232804
GlobalTracer [candidate] (232.956 ms) : 0, 232956
IAST [baseline] (30.348 ms) : 0, 30348
IAST [candidate] (31.275 ms) : 0, 31275
AppSec [baseline] (27.656 ms) : 0, 27656
AppSec [candidate] (26.125 ms) : 0, 26125
Debugger [baseline] (5.739 ms) : 0, 5739
Debugger [candidate] (6.52 ms) : 0, 6520
Remote Config [baseline] (601.973 µs) : 0, 602
Remote Config [candidate] (595.123 µs) : 0, 595
Telemetry [baseline] (8.247 ms) : 0, 8247
Telemetry [candidate] (8.267 ms) : 0, 8267
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/codenarc-update
git_commit_date 1756210508 1756225297
git_commit_sha fb836a1 eedf11e
release_version 1.53.0-SNAPSHOT~fb836a13ab 1.53.0-SNAPSHOT~eedf11e792
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1756226828 1756226828
ci_job_id 1099458235 1099458235
ci_pipeline_id 74760321 74760321
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-ng959c4m 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-ng959c4m 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:tracing:high_load better
[-552.986µs; -324.236µs] or [-7.067%; -4.143%]		 unstable
[-37.540op/s; +106.540op/s] or [-6.340%; +17.993%]		 7.387ms 626.625op/s 7.825ms 592.125op/s
scenario:load:insecure-bank:no_agent:high_load worse
[+95.031µs; +200.457µs] or [+2.211%; +4.665%]		 unstable
[-143.197op/s; +73.822op/s] or [-13.410%; +6.913%]		 4.445ms 1033.125op/s 4.297ms 1067.812op/s
scenario:load:petclinic:iast:high_load better
[-1.849ms; -0.997ms] or [-4.023%; -2.168%]		 unstable
[-5.297op/s; +9.145op/s] or [-5.138%; +8.871%]		 44.541ms 105.013op/s 45.964ms 103.089op/s
scenario:load:petclinic:profiling:high_load better
[-4.550ms; -3.607ms] or [-9.090%; -7.205%]		 unstable
[+0.916op/s; +15.484op/s] or [+0.979%; +16.547%]		 45.981ms 101.775op/s 50.060ms 93.575op/s
scenario:load:petclinic:appsec:high_load better
[-2.751ms; -1.833ms] or [-5.528%; -3.684%]		 unstable
[-2.540op/s; +11.615op/s] or [-2.700%; +12.348%]		 47.470ms 98.600op/s 49.762ms 94.062op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~eedf11e792, baseline=1.53.0-SNAPSHOT~fb836a13ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.297 ms) : 4250, 4345
.   : milestone, 4297,
iast (9.178 ms) : 9027, 9330
.   : milestone, 9178,
iast_FULL (14.472 ms) : 14184, 14760
.   : milestone, 14472,
iast_GLOBAL (10.247 ms) : 10065, 10430
.   : milestone, 10247,
profiling (8.864 ms) : 8725, 9003
.   : milestone, 8864,
tracing (7.825 ms) : 7714, 7936
.   : milestone, 7825,
section candidate
no_agent (4.445 ms) : 4395, 4495
.   : milestone, 4445,
iast (9.217 ms) : 9067, 9366
.   : milestone, 9217,
iast_FULL (14.531 ms) : 14240, 14822
.   : milestone, 14531,
iast_GLOBAL (9.952 ms) : 9769, 10136
.   : milestone, 9952,
profiling (8.878 ms) : 8736, 9020
.   : milestone, 8878,
tracing (7.387 ms) : 7285, 7488
.   : milestone, 7387,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.297 ms [4.25 ms, 4.345 ms] -
iast 9.178 ms [9.027 ms, 9.33 ms] 4.881 ms (113.6%)
iast_FULL 14.472 ms [14.184 ms, 14.76 ms] 10.175 ms (236.8%)
iast_GLOBAL 10.247 ms [10.065 ms, 10.43 ms] 5.95 ms (138.5%)
profiling 8.864 ms [8.725 ms, 9.003 ms] 4.567 ms (106.3%)
tracing 7.825 ms [7.714 ms, 7.936 ms] 3.528 ms (82.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.445 ms [4.395 ms, 4.495 ms] -
iast 9.217 ms [9.067 ms, 9.366 ms] 4.772 ms (107.3%)
iast_FULL 14.531 ms [14.24 ms, 14.822 ms] 10.086 ms (226.9%)
iast_GLOBAL 9.952 ms [9.769 ms, 10.136 ms] 5.507 ms (123.9%)
profiling 8.878 ms [8.736 ms, 9.02 ms] 4.433 ms (99.7%)
tracing 7.387 ms [7.285 ms, 7.488 ms] 2.942 ms (66.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~eedf11e792, baseline=1.53.0-SNAPSHOT~fb836a13ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.873 ms) : 36575, 37171
.   : milestone, 36873,
appsec (49.762 ms) : 49328, 50196
.   : milestone, 49762,
code_origins (44.806 ms) : 44414, 45197
.   : milestone, 44806,
iast (45.964 ms) : 45563, 46365
.   : milestone, 45964,
profiling (50.06 ms) : 49580, 50540
.   : milestone, 50060,
tracing (43.723 ms) : 43360, 44085
.   : milestone, 43723,
section candidate
no_agent (36.533 ms) : 36238, 36828
.   : milestone, 36533,
appsec (47.47 ms) : 47052, 47889
.   : milestone, 47470,
code_origins (44.967 ms) : 44577, 45356
.   : milestone, 44967,
iast (44.541 ms) : 44150, 44932
.   : milestone, 44541,
profiling (45.981 ms) : 45589, 46374
.   : milestone, 45981,
tracing (43.519 ms) : 43154, 43884
.   : milestone, 43519,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.873 ms [36.575 ms, 37.171 ms] -
appsec 49.762 ms [49.328 ms, 50.196 ms] 12.889 ms (35.0%)
code_origins 44.806 ms [44.414 ms, 45.197 ms] 7.933 ms (21.5%)
iast 45.964 ms [45.563 ms, 46.365 ms] 9.091 ms (24.7%)
profiling 50.06 ms [49.58 ms, 50.54 ms] 13.187 ms (35.8%)
tracing 43.723 ms [43.36 ms, 44.085 ms] 6.85 ms (18.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.533 ms [36.238 ms, 36.828 ms] -
appsec 47.47 ms [47.052 ms, 47.889 ms] 10.937 ms (29.9%)
code_origins 44.967 ms [44.577 ms, 45.356 ms] 8.434 ms (23.1%)
iast 44.541 ms [44.15 ms, 44.932 ms] 8.008 ms (21.9%)
profiling 45.981 ms [45.589 ms, 46.374 ms] 9.448 ms (25.9%)
tracing 43.519 ms [43.154 ms, 43.884 ms] 6.986 ms (19.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/codenarc-update
git_commit_date 1756210508 1756225297
git_commit_sha fb836a1 eedf11e
release_version 1.53.0-SNAPSHOT~fb836a13ab 1.53.0-SNAPSHOT~eedf11e792
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1756227246 1756227246
ci_job_id 1099458237 1099458237
ci_pipeline_id 74760321 74760321
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-zqx0oihc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-zqx0oihc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~eedf11e792, baseline=1.53.0-SNAPSHOT~fb836a13ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.096 s) : 15096000, 15096000
.   : milestone, 15096000,
appsec (14.834 s) : 14834000, 14834000
.   : milestone, 14834000,
iast (18.393 s) : 18393000, 18393000
.   : milestone, 18393000,
iast_GLOBAL (17.975 s) : 17975000, 17975000
.   : milestone, 17975000,
profiling (16.034 s) : 16034000, 16034000
.   : milestone, 16034000,
tracing (14.793 s) : 14793000, 14793000
.   : milestone, 14793000,
section candidate
no_agent (15.463 s) : 15463000, 15463000
.   : milestone, 15463000,
appsec (14.918 s) : 14918000, 14918000
.   : milestone, 14918000,
iast (18.151 s) : 18151000, 18151000
.   : milestone, 18151000,
iast_GLOBAL (17.874 s) : 17874000, 17874000
.   : milestone, 17874000,
profiling (15.014 s) : 15014000, 15014000
.   : milestone, 15014000,
tracing (14.994 s) : 14994000, 14994000
.   : milestone, 14994000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.096 s [15.096 s, 15.096 s] -
appsec 14.834 s [14.834 s, 14.834 s] -262.0 ms (-1.7%)
iast 18.393 s [18.393 s, 18.393 s] 3.297 s (21.8%)
iast_GLOBAL 17.975 s [17.975 s, 17.975 s] 2.879 s (19.1%)
profiling 16.034 s [16.034 s, 16.034 s] 938.0 ms (6.2%)
tracing 14.793 s [14.793 s, 14.793 s] -303.0 ms (-2.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.463 s [15.463 s, 15.463 s] -
appsec 14.918 s [14.918 s, 14.918 s] -545.0 ms (-3.5%)
iast 18.151 s [18.151 s, 18.151 s] 2.688 s (17.4%)
iast_GLOBAL 17.874 s [17.874 s, 17.874 s] 2.411 s (15.6%)
profiling 15.014 s [15.014 s, 15.014 s] -449.0 ms (-2.9%)
tracing 14.994 s [14.994 s, 14.994 s] -469.0 ms (-3.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~eedf11e792, baseline=1.53.0-SNAPSHOT~fb836a13ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
.   : milestone, 1482,
appsec (3.641 ms) : 3426, 3856
.   : milestone, 3641,
iast (2.217 ms) : 2154, 2281
.   : milestone, 2217,
iast_GLOBAL (2.253 ms) : 2189, 2316
.   : milestone, 2253,
profiling (2.486 ms) : 2269, 2702
.   : milestone, 2486,
tracing (2.035 ms) : 1986, 2085
.   : milestone, 2035,
section candidate
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (3.677 ms) : 3454, 3899
.   : milestone, 3677,
iast (2.222 ms) : 2159, 2286
.   : milestone, 2222,
iast_GLOBAL (2.258 ms) : 2195, 2322
.   : milestone, 2258,
profiling (2.081 ms) : 2028, 2133
.   : milestone, 2081,
tracing (2.027 ms) : 1978, 2076
.   : milestone, 2027,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.47 ms, 1.493 ms] -
appsec 3.641 ms [3.426 ms, 3.856 ms] 2.159 ms (145.7%)
iast 2.217 ms [2.154 ms, 2.281 ms] 735.278 µs (49.6%)
iast_GLOBAL 2.253 ms [2.189 ms, 2.316 ms] 770.789 µs (52.0%)
profiling 2.486 ms [2.269 ms, 2.702 ms] 1.004 ms (67.7%)
tracing 2.035 ms [1.986 ms, 2.085 ms] 553.441 µs (37.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 3.677 ms [3.454 ms, 3.899 ms] 2.198 ms (148.6%)
iast 2.222 ms [2.159 ms, 2.286 ms] 743.068 µs (50.2%)
iast_GLOBAL 2.258 ms [2.195 ms, 2.322 ms] 779.371 µs (52.7%)
profiling 2.081 ms [2.028 ms, 2.133 ms] 601.561 µs (40.7%)
tracing 2.027 ms [1.978 ms, 2.076 ms] 547.773 µs (37.0%)

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 26, 2025 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/codenarc-update
git_commit_date 1756135553 1756225297
git_commit_sha 13674fd eedf11e
See matching parameters
Baseline Candidate
ci_job_date 1756226409 1756226409
ci_job_id 1099458246 1099458246
ci_pipeline_id 74760321 74760321
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 26, 2025

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/codenarc-update
git_commit_date 1756135553 1756174056
git_commit_sha 13674fd 409c915
See matching parameters
Baseline Candidate
ci_job_date 1756175779 1756175779
ci_job_id 1097978512 1097978512
ci_pipeline_id 74695976 74695976
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review August 26, 2025 15:16
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners August 26, 2025 15:16
smola
smola approved these changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@smola smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some rules are a bit annoying, but looks good.

Comment thread ...-tests/iast-util/src/testFixtures/groovy/datadog/smoketest/AbstractIastSpringBootTest.groovy
Comment thread dd-java-agent/appsec/src/test/groovy/com/datadog/appsec/ddwaf/WAFModuleSpecification.groovy Outdated
Comment thread .../servicetalk/servicetalk-0.42.56/src/test/groovy/ContextPreservingInstrumentationTest.groovy Outdated
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD merged commit 646403a into master Aug 26, 2025
673 of 674 checks passed
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD deleted the alexeyk/codenarc-update branch August 26, 2025 18:14
@github-actions github-actions Bot added this to the 1.53.0 milestone Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes

@sarahchen6 sarahchen6 sarahchen6 approved these changes

@nikita-tkachenko-datadog nikita-tkachenko-datadog nikita-tkachenko-datadog approved these changes

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

@daniel-mohedano daniel-mohedano Awaiting requested review from daniel-mohedano

@bric3 bric3 Awaiting requested review from bric3

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer

Assignees

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexeyKuznetsov-DD @smola @sarahchen6 @nikita-tkachenko-datadog