Update Spock to 2.4-M6. by AlexeyKuznetsov-DD · Pull Request #9326 · DataDog/dd-trace-java

AlexeyKuznetsov-DD · 2025-08-06T18:52:23Z

What Does This Do

Update module java-concurrent-21 to use Spock 2.4 to mitigate issue with hanging test on GitLab.
Spock 2.4 contains fix for possible deadlock, when blocking in mock response generators.
See: Spock release notes

Motivation

Green CI

Additional Notes

This change addresses test hangs observed in this module, which appear to be similar to issues seen in several other modules. If this fix proves effective in resolving the freezing behavior on GitLab, we will apply similar updates to the remaining affected modules.

NOTE, that we are not upgrading the entire project to Spock 2.4 at this time. Initial attempts to do so resulted in widespread test failures without clear root causes. A full upgrade will require further investigation and will be handled separately.

datadog-datadog-prod-us1 · 2025-08-06T19:14:16Z

Code coverage: total 57.30%, patch 100.00% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: d748a1c | Docs | Was this helpful? Give us feedback!}

datadog-official · 2025-08-06T19:14:20Z

Code coverage: total 24.95%, patch 100.00% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 7316968 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-06T19:51:34Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/update-spock
git_commit_date	1754914402	1754922484
git_commit_sha	`893780c`	`d748a1c`
release_version	1.53.0-SNAPSHOT~893780c76b	1.53.0-SNAPSHOT~d748a1c4b9

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1754924425	1754924425
ci_job_id	1073951378	1073951378
ci_pipeline_id	73286593	73286593
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-4-k9rkru3w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-4-k9rkru3w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~d748a1c4b9, baseline=1.53.0-SNAPSHOT~893780c76b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050593
Total [baseline] (10.698 s) : 0, 10698375
Agent [candidate] (1.046 s) : 0, 1045938
Total [candidate] (10.691 s) : 0, 10690628
section appsec
Agent [baseline] (1.227 s) : 0, 1226947
Total [baseline] (10.766 s) : 0, 10766128
Agent [candidate] (1.228 s) : 0, 1228256
Total [candidate] (10.777 s) : 0, 10776691
section iast
Agent [baseline] (1.192 s) : 0, 1192365
Total [baseline] (10.982 s) : 0, 10981659
Agent [candidate] (1.185 s) : 0, 1185156
Total [candidate] (11.02 s) : 0, 11019562
section profiling
Agent [baseline] (1.19 s) : 0, 1190418
Total [baseline] (10.861 s) : 0, 10861045
Agent [candidate] (1.192 s) : 0, 1192066
Total [candidate] (10.801 s) : 0, 10801392

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	appsec	1.227 s	176.354 ms (16.8%)
Agent	iast	1.192 s	141.772 ms (13.5%)
Agent	profiling	1.19 s	139.825 ms (13.3%)
Total	tracing	10.698 s	-
Total	appsec	10.766 s	67.752 ms (0.6%)
Total	iast	10.982 s	283.283 ms (2.6%)
Total	profiling	10.861 s	162.67 ms (1.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.228 s	182.317 ms (17.4%)
Agent	iast	1.185 s	139.218 ms (13.3%)
Agent	profiling	1.192 s	146.128 ms (14.0%)
Total	tracing	10.691 s	-
Total	appsec	10.777 s	86.063 ms (0.8%)
Total	iast	11.02 s	328.935 ms (3.1%)
Total	profiling	10.801 s	110.765 ms (1.0%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~d748a1c4b9, baseline=1.53.0-SNAPSHOT~893780c76b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (735.908 ms) : 0, 735908
BytebuddyAgent [candidate] (732.066 ms) : 0, 732066
GlobalTracer [baseline] (243.003 ms) : 0, 243003
GlobalTracer [candidate] (241.59 ms) : 0, 241590
AppSec [baseline] (30.277 ms) : 0, 30277
AppSec [candidate] (29.932 ms) : 0, 29932
Debugger [baseline] (6.043 ms) : 0, 6043
Debugger [candidate] (5.965 ms) : 0, 5965
Remote Config [baseline] (662.7 µs) : 0, 663
Remote Config [candidate] (648.515 µs) : 0, 649
Telemetry [baseline] (12.204 ms) : 0, 12204
Telemetry [candidate] (13.35 ms) : 0, 13350
section appsec
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (758.835 ms) : 0, 758835
BytebuddyAgent [candidate] (759.441 ms) : 0, 759441
GlobalTracer [baseline] (235.73 ms) : 0, 235730
GlobalTracer [candidate] (236.288 ms) : 0, 236288
AppSec [baseline] (169.173 ms) : 0, 169173
AppSec [candidate] (169.869 ms) : 0, 169869
Debugger [baseline] (7.917 ms) : 0, 7917
Debugger [candidate] (6.558 ms) : 0, 6558
Remote Config [baseline] (611.502 µs) : 0, 612
Remote Config [candidate] (622.078 µs) : 0, 622
Telemetry [baseline] (8.356 ms) : 0, 8356
Telemetry [candidate] (9.185 ms) : 0, 9185
IAST [baseline] (23.781 ms) : 0, 23781
IAST [candidate] (23.751 ms) : 0, 23751
section iast
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (862.049 ms) : 0, 862049
BytebuddyAgent [candidate] (856.159 ms) : 0, 856159
GlobalTracer [baseline] (234.767 ms) : 0, 234767
GlobalTracer [candidate] (233.355 ms) : 0, 233355
AppSec [baseline] (29.285 ms) : 0, 29285
AppSec [candidate] (26.973 ms) : 0, 26973
Debugger [baseline] (6.567 ms) : 0, 6567
Debugger [candidate] (6.611 ms) : 0, 6611
Remote Config [baseline] (601.176 µs) : 0, 601
Remote Config [candidate] (587.266 µs) : 0, 587
Telemetry [baseline] (8.395 ms) : 0, 8395
Telemetry [candidate] (8.402 ms) : 0, 8402
IAST [baseline] (27.927 ms) : 0, 27927
IAST [candidate] (30.524 ms) : 0, 30524
section profiling
crashtracking [baseline] (1.401 ms) : 0, 1401
crashtracking [candidate] (1.392 ms) : 0, 1392
BytebuddyAgent [baseline] (758.334 ms) : 0, 758334
BytebuddyAgent [candidate] (759.944 ms) : 0, 759944
GlobalTracer [baseline] (221.368 ms) : 0, 221368
GlobalTracer [candidate] (221.068 ms) : 0, 221068
AppSec [baseline] (29.782 ms) : 0, 29782
AppSec [candidate] (29.815 ms) : 0, 29815
Debugger [baseline] (6.214 ms) : 0, 6214
Debugger [candidate] (6.288 ms) : 0, 6288
Remote Config [baseline] (682.571 µs) : 0, 683
Remote Config [candidate] (693.567 µs) : 0, 694
Telemetry [baseline] (15.893 ms) : 0, 15893
Telemetry [candidate] (15.797 ms) : 0, 15797
ProfilingAgent [baseline] (107.317 ms) : 0, 107317
ProfilingAgent [candidate] (107.687 ms) : 0, 107687
Profiling [baseline] (107.956 ms) : 0, 107956
Profiling [candidate] (108.312 ms) : 0, 108312

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~d748a1c4b9, baseline=1.53.0-SNAPSHOT~893780c76b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054701
Total [baseline] (8.578 s) : 0, 8577856
Agent [candidate] (1.048 s) : 0, 1047678
Total [candidate] (8.574 s) : 0, 8573997
section iast
Agent [baseline] (1.179 s) : 0, 1179051
Total [baseline] (9.345 s) : 0, 9345159
Agent [candidate] (1.177 s) : 0, 1177426
Total [candidate] (9.292 s) : 0, 9292185

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	iast	1.179 s	124.35 ms (11.8%)
Total	tracing	8.578 s	-
Total	iast	9.345 s	767.303 ms (8.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.177 s	129.748 ms (12.4%)
Total	tracing	8.574 s	-
Total	iast	9.292 s	718.189 ms (8.4%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~d748a1c4b9, baseline=1.53.0-SNAPSHOT~893780c76b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.419 ms) : 0, 1419
BytebuddyAgent [baseline] (737.004 ms) : 0, 737004
BytebuddyAgent [candidate] (732.853 ms) : 0, 732853
GlobalTracer [baseline] (243.693 ms) : 0, 243693
GlobalTracer [candidate] (241.717 ms) : 0, 241717
AppSec [baseline] (30.489 ms) : 0, 30489
AppSec [candidate] (30.019 ms) : 0, 30019
Debugger [baseline] (6.099 ms) : 0, 6099
Debugger [candidate] (6.011 ms) : 0, 6011
Remote Config [baseline] (661.144 µs) : 0, 661
Remote Config [candidate] (649.585 µs) : 0, 650
Telemetry [baseline] (14.309 ms) : 0, 14309
Telemetry [candidate] (14.074 ms) : 0, 14074
section iast
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (851.52 ms) : 0, 851520
BytebuddyAgent [candidate] (850.132 ms) : 0, 850132
GlobalTracer [baseline] (233.854 ms) : 0, 233854
GlobalTracer [candidate] (232.825 ms) : 0, 232825
AppSec [baseline] (28.21 ms) : 0, 28210
AppSec [candidate] (28.044 ms) : 0, 28044
Debugger [baseline] (6.633 ms) : 0, 6633
Debugger [candidate] (5.794 ms) : 0, 5794
Remote Config [baseline] (568.505 µs) : 0, 569
Remote Config [candidate] (580.379 µs) : 0, 580
Telemetry [baseline] (8.244 ms) : 0, 8244
Telemetry [candidate] (8.358 ms) : 0, 8358
IAST [baseline] (27.578 ms) : 0, 27578
IAST [candidate] (29.268 ms) : 0, 29268

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/update-spock
git_commit_date	1754914402	1754922484
git_commit_sha	`893780c`	`d748a1c`
release_version	1.53.0-SNAPSHOT~893780c76b	1.53.0-SNAPSHOT~d748a1c4b9

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1754924024	1754924024
ci_job_id	1073951379	1073951379
ci_pipeline_id	73286593	73286593
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-h0uhng8l 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-h0uhng8l 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	worse [+262.363µs; +491.312µs] or [+3.620%; +6.778%]	unstable [-111.043op/s; +48.605op/s] or [-17.390%; +7.612%]	7.625ms	607.312op/s	7.248ms	638.531op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+638.315µs; +1038.942µs] or [+6.492%; +10.566%]	unstable [-90.491op/s; +17.178op/s] or [-19.159%; +3.637%]	10.671ms	435.656op/s	9.833ms	472.312op/s
scenario:load:petclinic:appsec:high_load	worse [+1.949ms; +2.854ms] or [+4.211%; +6.169%]	unstable [-13.056op/s; +0.745op/s] or [-12.746%; +0.727%]	48.670ms	96.275op/s	46.268ms	102.430op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d748a1c4b9, baseline=1.53.0-SNAPSHOT~893780c76b
    dateFormat X
    axisFormat %s
section baseline
no_agent (35.935 ms) : 35653, 36217
.   : milestone, 35935,
appsec (46.268 ms) : 45858, 46679
.   : milestone, 46268,
code_origins (45.688 ms) : 45275, 46101
.   : milestone, 45688,
iast (45.649 ms) : 45244, 46054
.   : milestone, 45649,
profiling (48.932 ms) : 48506, 49357
.   : milestone, 48932,
tracing (45.475 ms) : 45086, 45864
.   : milestone, 45475,
section candidate
no_agent (36.829 ms) : 36533, 37126
.   : milestone, 36829,
appsec (48.67 ms) : 48239, 49100
.   : milestone, 48670,
code_origins (44.91 ms) : 44510, 45309
.   : milestone, 44910,
iast (45.197 ms) : 44803, 45591
.   : milestone, 45197,
profiling (50.28 ms) : 49798, 50763
.   : milestone, 50280,
tracing (44.502 ms) : 44132, 44871
.   : milestone, 44502,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.935 ms [35.653 ms, 36.217 ms]	-
appsec	46.268 ms [45.858 ms, 46.679 ms]	10.334 ms (28.8%)
code_origins	45.688 ms [45.275 ms, 46.101 ms]	9.753 ms (27.1%)
iast	45.649 ms [45.244 ms, 46.054 ms]	9.714 ms (27.0%)
profiling	48.932 ms [48.506 ms, 49.357 ms]	12.997 ms (36.2%)
tracing	45.475 ms [45.086 ms, 45.864 ms]	9.54 ms (26.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.829 ms [36.533 ms, 37.126 ms]	-
appsec	48.67 ms [48.239 ms, 49.1 ms]	11.841 ms (32.1%)
code_origins	44.91 ms [44.51 ms, 45.309 ms]	8.081 ms (21.9%)
iast	45.197 ms [44.803 ms, 45.591 ms]	8.368 ms (22.7%)
profiling	50.28 ms [49.798 ms, 50.763 ms]	13.451 ms (36.5%)
tracing	44.502 ms [44.132 ms, 44.871 ms]	7.673 ms (20.8%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d748a1c4b9, baseline=1.53.0-SNAPSHOT~893780c76b
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.309 ms) : 4260, 4358
.   : milestone, 4309,
iast (9.503 ms) : 9349, 9656
.   : milestone, 9503,
iast_FULL (13.911 ms) : 13635, 14188
.   : milestone, 13911,
iast_GLOBAL (9.833 ms) : 9651, 10015
.   : milestone, 9833,
profiling (8.872 ms) : 8728, 9017
.   : milestone, 8872,
tracing (7.248 ms) : 7148, 7349
.   : milestone, 7248,
section candidate
no_agent (4.317 ms) : 4262, 4373
.   : milestone, 4317,
iast (9.438 ms) : 9270, 9605
.   : milestone, 9438,
iast_FULL (13.65 ms) : 13378, 13922
.   : milestone, 13650,
iast_GLOBAL (10.671 ms) : 10481, 10862
.   : milestone, 10671,
profiling (8.9 ms) : 8750, 9049
.   : milestone, 8900,
tracing (7.625 ms) : 7513, 7737
.   : milestone, 7625,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.309 ms [4.26 ms, 4.358 ms]	-
iast	9.503 ms [9.349 ms, 9.656 ms]	5.194 ms (120.5%)
iast_FULL	13.911 ms [13.635 ms, 14.188 ms]	9.602 ms (222.8%)
iast_GLOBAL	9.833 ms [9.651 ms, 10.015 ms]	5.524 ms (128.2%)
profiling	8.872 ms [8.728 ms, 9.017 ms]	4.563 ms (105.9%)
tracing	7.248 ms [7.148 ms, 7.349 ms]	2.939 ms (68.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.317 ms [4.262 ms, 4.373 ms]	-
iast	9.438 ms [9.27 ms, 9.605 ms]	5.12 ms (118.6%)
iast_FULL	13.65 ms [13.378 ms, 13.922 ms]	9.332 ms (216.2%)
iast_GLOBAL	10.671 ms [10.481 ms, 10.862 ms]	6.354 ms (147.2%)
profiling	8.9 ms [8.75 ms, 9.049 ms]	4.582 ms (106.1%)
tracing	7.625 ms [7.513 ms, 7.737 ms]	3.308 ms (76.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/update-spock
git_commit_date	1754914402	1754922484
git_commit_sha	`893780c`	`d748a1c`
release_version	1.53.0-SNAPSHOT~893780c76b	1.53.0-SNAPSHOT~d748a1c4b9

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1754924585	1754924585
ci_job_id	1073951380	1073951380
ci_pipeline_id	73286593	73286593
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-5-x5aj2haq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-5-x5aj2haq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d748a1c4b9, baseline=1.53.0-SNAPSHOT~893780c76b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
.   : milestone, 1479,
appsec (3.641 ms) : 3425, 3858
.   : milestone, 3641,
iast (2.199 ms) : 2137, 2261
.   : milestone, 2199,
iast_GLOBAL (2.25 ms) : 2187, 2313
.   : milestone, 2250,
profiling (2.045 ms) : 1995, 2096
.   : milestone, 2045,
tracing (2.017 ms) : 1969, 2066
.   : milestone, 2017,
section candidate
no_agent (1.483 ms) : 1471, 1494
.   : milestone, 1483,
appsec (3.672 ms) : 3454, 3890
.   : milestone, 3672,
iast (2.204 ms) : 2142, 2267
.   : milestone, 2204,
iast_GLOBAL (2.251 ms) : 2188, 2315
.   : milestone, 2251,
profiling (2.042 ms) : 1992, 2092
.   : milestone, 2042,
tracing (2.018 ms) : 1970, 2067
.   : milestone, 2018,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.467 ms, 1.49 ms]	-
appsec	3.641 ms [3.425 ms, 3.858 ms]	2.163 ms (146.3%)
iast	2.199 ms [2.137 ms, 2.261 ms]	720.296 µs (48.7%)
iast_GLOBAL	2.25 ms [2.187 ms, 2.313 ms]	771.295 µs (52.2%)
profiling	2.045 ms [1.995 ms, 2.096 ms]	566.571 µs (38.3%)
tracing	2.017 ms [1.969 ms, 2.066 ms]	538.777 µs (36.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.483 ms [1.471 ms, 1.494 ms]	-
appsec	3.672 ms [3.454 ms, 3.89 ms]	2.19 ms (147.7%)
iast	2.204 ms [2.142 ms, 2.267 ms]	721.854 µs (48.7%)
iast_GLOBAL	2.251 ms [2.188 ms, 2.315 ms]	768.874 µs (51.9%)
profiling	2.042 ms [1.992 ms, 2.092 ms]	559.247 µs (37.7%)
tracing	2.018 ms [1.97 ms, 2.067 ms]	535.478 µs (36.1%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d748a1c4b9, baseline=1.53.0-SNAPSHOT~893780c76b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.317 s) : 15317000, 15317000
.   : milestone, 15317000,
appsec (15.047 s) : 15047000, 15047000
.   : milestone, 15047000,
iast (18.468 s) : 18468000, 18468000
.   : milestone, 18468000,
iast_GLOBAL (18.229 s) : 18229000, 18229000
.   : milestone, 18229000,
profiling (15.232 s) : 15232000, 15232000
.   : milestone, 15232000,
tracing (14.806 s) : 14806000, 14806000
.   : milestone, 14806000,
section candidate
no_agent (15.671 s) : 15671000, 15671000
.   : milestone, 15671000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.391 s) : 18391000, 18391000
.   : milestone, 18391000,
iast_GLOBAL (18.312 s) : 18312000, 18312000
.   : milestone, 18312000,
profiling (14.966 s) : 14966000, 14966000
.   : milestone, 14966000,
tracing (15.062 s) : 15062000, 15062000
.   : milestone, 15062000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.317 s [15.317 s, 15.317 s]	-
appsec	15.047 s [15.047 s, 15.047 s]	-270.0 ms (-1.8%)
iast	18.468 s [18.468 s, 18.468 s]	3.151 s (20.6%)
iast_GLOBAL	18.229 s [18.229 s, 18.229 s]	2.912 s (19.0%)
profiling	15.232 s [15.232 s, 15.232 s]	-85.0 ms (-0.6%)
tracing	14.806 s [14.806 s, 14.806 s]	-511.0 ms (-3.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.671 s [15.671 s, 15.671 s]	-
appsec	14.998 s [14.998 s, 14.998 s]	-673.0 ms (-4.3%)
iast	18.391 s [18.391 s, 18.391 s]	2.72 s (17.4%)
iast_GLOBAL	18.312 s [18.312 s, 18.312 s]	2.641 s (16.9%)
profiling	14.966 s [14.966 s, 14.966 s]	-705.0 ms (-4.5%)
tracing	15.062 s [15.062 s, 15.062 s]	-609.0 ms (-3.9%)

PerfectSlayer

Thanks for the fix. Left a minor comment about version catalog

PerfectSlayer · 2025-08-07T06:39:04Z

 cafe-crypto = ["cafe-crypto-curve25519", "cafe-crypto-ed25519"]
 # Testing
 spock = ["spock-core", "spock-junit4", "objenesis"]
+spock24 = ["spock24-core", "spock24-junit4", "objenesis34"]


❔ question: ‏Why do we end up with different versions of the same library within the catalog?
Can we limit the catalog to the "core" / "platform" libraries and move module specific or transitional changes (like the partial migration of Spock to a non stable version) into their build config only?

I really would like to keep the default catalog to the minimal set of libraries that contributors can safely rely on and start building onto.

We can start a small RFC on this.

That would be a good improvement

@PerfectSlayer Yes, there 2 versions of same lib, but I hope it is temporary. My ultimate goal is to migrate whole project to the latest Spock, but this would require more work. With this change I'm trying to proof that update to latest Spock will help us to fix freezes on CI.

sarahchen6

🙌

PerfectSlayer

Should be good to unblock the CI, thanks! 🤝
We will need to come up with a plan to either migrate such kind of tests to JUnit or find a way to have a stable and fixed Spock library.

Update Spock to 2.4-M6.

7316968

AlexeyKuznetsov-DD self-assigned this Aug 6, 2025

AlexeyKuznetsov-DD added tag: do not merge Do not merge changes comp: testing Testing labels Aug 6, 2025

Update Spock only for one module.

5746e36

AlexeyKuznetsov-DD added tag: no release notes Changes to exclude from release notes and removed tag: do not merge Do not merge changes labels Aug 6, 2025

AlexeyKuznetsov-DD marked this pull request as ready for review August 6, 2025 20:59

AlexeyKuznetsov-DD requested review from a team as code owners August 6, 2025 20:59

AlexeyKuznetsov-DD requested review from bric3, dougqh, sarahchen6 and zhengyu123 and removed request for a team August 6, 2025 20:59

PerfectSlayer reviewed Aug 7, 2025

View reviewed changes

AlexeyKuznetsov-DD requested a review from PerfectSlayer August 8, 2025 16:46

AlexeyKuznetsov-DD added 2 commits August 11, 2025 08:14

Merge branch 'master' into alexeyk/update-spock

fd670c8

Move Spock 2.4 usage only to problematic project that freezes on CI.

d748a1c

sarahchen6 approved these changes Aug 11, 2025

View reviewed changes

PerfectSlayer approved these changes Aug 11, 2025

View reviewed changes

AlexeyKuznetsov-DD merged commit d28a3ef into master Aug 11, 2025
671 of 672 checks passed

AlexeyKuznetsov-DD deleted the alexeyk/update-spock branch August 11, 2025 16:20

github-actions Bot added this to the 1.53.0 milestone Aug 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Spock to 2.4-M6.#9326

Update Spock to 2.4-M6.#9326
AlexeyKuznetsov-DD merged 4 commits intomasterfrom
alexeyk/update-spock

AlexeyKuznetsov-DD commented Aug 6, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 Bot commented Aug 6, 2025 •

edited

Loading

Uh oh!

datadog-official Bot commented Aug 6, 2025

Uh oh!

pr-commenter Bot commented Aug 6, 2025 •

edited

Loading

Uh oh!

PerfectSlayer left a comment

Uh oh!

PerfectSlayer Aug 7, 2025

Uh oh!

bric3 Aug 7, 2025

Uh oh!

AlexeyKuznetsov-DD Aug 8, 2025

Uh oh!

sarahchen6 left a comment

Uh oh!

PerfectSlayer left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AlexeyKuznetsov-DD commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

datadog-datadog-prod-us1 Bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-official Bot commented Aug 6, 2025

Uh oh!

pr-commenter Bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

AlexeyKuznetsov-DD Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

sarahchen6 left a comment

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AlexeyKuznetsov-DD commented Aug 6, 2025 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Aug 6, 2025 •

edited

Loading

pr-commenter Bot commented Aug 6, 2025 •

edited

Loading