Avoid using GITHUB_TOKEN for PR creation#9288
Merged
sarahchen6 merged 2 commits intomasterfrom Aug 1, 2025
Merged
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
xopham
changed the title
Contributor
PerfectSlayer
left a comment
PerfectSlayer
left a comment
There was a problem hiding this comment.
Thanks for helping us to make the transition.
As general comment, it’s missing update-jmxfetch-submodule and add-release-to-cloudfoundry fix.
But overall, the migration will consist of getting rid of ghcommit and replace it with the usual git commands and the new octo-sts way of signing way.
Would you be able to make the overall migration or would you need to pair with someone from my team?
| @@ -37,7 +43,7 @@ jobs: | |||
| ./gradlew resolveAndLockAll --write-locks --parallel --stacktrace --no-daemon --max-workers=4 | |||
| - name: Commit changes | |||
Contributor
There was a problem hiding this comment.
This whole logic need to be changed. If we can make signed commit, we don’t have to forge commits using ghcommit and can use git instead
This will greatly simplify the workflow
There was a problem hiding this comment.
You cannot make signed commits using git unless you:
- Have a user account with a verified email address for the committer
- Have an SSH or GPG public signing key uploaded for that user
- Have the SSH or GPG private key available in your Action
Using ghcommit (or https://github.com/DataDog/commit-headless which does the same thing) is the better option here.
There was a problem hiding this comment.
The main difference with, eg, commit-headless is that you can just make an unsigned commit locally then pass the commit hash to commit-headless and it'll create it remotely.
| GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} | ||
| GITHUB_TOKEN: ${{ steps.octo-sts.outputs.token }} | ||
| run: | | ||
| ghcommit --repository ${{ github.repository }} --branch ${{ steps.define-branch.outputs.branch }} --add .gitlab-ci.yml --message "feat(ci): Update Docker build image" |
Contributor
There was a problem hiding this comment.
similarly, it can be replaced by git commands too
Contributor
|
Code coverage: total 57.09%, patch 100.00% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: b6e54fc | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~b6e54fc9c8, baseline=1.51.1-SNAPSHOT~023e5251a6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041743
Total [baseline] (10.72 s) : 0, 10720054
Agent [candidate] (1.043 s) : 0, 1043362
Total [candidate] (10.729 s) : 0, 10728962
section appsec
Agent [baseline] (1.218 s) : 0, 1218055
Total [baseline] (10.813 s) : 0, 10812633
Agent [candidate] (1.219 s) : 0, 1218584
Total [candidate] (10.867 s) : 0, 10866588
section iast
Agent [baseline] (1.174 s) : 0, 1173730
Total [baseline] (10.874 s) : 0, 10873642
Agent [candidate] (1.171 s) : 0, 1170938
Total [candidate] (10.845 s) : 0, 10845233
section profiling
Agent [baseline] (1.191 s) : 0, 1191308
Total [baseline] (10.861 s) : 0, 10860595
Agent [candidate] (1.208 s) : 0, 1207504
Total [candidate] (10.923 s) : 0, 10922885
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~b6e54fc9c8, baseline=1.51.1-SNAPSHOT~023e5251a6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (731.378 ms) : 0, 731378
BytebuddyAgent [candidate] (731.829 ms) : 0, 731829
GlobalTracer [baseline] (241.353 ms) : 0, 241353
GlobalTracer [candidate] (241.267 ms) : 0, 241267
AppSec [baseline] (30.033 ms) : 0, 30033
AppSec [candidate] (29.938 ms) : 0, 29938
Debugger [baseline] (6.055 ms) : 0, 6055
Debugger [candidate] (6.036 ms) : 0, 6036
Remote Config [baseline] (653.313 µs) : 0, 653
Remote Config [candidate] (650.172 µs) : 0, 650
Telemetry [baseline] (9.888 ms) : 0, 9888
Telemetry [candidate] (11.204 ms) : 0, 11204
section appsec
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (752.275 ms) : 0, 752275
BytebuddyAgent [candidate] (752.349 ms) : 0, 752349
GlobalTracer [baseline] (234.218 ms) : 0, 234218
GlobalTracer [candidate] (234.804 ms) : 0, 234804
AppSec [baseline] (166.591 ms) : 0, 166591
AppSec [candidate] (167.921 ms) : 0, 167921
Debugger [baseline] (10.137 ms) : 0, 10137
Debugger [candidate] (7.93 ms) : 0, 7930
Remote Config [baseline] (625.486 µs) : 0, 625
Remote Config [candidate] (622.814 µs) : 0, 623
Telemetry [baseline] (8.287 ms) : 0, 8287
Telemetry [candidate] (9.015 ms) : 0, 9015
IAST [baseline] (23.49 ms) : 0, 23490
IAST [candidate] (23.547 ms) : 0, 23547
section iast
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.42 ms) : 0, 1420
BytebuddyAgent [baseline] (847.476 ms) : 0, 847476
BytebuddyAgent [candidate] (846.049 ms) : 0, 846049
GlobalTracer [baseline] (231.605 ms) : 0, 231605
GlobalTracer [candidate] (230.845 ms) : 0, 230845
AppSec [baseline] (25.926 ms) : 0, 25926
AppSec [candidate] (27.388 ms) : 0, 27388
Debugger [baseline] (5.813 ms) : 0, 5813
Debugger [candidate] (6.689 ms) : 0, 6689
Remote Config [baseline] (596.943 µs) : 0, 597
Remote Config [candidate] (580.876 µs) : 0, 581
Telemetry [baseline] (8.159 ms) : 0, 8159
Telemetry [candidate] (8.116 ms) : 0, 8116
IAST [baseline] (31.718 ms) : 0, 31718
IAST [candidate] (28.867 ms) : 0, 28867
section profiling
crashtracking [baseline] (1.391 ms) : 0, 1391
crashtracking [candidate] (1.414 ms) : 0, 1414
BytebuddyAgent [baseline] (759.551 ms) : 0, 759551
BytebuddyAgent [candidate] (769.521 ms) : 0, 769521
GlobalTracer [baseline] (221.329 ms) : 0, 221329
GlobalTracer [candidate] (223.529 ms) : 0, 223529
AppSec [baseline] (29.852 ms) : 0, 29852
AppSec [candidate] (30.496 ms) : 0, 30496
Debugger [baseline] (6.29 ms) : 0, 6290
Debugger [candidate] (6.366 ms) : 0, 6366
Remote Config [baseline] (684.221 µs) : 0, 684
Remote Config [candidate] (705.951 µs) : 0, 706
Telemetry [baseline] (15.804 ms) : 0, 15804
Telemetry [candidate] (16.276 ms) : 0, 16276
ProfilingAgent [baseline] (107.103 ms) : 0, 107103
ProfilingAgent [candidate] (109.154 ms) : 0, 109154
Profiling [baseline] (107.73 ms) : 0, 107730
Profiling [candidate] (109.815 ms) : 0, 109815
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~b6e54fc9c8, baseline=1.51.1-SNAPSHOT~023e5251a6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047230
Total [baseline] (8.596 s) : 0, 8596335
Agent [candidate] (1.043 s) : 0, 1042817
Total [candidate] (8.559 s) : 0, 8558801
section iast
Agent [baseline] (1.174 s) : 0, 1173932
Total [baseline] (9.324 s) : 0, 9323838
Agent [candidate] (1.176 s) : 0, 1175886
Total [candidate] (9.299 s) : 0, 9299330
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~b6e54fc9c8, baseline=1.51.1-SNAPSHOT~023e5251a6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (732.4 ms) : 0, 732400
BytebuddyAgent [candidate] (730.039 ms) : 0, 730039
GlobalTracer [baseline] (241.722 ms) : 0, 241722
GlobalTracer [candidate] (241.302 ms) : 0, 241302
AppSec [baseline] (30.052 ms) : 0, 30052
AppSec [candidate] (29.958 ms) : 0, 29958
Debugger [baseline] (6.053 ms) : 0, 6053
Debugger [candidate] (5.998 ms) : 0, 5998
Remote Config [baseline] (641.577 µs) : 0, 642
Remote Config [candidate] (647.798 µs) : 0, 648
Telemetry [baseline] (13.987 ms) : 0, 13987
Telemetry [candidate] (12.551 ms) : 0, 12551
section iast
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (848.313 ms) : 0, 848313
BytebuddyAgent [candidate] (849.255 ms) : 0, 849255
GlobalTracer [baseline] (232.408 ms) : 0, 232408
GlobalTracer [candidate] (231.448 ms) : 0, 231448
AppSec [baseline] (25.063 ms) : 0, 25063
AppSec [candidate] (26.31 ms) : 0, 26310
Debugger [baseline] (6.67 ms) : 0, 6670
Debugger [candidate] (6.834 ms) : 0, 6834
Remote Config [baseline] (598.835 µs) : 0, 599
Remote Config [candidate] (598.678 µs) : 0, 599
Telemetry [baseline] (8.049 ms) : 0, 8049
Telemetry [candidate] (8.169 ms) : 0, 8169
IAST [baseline] (30.508 ms) : 0, 30508
IAST [candidate] (30.851 ms) : 0, 30851
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~b6e54fc9c8, baseline=1.51.1-SNAPSHOT~023e5251a6
dateFormat X
axisFormat %s
section baseline
no_agent (37.17 ms) : 36878, 37463
. : milestone, 37170,
appsec (48.68 ms) : 48242, 49117
. : milestone, 48680,
code_origins (46.137 ms) : 45739, 46535
. : milestone, 46137,
iast (47.083 ms) : 46674, 47492
. : milestone, 47083,
profiling (48.862 ms) : 48374, 49350
. : milestone, 48862,
tracing (43.357 ms) : 42991, 43723
. : milestone, 43357,
section candidate
no_agent (37.308 ms) : 37012, 37604
. : milestone, 37308,
appsec (46.571 ms) : 46176, 46965
. : milestone, 46571,
code_origins (43.418 ms) : 43043, 43794
. : milestone, 43418,
iast (47.486 ms) : 47076, 47896
. : milestone, 47486,
profiling (48.063 ms) : 47604, 48521
. : milestone, 48063,
tracing (44.672 ms) : 44287, 45056
. : milestone, 44672,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~b6e54fc9c8, baseline=1.51.1-SNAPSHOT~023e5251a6
dateFormat X
axisFormat %s
section baseline
no_agent (4.352 ms) : 4298, 4406
. : milestone, 4352,
iast (9.511 ms) : 9355, 9667
. : milestone, 9511,
iast_FULL (14.343 ms) : 14053, 14633
. : milestone, 14343,
iast_GLOBAL (10.824 ms) : 10633, 11016
. : milestone, 10824,
profiling (8.625 ms) : 8494, 8755
. : milestone, 8625,
tracing (7.667 ms) : 7558, 7776
. : milestone, 7667,
section candidate
no_agent (4.347 ms) : 4299, 4396
. : milestone, 4347,
iast (9.619 ms) : 9454, 9784
. : milestone, 9619,
iast_FULL (13.925 ms) : 13652, 14199
. : milestone, 13925,
iast_GLOBAL (10.217 ms) : 10039, 10395
. : milestone, 10217,
profiling (8.551 ms) : 8421, 8680
. : milestone, 8551,
tracing (7.875 ms) : 7764, 7987
. : milestone, 7875,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~b6e54fc9c8, baseline=1.51.1-SNAPSHOT~023e5251a6
dateFormat X
axisFormat %s
section baseline
no_agent (15.406 s) : 15406000, 15406000
. : milestone, 15406000,
appsec (14.673 s) : 14673000, 14673000
. : milestone, 14673000,
iast (18.651 s) : 18651000, 18651000
. : milestone, 18651000,
iast_GLOBAL (18.178 s) : 18178000, 18178000
. : milestone, 18178000,
profiling (15.284 s) : 15284000, 15284000
. : milestone, 15284000,
tracing (14.907 s) : 14907000, 14907000
. : milestone, 14907000,
section candidate
no_agent (15.675 s) : 15675000, 15675000
. : milestone, 15675000,
appsec (14.794 s) : 14794000, 14794000
. : milestone, 14794000,
iast (18.298 s) : 18298000, 18298000
. : milestone, 18298000,
iast_GLOBAL (18.042 s) : 18042000, 18042000
. : milestone, 18042000,
profiling (15.384 s) : 15384000, 15384000
. : milestone, 15384000,
tracing (15.206 s) : 15206000, 15206000
. : milestone, 15206000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~b6e54fc9c8, baseline=1.51.1-SNAPSHOT~023e5251a6
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.601 ms) : 3386, 3816
. : milestone, 3601,
iast (2.208 ms) : 2144, 2272
. : milestone, 2208,
iast_GLOBAL (2.241 ms) : 2177, 2304
. : milestone, 2241,
profiling (2.058 ms) : 2006, 2111
. : milestone, 2058,
tracing (2.005 ms) : 1956, 2054
. : milestone, 2005,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.669 ms) : 3452, 3886
. : milestone, 3669,
iast (2.199 ms) : 2136, 2262
. : milestone, 2199,
iast_GLOBAL (2.243 ms) : 2180, 2307
. : milestone, 2243,
profiling (2.046 ms) : 1994, 2097
. : milestone, 2046,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
|
sarahchen6
approved these changes
Aug 1, 2025
Contributor
sarahchen6
left a comment
sarahchen6
left a comment
There was a problem hiding this comment.
Approving with the plan to add in commit-headless signing for commits in a separate PR
|
sarahchen6
deleted the
christoph.hamsen/avoid-using-github-token-for-pr-creation
branch
sarahchen6
pushed a commit
that referenced
this pull request
Aug 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]