Fix the annotation region format parsing on JDK 24/25#9234
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~7624c4a8cf, baseline=1.51.1-SNAPSHOT~a1e426cf1e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041024
Total [baseline] (10.658 s) : 0, 10658134
Agent [candidate] (1.044 s) : 0, 1044371
Total [candidate] (10.815 s) : 0, 10814666
section appsec
Agent [baseline] (1.219 s) : 0, 1218577
Total [baseline] (10.753 s) : 0, 10753192
Agent [candidate] (1.217 s) : 0, 1217409
Total [candidate] (10.776 s) : 0, 10776314
section iast
Agent [baseline] (1.182 s) : 0, 1182253
Total [baseline] (10.909 s) : 0, 10909053
Agent [candidate] (1.187 s) : 0, 1187090
Total [candidate] (10.894 s) : 0, 10893564
section profiling
Agent [baseline] (1.191 s) : 0, 1191106
Total [baseline] (10.824 s) : 0, 10823624
Agent [candidate] (1.191 s) : 0, 1190551
Total [candidate] (10.885 s) : 0, 10885306
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~7624c4a8cf, baseline=1.51.1-SNAPSHOT~a1e426cf1e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (728.756 ms) : 0, 728756
BytebuddyAgent [candidate] (730.081 ms) : 0, 730081
GlobalTracer [baseline] (241.283 ms) : 0, 241283
GlobalTracer [candidate] (241.572 ms) : 0, 241572
AppSec [baseline] (30.085 ms) : 0, 30085
AppSec [candidate] (30.317 ms) : 0, 30317
Debugger [baseline] (5.957 ms) : 0, 5957
Debugger [candidate] (6.01 ms) : 0, 6010
Remote Config [baseline] (647.278 µs) : 0, 647
Remote Config [candidate] (668.508 µs) : 0, 669
Telemetry [baseline] (11.885 ms) : 0, 11885
Telemetry [candidate] (13.305 ms) : 0, 13305
section appsec
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (752.398 ms) : 0, 752398
BytebuddyAgent [candidate] (750.745 ms) : 0, 750745
GlobalTracer [baseline] (234.647 ms) : 0, 234647
GlobalTracer [candidate] (234.603 ms) : 0, 234603
AppSec [baseline] (169.487 ms) : 0, 169487
AppSec [candidate] (168.349 ms) : 0, 168349
Debugger [baseline] (7.062 ms) : 0, 7062
Debugger [candidate] (8.576 ms) : 0, 8576
Remote Config [baseline] (615.254 µs) : 0, 615
Remote Config [candidate] (621.182 µs) : 0, 621
Telemetry [baseline] (8.219 ms) : 0, 8219
Telemetry [candidate] (8.232 ms) : 0, 8232
IAST [baseline] (23.536 ms) : 0, 23536
IAST [candidate] (23.632 ms) : 0, 23632
section iast
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (854.093 ms) : 0, 854093
BytebuddyAgent [candidate] (857.169 ms) : 0, 857169
GlobalTracer [baseline] (232.843 ms) : 0, 232843
GlobalTracer [candidate] (234.123 ms) : 0, 234123
AppSec [baseline] (28.201 ms) : 0, 28201
AppSec [candidate] (27.508 ms) : 0, 27508
Debugger [baseline] (6.697 ms) : 0, 6697
Debugger [candidate] (6.617 ms) : 0, 6617
Remote Config [baseline] (600.773 µs) : 0, 601
Remote Config [candidate] (593.151 µs) : 0, 593
Telemetry [baseline] (8.078 ms) : 0, 8078
Telemetry [candidate] (8.169 ms) : 0, 8169
IAST [baseline] (29.259 ms) : 0, 29259
IAST [candidate] (30.407 ms) : 0, 30407
section profiling
ProfilingAgent [baseline] (108.31 ms) : 0, 108310
ProfilingAgent [candidate] (108.308 ms) : 0, 108308
crashtracking [baseline] (1.4 ms) : 0, 1400
crashtracking [candidate] (1.406 ms) : 0, 1406
BytebuddyAgent [baseline] (759.446 ms) : 0, 759446
BytebuddyAgent [candidate] (758.744 ms) : 0, 758744
GlobalTracer [baseline] (220.369 ms) : 0, 220369
GlobalTracer [candidate] (220.506 ms) : 0, 220506
AppSec [baseline] (30.316 ms) : 0, 30316
AppSec [candidate] (30.187 ms) : 0, 30187
Debugger [baseline] (6.225 ms) : 0, 6225
Debugger [candidate] (6.234 ms) : 0, 6234
Remote Config [baseline] (688.031 µs) : 0, 688
Remote Config [candidate] (684.639 µs) : 0, 685
Telemetry [baseline] (15.954 ms) : 0, 15954
Telemetry [candidate] (15.917 ms) : 0, 15917
Profiling [baseline] (108.334 ms) : 0, 108334
Profiling [candidate] (108.332 ms) : 0, 108332
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~7624c4a8cf, baseline=1.51.1-SNAPSHOT~a1e426cf1e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050421
Total [baseline] (8.609 s) : 0, 8609127
Agent [candidate] (1.043 s) : 0, 1043153
Total [candidate] (8.613 s) : 0, 8612632
section iast
Agent [baseline] (1.173 s) : 0, 1172570
Total [baseline] (9.314 s) : 0, 9314497
Agent [candidate] (1.17 s) : 0, 1170012
Total [candidate] (9.279 s) : 0, 9278659
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~7624c4a8cf, baseline=1.51.1-SNAPSHOT~a1e426cf1e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (734.474 ms) : 0, 734474
BytebuddyAgent [candidate] (729.805 ms) : 0, 729805
GlobalTracer [baseline] (242.896 ms) : 0, 242896
GlobalTracer [candidate] (242.291 ms) : 0, 242291
AppSec [baseline] (30.568 ms) : 0, 30568
AppSec [candidate] (30.579 ms) : 0, 30579
Debugger [baseline] (6.007 ms) : 0, 6007
Debugger [candidate] (6.01 ms) : 0, 6010
Remote Config [baseline] (656.798 µs) : 0, 657
Remote Config [candidate] (655.487 µs) : 0, 655
Telemetry [baseline] (13.321 ms) : 0, 13321
Telemetry [candidate] (11.335 ms) : 0, 11335
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (846.698 ms) : 0, 846698
BytebuddyAgent [candidate] (845.196 ms) : 0, 845196
GlobalTracer [baseline] (230.869 ms) : 0, 230869
GlobalTracer [candidate] (230.466 ms) : 0, 230466
IAST [baseline] (29.814 ms) : 0, 29814
IAST [candidate] (30.233 ms) : 0, 30233
AppSec [baseline] (27.497 ms) : 0, 27497
AppSec [candidate] (25.758 ms) : 0, 25758
Debugger [baseline] (6.707 ms) : 0, 6707
Debugger [candidate] (7.484 ms) : 0, 7484
Remote Config [baseline] (585.091 µs) : 0, 585
Remote Config [candidate] (580.92 µs) : 0, 581
Telemetry [baseline] (8.068 ms) : 0, 8068
Telemetry [candidate] (8.079 ms) : 0, 8079
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~7624c4a8cf, baseline=1.51.1-SNAPSHOT~a1e426cf1e
dateFormat X
axisFormat %s
section baseline
no_agent (4.386 ms) : 4330, 4442
. : milestone, 4386,
iast (9.225 ms) : 9076, 9374
. : milestone, 9225,
iast_FULL (14.359 ms) : 14070, 14647
. : milestone, 14359,
iast_GLOBAL (10.423 ms) : 10237, 10609
. : milestone, 10423,
profiling (8.805 ms) : 8670, 8940
. : milestone, 8805,
tracing (7.254 ms) : 7148, 7361
. : milestone, 7254,
section candidate
no_agent (4.405 ms) : 4355, 4455
. : milestone, 4405,
iast (9.203 ms) : 9053, 9353
. : milestone, 9203,
iast_FULL (13.595 ms) : 13323, 13867
. : milestone, 13595,
iast_GLOBAL (10.163 ms) : 9986, 10339
. : milestone, 10163,
profiling (8.972 ms) : 8815, 9129
. : milestone, 8972,
tracing (7.354 ms) : 7241, 7467
. : milestone, 7354,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~7624c4a8cf, baseline=1.51.1-SNAPSHOT~a1e426cf1e
dateFormat X
axisFormat %s
section baseline
no_agent (37.076 ms) : 36775, 37376
. : milestone, 37076,
appsec (47.23 ms) : 46828, 47632
. : milestone, 47230,
code_origins (43.182 ms) : 42807, 43557
. : milestone, 43182,
iast (46.202 ms) : 45785, 46619
. : milestone, 46202,
profiling (50.056 ms) : 49554, 50558
. : milestone, 50056,
tracing (42.521 ms) : 42152, 42890
. : milestone, 42521,
section candidate
no_agent (37.322 ms) : 37017, 37627
. : milestone, 37322,
appsec (47.923 ms) : 47505, 48340
. : milestone, 47923,
code_origins (45.266 ms) : 44884, 45648
. : milestone, 45266,
iast (46.876 ms) : 46467, 47285
. : milestone, 46876,
profiling (46.581 ms) : 46112, 47050
. : milestone, 46581,
tracing (45.262 ms) : 44874, 45650
. : milestone, 45262,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~7624c4a8cf, baseline=1.51.1-SNAPSHOT~a1e426cf1e
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.63 ms) : 3415, 3846
. : milestone, 3630,
iast (2.212 ms) : 2149, 2276
. : milestone, 2212,
iast_GLOBAL (2.246 ms) : 2183, 2309
. : milestone, 2246,
profiling (2.037 ms) : 1987, 2087
. : milestone, 2037,
tracing (2.023 ms) : 1974, 2072
. : milestone, 2023,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.646 ms) : 3431, 3860
. : milestone, 3646,
iast (2.201 ms) : 2138, 2263
. : milestone, 2201,
iast_GLOBAL (2.233 ms) : 2170, 2295
. : milestone, 2233,
profiling (2.027 ms) : 1977, 2078
. : milestone, 2027,
tracing (2.009 ms) : 1960, 2058
. : milestone, 2009,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~7624c4a8cf, baseline=1.51.1-SNAPSHOT~a1e426cf1e
dateFormat X
axisFormat %s
section baseline
no_agent (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
appsec (15.084 s) : 15084000, 15084000
. : milestone, 15084000,
iast (18.025 s) : 18025000, 18025000
. : milestone, 18025000,
iast_GLOBAL (18.077 s) : 18077000, 18077000
. : milestone, 18077000,
profiling (15.106 s) : 15106000, 15106000
. : milestone, 15106000,
tracing (15.092 s) : 15092000, 15092000
. : milestone, 15092000,
section candidate
no_agent (15.323 s) : 15323000, 15323000
. : milestone, 15323000,
appsec (14.667 s) : 14667000, 14667000
. : milestone, 14667000,
iast (17.928 s) : 17928000, 17928000
. : milestone, 17928000,
iast_GLOBAL (18.071 s) : 18071000, 18071000
. : milestone, 18071000,
profiling (15.234 s) : 15234000, 15234000
. : milestone, 15234000,
tracing (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
It adjusts the parser to the 24+ version of the
System.mapDCMD formatMotivation
Make sure the parser works correctly with JDK 24+
Additional Notes
Added a sanity test to check the correct parsing of the JDK 24+ region addresses
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issue