Skip to content

Avoid initializing SMAP events on JDKs with no JFR#9231

Merged
jbachorik merged 1 commit intomasterfrom
jb/smap_j9
Jul 24, 2025
Merged

Avoid initializing SMAP events on JDKs with no JFR#9231
jbachorik merged 1 commit intomasterfrom
jb/smap_j9

Conversation

@jbachorik
Copy link
Copy Markdown
Contributor

@jbachorik jbachorik commented Jul 23, 2025

What Does This Do

What title says

Motivation

Avoid errors when trying to initialize the support on JDKs without JFR

Additional Notes

Contributor Checklist

@jbachorik jbachorik added type: bug Bug report and fix tag: no release notes Changes to exclude from release notes comp: profiling Profiling run-tests: semeru11 Run tests using Sumuru 11 JDK run-tests: semeru17 Run tests using Sumuru 17 JDK labels Jul 23, 2025
@jbachorik jbachorik marked this pull request as ready for review July 23, 2025 23:36
@jbachorik jbachorik requested review from a team as code owners July 23, 2025 23:36
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jul 23, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/smap_j9
git_commit_date 1753303640 1753311359
git_commit_sha 05a10a5 410b501
release_version 1.51.1-SNAPSHOT~05a10a5f19 1.51.1-SNAPSHOT~410b501b8e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1753313839 1753313839
ci_job_id 1044817247 1044817247
ci_pipeline_id 71529448 71529448
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-9nl8atje 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-9nl8atje 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~410b501b8e, baseline=1.51.1-SNAPSHOT~05a10a5f19

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042555
Total [baseline] (10.658 s) : 0, 10657507
Agent [candidate] (1.039 s) : 0, 1038926
Total [candidate] (10.684 s) : 0, 10683695
section appsec
Agent [baseline] (1.214 s) : 0, 1214360
Total [baseline] (10.782 s) : 0, 10782322
Agent [candidate] (1.22 s) : 0, 1219780
Total [candidate] (10.801 s) : 0, 10801271
section iast
Agent [baseline] (1.172 s) : 0, 1171822
Total [baseline] (10.878 s) : 0, 10877892
Agent [candidate] (1.183 s) : 0, 1183258
Total [candidate] (10.907 s) : 0, 10907230
section profiling
Agent [baseline] (1.19 s) : 0, 1189859
Total [baseline] (10.867 s) : 0, 10867289
Agent [candidate] (1.191 s) : 0, 1191001
Total [candidate] (10.822 s) : 0, 10821543
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent appsec 1.214 s 171.805 ms (16.5%)
Agent iast 1.172 s 129.267 ms (12.4%)
Agent profiling 1.19 s 147.304 ms (14.1%)
Total tracing 10.658 s -
Total appsec 10.782 s 124.815 ms (1.2%)
Total iast 10.878 s 220.385 ms (2.1%)
Total profiling 10.867 s 209.783 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent appsec 1.22 s 180.854 ms (17.4%)
Agent iast 1.183 s 144.332 ms (13.9%)
Agent profiling 1.191 s 152.075 ms (14.6%)
Total tracing 10.684 s -
Total appsec 10.801 s 117.575 ms (1.1%)
Total iast 10.907 s 223.534 ms (2.1%)
Total profiling 10.822 s 137.847 ms (1.3%) 
gantt
    title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~410b501b8e, baseline=1.51.1-SNAPSHOT~05a10a5f19

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.423 ms) : 0, 1423
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (728.97 ms) : 0, 728970
BytebuddyAgent [candidate] (727.882 ms) : 0, 727882
GlobalTracer [baseline] (241.612 ms) : 0, 241612
GlobalTracer [candidate] (240.477 ms) : 0, 240477
AppSec [baseline] (30.339 ms) : 0, 30339
AppSec [candidate] (30.403 ms) : 0, 30403
Debugger [baseline] (6.017 ms) : 0, 6017
Debugger [candidate] (5.976 ms) : 0, 5976
Remote Config [baseline] (656.399 µs) : 0, 656
Remote Config [candidate] (635.675 µs) : 0, 636
Telemetry [baseline] (12.578 ms) : 0, 12578
Telemetry [candidate] (11.183 ms) : 0, 11183
section appsec
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (748.93 ms) : 0, 748930
BytebuddyAgent [candidate] (752.386 ms) : 0, 752386
GlobalTracer [baseline] (234.032 ms) : 0, 234032
GlobalTracer [candidate] (234.997 ms) : 0, 234997
AppSec [baseline] (167.715 ms) : 0, 167715
AppSec [candidate] (169.265 ms) : 0, 169265
Debugger [baseline] (7.947 ms) : 0, 7947
Debugger [candidate] (7.921 ms) : 0, 7921
Remote Config [baseline] (615.791 µs) : 0, 616
Remote Config [candidate] (623.892 µs) : 0, 624
Telemetry [baseline] (8.968 ms) : 0, 8968
Telemetry [candidate] (8.303 ms) : 0, 8303
IAST [baseline] (23.547 ms) : 0, 23547
IAST [candidate] (23.57 ms) : 0, 23570
section iast
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (845.417 ms) : 0, 845417
BytebuddyAgent [candidate] (854.897 ms) : 0, 854897
GlobalTracer [baseline] (232.461 ms) : 0, 232461
GlobalTracer [candidate] (232.557 ms) : 0, 232557
AppSec [baseline] (26.519 ms) : 0, 26519
AppSec [candidate] (26.73 ms) : 0, 26730
Debugger [baseline] (8.248 ms) : 0, 8248
Debugger [candidate] (8.455 ms) : 0, 8455
Remote Config [baseline] (591.121 µs) : 0, 591
Remote Config [candidate] (597.131 µs) : 0, 597
Telemetry [baseline] (8.114 ms) : 0, 8114
Telemetry [candidate] (8.096 ms) : 0, 8096
IAST [baseline] (28.097 ms) : 0, 28097
IAST [candidate] (29.324 ms) : 0, 29324
section profiling
ProfilingAgent [baseline] (108.004 ms) : 0, 108004
ProfilingAgent [candidate] (107.968 ms) : 0, 107968
crashtracking [baseline] (1.405 ms) : 0, 1405
crashtracking [candidate] (1.389 ms) : 0, 1389
BytebuddyAgent [baseline] (758.4 ms) : 0, 758400
BytebuddyAgent [candidate] (758.945 ms) : 0, 758945
GlobalTracer [baseline] (220.327 ms) : 0, 220327
GlobalTracer [candidate] (220.934 ms) : 0, 220934
AppSec [baseline] (30.287 ms) : 0, 30287
AppSec [candidate] (30.381 ms) : 0, 30381
Debugger [baseline] (6.181 ms) : 0, 6181
Debugger [candidate] (6.249 ms) : 0, 6249
Remote Config [baseline] (725.815 µs) : 0, 726
Remote Config [candidate] (688.666 µs) : 0, 689
Telemetry [baseline] (15.99 ms) : 0, 15990
Telemetry [candidate] (15.955 ms) : 0, 15955
Profiling [baseline] (108.026 ms) : 0, 108026
Profiling [candidate] (107.991 ms) : 0, 107991
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~410b501b8e, baseline=1.51.1-SNAPSHOT~05a10a5f19

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045257
Total [baseline] (8.606 s) : 0, 8606015
Agent [candidate] (1.052 s) : 0, 1051832
Total [candidate] (8.585 s) : 0, 8584909
section iast
Agent [baseline] (1.173 s) : 0, 1172744
Total [baseline] (9.316 s) : 0, 9316251
Agent [candidate] (1.17 s) : 0, 1169902
Total [candidate] (9.296 s) : 0, 9295651
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.173 s 127.487 ms (12.2%)
Total tracing 8.606 s -
Total iast 9.316 s 710.236 ms (8.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.17 s 118.069 ms (11.2%)
Total tracing 8.585 s -
Total iast 9.296 s 710.742 ms (8.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~410b501b8e, baseline=1.51.1-SNAPSHOT~05a10a5f19

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (732.834 ms) : 0, 732834
BytebuddyAgent [candidate] (735.977 ms) : 0, 735977
GlobalTracer [baseline] (241.839 ms) : 0, 241839
GlobalTracer [candidate] (243.142 ms) : 0, 243142
AppSec [baseline] (30.456 ms) : 0, 30456
AppSec [candidate] (30.74 ms) : 0, 30740
Debugger [baseline] (5.965 ms) : 0, 5965
Debugger [candidate] (6.013 ms) : 0, 6013
Remote Config [baseline] (651.742 µs) : 0, 652
Remote Config [candidate] (649.086 µs) : 0, 649
Telemetry [baseline] (11.104 ms) : 0, 11104
Telemetry [candidate] (12.754 ms) : 0, 12754
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (846.705 ms) : 0, 846705
BytebuddyAgent [candidate] (845.056 ms) : 0, 845056
GlobalTracer [baseline] (232.026 ms) : 0, 232026
GlobalTracer [candidate] (230.435 ms) : 0, 230435
IAST [baseline] (29.837 ms) : 0, 29837
IAST [candidate] (30.523 ms) : 0, 30523
AppSec [baseline] (24.896 ms) : 0, 24896
AppSec [candidate] (25.502 ms) : 0, 25502
Debugger [baseline] (8.332 ms) : 0, 8332
Debugger [candidate] (7.504 ms) : 0, 7504
Remote Config [baseline] (571.995 µs) : 0, 572
Remote Config [candidate] (606.866 µs) : 0, 607
Telemetry [baseline] (8.056 ms) : 0, 8056
Telemetry [candidate] (8.025 ms) : 0, 8025
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/smap_j9
git_commit_date 1753303640 1753311359
git_commit_sha 05a10a5 410b501
release_version 1.51.1-SNAPSHOT~05a10a5f19 1.51.1-SNAPSHOT~410b501b8e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1753313511 1753313511
ci_job_id 1044817248 1044817248
ci_pipeline_id 71529448 71529448
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-ti4figbo 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-ti4figbo 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:tracing:high_load worse
[+241.975µs; +482.847µs] or [+3.228%; +6.441%]		 unstable
[-106.900op/s; +50.275op/s] or [-17.303%; +8.138%]		 7.859ms 589.500op/s 7.496ms 617.812op/s
scenario:load:petclinic:tracing:high_load worse
[+2.988ms; +3.822ms] or [+6.871%; +8.787%]		 unstable
[-15.307op/s; -0.318op/s] or [-14.227%; -0.296%]		 46.900ms 99.775op/s 43.495ms 107.588op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~410b501b8e, baseline=1.51.1-SNAPSHOT~05a10a5f19
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.381 ms) : 4331, 4432
.   : milestone, 4381,
iast (9.59 ms) : 9431, 9748
.   : milestone, 9590,
iast_FULL (14.123 ms) : 13842, 14404
.   : milestone, 14123,
iast_GLOBAL (10.211 ms) : 10032, 10389
.   : milestone, 10211,
profiling (8.755 ms) : 8604, 8907
.   : milestone, 8755,
tracing (7.496 ms) : 7392, 7600
.   : milestone, 7496,
section candidate
no_agent (4.341 ms) : 4290, 4391
.   : milestone, 4341,
iast (9.536 ms) : 9380, 9691
.   : milestone, 9536,
iast_FULL (13.877 ms) : 13605, 14150
.   : milestone, 13877,
iast_GLOBAL (10.091 ms) : 9916, 10265
.   : milestone, 10091,
profiling (8.96 ms) : 8804, 9116
.   : milestone, 8960,
tracing (7.859 ms) : 7739, 7978
.   : milestone, 7859,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.381 ms [4.331 ms, 4.432 ms] -
iast 9.59 ms [9.431 ms, 9.748 ms] 5.209 ms (118.9%)
iast_FULL 14.123 ms [13.842 ms, 14.404 ms] 9.742 ms (222.4%)
iast_GLOBAL 10.211 ms [10.032 ms, 10.389 ms] 5.829 ms (133.1%)
profiling 8.755 ms [8.604 ms, 8.907 ms] 4.374 ms (99.8%)
tracing 7.496 ms [7.392 ms, 7.6 ms] 3.115 ms (71.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.341 ms [4.29 ms, 4.391 ms] -
iast 9.536 ms [9.38 ms, 9.691 ms] 5.195 ms (119.7%)
iast_FULL 13.877 ms [13.605 ms, 14.15 ms] 9.537 ms (219.7%)
iast_GLOBAL 10.091 ms [9.916 ms, 10.265 ms] 5.75 ms (132.5%)
profiling 8.96 ms [8.804 ms, 9.116 ms] 4.62 ms (106.4%)
tracing 7.859 ms [7.739 ms, 7.978 ms] 3.518 ms (81.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~410b501b8e, baseline=1.51.1-SNAPSHOT~05a10a5f19
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.514 ms) : 36229, 36800
.   : milestone, 36514,
appsec (47.015 ms) : 46609, 47421
.   : milestone, 47015,
code_origins (46.313 ms) : 45919, 46708
.   : milestone, 46313,
iast (45.414 ms) : 45006, 45823
.   : milestone, 45414,
profiling (47.466 ms) : 46995, 47936
.   : milestone, 47466,
tracing (43.495 ms) : 43137, 43854
.   : milestone, 43495,
section candidate
no_agent (37.424 ms) : 37130, 37717
.   : milestone, 37424,
appsec (46.55 ms) : 46133, 46968
.   : milestone, 46550,
code_origins (45.053 ms) : 44660, 45445
.   : milestone, 45053,
iast (44.948 ms) : 44559, 45338
.   : milestone, 44948,
profiling (48.355 ms) : 47843, 48868
.   : milestone, 48355,
tracing (46.9 ms) : 46486, 47315
.   : milestone, 46900,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.514 ms [36.229 ms, 36.8 ms] -
appsec 47.015 ms [46.609 ms, 47.421 ms] 10.501 ms (28.8%)
code_origins 46.313 ms [45.919 ms, 46.708 ms] 9.799 ms (26.8%)
iast 45.414 ms [45.006 ms, 45.823 ms] 8.9 ms (24.4%)
profiling 47.466 ms [46.995 ms, 47.936 ms] 10.951 ms (30.0%)
tracing 43.495 ms [43.137 ms, 43.854 ms] 6.981 ms (19.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.424 ms [37.13 ms, 37.717 ms] -
appsec 46.55 ms [46.133 ms, 46.968 ms] 9.127 ms (24.4%)
code_origins 45.053 ms [44.66 ms, 45.445 ms] 7.629 ms (20.4%)
iast 44.948 ms [44.559 ms, 45.338 ms] 7.525 ms (20.1%)
profiling 48.355 ms [47.843 ms, 48.868 ms] 10.932 ms (29.2%)
tracing 46.9 ms [46.486 ms, 47.315 ms] 9.477 ms (25.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/smap_j9
git_commit_date 1753303640 1753311359
git_commit_sha 05a10a5 410b501
release_version 1.51.1-SNAPSHOT~05a10a5f19 1.51.1-SNAPSHOT~410b501b8e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1753314037 1753314037
ci_job_id 1044817249 1044817249
ci_pipeline_id 71529448 71529448
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-69vjivuv 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-69vjivuv 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~410b501b8e, baseline=1.51.1-SNAPSHOT~05a10a5f19
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.571 s) : 15571000, 15571000
.   : milestone, 15571000,
appsec (14.732 s) : 14732000, 14732000
.   : milestone, 14732000,
iast (18.633 s) : 18633000, 18633000
.   : milestone, 18633000,
iast_GLOBAL (17.93 s) : 17930000, 17930000
.   : milestone, 17930000,
profiling (15.093 s) : 15093000, 15093000
.   : milestone, 15093000,
tracing (15.12 s) : 15120000, 15120000
.   : milestone, 15120000,
section candidate
no_agent (15.655 s) : 15655000, 15655000
.   : milestone, 15655000,
appsec (14.84 s) : 14840000, 14840000
.   : milestone, 14840000,
iast (18.317 s) : 18317000, 18317000
.   : milestone, 18317000,
iast_GLOBAL (17.869 s) : 17869000, 17869000
.   : milestone, 17869000,
profiling (16.108 s) : 16108000, 16108000
.   : milestone, 16108000,
tracing (15.15 s) : 15150000, 15150000
.   : milestone, 15150000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.571 s [15.571 s, 15.571 s] -
appsec 14.732 s [14.732 s, 14.732 s] -839.0 ms (-5.4%)
iast 18.633 s [18.633 s, 18.633 s] 3.062 s (19.7%)
iast_GLOBAL 17.93 s [17.93 s, 17.93 s] 2.359 s (15.1%)
profiling 15.093 s [15.093 s, 15.093 s] -478.0 ms (-3.1%)
tracing 15.12 s [15.12 s, 15.12 s] -451.0 ms (-2.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.655 s [15.655 s, 15.655 s] -
appsec 14.84 s [14.84 s, 14.84 s] -815.0 ms (-5.2%)
iast 18.317 s [18.317 s, 18.317 s] 2.662 s (17.0%)
iast_GLOBAL 17.869 s [17.869 s, 17.869 s] 2.214 s (14.1%)
profiling 16.108 s [16.108 s, 16.108 s] 453.0 ms (2.9%)
tracing 15.15 s [15.15 s, 15.15 s] -505.0 ms (-3.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~410b501b8e, baseline=1.51.1-SNAPSHOT~05a10a5f19
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (3.578 ms) : 3365, 3790
.   : milestone, 3578,
iast (2.199 ms) : 2136, 2262
.   : milestone, 2199,
iast_GLOBAL (2.234 ms) : 2171, 2298
.   : milestone, 2234,
profiling (2.065 ms) : 2012, 2117
.   : milestone, 2065,
tracing (2.007 ms) : 1959, 2056
.   : milestone, 2007,
section candidate
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (3.583 ms) : 3369, 3796
.   : milestone, 3583,
iast (2.189 ms) : 2126, 2253
.   : milestone, 2189,
iast_GLOBAL (2.234 ms) : 2171, 2298
.   : milestone, 2234,
profiling (2.042 ms) : 1992, 2093
.   : milestone, 2042,
tracing (2.022 ms) : 1973, 2071
.   : milestone, 2022,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 3.578 ms [3.365 ms, 3.79 ms] 2.109 ms (143.5%)
iast 2.199 ms [2.136 ms, 2.262 ms] 730.209 µs (49.7%)
iast_GLOBAL 2.234 ms [2.171 ms, 2.298 ms] 765.421 µs (52.1%)
profiling 2.065 ms [2.012 ms, 2.117 ms] 595.586 µs (40.5%)
tracing 2.007 ms [1.959 ms, 2.056 ms] 538.231 µs (36.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 3.583 ms [3.369 ms, 3.796 ms] 2.114 ms (144.0%)
iast 2.189 ms [2.126 ms, 2.253 ms] 720.818 µs (49.1%)
iast_GLOBAL 2.234 ms [2.171 ms, 2.298 ms] 766.016 µs (52.2%)
profiling 2.042 ms [1.992 ms, 2.093 ms] 573.986 µs (39.1%)
tracing 2.022 ms [1.973 ms, 2.071 ms] 553.288 µs (37.7%)

AlexeyKuznetsov-DD
AlexeyKuznetsov-DD reviewed Jul 24, 2025
View reviewed changes
Comment thread ...-openjdk/src/main/java/com/datadog/profiling/controller/openjdk/events/SmapEntryFactory.java
Comment on lines +31 to +37
if (!JavaVirtualMachine.isJ9() && !JavaVirtualMachine.isOracleJDK8()) {
SMAP_ENTRY_EVENT_TYPE = EventType.getEventType(SmapEntryEvent.class);
AGGREGATED_SMAP_ENTRY_EVENT_TYPE = EventType.getEventType(AggregatedSmapEntryEvent.class);
} else {
SMAP_ENTRY_EVENT_TYPE = null;
AGGREGATED_SMAP_ENTRY_EVENT_TYPE = null;
}
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Small suggestion: maybe make sense to revert if block?
    if (isJ9() || isOracleJdk8() { ...set nulls...} else {set values}
  2. What is special about Oracle JDK8 compared to other vendors that we need to exclude it?
  3. I would put some comments around this explaining situation with JFR and JDKs.

Copy link
Copy Markdown
Contributor Author

@jbachorik jbachorik Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle JDK 8 has an old and commercial JFR implementation which does not really support to user events. It has some rudimentary support but the capabilities and the ways to register them are vastly different.

I think we should extract the logic out to a separate component - currently we have the similar logic in various places. Unfortunately, this is a very low priority task so it may take some time till we get there.

@jbachorik jbachorik merged commit a1e426c into master Jul 24, 2025
788 of 789 checks passed
@jbachorik jbachorik deleted the jb/smap_j9 branch July 24, 2025 07:26
@github-actions github-actions Bot added this to the 1.52.0 milestone Jul 24, 2025
@jbachorik
Copy link
Copy Markdown
Contributor Author

jbachorik commented Jul 24, 2025

@AlexeyKuznetsov-DD Thanks for the review. I hope this unblocks the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: profiling Profiling run-tests: semeru11 Run tests using Sumuru 11 JDK run-tests: semeru17 Run tests using Sumuru 17 JDK tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.52.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jbachorik @AlexeyKuznetsov-DD