Skip to content

Refactor the SmapEntry event generation#9215

Merged
jbachorik merged 3 commits intomasterfrom
jb/smap_refactoring
Jul 23, 2025
Merged

Refactor the SmapEntry event generation#9215
jbachorik merged 3 commits intomasterfrom
jb/smap_refactoring

Conversation

@jbachorik
Copy link
Copy Markdown
Contributor

@jbachorik jbachorik commented Jul 22, 2025 •
edited by atlassian Bot
Loading

What Does This Do

It is refactoring the Smap event generation code.

Motivation

The smap events were generated unreliably. Actually, because of a bug in the registration they even should not be generated but because this functionality is disabled by default we haven't even noticed.

The change is clearing up the code hierarchy and adds some more sanity tests that should capture an accidental breakage in the future.

Additional Notes

While working on this I also realized that the format of the JVM annotated map output had changed between Java 23 and 24 so I updated the implementation to correctly work with the updated format as well.

Contributor Checklist

Jira ticket: PROF-12168

@jbachorik jbachorik added tag: no release notes Changes to exclude from release notes type: refactoring comp: profiling Profiling labels Jul 22, 2025
@jbachorik jbachorik force-pushed the jb/smap_refactoring branch from dd32001 to d281e82 Compare July 22, 2025 15:36
@jbachorik jbachorik marked this pull request as ready for review July 22, 2025 15:56
@jbachorik jbachorik requested a review from a team as a code owner July 22, 2025 15:56
@jbachorik jbachorik requested a review from zhengyu123 July 22, 2025 15:56
@jbachorik jbachorik force-pushed the jb/smap_refactoring branch from d281e82 to 7dc0593 Compare July 22, 2025 16:02
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jul 22, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/smap_refactoring
git_commit_date 1753262181 1753265001
git_commit_sha 37a4462 5814a9b
release_version 1.51.1-SNAPSHOT~37a4462bcf 1.51.1-SNAPSHOT~5814a9b94d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1753267154 1753267154
ci_job_id 1042923108 1042923108
ci_pipeline_id 71426020 71426020
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-m3ux2rh7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-m3ux2rh7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~5814a9b94d, baseline=1.51.1-SNAPSHOT~37a4462bcf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059554
Total [baseline] (10.817 s) : 0, 10817396
Agent [candidate] (1.051 s) : 0, 1051113
Total [candidate] (10.765 s) : 0, 10764675
section appsec
Agent [baseline] (1.225 s) : 0, 1225375
Total [baseline] (10.864 s) : 0, 10863630
Agent [candidate] (1.217 s) : 0, 1217109
Total [candidate] (10.785 s) : 0, 10785254
section iast
Agent [baseline] (1.174 s) : 0, 1173552
Total [baseline] (10.894 s) : 0, 10893951
Agent [candidate] (1.181 s) : 0, 1181259
Total [candidate] (10.962 s) : 0, 10962204
section profiling
Agent [baseline] (1.195 s) : 0, 1194701
Total [baseline] (10.878 s) : 0, 10877931
Agent [candidate] (1.2 s) : 0, 1200360
Total [candidate] (10.943 s) : 0, 10942760
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.225 s 165.821 ms (15.7%)
Agent iast 1.174 s 113.999 ms (10.8%)
Agent profiling 1.195 s 135.148 ms (12.8%)
Total tracing 10.817 s -
Total appsec 10.864 s 46.234 ms (0.4%)
Total iast 10.894 s 76.555 ms (0.7%)
Total profiling 10.878 s 60.535 ms (0.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent appsec 1.217 s 165.996 ms (15.8%)
Agent iast 1.181 s 130.145 ms (12.4%)
Agent profiling 1.2 s 149.247 ms (14.2%)
Total tracing 10.765 s -
Total appsec 10.785 s 20.579 ms (0.2%)
Total iast 10.962 s 197.529 ms (1.8%)
Total profiling 10.943 s 178.085 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~5814a9b94d, baseline=1.51.1-SNAPSHOT~37a4462bcf

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (743.639 ms) : 0, 743639
BytebuddyAgent [candidate] (736.158 ms) : 0, 736158
GlobalTracer [baseline] (244.737 ms) : 0, 244737
GlobalTracer [candidate] (243.129 ms) : 0, 243129
AppSec [baseline] (30.901 ms) : 0, 30901
AppSec [candidate] (30.663 ms) : 0, 30663
Debugger [baseline] (6.051 ms) : 0, 6051
Debugger [candidate] (5.999 ms) : 0, 5999
Remote Config [baseline] (665.914 µs) : 0, 666
Remote Config [candidate] (660.082 µs) : 0, 660
Telemetry [baseline] (10.678 ms) : 0, 10678
Telemetry [candidate] (11.19 ms) : 0, 11190
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (756.058 ms) : 0, 756058
BytebuddyAgent [candidate] (750.921 ms) : 0, 750921
GlobalTracer [baseline] (235.895 ms) : 0, 235895
GlobalTracer [candidate] (234.509 ms) : 0, 234509
AppSec [baseline] (169.824 ms) : 0, 169824
AppSec [candidate] (170.219 ms) : 0, 170219
Debugger [baseline] (8.0 ms) : 0, 8000
Debugger [candidate] (6.362 ms) : 0, 6362
Remote Config [baseline] (648.794 µs) : 0, 649
Remote Config [candidate] (621.901 µs) : 0, 622
Telemetry [baseline] (8.412 ms) : 0, 8412
Telemetry [candidate] (8.246 ms) : 0, 8246
IAST [baseline] (23.764 ms) : 0, 23764
IAST [candidate] (23.515 ms) : 0, 23515
section iast
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (846.828 ms) : 0, 846828
BytebuddyAgent [candidate] (853.683 ms) : 0, 853683
GlobalTracer [baseline] (233.258 ms) : 0, 233258
GlobalTracer [candidate] (232.377 ms) : 0, 232377
AppSec [baseline] (25.798 ms) : 0, 25798
AppSec [candidate] (29.58 ms) : 0, 29580
Debugger [baseline] (8.352 ms) : 0, 8352
Debugger [candidate] (5.684 ms) : 0, 5684
Remote Config [baseline] (588.77 µs) : 0, 589
Remote Config [candidate] (584.134 µs) : 0, 584
Telemetry [baseline] (8.093 ms) : 0, 8093
Telemetry [candidate] (8.172 ms) : 0, 8172
IAST [baseline] (28.179 ms) : 0, 28179
IAST [candidate] (28.623 ms) : 0, 28623
section profiling
ProfilingAgent [baseline] (110.455 ms) : 0, 110455
ProfilingAgent [candidate] (109.017 ms) : 0, 109017
crashtracking [baseline] (1.409 ms) : 0, 1409
crashtracking [candidate] (1.413 ms) : 0, 1413
BytebuddyAgent [baseline] (760.697 ms) : 0, 760697
BytebuddyAgent [candidate] (765.093 ms) : 0, 765093
GlobalTracer [baseline] (221.289 ms) : 0, 221289
GlobalTracer [candidate] (222.233 ms) : 0, 222233
AppSec [baseline] (30.27 ms) : 0, 30270
AppSec [candidate] (30.574 ms) : 0, 30574
Debugger [baseline] (6.214 ms) : 0, 6214
Debugger [candidate] (6.277 ms) : 0, 6277
Remote Config [baseline] (678.551 µs) : 0, 679
Remote Config [candidate] (709.742 µs) : 0, 710
Telemetry [baseline] (15.07 ms) : 0, 15070
Telemetry [candidate] (16.115 ms) : 0, 16115
Profiling [baseline] (110.479 ms) : 0, 110479
Profiling [candidate] (109.042 ms) : 0, 109042
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~5814a9b94d, baseline=1.51.1-SNAPSHOT~37a4462bcf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042432
Total [baseline] (8.616 s) : 0, 8616343
Agent [candidate] (1.051 s) : 0, 1051494
Total [candidate] (8.623 s) : 0, 8623066
section iast
Agent [baseline] (1.179 s) : 0, 1178836
Total [baseline] (9.336 s) : 0, 9335918
Agent [candidate] (1.182 s) : 0, 1182161
Total [candidate] (9.274 s) : 0, 9274361
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent iast 1.179 s 136.403 ms (13.1%)
Total tracing 8.616 s -
Total iast 9.336 s 719.574 ms (8.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.182 s 130.667 ms (12.4%)
Total tracing 8.623 s -
Total iast 9.274 s 651.294 ms (7.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~5814a9b94d, baseline=1.51.1-SNAPSHOT~37a4462bcf

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (729.211 ms) : 0, 729211
BytebuddyAgent [candidate] (735.815 ms) : 0, 735815
GlobalTracer [baseline] (241.281 ms) : 0, 241281
GlobalTracer [candidate] (243.108 ms) : 0, 243108
AppSec [baseline] (30.307 ms) : 0, 30307
AppSec [candidate] (30.718 ms) : 0, 30718
Debugger [baseline] (5.981 ms) : 0, 5981
Debugger [candidate] (6.025 ms) : 0, 6025
Remote Config [baseline] (650.431 µs) : 0, 650
Remote Config [candidate] (671.549 µs) : 0, 672
Telemetry [baseline] (12.613 ms) : 0, 12613
Telemetry [candidate] (12.668 ms) : 0, 12668
section iast
crashtracking [baseline] (1.421 ms) : 0, 1421
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (851.242 ms) : 0, 851242
BytebuddyAgent [candidate] (854.72 ms) : 0, 854720
GlobalTracer [baseline] (232.167 ms) : 0, 232167
GlobalTracer [candidate] (232.673 ms) : 0, 232673
AppSec [baseline] (26.697 ms) : 0, 26697
AppSec [candidate] (27.246 ms) : 0, 27246
Debugger [baseline] (8.451 ms) : 0, 8451
Debugger [candidate] (5.731 ms) : 0, 5731
Remote Config [baseline] (599.718 µs) : 0, 600
Remote Config [candidate] (589.045 µs) : 0, 589
Telemetry [baseline] (8.108 ms) : 0, 8108
Telemetry [candidate] (8.128 ms) : 0, 8128
IAST [baseline] (29.203 ms) : 0, 29203
IAST [candidate] (30.581 ms) : 0, 30581
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/smap_refactoring
git_commit_date 1753262181 1753265001
git_commit_sha 37a4462 5814a9b
release_version 1.51.1-SNAPSHOT~37a4462bcf 1.51.1-SNAPSHOT~5814a9b94d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1753266840 1753266840
ci_job_id 1042923111 1042923111
ci_pipeline_id 71426020 71426020
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-dg0gtapq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-dg0gtapq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load worse
[+237.027µs; +622.500µs] or [+2.388%; +6.270%]		 unstable
[-70.447op/s; +32.197op/s] or [-15.059%; +6.882%]		 10.357ms 448.688op/s 9.928ms 467.812op/s
scenario:load:petclinic:tracing:high_load worse
[+1.931ms; +2.737ms] or [+4.580%; +6.493%]		 unstable
[-13.647op/s; +2.172op/s] or [-12.295%; +1.957%]		 44.480ms 105.263op/s 42.146ms 111.000op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~5814a9b94d, baseline=1.51.1-SNAPSHOT~37a4462bcf
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.141 ms) : 36835, 37448
.   : milestone, 37141,
appsec (48.449 ms) : 48014, 48883
.   : milestone, 48449,
code_origins (44.452 ms) : 44072, 44831
.   : milestone, 44452,
iast (46.12 ms) : 45732, 46507
.   : milestone, 46120,
profiling (49.847 ms) : 49394, 50300
.   : milestone, 49847,
tracing (42.146 ms) : 41794, 42499
.   : milestone, 42146,
section candidate
no_agent (37.324 ms) : 37018, 37630
.   : milestone, 37324,
appsec (47.219 ms) : 46807, 47630
.   : milestone, 47219,
code_origins (45.595 ms) : 45204, 45987
.   : milestone, 45595,
iast (45.679 ms) : 45287, 46070
.   : milestone, 45679,
profiling (48.37 ms) : 47927, 48812
.   : milestone, 48370,
tracing (44.48 ms) : 44084, 44876
.   : milestone, 44480,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.141 ms [36.835 ms, 37.448 ms] -
appsec 48.449 ms [48.014 ms, 48.883 ms] 11.307 ms (30.4%)
code_origins 44.452 ms [44.072 ms, 44.831 ms] 7.311 ms (19.7%)
iast 46.12 ms [45.732 ms, 46.507 ms] 8.979 ms (24.2%)
profiling 49.847 ms [49.394 ms, 50.3 ms] 12.706 ms (34.2%)
tracing 42.146 ms [41.794 ms, 42.499 ms] 5.005 ms (13.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.324 ms [37.018 ms, 37.63 ms] -
appsec 47.219 ms [46.807 ms, 47.63 ms] 9.895 ms (26.5%)
code_origins 45.595 ms [45.204 ms, 45.987 ms] 8.272 ms (22.2%)
iast 45.679 ms [45.287 ms, 46.07 ms] 8.355 ms (22.4%)
profiling 48.37 ms [47.927 ms, 48.812 ms] 11.046 ms (29.6%)
tracing 44.48 ms [44.084 ms, 44.876 ms] 7.156 ms (19.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~5814a9b94d, baseline=1.51.1-SNAPSHOT~37a4462bcf
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.343 ms) : 4287, 4399
.   : milestone, 4343,
iast (9.145 ms) : 8997, 9293
.   : milestone, 9145,
iast_FULL (13.951 ms) : 13675, 14228
.   : milestone, 13951,
iast_GLOBAL (9.928 ms) : 9753, 10102
.   : milestone, 9928,
profiling (8.658 ms) : 8516, 8800
.   : milestone, 8658,
tracing (7.506 ms) : 7393, 7619
.   : milestone, 7506,
section candidate
no_agent (4.396 ms) : 4346, 4445
.   : milestone, 4396,
iast (9.149 ms) : 9000, 9298
.   : milestone, 9149,
iast_FULL (14.006 ms) : 13723, 14288
.   : milestone, 14006,
iast_GLOBAL (10.357 ms) : 10174, 10541
.   : milestone, 10357,
profiling (8.836 ms) : 8699, 8973
.   : milestone, 8836,
tracing (7.441 ms) : 7338, 7545
.   : milestone, 7441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.343 ms [4.287 ms, 4.399 ms] -
iast 9.145 ms [8.997 ms, 9.293 ms] 4.802 ms (110.6%)
iast_FULL 13.951 ms [13.675 ms, 14.228 ms] 9.608 ms (221.2%)
iast_GLOBAL 9.928 ms [9.753 ms, 10.102 ms] 5.584 ms (128.6%)
profiling 8.658 ms [8.516 ms, 8.8 ms] 4.315 ms (99.3%)
tracing 7.506 ms [7.393 ms, 7.619 ms] 3.162 ms (72.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.396 ms [4.346 ms, 4.445 ms] -
iast 9.149 ms [9.0 ms, 9.298 ms] 4.753 ms (108.1%)
iast_FULL 14.006 ms [13.723 ms, 14.288 ms] 9.61 ms (218.6%)
iast_GLOBAL 10.357 ms [10.174 ms, 10.541 ms] 5.962 ms (135.6%)
profiling 8.836 ms [8.699 ms, 8.973 ms] 4.44 ms (101.0%)
tracing 7.441 ms [7.338 ms, 7.545 ms] 3.046 ms (69.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/smap_refactoring
git_commit_date 1753262181 1753265001
git_commit_sha 37a4462 5814a9b
release_version 1.51.1-SNAPSHOT~37a4462bcf 1.51.1-SNAPSHOT~5814a9b94d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1753267346 1753267346
ci_job_id 1042923113 1042923113
ci_pipeline_id 71426020 71426020
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-qq998lwh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-qq998lwh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~5814a9b94d, baseline=1.51.1-SNAPSHOT~37a4462bcf
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.398 s) : 15398000, 15398000
.   : milestone, 15398000,
appsec (14.822 s) : 14822000, 14822000
.   : milestone, 14822000,
iast (18.171 s) : 18171000, 18171000
.   : milestone, 18171000,
iast_GLOBAL (18.164 s) : 18164000, 18164000
.   : milestone, 18164000,
profiling (15.318 s) : 15318000, 15318000
.   : milestone, 15318000,
tracing (15.073 s) : 15073000, 15073000
.   : milestone, 15073000,
section candidate
no_agent (15.003 s) : 15003000, 15003000
.   : milestone, 15003000,
appsec (14.716 s) : 14716000, 14716000
.   : milestone, 14716000,
iast (18.698 s) : 18698000, 18698000
.   : milestone, 18698000,
iast_GLOBAL (17.719 s) : 17719000, 17719000
.   : milestone, 17719000,
profiling (15.345 s) : 15345000, 15345000
.   : milestone, 15345000,
tracing (15.241 s) : 15241000, 15241000
.   : milestone, 15241000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.398 s [15.398 s, 15.398 s] -
appsec 14.822 s [14.822 s, 14.822 s] -576.0 ms (-3.7%)
iast 18.171 s [18.171 s, 18.171 s] 2.773 s (18.0%)
iast_GLOBAL 18.164 s [18.164 s, 18.164 s] 2.766 s (18.0%)
profiling 15.318 s [15.318 s, 15.318 s] -80.0 ms (-0.5%)
tracing 15.073 s [15.073 s, 15.073 s] -325.0 ms (-2.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.003 s [15.003 s, 15.003 s] -
appsec 14.716 s [14.716 s, 14.716 s] -287.0 ms (-1.9%)
iast 18.698 s [18.698 s, 18.698 s] 3.695 s (24.6%)
iast_GLOBAL 17.719 s [17.719 s, 17.719 s] 2.716 s (18.1%)
profiling 15.345 s [15.345 s, 15.345 s] 342.0 ms (2.3%)
tracing 15.241 s [15.241 s, 15.241 s] 238.0 ms (1.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~5814a9b94d, baseline=1.51.1-SNAPSHOT~37a4462bcf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1478
.   : milestone, 1467,
appsec (2.452 ms) : 2399, 2505
.   : milestone, 2452,
iast (2.183 ms) : 2121, 2246
.   : milestone, 2183,
iast_GLOBAL (2.22 ms) : 2157, 2282
.   : milestone, 2220,
profiling (2.017 ms) : 1968, 2067
.   : milestone, 2017,
tracing (1.989 ms) : 1940, 2037
.   : milestone, 1989,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (3.601 ms) : 3385, 3816
.   : milestone, 3601,
iast (2.18 ms) : 2117, 2243
.   : milestone, 2180,
iast_GLOBAL (2.221 ms) : 2159, 2284
.   : milestone, 2221,
profiling (2.043 ms) : 1992, 2094
.   : milestone, 2043,
tracing (2.0 ms) : 1951, 2048
.   : milestone, 2000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.478 ms] -
appsec 2.452 ms [2.399 ms, 2.505 ms] 985.115 µs (67.2%)
iast 2.183 ms [2.121 ms, 2.246 ms] 716.436 µs (48.8%)
iast_GLOBAL 2.22 ms [2.157 ms, 2.282 ms] 752.839 µs (51.3%)
profiling 2.017 ms [1.968 ms, 2.067 ms] 550.281 µs (37.5%)
tracing 1.989 ms [1.94 ms, 2.037 ms] 521.646 µs (35.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 3.601 ms [3.385 ms, 3.816 ms] 2.134 ms (145.5%)
iast 2.18 ms [2.117 ms, 2.243 ms] 713.519 µs (48.7%)
iast_GLOBAL 2.221 ms [2.159 ms, 2.284 ms] 754.871 µs (51.5%)
profiling 2.043 ms [1.992 ms, 2.094 ms] 576.328 µs (39.3%)
tracing 2.0 ms [1.951 ms, 2.048 ms] 533.312 µs (36.4%)

zhengyu123
zhengyu123 approved these changes Jul 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit. Otherwise, LGTM

Comment thread ...er-openjdk/src/main/java/com/datadog/profiling/controller/openjdk/events/SmapEntryCache.java Outdated
@jbachorik jbachorik force-pushed the jb/smap_refactoring branch from 7dc0593 to 9fc47f8 Compare July 23, 2025 06:08
@jbachorik jbachorik enabled auto-merge (squash) July 23, 2025 10:58
@jbachorik jbachorik merged commit 6fc7077 into master Jul 23, 2025
670 of 671 checks passed
@jbachorik jbachorik deleted the jb/smap_refactoring branch July 23, 2025 10:59
@github-actions github-actions Bot added this to the 1.52.0 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhengyu123 zhengyu123 zhengyu123 approved these changes

Assignees

No one assigned

Labels

comp: profiling Profiling tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.52.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jbachorik @zhengyu123