Skip to content

Implement Failed Test Replay #9214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-mohedano merged 46 commits into from
Sep 9, 2025
Merged

Implement Failed Test Replay #9214

Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
2c219fd
add `di_enabled` to settings response
daniel-mohedano Jul 4, 2025
a911ae0
add FTR related metrics
daniel-mohedano Jul 4, 2025
d20159e
add FTR to execution settings
daniel-mohedano Jul 4, 2025
c4c84d6
add basic exception replay integration in agent mode
daniel-mohedano Jul 14, 2025
ae31670
feat: headless and agentless changes
daniel-mohedano Jul 22, 2025
4f2d6a9
Merge branch 'master' into daniel.mohedano/failed-test-replay
daniel-mohedano Jul 22, 2025
c7eeac8
fix: tests
daniel-mohedano Jul 23, 2025
14cf11c
fix: testng capabilities
daniel-mohedano Aug 4, 2025
461fb1f
feat: refactor agentless intakes
daniel-mohedano Aug 6, 2025
14b1054
Merge branch 'master' into daniel.mohedano/failed-test-replay
daniel-mohedano Aug 6, 2025
a87eff0
chore: update smoke test fixtures
daniel-mohedano Aug 6, 2025
19b4edf
test: add unit test for new Intake enum
daniel-mohedano Aug 6, 2025
9e81cc7
test: remove ftr from instrumentation tests (not used)
daniel-mohedano Aug 6, 2025
4e3deb4
test: introduce FTR smoke tests for headfull and headless modes
daniel-mohedano Aug 11, 2025
f931654
style: spotless and codenarc
daniel-mohedano Aug 11, 2025
eacde60
feat: add test event finished FTR telemetry
daniel-mohedano Aug 11, 2025
0228f71
feat: add `product` field to snapshots
daniel-mohedano Aug 11, 2025
88fd665
feat: implement SuiteEnd listener for sink flushing
daniel-mohedano Aug 11, 2025
ec9c54d
feat: introduce new config variables for debugger
daniel-mohedano Aug 12, 2025
d4d2432
chore: remove todo
daniel-mohedano Aug 19, 2025
ffda9b3
Merge branch 'master' into daniel.mohedano/failed-test-replay
daniel-mohedano Aug 19, 2025
49eaebf
feat: align FTR settings with JS' implementation
daniel-mohedano Aug 21, 2025
b4cef2c
feat: PR suggestions
daniel-mohedano Aug 22, 2025
d82a7fa
feat: implement debugger config bridge
daniel-mohedano Aug 27, 2025
ab8d8e9
fix: move check from policy to history for FTR
daniel-mohedano Aug 27, 2025
bd81769
fix: tests
daniel-mohedano Aug 27, 2025
c257390
chore: update codeowners
daniel-mohedano Aug 27, 2025
73bf81d
Merge branch 'master' into daniel.mohedano/failed-test-replay
daniel-mohedano Aug 27, 2025
3a89ca3
test: better unit tests
daniel-mohedano Sep 1, 2025
54dbb03
Merge branch 'master' into daniel.mohedano/failed-test-replay
daniel-mohedano Sep 1, 2025
a1f58f3
fix: add CI Intake back
daniel-mohedano Sep 1, 2025
719a934
style: spotless
daniel-mohedano Sep 1, 2025
b223a21
fix: tests
daniel-mohedano Sep 1, 2025
58a096b
fix: correct intake usage
daniel-mohedano Sep 1, 2025
920421a
fix: change info to debug log
daniel-mohedano Sep 3, 2025
2852d25
feat: move away from deferred queue in favor of merging updates
daniel-mohedano Sep 3, 2025
d80e531
fix: pr suggestions
daniel-mohedano Sep 4, 2025
34cf624
feat: refactor FTR logic into it's own exceptiondebugger implementation
daniel-mohedano Sep 4, 2025
887350f
fix: jacoco coverage
daniel-mohedano Sep 4, 2025
f1f1264
fix: remove snapshot product and async instrumentation config
daniel-mohedano Sep 8, 2025
8e145f4
fix: remove sync config test
daniel-mohedano Sep 8, 2025
bb06f75
Merge branch 'master' into daniel.mohedano/failed-test-replay
daniel-mohedano Sep 8, 2025
098b929
fix: add history on test start
daniel-mohedano Sep 8, 2025
a56d10f
fix: use synchronized instead of atomic refs in bridge
daniel-mohedano Sep 8, 2025
f32dcef
fix: abstract repeated smoke test logic
daniel-mohedano Sep 8, 2025
ea090f9
fix: synchronization on bridge
daniel-mohedano Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: synchronization on bridge
  • Loading branch information
@daniel-mohedano
daniel-mohedano committed Sep 9, 2025
commit ea090f98cffa2d3e8199d026f9506166f7d7ce59
27 changes: 15 additions & 12 deletions internal-api/src/main/java/datadog/trace/api/debugger/DebuggerConfigBridge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,43 +28,46 @@ public static synchronized void updateConfig(DebuggerConfigUpdate update) {
public static synchronized void setUpdater(@Nonnull DebuggerConfigUpdater updater) {
UPDATER = updater;
if (DEFERRED_UPDATE != null && DEFERRED_UPDATE.hasUpdates()) {
DebuggerConfigUpdate toApply = DEFERRED_UPDATE;
LOGGER.debug("Processing deferred update {}", DEFERRED_UPDATE);
updater.updateConfig(DEFERRED_UPDATE);
DEFERRED_UPDATE = null;
LOGGER.debug("Processing deferred update {}", toApply);
updater.updateConfig(toApply);
}
}

// for testing purposes
static void reset() {
static synchronized void reset() {
UPDATER = null;
DEFERRED_UPDATE = null;
Copy link
Copy Markdown
Member

@jpbempel jpbempel Sep 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even this can be problematic for test. the null assigned to DEFERRED_UPDATE can be non-visible for other threads

}

public static boolean isDynamicInstrumentationEnabled() {
if (UPDATER != null) {
return UPDATER.isDynamicInstrumentationEnabled();
DebuggerConfigUpdater updater = UPDATER;
if (updater != null) {
return updater.isDynamicInstrumentationEnabled();
}
Comment on lines +44 to +47
Copy link
Copy Markdown
Member

@jpbempel jpbempel Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need local variable, UPDATER field can be updated in the middle

return Config.get().isDynamicInstrumentationEnabled();
}

public static boolean isExceptionReplayEnabled() {
if (UPDATER != null) {
return UPDATER.isExceptionReplayEnabled();
DebuggerConfigUpdater updater = UPDATER;
if (updater != null) {
return updater.isExceptionReplayEnabled();
}
return Config.get().isDebuggerExceptionEnabled();
}

public static boolean isCodeOriginEnabled() {
if (UPDATER != null) {
return UPDATER.isCodeOriginEnabled();
DebuggerConfigUpdater updater = UPDATER;
if (updater != null) {
return updater.isCodeOriginEnabled();
}
return Config.get().isDebuggerCodeOriginEnabled();
}

public static boolean isDistributedDebuggerEnabled() {
if (UPDATER != null) {
return UPDATER.isDistributedDebuggerEnabled();
DebuggerConfigUpdater updater = UPDATER;
if (updater != null) {
return updater.isDistributedDebuggerEnabled();
}
return Config.get().isDistributedDebuggerEnabled();
}
Expand Down