KTLO: Removed unused imports. by AlexeyKuznetsov-DD · Pull Request #9035 · DataDog/dd-trace-java

AlexeyKuznetsov-DD · 2025-06-25T18:31:45Z

What Does This Do

Code cleanup by removing unused imports.

Motivation

KTLO: Clean code.

Additional Notes

Detected by IDEA inspection "Unused imports"

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-06-25T18:54:02Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1750876897	1750877268
end_time	2025-06-25T18:42:58	2025-06-25T18:49:08
git_branch	master	alexeyk/ktlo-unused-imports
git_commit_sha	`d6d3d21`	`7fb8694`
start_time	2025-06-25T18:41:38	2025-06-25T18:47:49

See matching parameters

	Baseline	Candidate
ci_job_id	998803628	998803628
ci_pipeline_id	68775329	68775329
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1750876123	1750876123

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	worse [+199.378µs; +300.503µs] or [+1.979%; +2.983%]	worse [+208.763µs; +324.322µs] or [+2.041%; +3.171%]	worse [+198.583µs; +330.510µs] or [+1.925%; +3.204%]	worse [+172.735µs; +490.749µs] or [+1.631%; +4.635%]	worse [-3.187op/s; -1.371op/s] or [-3.298%; -1.419%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-33.319µs; +16.504µs] or [-11.751%; +5.821%]	unstable [-46.581µs; +25.840µs] or [-14.378%; +7.976%]	unstable [-57.677µs; +35.930µs] or [-17.004%; +10.593%]	unstable [-132.316µs; +92.385µs] or [-13.305%; +9.290%]	same
scenario:basic	unsure [-10.940µs; -2.565µs] or [-3.844%; -0.901%]	same	same	unstable [-131.095µs; +8.551µs] or [-15.203%; +0.992%]	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (323.978 µs) : 285, 363
.   : milestone, 324,
basic (314.287 µs) : 305, 324
.   : milestone, 314,
loop (10.229 ms) : 10201, 10257
.   : milestone, 10229,
section candidate
noprobe (313.607 µs) : 284, 343
.   : milestone, 314,
basic (307.936 µs) : 299, 317
.   : milestone, 308,
loop (10.496 ms) : 10425, 10566
.   : milestone, 10496,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	323.978 µs [285.348 µs, 362.609 µs]
basic	314.287 µs [304.772 µs, 323.802 µs]
loop	10.229 ms [10.201 ms, 10.257 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	313.607 µs [283.862 µs, 343.353 µs]
basic	307.936 µs [299.272 µs, 316.6 µs]
loop	10.496 ms [10.425 ms, 10.566 ms]

pr-commenter · 2025-06-25T19:03:03Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/ktlo-unused-imports
git_commit_date	1750865797	1750876123
git_commit_sha	`d6d3d21`	`7fb8694`
release_version	1.51.0-SNAPSHOT~d6d3d210b1	1.51.0-SNAPSHOT~7fb86942f9

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1750878138	1750878138
ci_job_id	998803617	998803617
ci_pipeline_id	68775329	68775329
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-vvzzugvx-project-304-concurrent-0-2wxpjrb6 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-vvzzugvx-project-304-concurrent-0-2wxpjrb6 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~7fb86942f9, baseline=1.51.0-SNAPSHOT~d6d3d210b1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.002 s) : 0, 1002238
Total [baseline] (10.811 s) : 0, 10811260
Agent [candidate] (997.44 ms) : 0, 997440
Total [candidate] (10.698 s) : 0, 10697868
section appsec
Agent [baseline] (1.176 s) : 0, 1176151
Total [baseline] (10.816 s) : 0, 10816383
Agent [candidate] (1.172 s) : 0, 1171819
Total [candidate] (10.752 s) : 0, 10751795
section iast
Agent [baseline] (1.144 s) : 0, 1144287
Total [baseline] (11.027 s) : 0, 11027162
Agent [candidate] (1.132 s) : 0, 1131836
Total [candidate] (10.897 s) : 0, 10896695
section profiling
Agent [baseline] (1.251 s) : 0, 1251232
Total [baseline] (11.048 s) : 0, 11048470
Agent [candidate] (1.254 s) : 0, 1253655
Total [candidate] (11.099 s) : 0, 11099498

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.002 s	-
Agent	appsec	1.176 s	173.913 ms (17.4%)
Agent	iast	1.144 s	142.049 ms (14.2%)
Agent	profiling	1.251 s	248.994 ms (24.8%)
Total	tracing	10.811 s	-
Total	appsec	10.816 s	5.123 ms (0.0%)
Total	iast	11.027 s	215.902 ms (2.0%)
Total	profiling	11.048 s	237.21 ms (2.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	997.44 ms	-
Agent	appsec	1.172 s	174.379 ms (17.5%)
Agent	iast	1.132 s	134.396 ms (13.5%)
Agent	profiling	1.254 s	256.215 ms (25.7%)
Total	tracing	10.698 s	-
Total	appsec	10.752 s	53.927 ms (0.5%)
Total	iast	10.897 s	198.828 ms (1.9%)
Total	profiling	11.099 s	401.63 ms (3.8%)

gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~7fb86942f9, baseline=1.51.0-SNAPSHOT~d6d3d210b1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.745 ms) : 0, 691745
BytebuddyAgent [candidate] (688.13 ms) : 0, 688130
GlobalTracer [baseline] (243.915 ms) : 0, 243915
GlobalTracer [candidate] (242.971 ms) : 0, 242971
AppSec [baseline] (30.611 ms) : 0, 30611
AppSec [candidate] (30.489 ms) : 0, 30489
Debugger [baseline] (6.074 ms) : 0, 6074
Debugger [candidate] (6.059 ms) : 0, 6059
Remote Config [baseline] (674.59 µs) : 0, 675
Remote Config [candidate] (672.757 µs) : 0, 673
Telemetry [baseline] (8.278 ms) : 0, 8278
Telemetry [candidate] (8.234 ms) : 0, 8234
section appsec
BytebuddyAgent [baseline] (711.923 ms) : 0, 711923
BytebuddyAgent [candidate] (709.047 ms) : 0, 709047
GlobalTracer [baseline] (236.869 ms) : 0, 236869
GlobalTracer [candidate] (235.588 ms) : 0, 235588
AppSec [baseline] (169.843 ms) : 0, 169843
AppSec [candidate] (169.891 ms) : 0, 169891
Debugger [baseline] (5.791 ms) : 0, 5791
Debugger [candidate] (5.768 ms) : 0, 5768
Remote Config [baseline] (608.274 µs) : 0, 608
Remote Config [candidate] (594.472 µs) : 0, 594
Telemetry [baseline] (8.134 ms) : 0, 8134
Telemetry [candidate] (8.046 ms) : 0, 8046
IAST [baseline] (22.144 ms) : 0, 22144
IAST [candidate] (22.116 ms) : 0, 22116
section iast
BytebuddyAgent [baseline] (816.928 ms) : 0, 816928
BytebuddyAgent [candidate] (807.835 ms) : 0, 807835
GlobalTracer [baseline] (235.642 ms) : 0, 235642
GlobalTracer [candidate] (233.083 ms) : 0, 233083
AppSec [baseline] (26.338 ms) : 0, 26338
AppSec [candidate] (26.872 ms) : 0, 26872
Debugger [baseline] (5.899 ms) : 0, 5899
Debugger [candidate] (5.8 ms) : 0, 5800
Remote Config [baseline] (595.753 µs) : 0, 596
Remote Config [candidate] (585.657 µs) : 0, 586
Telemetry [baseline] (8.086 ms) : 0, 8086
Telemetry [candidate] (7.897 ms) : 0, 7897
IAST [baseline] (29.867 ms) : 0, 29867
IAST [candidate] (28.985 ms) : 0, 28985
section profiling
BytebuddyAgent [baseline] (681.953 ms) : 0, 681953
BytebuddyAgent [candidate] (683.408 ms) : 0, 683408
GlobalTracer [baseline] (362.735 ms) : 0, 362735
GlobalTracer [candidate] (363.704 ms) : 0, 363704
AppSec [baseline] (31.707 ms) : 0, 31707
AppSec [candidate] (31.859 ms) : 0, 31859
Debugger [baseline] (11.304 ms) : 0, 11304
Debugger [candidate] (11.375 ms) : 0, 11375
Remote Config [baseline] (674.68 µs) : 0, 675
Remote Config [candidate] (673.711 µs) : 0, 674
Telemetry [baseline] (9.582 ms) : 0, 9582
Telemetry [candidate] (9.556 ms) : 0, 9556
ProfilingAgent [baseline] (104.449 ms) : 0, 104449
ProfilingAgent [candidate] (104.11 ms) : 0, 104110
Profiling [baseline] (104.473 ms) : 0, 104473
Profiling [candidate] (104.135 ms) : 0, 104135

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~7fb86942f9, baseline=1.51.0-SNAPSHOT~d6d3d210b1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (996.085 ms) : 0, 996085
Total [baseline] (8.59 s) : 0, 8589681
Agent [candidate] (998.88 ms) : 0, 998880
Total [candidate] (8.596 s) : 0, 8595933
section iast
Agent [baseline] (1.13 s) : 0, 1130400
Total [baseline] (9.315 s) : 0, 9315028
Agent [candidate] (1.131 s) : 0, 1131045
Total [candidate] (9.274 s) : 0, 9274481

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	996.085 ms	-
Agent	iast	1.13 s	134.315 ms (13.5%)
Total	tracing	8.59 s	-
Total	iast	9.315 s	725.347 ms (8.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	998.88 ms	-
Agent	iast	1.131 s	132.165 ms (13.2%)
Total	tracing	8.596 s	-
Total	iast	9.274 s	678.547 ms (7.9%)

gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~7fb86942f9, baseline=1.51.0-SNAPSHOT~d6d3d210b1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.671 ms) : 0, 687671
BytebuddyAgent [candidate] (689.478 ms) : 0, 689478
GlobalTracer [baseline] (242.364 ms) : 0, 242364
GlobalTracer [candidate] (243.09 ms) : 0, 243090
AppSec [baseline] (30.294 ms) : 0, 30294
AppSec [candidate] (30.441 ms) : 0, 30441
Debugger [baseline] (6.078 ms) : 0, 6078
Debugger [candidate] (6.083 ms) : 0, 6083
Remote Config [baseline] (673.596 µs) : 0, 674
Remote Config [candidate] (677.188 µs) : 0, 677
Telemetry [baseline] (8.19 ms) : 0, 8190
Telemetry [candidate] (8.263 ms) : 0, 8263
section iast
BytebuddyAgent [baseline] (806.876 ms) : 0, 806876
BytebuddyAgent [candidate] (807.728 ms) : 0, 807728
GlobalTracer [baseline] (232.408 ms) : 0, 232408
GlobalTracer [candidate] (232.663 ms) : 0, 232663
AppSec [baseline] (28.65 ms) : 0, 28650
AppSec [candidate] (28.285 ms) : 0, 28285
Debugger [baseline] (5.823 ms) : 0, 5823
Debugger [candidate] (5.781 ms) : 0, 5781
Remote Config [baseline] (582.84 µs) : 0, 583
Remote Config [candidate] (579.258 µs) : 0, 579
Telemetry [baseline] (8.029 ms) : 0, 8029
Telemetry [candidate] (8.024 ms) : 0, 8024
IAST [baseline] (27.275 ms) : 0, 27275
IAST [candidate] (27.111 ms) : 0, 27111

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/ktlo-unused-imports
git_commit_date	1750865797	1750876123
git_commit_sha	`d6d3d21`	`7fb8694`
release_version	1.51.0-SNAPSHOT~d6d3d210b1	1.51.0-SNAPSHOT~7fb86942f9

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1750877821	1750877821
ci_job_id	998803619	998803619
ci_pipeline_id	68775329	68775329
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-vvzzugvx-project-304-concurrent-1-0ee97sci 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-vvzzugvx-project-304-concurrent-1-0ee97sci 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	worse [+390.413µs; +712.351µs] or [+4.587%; +8.369%]	unstable [-107.896op/s; +42.271op/s] or [-19.809%; +7.761%]	9.063ms	511.875op/s	8.512ms	544.688op/s
scenario:load:insecure-bank:iast:high_load	worse [+297.140µs; +631.825µs] or [+3.191%; +6.785%]	unstable [-89.652op/s; +42.402op/s] or [-17.985%; +8.506%]	9.777ms	474.844op/s	9.312ms	498.469op/s
scenario:load:petclinic:profiling:high_load	worse [+1.475ms; +2.417ms] or [+3.145%; +5.155%]	unstable [-10.921op/s; +3.071op/s] or [-10.943%; +3.078%]	48.832ms	95.875op/s	46.886ms	99.800op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~7fb86942f9, baseline=1.51.0-SNAPSHOT~d6d3d210b1
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.333 ms) : 4284, 4381
.   : milestone, 4333,
iast (9.312 ms) : 9159, 9465
.   : milestone, 9312,
iast_FULL (13.832 ms) : 13561, 14102
.   : milestone, 13832,
iast_GLOBAL (10.065 ms) : 9890, 10240
.   : milestone, 10065,
profiling (8.512 ms) : 8371, 8652
.   : milestone, 8512,
tracing (7.499 ms) : 7394, 7603
.   : milestone, 7499,
section candidate
no_agent (4.443 ms) : 4388, 4499
.   : milestone, 4443,
iast (9.777 ms) : 9619, 9935
.   : milestone, 9777,
iast_FULL (13.947 ms) : 13669, 14225
.   : milestone, 13947,
iast_GLOBAL (10.072 ms) : 9894, 10250
.   : milestone, 10072,
profiling (9.063 ms) : 8905, 9221
.   : milestone, 9063,
tracing (7.702 ms) : 7590, 7814
.   : milestone, 7702,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.333 ms [4.284 ms, 4.381 ms]	-
iast	9.312 ms [9.159 ms, 9.465 ms]	4.98 ms (114.9%)
iast_FULL	13.832 ms [13.561 ms, 14.102 ms]	9.499 ms (219.2%)
iast_GLOBAL	10.065 ms [9.89 ms, 10.24 ms]	5.732 ms (132.3%)
profiling	8.512 ms [8.371 ms, 8.652 ms]	4.179 ms (96.5%)
tracing	7.499 ms [7.394 ms, 7.603 ms]	3.166 ms (73.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.443 ms [4.388 ms, 4.499 ms]	-
iast	9.777 ms [9.619 ms, 9.935 ms]	5.333 ms (120.0%)
iast_FULL	13.947 ms [13.669 ms, 14.225 ms]	9.504 ms (213.9%)
iast_GLOBAL	10.072 ms [9.894 ms, 10.25 ms]	5.629 ms (126.7%)
profiling	9.063 ms [8.905 ms, 9.221 ms]	4.619 ms (104.0%)
tracing	7.702 ms [7.59 ms, 7.814 ms]	3.259 ms (73.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~7fb86942f9, baseline=1.51.0-SNAPSHOT~d6d3d210b1
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.125 ms) : 36819, 37432
.   : milestone, 37125,
appsec (48.272 ms) : 47839, 48706
.   : milestone, 48272,
code_origins (45.544 ms) : 45178, 45910
.   : milestone, 45544,
iast (44.288 ms) : 43897, 44679
.   : milestone, 44288,
profiling (46.886 ms) : 46464, 47309
.   : milestone, 46886,
tracing (42.781 ms) : 42423, 43139
.   : milestone, 42781,
section candidate
no_agent (36.285 ms) : 35988, 36583
.   : milestone, 36285,
appsec (47.916 ms) : 47483, 48349
.   : milestone, 47916,
code_origins (45.264 ms) : 44882, 45645
.   : milestone, 45264,
iast (44.982 ms) : 44583, 45382
.   : milestone, 44982,
profiling (48.832 ms) : 48380, 49284
.   : milestone, 48832,
tracing (43.549 ms) : 43187, 43911
.   : milestone, 43549,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.125 ms [36.819 ms, 37.432 ms]	-
appsec	48.272 ms [47.839 ms, 48.706 ms]	11.147 ms (30.0%)
code_origins	45.544 ms [45.178 ms, 45.91 ms]	8.418 ms (22.7%)
iast	44.288 ms [43.897 ms, 44.679 ms]	7.163 ms (19.3%)
profiling	46.886 ms [46.464 ms, 47.309 ms]	9.761 ms (26.3%)
tracing	42.781 ms [42.423 ms, 43.139 ms]	5.655 ms (15.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.285 ms [35.988 ms, 36.583 ms]	-
appsec	47.916 ms [47.483 ms, 48.349 ms]	11.631 ms (32.1%)
code_origins	45.264 ms [44.882 ms, 45.645 ms]	8.979 ms (24.7%)
iast	44.982 ms [44.583 ms, 45.382 ms]	8.697 ms (24.0%)
profiling	48.832 ms [48.38 ms, 49.284 ms]	12.547 ms (34.6%)
tracing	43.549 ms [43.187 ms, 43.911 ms]	7.264 ms (20.0%)

Dacapo

KTLO: Removed unused imports.

7fb8694

AlexeyKuznetsov-DD self-assigned this Jun 25, 2025

AlexeyKuznetsov-DD added type: enhancement Enhancements and improvements comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Jun 25, 2025

AlexeyKuznetsov-DD marked this pull request as ready for review June 25, 2025 18:36

AlexeyKuznetsov-DD requested review from a team as code owners June 25, 2025 18:36

AlexeyKuznetsov-DD requested a review from PerfectSlayer June 25, 2025 18:36

sarahchen6 approved these changes Jun 25, 2025

View reviewed changes

PerfectSlayer approved these changes Jun 26, 2025

View reviewed changes

Comment thread dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/CodeOriginProbe.java

PerfectSlayer added type: refactoring and removed type: enhancement Enhancements and improvements labels Jun 26, 2025

AlexeyKuznetsov-DD merged commit df6adb3 into master Jun 26, 2025
521 checks passed

AlexeyKuznetsov-DD deleted the alexeyk/ktlo-unused-imports branch June 26, 2025 19:11

github-actions Bot added this to the 1.51.0 milestone Jun 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KTLO: Removed unused imports.#9035

KTLO: Removed unused imports.#9035
AlexeyKuznetsov-DD merged 1 commit intomasterfrom
alexeyk/ktlo-unused-imports

AlexeyKuznetsov-DD commented Jun 25, 2025

Uh oh!

pr-commenter Bot commented Jun 25, 2025

Uh oh!

pr-commenter Bot commented Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

AlexeyKuznetsov-DD commented Jun 25, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter Bot commented Jun 25, 2025

Debugger benchmarks

Parameters

Summary

Uh oh!

pr-commenter Bot commented Jun 25, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants