Remove top-level maven pom.properties of vendored packages#8760
Merged
Remove top-level maven pom.properties of vendored packages#8760
Conversation
…uld trigger unwanted framework checks Also remove some empty 'META-INF/versions' directories leftover from vendoring SnakeYaml
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~b4ed821ccc, baseline=1.49.0-SNAPSHOT~5a04e8c591
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.005 s) : 0, 1005251
Total [baseline] (8.656 s) : 0, 8656460
Agent [candidate] (1.006 s) : 0, 1006344
Total [candidate] (8.648 s) : 0, 8648118
section iast
Agent [baseline] (1.136 s) : 0, 1135600
Total [baseline] (9.202 s) : 0, 9201949
Agent [candidate] (1.137 s) : 0, 1136902
Total [candidate] (9.228 s) : 0, 9228319
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.144 s) : 0, 1144003
Total [baseline] (9.263 s) : 0, 9262802
Agent [candidate] (1.137 s) : 0, 1136681
Total [candidate] (9.184 s) : 0, 9184354
section iast_TELEMETRY_OFF
Agent [baseline] (1.129 s) : 0, 1129326
Total [baseline] (9.182 s) : 0, 9182236
Agent [candidate] (1.133 s) : 0, 1132748
Total [candidate] (9.195 s) : 0, 9195412
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~b4ed821ccc, baseline=1.49.0-SNAPSHOT~5a04e8c591
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.961 ms) : 0, 670961
BytebuddyAgent [candidate] (670.902 ms) : 0, 670902
GlobalTracer [baseline] (240.095 ms) : 0, 240095
GlobalTracer [candidate] (239.633 ms) : 0, 239633
AppSec [baseline] (54.701 ms) : 0, 54701
AppSec [candidate] (54.597 ms) : 0, 54597
Debugger [baseline] (6.839 ms) : 0, 6839
Debugger [candidate] (6.897 ms) : 0, 6897
Remote Config [baseline] (708.226 µs) : 0, 708
Remote Config [candidate] (715.997 µs) : 0, 716
Telemetry [baseline] (8.392 ms) : 0, 8392
Telemetry [candidate] (10.055 ms) : 0, 10055
section iast
BytebuddyAgent [baseline] (789.377 ms) : 0, 789377
BytebuddyAgent [candidate] (789.065 ms) : 0, 789065
GlobalTracer [baseline] (229.386 ms) : 0, 229386
GlobalTracer [candidate] (230.653 ms) : 0, 230653
IAST [baseline] (22.808 ms) : 0, 22808
IAST [candidate] (22.784 ms) : 0, 22784
AppSec [baseline] (56.342 ms) : 0, 56342
AppSec [candidate] (56.563 ms) : 0, 56563
Debugger [baseline] (5.885 ms) : 0, 5885
Debugger [candidate] (5.848 ms) : 0, 5848
Remote Config [baseline] (590.03 µs) : 0, 590
Remote Config [candidate] (575.985 µs) : 0, 576
Telemetry [baseline] (7.852 ms) : 0, 7852
Telemetry [candidate] (7.908 ms) : 0, 7908
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.007 ms) : 0, 795007
BytebuddyAgent [candidate] (789.953 ms) : 0, 789953
GlobalTracer [baseline] (231.108 ms) : 0, 231108
GlobalTracer [candidate] (230.094 ms) : 0, 230094
IAST [baseline] (22.946 ms) : 0, 22946
IAST [candidate] (22.728 ms) : 0, 22728
AppSec [baseline] (56.983 ms) : 0, 56983
AppSec [candidate] (56.018 ms) : 0, 56018
Debugger [baseline] (5.973 ms) : 0, 5973
Debugger [candidate] (5.864 ms) : 0, 5864
Remote Config [baseline] (598.642 µs) : 0, 599
Remote Config [candidate] (581.492 µs) : 0, 581
Telemetry [baseline] (8.011 ms) : 0, 8011
Telemetry [candidate] (7.943 ms) : 0, 7943
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.415 ms) : 0, 784415
BytebuddyAgent [candidate] (785.557 ms) : 0, 785557
GlobalTracer [baseline] (229.12 ms) : 0, 229120
GlobalTracer [candidate] (230.278 ms) : 0, 230278
IAST [baseline] (22.269 ms) : 0, 22269
IAST [candidate] (22.491 ms) : 0, 22491
AppSec [baseline] (55.925 ms) : 0, 55925
AppSec [candidate] (56.758 ms) : 0, 56758
Debugger [baseline] (5.892 ms) : 0, 5892
Debugger [candidate] (5.968 ms) : 0, 5968
Remote Config [baseline] (589.373 µs) : 0, 589
Remote Config [candidate] (613.038 µs) : 0, 613
Telemetry [baseline] (7.775 ms) : 0, 7775
Telemetry [candidate] (7.72 ms) : 0, 7720
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~b4ed821ccc, baseline=1.49.0-SNAPSHOT~5a04e8c591
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1006441
Total [baseline] (10.558 s) : 0, 10557556
Agent [candidate] (1.003 s) : 0, 1003402
Total [candidate] (10.513 s) : 0, 10513173
section appsec
Agent [baseline] (1.148 s) : 0, 1148473
Total [baseline] (10.665 s) : 0, 10664695
Agent [candidate] (1.149 s) : 0, 1148538
Total [candidate] (10.674 s) : 0, 10674360
section iast
Agent [baseline] (1.135 s) : 0, 1134846
Total [baseline] (10.878 s) : 0, 10878357
Agent [candidate] (1.138 s) : 0, 1137756
Total [candidate] (10.806 s) : 0, 10805606
section profiling
Agent [baseline] (1.27 s) : 0, 1269531
Total [baseline] (10.841 s) : 0, 10841348
Agent [candidate] (1.259 s) : 0, 1258696
Total [candidate] (10.749 s) : 0, 10749495
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~b4ed821ccc, baseline=1.49.0-SNAPSHOT~5a04e8c591
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.197 ms) : 0, 670197
BytebuddyAgent [candidate] (668.845 ms) : 0, 668845
GlobalTracer [baseline] (240.949 ms) : 0, 240949
GlobalTracer [candidate] (239.699 ms) : 0, 239699
AppSec [baseline] (55.078 ms) : 0, 55078
AppSec [candidate] (54.662 ms) : 0, 54662
Debugger [baseline] (6.182 ms) : 0, 6182
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (719.084 µs) : 0, 719
Remote Config [candidate] (696.15 µs) : 0, 696
Telemetry [baseline] (9.948 ms) : 0, 9948
Telemetry [candidate] (9.946 ms) : 0, 9946
section appsec
BytebuddyAgent [baseline] (687.718 ms) : 0, 687718
BytebuddyAgent [candidate] (688.382 ms) : 0, 688382
GlobalTracer [baseline] (236.629 ms) : 0, 236629
GlobalTracer [candidate] (236.323 ms) : 0, 236323
IAST [baseline] (21.85 ms) : 0, 21850
IAST [candidate] (21.634 ms) : 0, 21634
AppSec [baseline] (175.554 ms) : 0, 175554
AppSec [candidate] (175.06 ms) : 0, 175060
Debugger [baseline] (5.842 ms) : 0, 5842
Debugger [candidate] (5.852 ms) : 0, 5852
Remote Config [baseline] (637.374 µs) : 0, 637
Remote Config [candidate] (633.077 µs) : 0, 633
Telemetry [baseline] (7.751 ms) : 0, 7751
Telemetry [candidate] (8.095 ms) : 0, 8095
section iast
BytebuddyAgent [baseline] (788.922 ms) : 0, 788922
BytebuddyAgent [candidate] (790.144 ms) : 0, 790144
GlobalTracer [baseline] (229.713 ms) : 0, 229713
GlobalTracer [candidate] (230.235 ms) : 0, 230235
IAST [baseline] (23.35 ms) : 0, 23350
IAST [candidate] (22.861 ms) : 0, 22861
AppSec [baseline] (55.216 ms) : 0, 55216
AppSec [candidate] (56.618 ms) : 0, 56618
Debugger [baseline] (5.888 ms) : 0, 5888
Debugger [candidate] (5.931 ms) : 0, 5931
Remote Config [baseline] (592.503 µs) : 0, 593
Remote Config [candidate] (591.116 µs) : 0, 591
Telemetry [baseline] (7.861 ms) : 0, 7861
Telemetry [candidate] (7.905 ms) : 0, 7905
section profiling
BytebuddyAgent [baseline] (668.966 ms) : 0, 668966
BytebuddyAgent [candidate] (663.464 ms) : 0, 663464
GlobalTracer [baseline] (381.066 ms) : 0, 381066
GlobalTracer [candidate] (379.107 ms) : 0, 379107
AppSec [baseline] (55.795 ms) : 0, 55795
AppSec [candidate] (53.935 ms) : 0, 53935
Debugger [baseline] (6.263 ms) : 0, 6263
Debugger [candidate] (6.175 ms) : 0, 6175
Remote Config [baseline] (671.166 µs) : 0, 671
Remote Config [candidate] (653.22 µs) : 0, 653
Telemetry [baseline] (8.305 ms) : 0, 8305
Telemetry [candidate] (8.233 ms) : 0, 8233
ProfilingAgent [baseline] (97.782 ms) : 0, 97782
ProfilingAgent [candidate] (96.156 ms) : 0, 96156
Profiling [baseline] (97.806 ms) : 0, 97806
Profiling [candidate] (96.179 ms) : 0, 96179
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~b4ed821ccc, baseline=1.49.0-SNAPSHOT~5a04e8c591
dateFormat X
axisFormat %s
section baseline
no_agent (381.805 µs) : 362, 401
. : milestone, 382,
iast (525.203 µs) : 502, 548
. : milestone, 525,
iast_FULL (729.789 µs) : 707, 753
. : milestone, 730,
iast_GLOBAL (574.314 µs) : 551, 598
. : milestone, 574,
iast_HARDCODED_SECRET_DISABLED (527.606 µs) : 505, 551
. : milestone, 528,
iast_INACTIVE (466.111 µs) : 444, 488
. : milestone, 466,
iast_TELEMETRY_OFF (500.167 µs) : 478, 522
. : milestone, 500,
tracing (460.486 µs) : 438, 483
. : milestone, 460,
section candidate
no_agent (381.999 µs) : 362, 402
. : milestone, 382,
iast (513.238 µs) : 489, 538
. : milestone, 513,
iast_FULL (731.814 µs) : 709, 755
. : milestone, 732,
iast_GLOBAL (555.035 µs) : 532, 578
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (514.651 µs) : 492, 537
. : milestone, 515,
iast_INACTIVE (465.958 µs) : 444, 488
. : milestone, 466,
iast_TELEMETRY_OFF (497.598 µs) : 475, 520
. : milestone, 498,
tracing (463.914 µs) : 442, 486
. : milestone, 464,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~b4ed821ccc, baseline=1.49.0-SNAPSHOT~5a04e8c591
dateFormat X
axisFormat %s
section baseline
no_agent (1.369 ms) : 1350, 1389
. : milestone, 1369,
appsec (1.715 ms) : 1691, 1738
. : milestone, 1715,
appsec_no_iast (1.722 ms) : 1698, 1745
. : milestone, 1722,
code_origins (1.663 ms) : 1636, 1690
. : milestone, 1663,
iast (1.516 ms) : 1491, 1540
. : milestone, 1516,
profiling (1.542 ms) : 1518, 1567
. : milestone, 1542,
tracing (1.485 ms) : 1460, 1510
. : milestone, 1485,
section candidate
no_agent (1.348 ms) : 1329, 1368
. : milestone, 1348,
appsec (1.73 ms) : 1705, 1754
. : milestone, 1730,
appsec_no_iast (1.728 ms) : 1705, 1752
. : milestone, 1728,
code_origins (1.695 ms) : 1667, 1723
. : milestone, 1695,
iast (1.52 ms) : 1496, 1544
. : milestone, 1520,
profiling (1.515 ms) : 1491, 1538
. : milestone, 1515,
tracing (1.482 ms) : 1457, 1507
. : milestone, 1482,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~b4ed821ccc, baseline=1.49.0-SNAPSHOT~5a04e8c591
dateFormat X
axisFormat %s
section baseline
no_agent (15.535 s) : 15535000, 15535000
. : milestone, 15535000,
appsec (15.241 s) : 15241000, 15241000
. : milestone, 15241000,
iast (18.807 s) : 18807000, 18807000
. : milestone, 18807000,
iast_GLOBAL (18.224 s) : 18224000, 18224000
. : milestone, 18224000,
profiling (15.186 s) : 15186000, 15186000
. : milestone, 15186000,
tracing (14.936 s) : 14936000, 14936000
. : milestone, 14936000,
section candidate
no_agent (15.431 s) : 15431000, 15431000
. : milestone, 15431000,
appsec (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
iast (18.895 s) : 18895000, 18895000
. : milestone, 18895000,
iast_GLOBAL (18.15 s) : 18150000, 18150000
. : milestone, 18150000,
profiling (15.576 s) : 15576000, 15576000
. : milestone, 15576000,
tracing (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~b4ed821ccc, baseline=1.49.0-SNAPSHOT~5a04e8c591
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.375 ms) : 2327, 2422
. : milestone, 2375,
iast (2.152 ms) : 2093, 2211
. : milestone, 2152,
iast_GLOBAL (2.193 ms) : 2133, 2253
. : milestone, 2193,
profiling (1.997 ms) : 1950, 2044
. : milestone, 1997,
tracing (1.977 ms) : 1931, 2023
. : milestone, 1977,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.374 ms) : 2327, 2421
. : milestone, 2374,
iast (2.162 ms) : 2103, 2222
. : milestone, 2162,
iast_GLOBAL (2.194 ms) : 2135, 2254
. : milestone, 2194,
profiling (2.036 ms) : 1987, 2085
. : milestone, 2036,
tracing (1.977 ms) : 1932, 2023
. : milestone, 1977,
|
amarziali
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove top-level maven
pom.propertiesof vendored packages as they could trigger unwanted framework checks. See APMS-15680 for an example of such a check.Additional Notes
Also remove some empty
META-INF/versionsdirectories leftover from vendoring SnakeYamlContributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMS-15680