Do not use strict write with latest lettuce#8670
Merged
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
mcculls
approved these changes
Apr 4, 2025
2b98d6c to
0c2e77f
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 69 metrics, 2 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~2b98d6c877, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064141
Total [baseline] (8.685 s) : 0, 8685149
Agent [candidate] (1.058 s) : 0, 1058482
Total [candidate] (8.682 s) : 0, 8682030
section iast
Agent [baseline] (1.185 s) : 0, 1184949
Total [baseline] (9.247 s) : 0, 9246967
Agent [candidate] (1.185 s) : 0, 1184891
Total [candidate] (9.281 s) : 0, 9281319
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1182865
Total [baseline] (9.22 s) : 0, 9219965
Agent [candidate] (1.181 s) : 0, 1181285
Total [candidate] (9.201 s) : 0, 9200750
section iast_TELEMETRY_OFF
Agent [baseline] (1.185 s) : 0, 1184718
Total [baseline] (9.279 s) : 0, 9279109
Agent [candidate] (1.194 s) : 0, 1193505
Total [candidate] (9.263 s) : 0, 9262832
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~2b98d6c877, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (727.141 ms) : 0, 727141
BytebuddyAgent [candidate] (722.649 ms) : 0, 722649
GlobalTracer [baseline] (241.514 ms) : 0, 241514
GlobalTracer [candidate] (240.18 ms) : 0, 240180
AppSec [baseline] (54.978 ms) : 0, 54978
AppSec [candidate] (54.696 ms) : 0, 54696
Debugger [baseline] (4.444 ms) : 0, 4444
Debugger [candidate] (4.409 ms) : 0, 4409
Remote Config [baseline] (694.824 µs) : 0, 695
Remote Config [candidate] (694.386 µs) : 0, 694
Telemetry [baseline] (14.38 ms) : 0, 14380
Telemetry [candidate] (14.987 ms) : 0, 14987
section iast
BytebuddyAgent [baseline] (841.426 ms) : 0, 841426
BytebuddyAgent [candidate] (842.259 ms) : 0, 842259
GlobalTracer [baseline] (230.682 ms) : 0, 230682
GlobalTracer [candidate] (230.29 ms) : 0, 230290
IAST [baseline] (22.715 ms) : 0, 22715
IAST [candidate] (22.741 ms) : 0, 22741
AppSec [baseline] (55.879 ms) : 0, 55879
AppSec [candidate] (55.403 ms) : 0, 55403
Debugger [baseline] (4.124 ms) : 0, 4124
Debugger [candidate] (4.123 ms) : 0, 4123
Remote Config [baseline] (596.542 µs) : 0, 597
Remote Config [candidate] (589.115 µs) : 0, 589
Telemetry [baseline] (8.705 ms) : 0, 8705
Telemetry [candidate] (8.686 ms) : 0, 8686
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.011 ms) : 0, 840011
BytebuddyAgent [candidate] (839.082 ms) : 0, 839082
GlobalTracer [baseline] (230.003 ms) : 0, 230003
GlobalTracer [candidate] (229.702 ms) : 0, 229702
IAST [baseline] (22.85 ms) : 0, 22850
IAST [candidate] (22.732 ms) : 0, 22732
AppSec [baseline] (55.757 ms) : 0, 55757
AppSec [candidate] (55.597 ms) : 0, 55597
Debugger [baseline] (4.143 ms) : 0, 4143
Debugger [candidate] (4.127 ms) : 0, 4127
Remote Config [baseline] (582.808 µs) : 0, 583
Remote Config [candidate] (585.067 µs) : 0, 585
Telemetry [baseline] (8.673 ms) : 0, 8673
Telemetry [candidate] (8.659 ms) : 0, 8659
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (840.664 ms) : 0, 840664
BytebuddyAgent [candidate] (846.483 ms) : 0, 846483
GlobalTracer [baseline] (231.126 ms) : 0, 231126
GlobalTracer [candidate] (233.116 ms) : 0, 233116
IAST [baseline] (22.318 ms) : 0, 22318
IAST [candidate] (22.602 ms) : 0, 22602
AppSec [baseline] (56.251 ms) : 0, 56251
AppSec [candidate] (56.635 ms) : 0, 56635
Debugger [baseline] (4.175 ms) : 0, 4175
Debugger [candidate] (4.225 ms) : 0, 4225
Remote Config [baseline] (606.494 µs) : 0, 606
Remote Config [candidate] (607.721 µs) : 0, 608
Telemetry [baseline] (8.707 ms) : 0, 8707
Telemetry [candidate] (8.822 ms) : 0, 8822
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~2b98d6c877, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062614
Total [baseline] (10.463 s) : 0, 10463389
Agent [candidate] (1.059 s) : 0, 1058514
Total [candidate] (10.491 s) : 0, 10491237
section appsec
Agent [baseline] (1.199 s) : 0, 1199059
Total [baseline] (10.771 s) : 0, 10770538
Agent [candidate] (1.206 s) : 0, 1205952
Total [candidate] (10.802 s) : 0, 10802460
section iast
Agent [baseline] (1.186 s) : 0, 1185629
Total [baseline] (11.047 s) : 0, 11046954
Agent [candidate] (1.186 s) : 0, 1185724
Total [candidate] (11.053 s) : 0, 11053120
section profiling
Agent [baseline] (1.279 s) : 0, 1278596
Total [baseline] (10.882 s) : 0, 10881939
Agent [candidate] (1.294 s) : 0, 1294467
Total [candidate] (10.993 s) : 0, 10992935
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~2b98d6c877, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (725.969 ms) : 0, 725969
BytebuddyAgent [candidate] (721.854 ms) : 0, 721854
GlobalTracer [baseline] (241.418 ms) : 0, 241418
GlobalTracer [candidate] (240.248 ms) : 0, 240248
AppSec [baseline] (54.887 ms) : 0, 54887
AppSec [candidate] (54.585 ms) : 0, 54585
Debugger [baseline] (4.474 ms) : 0, 4474
Debugger [candidate] (4.433 ms) : 0, 4433
Remote Config [baseline] (697.008 µs) : 0, 697
Remote Config [candidate] (698.038 µs) : 0, 698
Telemetry [baseline] (14.175 ms) : 0, 14175
Telemetry [candidate] (15.827 ms) : 0, 15827
section appsec
BytebuddyAgent [baseline] (740.972 ms) : 0, 740972
BytebuddyAgent [candidate] (746.597 ms) : 0, 746597
GlobalTracer [baseline] (236.904 ms) : 0, 236904
GlobalTracer [candidate] (237.749 ms) : 0, 237749
IAST [baseline] (21.463 ms) : 0, 21463
IAST [candidate] (21.362 ms) : 0, 21362
AppSec [baseline] (176.452 ms) : 0, 176452
AppSec [candidate] (176.768 ms) : 0, 176768
Debugger [baseline] (4.293 ms) : 0, 4293
Debugger [candidate] (4.299 ms) : 0, 4299
Remote Config [baseline] (645.826 µs) : 0, 646
Remote Config [candidate] (645.466 µs) : 0, 645
Telemetry [baseline] (8.213 ms) : 0, 8213
Telemetry [candidate] (8.275 ms) : 0, 8275
section iast
BytebuddyAgent [baseline] (842.177 ms) : 0, 842177
BytebuddyAgent [candidate] (842.732 ms) : 0, 842732
GlobalTracer [baseline] (230.899 ms) : 0, 230899
GlobalTracer [candidate] (230.348 ms) : 0, 230348
IAST [baseline] (22.697 ms) : 0, 22697
IAST [candidate] (22.676 ms) : 0, 22676
AppSec [baseline] (55.469 ms) : 0, 55469
AppSec [candidate] (55.744 ms) : 0, 55744
Debugger [baseline] (4.127 ms) : 0, 4127
Debugger [candidate] (4.061 ms) : 0, 4061
Remote Config [baseline] (592.722 µs) : 0, 593
Remote Config [candidate] (590.195 µs) : 0, 590
Telemetry [baseline] (8.726 ms) : 0, 8726
Telemetry [candidate] (8.704 ms) : 0, 8704
section profiling
BytebuddyAgent [baseline] (711.336 ms) : 0, 711336
BytebuddyAgent [candidate] (720.064 ms) : 0, 720064
GlobalTracer [baseline] (349.818 ms) : 0, 349818
GlobalTracer [candidate] (353.409 ms) : 0, 353409
AppSec [baseline] (53.994 ms) : 0, 53994
AppSec [candidate] (53.974 ms) : 0, 53974
Debugger [baseline] (4.319 ms) : 0, 4319
Debugger [candidate] (4.378 ms) : 0, 4378
Remote Config [baseline] (684.346 µs) : 0, 684
Remote Config [candidate] (708.682 µs) : 0, 709
Telemetry [baseline] (8.946 ms) : 0, 8946
Telemetry [candidate] (9.062 ms) : 0, 9062
ProfilingAgent [baseline] (101.412 ms) : 0, 101412
ProfilingAgent [candidate] (104.379 ms) : 0, 104379
Profiling [baseline] (101.438 ms) : 0, 101438
Profiling [candidate] (104.406 ms) : 0, 104406
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~2b98d6c877, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
dateFormat X
axisFormat %s
section baseline
no_agent (378.655 µs) : 359, 399
. : milestone, 379,
iast (526.773 µs) : 504, 549
. : milestone, 527,
iast_FULL (733.882 µs) : 712, 756
. : milestone, 734,
iast_GLOBAL (568.949 µs) : 547, 591
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (525.003 µs) : 503, 547
. : milestone, 525,
iast_INACTIVE (470.366 µs) : 449, 492
. : milestone, 470,
iast_TELEMETRY_OFF (500.486 µs) : 479, 522
. : milestone, 500,
tracing (465.527 µs) : 445, 486
. : milestone, 466,
section candidate
no_agent (383.112 µs) : 363, 403
. : milestone, 383,
iast (513.403 µs) : 491, 536
. : milestone, 513,
iast_FULL (732.704 µs) : 711, 755
. : milestone, 733,
iast_GLOBAL (572.91 µs) : 550, 596
. : milestone, 573,
iast_HARDCODED_SECRET_DISABLED (521.441 µs) : 500, 543
. : milestone, 521,
iast_INACTIVE (469.652 µs) : 448, 491
. : milestone, 470,
iast_TELEMETRY_OFF (507.508 µs) : 485, 530
. : milestone, 508,
tracing (463.716 µs) : 443, 485
. : milestone, 464,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~2b98d6c877, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
dateFormat X
axisFormat %s
section baseline
no_agent (1.354 ms) : 1334, 1374
. : milestone, 1354,
appsec (1.746 ms) : 1722, 1769
. : milestone, 1746,
appsec_no_iast (1.751 ms) : 1726, 1775
. : milestone, 1751,
code_origins (1.688 ms) : 1660, 1715
. : milestone, 1688,
iast (1.5 ms) : 1476, 1524
. : milestone, 1500,
profiling (1.516 ms) : 1492, 1540
. : milestone, 1516,
tracing (1.519 ms) : 1494, 1543
. : milestone, 1519,
section candidate
no_agent (1.388 ms) : 1369, 1408
. : milestone, 1388,
appsec (1.737 ms) : 1714, 1761
. : milestone, 1737,
appsec_no_iast (1.723 ms) : 1700, 1746
. : milestone, 1723,
code_origins (1.707 ms) : 1681, 1734
. : milestone, 1707,
iast (1.515 ms) : 1491, 1540
. : milestone, 1515,
profiling (1.528 ms) : 1503, 1553
. : milestone, 1528,
tracing (1.514 ms) : 1488, 1540
. : milestone, 1514,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~2b98d6c877, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.382 ms) : 2335, 2428
. : milestone, 2382,
iast (2.155 ms) : 2096, 2213
. : milestone, 2155,
iast_GLOBAL (2.197 ms) : 2138, 2256
. : milestone, 2197,
profiling (2.017 ms) : 1969, 2065
. : milestone, 2017,
tracing (1.987 ms) : 1942, 2032
. : milestone, 1987,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.373 ms) : 2326, 2419
. : milestone, 2373,
iast (2.161 ms) : 2103, 2220
. : milestone, 2161,
iast_GLOBAL (2.202 ms) : 2143, 2261
. : milestone, 2202,
profiling (2.011 ms) : 1963, 2058
. : milestone, 2011,
tracing (1.977 ms) : 1932, 2022
. : milestone, 1977,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~2b98d6c877, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
dateFormat X
axisFormat %s
section baseline
no_agent (15.409 s) : 15409000, 15409000
. : milestone, 15409000,
appsec (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
iast (19.099 s) : 19099000, 19099000
. : milestone, 19099000,
iast_GLOBAL (18.342 s) : 18342000, 18342000
. : milestone, 18342000,
profiling (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
tracing (14.695 s) : 14695000, 14695000
. : milestone, 14695000,
section candidate
no_agent (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
appsec (14.765 s) : 14765000, 14765000
. : milestone, 14765000,
iast (18.811 s) : 18811000, 18811000
. : milestone, 18811000,
iast_GLOBAL (18.243 s) : 18243000, 18243000
. : milestone, 18243000,
profiling (15.264 s) : 15264000, 15264000
. : milestone, 15264000,
tracing (14.629 s) : 14629000, 14629000
. : milestone, 14629000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]