When continuing a span merge it with any non-span context#8658
Merged
When continuing a span merge it with any non-span context#8658
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~d0d94091c8, baseline=1.48.0-SNAPSHOT~d8de1044d6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052009
Total [baseline] (8.699 s) : 0, 8699007
Agent [candidate] (1.054 s) : 0, 1054421
Total [candidate] (8.704 s) : 0, 8704433
section iast
Agent [baseline] (1.183 s) : 0, 1183362
Total [baseline] (9.27 s) : 0, 9270224
Agent [candidate] (1.181 s) : 0, 1181474
Total [candidate] (9.334 s) : 0, 9333955
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1188977
Total [baseline] (9.235 s) : 0, 9235498
Agent [candidate] (1.182 s) : 0, 1181512
Total [candidate] (9.256 s) : 0, 9255901
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1176908
Total [baseline] (9.312 s) : 0, 9311937
Agent [candidate] (1.186 s) : 0, 1185783
Total [candidate] (9.29 s) : 0, 9289690
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~d0d94091c8, baseline=1.48.0-SNAPSHOT~d8de1044d6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.253 ms) : 0, 718253
BytebuddyAgent [candidate] (720.466 ms) : 0, 720466
GlobalTracer [baseline] (239.833 ms) : 0, 239833
GlobalTracer [candidate] (240.507 ms) : 0, 240507
AppSec [baseline] (55.171 ms) : 0, 55171
AppSec [candidate] (54.721 ms) : 0, 54721
Debugger [baseline] (4.456 ms) : 0, 4456
Debugger [candidate] (4.461 ms) : 0, 4461
Remote Config [baseline] (703.743 µs) : 0, 704
Remote Config [candidate] (686.259 µs) : 0, 686
Telemetry [baseline] (12.965 ms) : 0, 12965
Telemetry [candidate] (13.012 ms) : 0, 13012
section iast
BytebuddyAgent [baseline] (839.299 ms) : 0, 839299
BytebuddyAgent [candidate] (838.039 ms) : 0, 838039
GlobalTracer [baseline] (230.569 ms) : 0, 230569
GlobalTracer [candidate] (230.114 ms) : 0, 230114
AppSec [baseline] (56.57 ms) : 0, 56570
AppSec [candidate] (56.434 ms) : 0, 56434
Debugger [baseline] (4.195 ms) : 0, 4195
Debugger [candidate] (4.173 ms) : 0, 4173
Remote Config [baseline] (618.454 µs) : 0, 618
Remote Config [candidate] (616.889 µs) : 0, 617
Telemetry [baseline] (8.888 ms) : 0, 8888
Telemetry [candidate] (8.891 ms) : 0, 8891
IAST [baseline] (22.706 ms) : 0, 22706
IAST [candidate] (22.801 ms) : 0, 22801
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (844.439 ms) : 0, 844439
BytebuddyAgent [candidate] (838.661 ms) : 0, 838661
GlobalTracer [baseline] (231.406 ms) : 0, 231406
GlobalTracer [candidate] (230.011 ms) : 0, 230011
AppSec [baseline] (55.879 ms) : 0, 55879
AppSec [candidate] (56.148 ms) : 0, 56148
Debugger [baseline] (4.169 ms) : 0, 4169
Debugger [candidate] (4.125 ms) : 0, 4125
Remote Config [baseline] (622.774 µs) : 0, 623
Remote Config [candidate] (620.987 µs) : 0, 621
Telemetry [baseline] (8.856 ms) : 0, 8856
Telemetry [candidate] (8.715 ms) : 0, 8715
IAST [baseline] (23.006 ms) : 0, 23006
IAST [candidate] (22.754 ms) : 0, 22754
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.591 ms) : 0, 834591
BytebuddyAgent [candidate] (841.458 ms) : 0, 841458
GlobalTracer [baseline] (230.029 ms) : 0, 230029
GlobalTracer [candidate] (230.602 ms) : 0, 230602
AppSec [baseline] (55.282 ms) : 0, 55282
AppSec [candidate] (56.86 ms) : 0, 56860
Debugger [baseline] (4.148 ms) : 0, 4148
Debugger [candidate] (4.271 ms) : 0, 4271
Remote Config [baseline] (622.569 µs) : 0, 623
Remote Config [candidate] (641.004 µs) : 0, 641
Telemetry [baseline] (8.708 ms) : 0, 8708
Telemetry [candidate] (8.979 ms) : 0, 8979
IAST [baseline] (23.164 ms) : 0, 23164
IAST [candidate] (22.434 ms) : 0, 22434
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~d0d94091c8, baseline=1.48.0-SNAPSHOT~d8de1044d6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053105
Total [baseline] (10.447 s) : 0, 10447428
Agent [candidate] (1.054 s) : 0, 1053641
Total [candidate] (10.502 s) : 0, 10502100
section appsec
Agent [baseline] (1.198 s) : 0, 1197729
Total [baseline] (10.83 s) : 0, 10829625
Agent [candidate] (1.196 s) : 0, 1195689
Total [candidate] (10.763 s) : 0, 10762592
section iast
Agent [baseline] (1.196 s) : 0, 1195860
Total [baseline] (11.106 s) : 0, 11106440
Agent [candidate] (1.183 s) : 0, 1182738
Total [candidate] (11.034 s) : 0, 11034309
section profiling
Agent [baseline] (1.278 s) : 0, 1277778
Total [baseline] (10.908 s) : 0, 10907797
Agent [candidate] (1.277 s) : 0, 1277212
Total [candidate] (10.927 s) : 0, 10927111
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~d0d94091c8, baseline=1.48.0-SNAPSHOT~d8de1044d6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.76 ms) : 0, 718760
BytebuddyAgent [candidate] (719.41 ms) : 0, 719410
GlobalTracer [baseline] (239.749 ms) : 0, 239749
GlobalTracer [candidate] (239.511 ms) : 0, 239511
AppSec [baseline] (54.635 ms) : 0, 54635
AppSec [candidate] (54.867 ms) : 0, 54867
Debugger [baseline] (4.48 ms) : 0, 4480
Debugger [candidate] (4.434 ms) : 0, 4434
Remote Config [baseline] (689.105 µs) : 0, 689
Remote Config [candidate] (677.394 µs) : 0, 677
Telemetry [baseline] (13.524 ms) : 0, 13524
Telemetry [candidate] (14.253 ms) : 0, 14253
section appsec
BytebuddyAgent [baseline] (740.106 ms) : 0, 740106
BytebuddyAgent [candidate] (738.996 ms) : 0, 738996
GlobalTracer [baseline] (236.999 ms) : 0, 236999
GlobalTracer [candidate] (236.148 ms) : 0, 236148
AppSec [baseline] (176.341 ms) : 0, 176341
AppSec [candidate] (175.833 ms) : 0, 175833
Debugger [baseline] (4.27 ms) : 0, 4270
Debugger [candidate] (4.265 ms) : 0, 4265
Remote Config [baseline] (641.348 µs) : 0, 641
Remote Config [candidate] (636.436 µs) : 0, 636
Telemetry [baseline] (8.164 ms) : 0, 8164
Telemetry [candidate] (8.573 ms) : 0, 8573
IAST [baseline] (21.478 ms) : 0, 21478
IAST [candidate] (21.48 ms) : 0, 21480
section iast
BytebuddyAgent [baseline] (849.007 ms) : 0, 849007
BytebuddyAgent [candidate] (839.807 ms) : 0, 839807
GlobalTracer [baseline] (233.295 ms) : 0, 233295
GlobalTracer [candidate] (230.325 ms) : 0, 230325
AppSec [baseline] (56.205 ms) : 0, 56205
AppSec [candidate] (55.911 ms) : 0, 55911
Debugger [baseline] (4.161 ms) : 0, 4161
Debugger [candidate] (4.104 ms) : 0, 4104
Remote Config [baseline] (626.701 µs) : 0, 627
Remote Config [candidate] (592.806 µs) : 0, 593
Telemetry [baseline] (8.9 ms) : 0, 8900
Telemetry [candidate] (8.766 ms) : 0, 8766
IAST [baseline] (22.982 ms) : 0, 22982
IAST [candidate] (22.711 ms) : 0, 22711
section profiling
BytebuddyAgent [baseline] (711.821 ms) : 0, 711821
BytebuddyAgent [candidate] (711.902 ms) : 0, 711902
GlobalTracer [baseline] (350.556 ms) : 0, 350556
GlobalTracer [candidate] (350.018 ms) : 0, 350018
AppSec [baseline] (53.963 ms) : 0, 53963
AppSec [candidate] (53.22 ms) : 0, 53220
Debugger [baseline] (4.28 ms) : 0, 4280
Debugger [candidate] (4.277 ms) : 0, 4277
Remote Config [baseline] (702.071 µs) : 0, 702
Remote Config [candidate] (697.59 µs) : 0, 698
Telemetry [baseline] (8.931 ms) : 0, 8931
Telemetry [candidate] (8.999 ms) : 0, 8999
ProfilingAgent [baseline] (101.879 ms) : 0, 101879
ProfilingAgent [candidate] (102.254 ms) : 0, 102254
Profiling [baseline] (101.905 ms) : 0, 101905
Profiling [candidate] (102.279 ms) : 0, 102279
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~d0d94091c8, baseline=1.48.0-SNAPSHOT~d8de1044d6
dateFormat X
axisFormat %s
section baseline
no_agent (376.467 µs) : 357, 396
. : milestone, 376,
iast (509.352 µs) : 488, 531
. : milestone, 509,
iast_FULL (727.287 µs) : 705, 749
. : milestone, 727,
iast_GLOBAL (561.223 µs) : 539, 583
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (514.883 µs) : 493, 537
. : milestone, 515,
iast_INACTIVE (471.628 µs) : 450, 493
. : milestone, 472,
iast_TELEMETRY_OFF (498.055 µs) : 476, 520
. : milestone, 498,
tracing (466.209 µs) : 445, 488
. : milestone, 466,
section candidate
no_agent (377.231 µs) : 358, 397
. : milestone, 377,
iast (512.834 µs) : 491, 535
. : milestone, 513,
iast_FULL (728.479 µs) : 706, 751
. : milestone, 728,
iast_GLOBAL (554.37 µs) : 533, 576
. : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (514.914 µs) : 493, 537
. : milestone, 515,
iast_INACTIVE (457.974 µs) : 437, 479
. : milestone, 458,
iast_TELEMETRY_OFF (501.402 µs) : 480, 523
. : milestone, 501,
tracing (458.797 µs) : 437, 480
. : milestone, 459,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~d0d94091c8, baseline=1.48.0-SNAPSHOT~d8de1044d6
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1336, 1374
. : milestone, 1355,
appsec (1.739 ms) : 1715, 1764
. : milestone, 1739,
appsec_no_iast (1.743 ms) : 1720, 1766
. : milestone, 1743,
code_origins (1.685 ms) : 1657, 1712
. : milestone, 1685,
iast (1.508 ms) : 1483, 1532
. : milestone, 1508,
profiling (1.507 ms) : 1483, 1530
. : milestone, 1507,
tracing (1.492 ms) : 1467, 1516
. : milestone, 1492,
section candidate
no_agent (1.359 ms) : 1340, 1379
. : milestone, 1359,
appsec (1.712 ms) : 1688, 1736
. : milestone, 1712,
appsec_no_iast (1.735 ms) : 1711, 1759
. : milestone, 1735,
code_origins (1.687 ms) : 1660, 1714
. : milestone, 1687,
iast (1.515 ms) : 1491, 1540
. : milestone, 1515,
profiling (1.54 ms) : 1516, 1564
. : milestone, 1540,
tracing (1.519 ms) : 1495, 1543
. : milestone, 1519,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~d0d94091c8, baseline=1.48.0-SNAPSHOT~d8de1044d6
dateFormat X
axisFormat %s
section baseline
no_agent (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
appsec (15.007 s) : 15007000, 15007000
. : milestone, 15007000,
iast (18.728 s) : 18728000, 18728000
. : milestone, 18728000,
iast_GLOBAL (17.726 s) : 17726000, 17726000
. : milestone, 17726000,
profiling (15.111 s) : 15111000, 15111000
. : milestone, 15111000,
tracing (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
section candidate
no_agent (15.274 s) : 15274000, 15274000
. : milestone, 15274000,
appsec (14.583 s) : 14583000, 14583000
. : milestone, 14583000,
iast (18.689 s) : 18689000, 18689000
. : milestone, 18689000,
iast_GLOBAL (18.07 s) : 18070000, 18070000
. : milestone, 18070000,
profiling (15.781 s) : 15781000, 15781000
. : milestone, 15781000,
tracing (14.824 s) : 14824000, 14824000
. : milestone, 14824000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~d0d94091c8, baseline=1.48.0-SNAPSHOT~d8de1044d6
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.37 ms) : 2324, 2417
. : milestone, 2370,
iast (2.148 ms) : 2089, 2206
. : milestone, 2148,
iast_GLOBAL (2.197 ms) : 2138, 2256
. : milestone, 2197,
profiling (2.011 ms) : 1963, 2059
. : milestone, 2011,
tracing (1.977 ms) : 1932, 2023
. : milestone, 1977,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.377 ms) : 2330, 2424
. : milestone, 2377,
iast (2.159 ms) : 2100, 2218
. : milestone, 2159,
iast_GLOBAL (2.201 ms) : 2141, 2260
. : milestone, 2201,
profiling (2.004 ms) : 1957, 2052
. : milestone, 2004,
tracing (1.985 ms) : 1940, 2031
. : milestone, 1985,
|
amarziali
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up to #8636 to handle the edge case where non-span context should be continued along with the span
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMAPI-960