Skip to content

Check known W3C propagation tags first when parsing#8597

Merged
mcculls merged 1 commit intomasterfrom
mcculls/fix-TagKey-invalid-header-message
Mar 20, 2025
Merged

Check known W3C propagation tags first when parsing#8597
mcculls merged 1 commit intomasterfrom
mcculls/fix-TagKey-invalid-header-message

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Mar 20, 2025 •
edited
Loading

Motivation

This avoids triggering a misleading log message from TagKey, for example:

  DEBUG d.t.core.propagation.ptags.TagKey - Invalid header h: W3C s: dd=p:456789abcdef0123 b: 3 e: 4

This is not an invalid header, it's just that TagKey rejected the 'p:' last parent trace-id because it didn't start with the 't.' prefix for custom tags. The code then falls back to checking known W3C propagation tags 's:', 'o:', and 'p:' - if we check for those first we can avoid the misleading message.

Before: running the W3C propagation tests led to ~100 "Invalid header" messages, the majority of them misleading.

After: running the W3C propagation tests produces only 8 "Invalid header" messages, all expected.

@mcculls
Check known W3C propagation tags first when parsing
277152f 
This avoids triggering a misleading log message from TagKey, for example:

  DEBUG d.t.core.propagation.ptags.TagKey - Invalid header h: W3C s: dd=p:456789abcdef0123 b: 3 e: 4

This is not an invalid header, it's just that TagKey rejected the 'p:' last parent trace-id because it didn't start with the 't.' prefix for custom tags.
The code then falls back to checking known W3C propagation tags 's:', 'o:', and 'p:' - if we check for those first we can avoid the misleading message.
@mcculls mcculls added type: bug Bug report and fix tag: no release notes Changes to exclude from release notes comp: context propagation Trace context propagation comp: logging Tracer internal logging labels Mar 20, 2025
@mcculls mcculls requested a review from a team as a code owner March 20, 2025 16:11
@mcculls mcculls requested a review from amarziali March 20, 2025 16:11
amarziali
amarziali approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@amarziali amarziali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will finally clear misunderstandings on escalations. Thanks

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 20, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fix-TagKey-invalid-header-message
git_commit_date 1742486010 1742486863
git_commit_sha 1b1f8bc 277152f
release_version 1.48.0-SNAPSHOT~1b1f8bc4a2 1.48.0-SNAPSHOT~277152fa47
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1742489267 1742489267
ci_job_id 857361435 857361435
ci_pipeline_id 59484531 59484531
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-hg2ss1eg-project-304-concurrent-1-ommdprsd 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-hg2ss1eg-project-304-concurrent-1-ommdprsd 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~277152fa47, baseline=1.48.0-SNAPSHOT~1b1f8bc4a2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048585
Total [baseline] (8.693 s) : 0, 8692621
Agent [candidate] (1.055 s) : 0, 1055479
Total [candidate] (8.711 s) : 0, 8710567
section iast
Agent [baseline] (1.172 s) : 0, 1171801
Total [baseline] (9.284 s) : 0, 9283828
Agent [candidate] (1.173 s) : 0, 1172816
Total [candidate] (9.237 s) : 0, 9236667
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1179206
Total [baseline] (9.224 s) : 0, 9223988
Agent [candidate] (1.178 s) : 0, 1178426
Total [candidate] (9.252 s) : 0, 9251805
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1173231
Total [baseline] (9.229 s) : 0, 9229228
Agent [candidate] (1.168 s) : 0, 1167792
Total [candidate] (9.211 s) : 0, 9210842
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.172 s 123.216 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.179 s 130.621 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.173 s 124.646 ms (11.9%)
Total tracing 8.693 s -
Total iast 9.284 s 591.208 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.224 s 531.368 ms (6.1%)
Total iast_TELEMETRY_OFF 9.229 s 536.607 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.173 s 117.338 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 122.947 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.168 s 112.313 ms (10.6%)
Total tracing 8.711 s -
Total iast 9.237 s 526.101 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.252 s 541.238 ms (6.2%)
Total iast_TELEMETRY_OFF 9.211 s 500.276 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~277152fa47, baseline=1.48.0-SNAPSHOT~1b1f8bc4a2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.216 ms) : 0, 723216
BytebuddyAgent [candidate] (728.058 ms) : 0, 728058
GlobalTracer [baseline] (240.476 ms) : 0, 240476
GlobalTracer [candidate] (242.499 ms) : 0, 242499
AppSec [baseline] (55.071 ms) : 0, 55071
AppSec [candidate] (55.072 ms) : 0, 55072
Remote Config [baseline] (698.329 µs) : 0, 698
Remote Config [candidate] (694.322 µs) : 0, 694
Telemetry [baseline] (13.09 ms) : 0, 13090
Telemetry [candidate] (13.089 ms) : 0, 13089
section iast
BytebuddyAgent [baseline] (837.643 ms) : 0, 837643
BytebuddyAgent [candidate] (838.211 ms) : 0, 838211
GlobalTracer [baseline] (229.939 ms) : 0, 229939
GlobalTracer [candidate] (230.188 ms) : 0, 230188
IAST [baseline] (22.792 ms) : 0, 22792
IAST [candidate] (23.755 ms) : 0, 23755
AppSec [baseline] (56.233 ms) : 0, 56233
AppSec [candidate] (55.49 ms) : 0, 55490
Remote Config [baseline] (625.121 µs) : 0, 625
Remote Config [candidate] (611.237 µs) : 0, 611
Telemetry [baseline] (8.697 ms) : 0, 8697
Telemetry [candidate] (8.653 ms) : 0, 8653
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (841.235 ms) : 0, 841235
BytebuddyAgent [candidate] (841.138 ms) : 0, 841138
GlobalTracer [baseline] (232.417 ms) : 0, 232417
GlobalTracer [candidate] (232.395 ms) : 0, 232395
IAST [baseline] (23.303 ms) : 0, 23303
IAST [candidate] (23.068 ms) : 0, 23068
AppSec [baseline] (56.651 ms) : 0, 56651
AppSec [candidate] (56.341 ms) : 0, 56341
Remote Config [baseline] (624.715 µs) : 0, 625
Remote Config [candidate] (635.289 µs) : 0, 635
Telemetry [baseline] (8.831 ms) : 0, 8831
Telemetry [candidate] (8.767 ms) : 0, 8767
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.093 ms) : 0, 839093
BytebuddyAgent [candidate] (834.102 ms) : 0, 834102
GlobalTracer [baseline] (230.515 ms) : 0, 230515
GlobalTracer [candidate] (230.124 ms) : 0, 230124
IAST [baseline] (23.141 ms) : 0, 23141
IAST [candidate] (22.3 ms) : 0, 22300
AppSec [baseline] (55.216 ms) : 0, 55216
AppSec [candidate] (56.17 ms) : 0, 56170
Remote Config [baseline] (616.424 µs) : 0, 616
Remote Config [candidate] (607.374 µs) : 0, 607
Telemetry [baseline] (8.689 ms) : 0, 8689
Telemetry [candidate] (8.537 ms) : 0, 8537
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~277152fa47, baseline=1.48.0-SNAPSHOT~1b1f8bc4a2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1037320
Total [baseline] (10.468 s) : 0, 10468446
Agent [candidate] (1.042 s) : 0, 1042482
Total [candidate] (10.489 s) : 0, 10489231
section appsec
Agent [baseline] (1.183 s) : 0, 1182941
Total [baseline] (10.75 s) : 0, 10750454
Agent [candidate] (1.19 s) : 0, 1190458
Total [candidate] (10.856 s) : 0, 10855865
section iast
Agent [baseline] (1.183 s) : 0, 1182520
Total [baseline] (10.993 s) : 0, 10993218
Agent [candidate] (1.171 s) : 0, 1171302
Total [candidate] (10.952 s) : 0, 10952156
section profiling
Agent [baseline] (1.26 s) : 0, 1260109
Total [baseline] (10.828 s) : 0, 10827722
Agent [candidate] (1.259 s) : 0, 1259308
Total [candidate] (10.874 s) : 0, 10873587
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.037 s -
Agent appsec 1.183 s 145.621 ms (14.0%)
Agent iast 1.183 s 145.201 ms (14.0%)
Agent profiling 1.26 s 222.789 ms (21.5%)
Total tracing 10.468 s -
Total appsec 10.75 s 282.008 ms (2.7%)
Total iast 10.993 s 524.772 ms (5.0%)
Total profiling 10.828 s 359.276 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent appsec 1.19 s 147.975 ms (14.2%)
Agent iast 1.171 s 128.819 ms (12.4%)
Agent profiling 1.259 s 216.825 ms (20.8%)
Total tracing 10.489 s -
Total appsec 10.856 s 366.634 ms (3.5%)
Total iast 10.952 s 462.926 ms (4.4%)
Total profiling 10.874 s 384.356 ms (3.7%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~277152fa47, baseline=1.48.0-SNAPSHOT~1b1f8bc4a2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.527 ms) : 0, 716527
BytebuddyAgent [candidate] (717.75 ms) : 0, 717750
GlobalTracer [baseline] (238.63 ms) : 0, 238630
GlobalTracer [candidate] (239.364 ms) : 0, 239364
AppSec [baseline] (54.782 ms) : 0, 54782
AppSec [candidate] (54.459 ms) : 0, 54459
Remote Config [baseline] (699.677 µs) : 0, 700
Remote Config [candidate] (684.25 µs) : 0, 684
Telemetry [baseline] (10.796 ms) : 0, 10796
Telemetry [candidate] (14.308 ms) : 0, 14308
section appsec
BytebuddyAgent [baseline] (735.492 ms) : 0, 735492
BytebuddyAgent [candidate] (740.255 ms) : 0, 740255
GlobalTracer [baseline] (235.783 ms) : 0, 235783
GlobalTracer [candidate] (237.265 ms) : 0, 237265
IAST [baseline] (21.536 ms) : 0, 21536
IAST [candidate] (21.761 ms) : 0, 21761
AppSec [baseline] (175.704 ms) : 0, 175704
AppSec [candidate] (177.017 ms) : 0, 177017
Remote Config [baseline] (659.649 µs) : 0, 660
Remote Config [candidate] (683.681 µs) : 0, 684
Telemetry [baseline] (8.57 ms) : 0, 8570
Telemetry [candidate] (8.374 ms) : 0, 8374
section iast
BytebuddyAgent [baseline] (846.033 ms) : 0, 846033
BytebuddyAgent [candidate] (837.705 ms) : 0, 837705
GlobalTracer [baseline] (231.423 ms) : 0, 231423
GlobalTracer [candidate] (230.151 ms) : 0, 230151
IAST [baseline] (23.158 ms) : 0, 23158
IAST [candidate] (22.66 ms) : 0, 22660
AppSec [baseline] (56.499 ms) : 0, 56499
AppSec [candidate] (55.635 ms) : 0, 55635
Remote Config [baseline] (617.287 µs) : 0, 617
Remote Config [candidate] (598.586 µs) : 0, 599
Telemetry [baseline] (8.765 ms) : 0, 8765
Telemetry [candidate] (8.633 ms) : 0, 8633
section profiling
BytebuddyAgent [baseline] (708.359 ms) : 0, 708359
BytebuddyAgent [candidate] (709.288 ms) : 0, 709288
GlobalTracer [baseline] (349.522 ms) : 0, 349522
GlobalTracer [candidate] (349.48 ms) : 0, 349480
AppSec [baseline] (54.147 ms) : 0, 54147
AppSec [candidate] (53.654 ms) : 0, 53654
Remote Config [baseline] (714.909 µs) : 0, 715
Remote Config [candidate] (697.312 µs) : 0, 697
Telemetry [baseline] (8.921 ms) : 0, 8921
Telemetry [candidate] (8.882 ms) : 0, 8882
ProfilingAgent [baseline] (96.993 ms) : 0, 96993
ProfilingAgent [candidate] (95.876 ms) : 0, 95876
Profiling [baseline] (97.018 ms) : 0, 97018
Profiling [candidate] (95.902 ms) : 0, 95902
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-20T17:21:49 2025-03-20T17:29:33
git_branch master mcculls/fix-TagKey-invalid-header-message
git_commit_date 1742486010 1742486863
git_commit_sha 1b1f8bc 277152f
release_version 1.48.0-SNAPSHOT~1b1f8bc4a2 1.48.0-SNAPSHOT~277152fa47
start_time 2025-03-20T17:21:34 2025-03-20T17:29:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1742492172 1742492172
ci_job_id 857549720 857549720
ci_pipeline_id 59484531 59484531
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-8h5zseff-project-304-concurrent-0-zw2fuezr 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-8h5zseff-project-304-concurrent-0-zw2fuezr 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~277152fa47, baseline=1.48.0-SNAPSHOT~1b1f8bc4a2
    dateFormat X
    axisFormat %s
section baseline
no_agent (389.961 µs) : 369, 411
.   : milestone, 390,
iast (518.826 µs) : 496, 541
.   : milestone, 519,
iast_FULL (734.638 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (564.024 µs) : 542, 586
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (516.926 µs) : 495, 539
.   : milestone, 517,
iast_INACTIVE (467.668 µs) : 446, 489
.   : milestone, 468,
iast_TELEMETRY_OFF (504.79 µs) : 483, 527
.   : milestone, 505,
tracing (465.049 µs) : 444, 487
.   : milestone, 465,
section candidate
no_agent (384.974 µs) : 365, 405
.   : milestone, 385,
iast (516.496 µs) : 495, 538
.   : milestone, 516,
iast_FULL (732.057 µs) : 710, 754
.   : milestone, 732,
iast_GLOBAL (556.818 µs) : 535, 578
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (515.741 µs) : 494, 538
.   : milestone, 516,
iast_INACTIVE (468.317 µs) : 447, 490
.   : milestone, 468,
iast_TELEMETRY_OFF (507.258 µs) : 485, 529
.   : milestone, 507,
tracing (460.545 µs) : 440, 481
.   : milestone, 461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 389.961 µs [369.033 µs, 410.888 µs] -
iast 518.826 µs [496.291 µs, 541.361 µs] 128.865 µs (33.0%)
iast_FULL 734.638 µs [712.718 µs, 756.559 µs] 344.677 µs (88.4%)
iast_GLOBAL 564.024 µs [541.61 µs, 586.437 µs] 174.063 µs (44.6%)
iast_HARDCODED_SECRET_DISABLED 516.926 µs [495.166 µs, 538.685 µs] 126.965 µs (32.6%)
iast_INACTIVE 467.668 µs [446.371 µs, 488.965 µs] 77.707 µs (19.9%)
iast_TELEMETRY_OFF 504.79 µs [482.799 µs, 526.781 µs] 114.829 µs (29.4%)
tracing 465.049 µs [443.532 µs, 486.566 µs] 75.088 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.974 µs [364.652 µs, 405.296 µs] -
iast 516.496 µs [494.899 µs, 538.093 µs] 131.522 µs (34.2%)
iast_FULL 732.057 µs [710.137 µs, 753.978 µs] 347.083 µs (90.2%)
iast_GLOBAL 556.818 µs [535.203 µs, 578.433 µs] 171.844 µs (44.6%)
iast_HARDCODED_SECRET_DISABLED 515.741 µs [493.758 µs, 537.724 µs] 130.767 µs (34.0%)
iast_INACTIVE 468.317 µs [447.077 µs, 489.557 µs] 83.342 µs (21.6%)
iast_TELEMETRY_OFF 507.258 µs [485.467 µs, 529.049 µs] 122.284 µs (31.8%)
tracing 460.545 µs [439.848 µs, 481.241 µs] 75.571 µs (19.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~277152fa47, baseline=1.48.0-SNAPSHOT~1b1f8bc4a2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.337 ms) : 1318, 1357
.   : milestone, 1337,
appsec (1.74 ms) : 1717, 1764
.   : milestone, 1740,
appsec_no_iast (1.736 ms) : 1712, 1761
.   : milestone, 1736,
code_origins (1.659 ms) : 1632, 1686
.   : milestone, 1659,
iast (1.515 ms) : 1491, 1539
.   : milestone, 1515,
profiling (1.562 ms) : 1537, 1588
.   : milestone, 1562,
tracing (1.494 ms) : 1469, 1520
.   : milestone, 1494,
section candidate
no_agent (1.359 ms) : 1340, 1378
.   : milestone, 1359,
appsec (1.751 ms) : 1727, 1774
.   : milestone, 1751,
appsec_no_iast (1.725 ms) : 1700, 1750
.   : milestone, 1725,
code_origins (1.703 ms) : 1677, 1730
.   : milestone, 1703,
iast (1.515 ms) : 1490, 1540
.   : milestone, 1515,
profiling (1.532 ms) : 1507, 1556
.   : milestone, 1532,
tracing (1.507 ms) : 1483, 1532
.   : milestone, 1507,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.318 ms, 1.357 ms] -
appsec 1.74 ms [1.717 ms, 1.764 ms] 402.942 µs (30.1%)
appsec_no_iast 1.736 ms [1.712 ms, 1.761 ms] 398.941 µs (29.8%)
code_origins 1.659 ms [1.632 ms, 1.686 ms] 321.397 µs (24.0%)
iast 1.515 ms [1.491 ms, 1.539 ms] 177.495 µs (13.3%)
profiling 1.562 ms [1.537 ms, 1.588 ms] 224.858 µs (16.8%)
tracing 1.494 ms [1.469 ms, 1.52 ms] 156.979 µs (11.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.34 ms, 1.378 ms] -
appsec 1.751 ms [1.727 ms, 1.774 ms] 391.49 µs (28.8%)
appsec_no_iast 1.725 ms [1.7 ms, 1.75 ms] 365.667 µs (26.9%)
code_origins 1.703 ms [1.677 ms, 1.73 ms] 344.007 µs (25.3%)
iast 1.515 ms [1.49 ms, 1.54 ms] 155.734 µs (11.5%)
profiling 1.532 ms [1.507 ms, 1.556 ms] 172.687 µs (12.7%)
tracing 1.507 ms [1.483 ms, 1.532 ms] 148.227 µs (10.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fix-TagKey-invalid-header-message
git_commit_date 1742486010 1742486863
git_commit_sha 1b1f8bc 277152f
release_version 1.48.0-SNAPSHOT~1b1f8bc4a2 1.48.0-SNAPSHOT~277152fa47
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1742488786 1742488786
ci_job_id 857361438 857361438
ci_pipeline_id 59484531 59484531
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-hg2ss1eg-project-304-concurrent-2-j1mx6jam 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-hg2ss1eg-project-304-concurrent-2-j1mx6jam 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~277152fa47, baseline=1.48.0-SNAPSHOT~1b1f8bc4a2
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.871 s) : 14871000, 14871000
.   : milestone, 14871000,
appsec (15.012 s) : 15012000, 15012000
.   : milestone, 15012000,
iast (19.085 s) : 19085000, 19085000
.   : milestone, 19085000,
iast_GLOBAL (18.283 s) : 18283000, 18283000
.   : milestone, 18283000,
profiling (15.03 s) : 15030000, 15030000
.   : milestone, 15030000,
tracing (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
section candidate
no_agent (15.47 s) : 15470000, 15470000
.   : milestone, 15470000,
appsec (15.143 s) : 15143000, 15143000
.   : milestone, 15143000,
iast (18.727 s) : 18727000, 18727000
.   : milestone, 18727000,
iast_GLOBAL (18.066 s) : 18066000, 18066000
.   : milestone, 18066000,
profiling (15.224 s) : 15224000, 15224000
.   : milestone, 15224000,
tracing (14.767 s) : 14767000, 14767000
.   : milestone, 14767000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.871 s [14.871 s, 14.871 s] -
appsec 15.012 s [15.012 s, 15.012 s] 141.0 ms (0.9%)
iast 19.085 s [19.085 s, 19.085 s] 4.214 s (28.3%)
iast_GLOBAL 18.283 s [18.283 s, 18.283 s] 3.412 s (22.9%)
profiling 15.03 s [15.03 s, 15.03 s] 159.0 ms (1.1%)
tracing 15.178 s [15.178 s, 15.178 s] 307.0 ms (2.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.47 s [15.47 s, 15.47 s] -
appsec 15.143 s [15.143 s, 15.143 s] -327.0 ms (-2.1%)
iast 18.727 s [18.727 s, 18.727 s] 3.257 s (21.1%)
iast_GLOBAL 18.066 s [18.066 s, 18.066 s] 2.596 s (16.8%)
profiling 15.224 s [15.224 s, 15.224 s] -246.0 ms (-1.6%)
tracing 14.767 s [14.767 s, 14.767 s] -703.0 ms (-4.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~277152fa47, baseline=1.48.0-SNAPSHOT~1b1f8bc4a2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
.   : milestone, 1479,
appsec (2.343 ms) : 2299, 2387
.   : milestone, 2343,
iast (2.123 ms) : 2068, 2179
.   : milestone, 2123,
iast_GLOBAL (2.165 ms) : 2108, 2221
.   : milestone, 2165,
profiling (2.444 ms) : 2263, 2625
.   : milestone, 2444,
tracing (1.949 ms) : 1906, 1991
.   : milestone, 1949,
section candidate
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.339 ms) : 2296, 2383
.   : milestone, 2339,
iast (2.112 ms) : 2057, 2168
.   : milestone, 2112,
iast_GLOBAL (2.158 ms) : 2102, 2214
.   : milestone, 2158,
profiling (1.983 ms) : 1937, 2029
.   : milestone, 1983,
tracing (1.945 ms) : 1902, 1988
.   : milestone, 1945,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.467 ms, 1.49 ms] -
appsec 2.343 ms [2.299 ms, 2.387 ms] 863.926 µs (58.4%)
iast 2.123 ms [2.068 ms, 2.179 ms] 644.426 µs (43.6%)
iast_GLOBAL 2.165 ms [2.108 ms, 2.221 ms] 685.963 µs (46.4%)
profiling 2.444 ms [2.263 ms, 2.625 ms] 965.028 µs (65.3%)
tracing 1.949 ms [1.906 ms, 1.991 ms] 469.95 µs (31.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.339 ms [2.296 ms, 2.383 ms] 870.153 µs (59.2%)
iast 2.112 ms [2.057 ms, 2.168 ms] 642.832 µs (43.7%)
iast_GLOBAL 2.158 ms [2.102 ms, 2.214 ms] 688.615 µs (46.9%)
profiling 1.983 ms [1.937 ms, 2.029 ms] 513.739 µs (35.0%)
tracing 1.945 ms [1.902 ms, 1.988 ms] 475.746 µs (32.4%)

@mcculls mcculls merged commit b999d0f into master Mar 20, 2025
11 checks passed
@mcculls mcculls deleted the mcculls/fix-TagKey-invalid-header-message branch March 20, 2025 17:47
@github-actions github-actions Bot added this to the 1.48.0 milestone Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarziali amarziali amarziali approved these changes

Assignees

No one assigned

Labels

comp: context propagation Trace context propagation comp: logging Tracer internal logging tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @amarziali