Introduce constants to eliminate unnecessary calls to String.format()#8590
Merged
evanchooly merged 1 commit intomasterfrom Mar 19, 2025
Merged
Introduce constants to eliminate unnecessary calls to String.format()#8590evanchooly merged 1 commit intomasterfrom
evanchooly merged 1 commit intomasterfrom
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (319.0 µs) : 285, 353
. : milestone, 319,
basic (312.22 µs) : 303, 321
. : milestone, 312,
loop (10.13 ms) : 10097, 10163
. : milestone, 10130,
section candidate
noprobe (319.269 µs) : 283, 356
. : milestone, 319,
basic (309.366 µs) : 300, 318
. : milestone, 309,
loop (10.14 ms) : 10104, 10177
. : milestone, 10140,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~0de7560ec2, baseline=1.48.0-SNAPSHOT~3c989a4ab1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041407
Total [baseline] (10.475 s) : 0, 10475172
Agent [candidate] (1.041 s) : 0, 1040611
Total [candidate] (10.411 s) : 0, 10411151
section appsec
Agent [baseline] (1.183 s) : 0, 1182531
Total [baseline] (10.793 s) : 0, 10792937
Agent [candidate] (1.184 s) : 0, 1183503
Total [candidate] (10.738 s) : 0, 10738401
section iast
Agent [baseline] (1.178 s) : 0, 1177650
Total [baseline] (11.045 s) : 0, 11045338
Agent [candidate] (1.183 s) : 0, 1182776
Total [candidate] (11.08 s) : 0, 11080394
section profiling
Agent [baseline] (1.262 s) : 0, 1261635
Total [baseline] (10.918 s) : 0, 10917718
Agent [candidate] (1.267 s) : 0, 1267345
Total [candidate] (10.951 s) : 0, 10951006
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~0de7560ec2, baseline=1.48.0-SNAPSHOT~3c989a4ab1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.748 ms) : 0, 717748
BytebuddyAgent [candidate] (717.44 ms) : 0, 717440
GlobalTracer [baseline] (240.446 ms) : 0, 240446
GlobalTracer [candidate] (239.457 ms) : 0, 239457
AppSec [baseline] (54.861 ms) : 0, 54861
AppSec [candidate] (54.174 ms) : 0, 54174
Remote Config [baseline] (703.164 µs) : 0, 703
Remote Config [candidate] (685.6 µs) : 0, 686
Telemetry [baseline] (11.627 ms) : 0, 11627
Telemetry [candidate] (12.963 ms) : 0, 12963
section appsec
BytebuddyAgent [baseline] (734.848 ms) : 0, 734848
BytebuddyAgent [candidate] (735.875 ms) : 0, 735875
GlobalTracer [baseline] (235.912 ms) : 0, 235912
GlobalTracer [candidate] (236.154 ms) : 0, 236154
AppSec [baseline] (176.042 ms) : 0, 176042
AppSec [candidate] (175.911 ms) : 0, 175911
Remote Config [baseline] (660.372 µs) : 0, 660
Remote Config [candidate] (660.745 µs) : 0, 661
Telemetry [baseline] (8.261 ms) : 0, 8261
Telemetry [candidate] (8.289 ms) : 0, 8289
IAST [baseline] (21.703 ms) : 0, 21703
IAST [candidate] (21.399 ms) : 0, 21399
section iast
BytebuddyAgent [baseline] (842.328 ms) : 0, 842328
BytebuddyAgent [candidate] (845.518 ms) : 0, 845518
GlobalTracer [baseline] (230.865 ms) : 0, 230865
GlobalTracer [candidate] (231.873 ms) : 0, 231873
AppSec [baseline] (56.247 ms) : 0, 56247
AppSec [candidate] (56.755 ms) : 0, 56755
Remote Config [baseline] (605.76 µs) : 0, 606
Remote Config [candidate] (621.345 µs) : 0, 621
Telemetry [baseline] (8.656 ms) : 0, 8656
Telemetry [candidate] (8.794 ms) : 0, 8794
IAST [baseline] (22.961 ms) : 0, 22961
IAST [candidate] (23.187 ms) : 0, 23187
section profiling
BytebuddyAgent [baseline] (709.237 ms) : 0, 709237
BytebuddyAgent [candidate] (713.393 ms) : 0, 713393
GlobalTracer [baseline] (350.623 ms) : 0, 350623
GlobalTracer [candidate] (351.352 ms) : 0, 351352
AppSec [baseline] (54.14 ms) : 0, 54140
AppSec [candidate] (53.877 ms) : 0, 53877
Remote Config [baseline] (712.322 µs) : 0, 712
Remote Config [candidate] (719.61 µs) : 0, 720
Telemetry [baseline] (8.966 ms) : 0, 8966
Telemetry [candidate] (8.978 ms) : 0, 8978
ProfilingAgent [baseline] (96.481 ms) : 0, 96481
ProfilingAgent [candidate] (97.464 ms) : 0, 97464
Profiling [baseline] (96.506 ms) : 0, 96506
Profiling [candidate] (97.488 ms) : 0, 97488
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~0de7560ec2, baseline=1.48.0-SNAPSHOT~3c989a4ab1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040606
Total [baseline] (8.689 s) : 0, 8689065
Agent [candidate] (1.057 s) : 0, 1057003
Total [candidate] (8.728 s) : 0, 8728123
section iast
Agent [baseline] (1.172 s) : 0, 1172200
Total [baseline] (9.313 s) : 0, 9312639
Agent [candidate] (1.172 s) : 0, 1171996
Total [candidate] (9.252 s) : 0, 9251895
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174752
Total [baseline] (9.247 s) : 0, 9247046
Agent [candidate] (1.174 s) : 0, 1173827
Total [candidate] (9.196 s) : 0, 9195650
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168888
Total [baseline] (9.257 s) : 0, 9256649
Agent [candidate] (1.178 s) : 0, 1177802
Total [candidate] (9.262 s) : 0, 9262010
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~0de7560ec2, baseline=1.48.0-SNAPSHOT~3c989a4ab1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.713 ms) : 0, 717713
BytebuddyAgent [candidate] (728.386 ms) : 0, 728386
GlobalTracer [baseline] (239.246 ms) : 0, 239246
GlobalTracer [candidate] (242.062 ms) : 0, 242062
AppSec [baseline] (54.676 ms) : 0, 54676
AppSec [candidate] (55.179 ms) : 0, 55179
Remote Config [baseline] (695.715 µs) : 0, 696
Remote Config [candidate] (712.867 µs) : 0, 713
Telemetry [baseline] (12.328 ms) : 0, 12328
Telemetry [candidate] (14.492 ms) : 0, 14492
section iast
BytebuddyAgent [baseline] (838.83 ms) : 0, 838830
BytebuddyAgent [candidate] (837.905 ms) : 0, 837905
GlobalTracer [baseline] (229.847 ms) : 0, 229847
GlobalTracer [candidate] (229.994 ms) : 0, 229994
IAST [baseline] (23.523 ms) : 0, 23523
IAST [candidate] (23.539 ms) : 0, 23539
AppSec [baseline] (54.762 ms) : 0, 54762
AppSec [candidate] (55.45 ms) : 0, 55450
Remote Config [baseline] (616.853 µs) : 0, 617
Remote Config [candidate] (625.777 µs) : 0, 626
Telemetry [baseline] (8.708 ms) : 0, 8708
Telemetry [candidate] (8.639 ms) : 0, 8639
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.195 ms) : 0, 839195
BytebuddyAgent [candidate] (838.922 ms) : 0, 838922
GlobalTracer [baseline] (230.903 ms) : 0, 230903
GlobalTracer [candidate] (231.111 ms) : 0, 231111
IAST [baseline] (22.94 ms) : 0, 22940
IAST [candidate] (23.554 ms) : 0, 23554
AppSec [baseline] (56.349 ms) : 0, 56349
AppSec [candidate] (55.041 ms) : 0, 55041
Remote Config [baseline] (622.934 µs) : 0, 623
Remote Config [candidate] (629.81 µs) : 0, 630
Telemetry [baseline] (8.763 ms) : 0, 8763
Telemetry [candidate] (8.662 ms) : 0, 8662
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.732 ms) : 0, 834732
BytebuddyAgent [candidate] (842.09 ms) : 0, 842090
GlobalTracer [baseline] (230.323 ms) : 0, 230323
GlobalTracer [candidate] (231.527 ms) : 0, 231527
IAST [baseline] (22.399 ms) : 0, 22399
IAST [candidate] (22.653 ms) : 0, 22653
AppSec [baseline] (56.265 ms) : 0, 56265
AppSec [candidate] (56.288 ms) : 0, 56288
Remote Config [baseline] (619.49 µs) : 0, 619
Remote Config [candidate] (616.125 µs) : 0, 616
Telemetry [baseline] (8.608 ms) : 0, 8608
Telemetry [candidate] (8.625 ms) : 0, 8625
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~0de7560ec2, baseline=1.48.0-SNAPSHOT~3c989a4ab1
dateFormat X
axisFormat %s
section baseline
no_agent (376.333 µs) : 356, 397
. : milestone, 376,
iast (516.543 µs) : 495, 538
. : milestone, 517,
iast_FULL (727.393 µs) : 706, 749
. : milestone, 727,
iast_GLOBAL (556.086 µs) : 534, 578
. : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (509.149 µs) : 487, 531
. : milestone, 509,
iast_INACTIVE (463.353 µs) : 442, 485
. : milestone, 463,
iast_TELEMETRY_OFF (502.587 µs) : 480, 525
. : milestone, 503,
tracing (451.287 µs) : 431, 472
. : milestone, 451,
section candidate
no_agent (373.792 µs) : 353, 394
. : milestone, 374,
iast (510.588 µs) : 489, 533
. : milestone, 511,
iast_FULL (731.24 µs) : 709, 753
. : milestone, 731,
iast_GLOBAL (557.395 µs) : 536, 579
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (504.662 µs) : 483, 526
. : milestone, 505,
iast_INACTIVE (464.557 µs) : 443, 486
. : milestone, 465,
iast_TELEMETRY_OFF (499.452 µs) : 478, 521
. : milestone, 499,
tracing (453.596 µs) : 433, 475
. : milestone, 454,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~0de7560ec2, baseline=1.48.0-SNAPSHOT~3c989a4ab1
dateFormat X
axisFormat %s
section baseline
no_agent (1.366 ms) : 1346, 1386
. : milestone, 1366,
appsec (1.735 ms) : 1711, 1758
. : milestone, 1735,
appsec_no_iast (1.759 ms) : 1732, 1785
. : milestone, 1759,
code_origins (1.676 ms) : 1649, 1703
. : milestone, 1676,
iast (1.5 ms) : 1475, 1524
. : milestone, 1500,
profiling (1.51 ms) : 1486, 1534
. : milestone, 1510,
tracing (1.473 ms) : 1447, 1498
. : milestone, 1473,
section candidate
no_agent (1.351 ms) : 1332, 1371
. : milestone, 1351,
appsec (1.733 ms) : 1709, 1756
. : milestone, 1733,
appsec_no_iast (1.73 ms) : 1706, 1754
. : milestone, 1730,
code_origins (1.668 ms) : 1640, 1695
. : milestone, 1668,
iast (1.521 ms) : 1497, 1545
. : milestone, 1521,
profiling (1.545 ms) : 1521, 1570
. : milestone, 1545,
tracing (1.488 ms) : 1464, 1512
. : milestone, 1488,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~0de7560ec2, baseline=1.48.0-SNAPSHOT~3c989a4ab1
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.362 ms) : 2317, 2407
. : milestone, 2362,
iast (2.135 ms) : 2078, 2191
. : milestone, 2135,
iast_GLOBAL (2.183 ms) : 2126, 2240
. : milestone, 2183,
profiling (1.998 ms) : 1952, 2044
. : milestone, 1998,
tracing (1.962 ms) : 1918, 2005
. : milestone, 1962,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.353 ms) : 2308, 2398
. : milestone, 2353,
iast (2.133 ms) : 2077, 2190
. : milestone, 2133,
iast_GLOBAL (2.176 ms) : 2119, 2233
. : milestone, 2176,
profiling (2.456 ms) : 2275, 2636
. : milestone, 2456,
tracing (1.961 ms) : 1917, 2004
. : milestone, 1961,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~0de7560ec2, baseline=1.48.0-SNAPSHOT~3c989a4ab1
dateFormat X
axisFormat %s
section baseline
no_agent (15.326 s) : 15326000, 15326000
. : milestone, 15326000,
appsec (15.084 s) : 15084000, 15084000
. : milestone, 15084000,
iast (18.466 s) : 18466000, 18466000
. : milestone, 18466000,
iast_GLOBAL (18.148 s) : 18148000, 18148000
. : milestone, 18148000,
profiling (15.301 s) : 15301000, 15301000
. : milestone, 15301000,
tracing (15.173 s) : 15173000, 15173000
. : milestone, 15173000,
section candidate
no_agent (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
appsec (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
iast (18.319 s) : 18319000, 18319000
. : milestone, 18319000,
iast_GLOBAL (17.981 s) : 17981000, 17981000
. : milestone, 17981000,
profiling (15.117 s) : 15117000, 15117000
. : milestone, 15117000,
tracing (15.202 s) : 15202000, 15202000
. : milestone, 15202000,
|
jpbempel
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Eliminates some unnecessary calls to String.format() so that they don't show up in the flamegraph when looking at traces.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issue