Skip to content

Simplification: Context.root() is always empty#8580

Merged
mcculls merged 1 commit intomasterfrom
mcculls/context-root-is-empty
Mar 18, 2025
Merged

Simplification: Context.root() is always empty#8580
mcculls merged 1 commit intomasterfrom
mcculls/context-root-is-empty

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Mar 18, 2025 •
edited by atlassian Bot
Loading

Motivation

We haven't needed a non-empty root context, and collapsing these concepts together simplifies the code.

Contributor Checklist

Jira ticket: APMAPI-981

@mcculls
Simplification: Context.root() is always empty
543740a 
We haven't needed a non-empty root context, and collapsing these concepts together simplifies the code.
@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 18, 2025
@mcculls mcculls requested a review from a team as a code owner March 18, 2025 10:36
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 18, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/context-root-is-empty
git_commit_date 1742285131 1742294117
git_commit_sha b046b86 543740a
release_version 1.48.0-SNAPSHOT~b046b86617 1.48.0-SNAPSHOT~543740a22b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1742296700 1742296700
ci_job_id 852378943 852378943
ci_pipeline_id 59149119 59149119
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-dthjy2ah-project-304-concurrent-2-ehj8ntbv 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-dthjy2ah-project-304-concurrent-2-ehj8ntbv 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~543740a22b, baseline=1.48.0-SNAPSHOT~b046b86617

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045242
Total [baseline] (10.497 s) : 0, 10496777
Agent [candidate] (1.042 s) : 0, 1042150
Total [candidate] (10.454 s) : 0, 10454473
section appsec
Agent [baseline] (1.186 s) : 0, 1186262
Total [baseline] (10.74 s) : 0, 10739681
Agent [candidate] (1.186 s) : 0, 1185869
Total [candidate] (10.744 s) : 0, 10744097
section iast
Agent [baseline] (1.177 s) : 0, 1176545
Total [baseline] (11.003 s) : 0, 11002553
Agent [candidate] (1.174 s) : 0, 1174348
Total [candidate] (10.978 s) : 0, 10977999
section profiling
Agent [baseline] (1.258 s) : 0, 1258468
Total [baseline] (10.822 s) : 0, 10822495
Agent [candidate] (1.261 s) : 0, 1261428
Total [candidate] (10.801 s) : 0, 10801151
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.186 s 141.02 ms (13.5%)
Agent iast 1.177 s 131.303 ms (12.6%)
Agent profiling 1.258 s 213.226 ms (20.4%)
Total tracing 10.497 s -
Total appsec 10.74 s 242.904 ms (2.3%)
Total iast 11.003 s 505.776 ms (4.8%)
Total profiling 10.822 s 325.717 ms (3.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent appsec 1.186 s 143.719 ms (13.8%)
Agent iast 1.174 s 132.198 ms (12.7%)
Agent profiling 1.261 s 219.278 ms (21.0%)
Total tracing 10.454 s -
Total appsec 10.744 s 289.624 ms (2.8%)
Total iast 10.978 s 523.526 ms (5.0%)
Total profiling 10.801 s 346.678 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~543740a22b, baseline=1.48.0-SNAPSHOT~b046b86617

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.298 ms) : 0, 722298
BytebuddyAgent [candidate] (717.932 ms) : 0, 717932
GlobalTracer [baseline] (240.628 ms) : 0, 240628
GlobalTracer [candidate] (239.606 ms) : 0, 239606
AppSec [baseline] (54.79 ms) : 0, 54790
AppSec [candidate] (54.837 ms) : 0, 54837
Remote Config [baseline] (693.356 µs) : 0, 693
Remote Config [candidate] (694.499 µs) : 0, 694
Telemetry [baseline] (11.523 ms) : 0, 11523
Telemetry [candidate] (13.915 ms) : 0, 13915
section appsec
BytebuddyAgent [baseline] (737.523 ms) : 0, 737523
BytebuddyAgent [candidate] (737.499 ms) : 0, 737499
GlobalTracer [baseline] (236.706 ms) : 0, 236706
GlobalTracer [candidate] (237.151 ms) : 0, 237151
IAST [baseline] (21.769 ms) : 0, 21769
IAST [candidate] (21.461 ms) : 0, 21461
AppSec [baseline] (176.625 ms) : 0, 176625
AppSec [candidate] (175.875 ms) : 0, 175875
Remote Config [baseline] (655.921 µs) : 0, 656
Remote Config [candidate] (660.082 µs) : 0, 660
Telemetry [baseline] (8.639 ms) : 0, 8639
Telemetry [candidate] (8.703 ms) : 0, 8703
section iast
BytebuddyAgent [baseline] (841.68 ms) : 0, 841680
BytebuddyAgent [candidate] (839.942 ms) : 0, 839942
GlobalTracer [baseline] (230.989 ms) : 0, 230989
GlobalTracer [candidate] (230.37 ms) : 0, 230370
IAST [baseline] (23.568 ms) : 0, 23568
IAST [candidate] (22.967 ms) : 0, 22967
AppSec [baseline] (55.709 ms) : 0, 55709
AppSec [candidate] (56.536 ms) : 0, 56536
Remote Config [baseline] (607.752 µs) : 0, 608
Remote Config [candidate] (625.253 µs) : 0, 625
Telemetry [baseline] (8.762 ms) : 0, 8762
Telemetry [candidate] (8.648 ms) : 0, 8648
section profiling
BytebuddyAgent [baseline] (708.925 ms) : 0, 708925
BytebuddyAgent [candidate] (709.96 ms) : 0, 709960
GlobalTracer [baseline] (348.728 ms) : 0, 348728
GlobalTracer [candidate] (351.393 ms) : 0, 351393
AppSec [baseline] (54.295 ms) : 0, 54295
AppSec [candidate] (53.601 ms) : 0, 53601
Remote Config [baseline] (672.93 µs) : 0, 673
Remote Config [candidate] (676.22 µs) : 0, 676
Telemetry [baseline] (8.982 ms) : 0, 8982
Telemetry [candidate] (9.003 ms) : 0, 9003
ProfilingAgent [baseline] (95.921 ms) : 0, 95921
ProfilingAgent [candidate] (95.996 ms) : 0, 95996
Profiling [baseline] (95.947 ms) : 0, 95947
Profiling [candidate] (96.02 ms) : 0, 96020
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~543740a22b, baseline=1.48.0-SNAPSHOT~b046b86617

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039765
Total [baseline] (8.689 s) : 0, 8689432
Agent [candidate] (1.043 s) : 0, 1042852
Total [candidate] (8.647 s) : 0, 8647005
section iast
Agent [baseline] (1.174 s) : 0, 1173557
Total [baseline] (9.264 s) : 0, 9263783
Agent [candidate] (1.187 s) : 0, 1186535
Total [candidate] (9.317 s) : 0, 9317256
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171724
Total [baseline] (9.181 s) : 0, 9180557
Agent [candidate] (1.177 s) : 0, 1177014
Total [candidate] (9.184 s) : 0, 9183913
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1176690
Total [baseline] (9.248 s) : 0, 9247680
Agent [candidate] (1.18 s) : 0, 1180427
Total [candidate] (9.228 s) : 0, 9228064
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.04 s -
Agent iast 1.174 s 133.792 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 131.958 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.177 s 136.925 ms (13.2%)
Total tracing 8.689 s -
Total iast 9.264 s 574.351 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.181 s 491.125 ms (5.7%)
Total iast_TELEMETRY_OFF 9.248 s 558.248 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent iast 1.187 s 143.683 ms (13.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 134.163 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.18 s 137.575 ms (13.2%)
Total tracing 8.647 s -
Total iast 9.317 s 670.251 ms (7.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.184 s 536.908 ms (6.2%)
Total iast_TELEMETRY_OFF 9.228 s 581.06 ms (6.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~543740a22b, baseline=1.48.0-SNAPSHOT~b046b86617

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.829 ms) : 0, 716829
BytebuddyAgent [candidate] (722.943 ms) : 0, 722943
GlobalTracer [baseline] (238.901 ms) : 0, 238901
GlobalTracer [candidate] (239.288 ms) : 0, 239288
AppSec [baseline] (54.586 ms) : 0, 54586
AppSec [candidate] (54.523 ms) : 0, 54523
Remote Config [baseline] (686.86 µs) : 0, 687
Remote Config [candidate] (691.391 µs) : 0, 691
Telemetry [baseline] (13.575 ms) : 0, 13575
Telemetry [candidate] (10.045 ms) : 0, 10045
section iast
BytebuddyAgent [baseline] (838.941 ms) : 0, 838941
BytebuddyAgent [candidate] (849.998 ms) : 0, 849998
GlobalTracer [baseline] (230.788 ms) : 0, 230788
GlobalTracer [candidate] (232.217 ms) : 0, 232217
IAST [baseline] (22.877 ms) : 0, 22877
IAST [candidate] (23.917 ms) : 0, 23917
AppSec [baseline] (56.418 ms) : 0, 56418
AppSec [candidate] (55.434 ms) : 0, 55434
Remote Config [baseline] (607.005 µs) : 0, 607
Remote Config [candidate] (610.621 µs) : 0, 611
Telemetry [baseline] (8.715 ms) : 0, 8715
Telemetry [candidate] (8.848 ms) : 0, 8848
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.767 ms) : 0, 837767
BytebuddyAgent [candidate] (843.188 ms) : 0, 843188
GlobalTracer [baseline] (230.368 ms) : 0, 230368
GlobalTracer [candidate] (230.128 ms) : 0, 230128
IAST [baseline] (22.861 ms) : 0, 22861
IAST [candidate] (22.727 ms) : 0, 22727
AppSec [baseline] (56.204 ms) : 0, 56204
AppSec [candidate] (56.157 ms) : 0, 56157
Remote Config [baseline] (597.062 µs) : 0, 597
Remote Config [candidate] (600.434 µs) : 0, 600
Telemetry [baseline] (8.678 ms) : 0, 8678
Telemetry [candidate] (8.659 ms) : 0, 8659
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (841.522 ms) : 0, 841522
BytebuddyAgent [candidate] (846.297 ms) : 0, 846297
GlobalTracer [baseline] (231.093 ms) : 0, 231093
GlobalTracer [candidate] (231.087 ms) : 0, 231087
IAST [baseline] (22.52 ms) : 0, 22520
IAST [candidate] (22.33 ms) : 0, 22330
AppSec [baseline] (56.696 ms) : 0, 56696
AppSec [candidate] (55.984 ms) : 0, 55984
Remote Config [baseline] (625.319 µs) : 0, 625
Remote Config [candidate] (607.763 µs) : 0, 608
Telemetry [baseline] (8.807 ms) : 0, 8807
Telemetry [candidate] (8.667 ms) : 0, 8667
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-18T10:50:43 2025-03-18T10:58:27
git_branch master mcculls/context-root-is-empty
git_commit_date 1742285131 1742294117
git_commit_sha b046b86 543740a
release_version 1.48.0-SNAPSHOT~b046b86617 1.48.0-SNAPSHOT~543740a22b
start_time 2025-03-18T10:50:29 2025-03-18T10:58:13
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1742295903 1742295903
ci_job_id 852378944 852378944
ci_pipeline_id 59149119 59149119
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ba8qknxw-project-304-concurrent-3-hxar9zoq 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ba8qknxw-project-304-concurrent-3-hxar9zoq 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-115.782µs; -63.505µs] or [-7.282%; -3.994%]		 unstable
[-442.436op/s; +670.356op/s] or [-14.932%; +22.625%]		 1.500ms 3076.923op/s 1.590ms 2962.963op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~543740a22b, baseline=1.48.0-SNAPSHOT~b046b86617
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.47 µs) : 356, 395
.   : milestone, 375,
iast (515.298 µs) : 493, 537
.   : milestone, 515,
iast_FULL (727.368 µs) : 705, 749
.   : milestone, 727,
iast_GLOBAL (557.239 µs) : 536, 579
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (508.976 µs) : 487, 531
.   : milestone, 509,
iast_INACTIVE (461.016 µs) : 440, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (494.77 µs) : 473, 516
.   : milestone, 495,
tracing (454.999 µs) : 434, 476
.   : milestone, 455,
section candidate
no_agent (380.718 µs) : 360, 401
.   : milestone, 381,
iast (509.394 µs) : 487, 532
.   : milestone, 509,
iast_FULL (723.327 µs) : 701, 745
.   : milestone, 723,
iast_GLOBAL (562.301 µs) : 540, 585
.   : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (512.086 µs) : 490, 534
.   : milestone, 512,
iast_INACTIVE (459.459 µs) : 438, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (494.477 µs) : 473, 516
.   : milestone, 494,
tracing (453.53 µs) : 433, 474
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.47 µs [355.548 µs, 395.392 µs] -
iast 515.298 µs [493.387 µs, 537.21 µs] 139.828 µs (37.2%)
iast_FULL 727.368 µs [705.485 µs, 749.251 µs] 351.898 µs (93.7%)
iast_GLOBAL 557.239 µs [535.606 µs, 578.871 µs] 181.769 µs (48.4%)
iast_HARDCODED_SECRET_DISABLED 508.976 µs [487.296 µs, 530.656 µs] 133.506 µs (35.6%)
iast_INACTIVE 461.016 µs [440.08 µs, 481.952 µs] 85.546 µs (22.8%)
iast_TELEMETRY_OFF 494.77 µs [473.446 µs, 516.093 µs] 119.3 µs (31.8%)
tracing 454.999 µs [434.239 µs, 475.758 µs] 79.529 µs (21.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.718 µs [360.121 µs, 401.314 µs] -
iast 509.394 µs [487.177 µs, 531.611 µs] 128.677 µs (33.8%)
iast_FULL 723.327 µs [701.439 µs, 745.215 µs] 342.609 µs (90.0%)
iast_GLOBAL 562.301 µs [539.531 µs, 585.072 µs] 181.584 µs (47.7%)
iast_HARDCODED_SECRET_DISABLED 512.086 µs [490.402 µs, 533.771 µs] 131.369 µs (34.5%)
iast_INACTIVE 459.459 µs [437.807 µs, 481.111 µs] 78.741 µs (20.7%)
iast_TELEMETRY_OFF 494.477 µs [472.761 µs, 516.192 µs] 113.759 µs (29.9%)
tracing 453.53 µs [432.599 µs, 474.46 µs] 72.812 µs (19.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~543740a22b, baseline=1.48.0-SNAPSHOT~b046b86617
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1368
.   : milestone, 1349,
appsec (1.744 ms) : 1721, 1767
.   : milestone, 1744,
appsec_no_iast (1.741 ms) : 1717, 1766
.   : milestone, 1741,
code_origins (1.65 ms) : 1622, 1677
.   : milestone, 1650,
iast (1.513 ms) : 1488, 1538
.   : milestone, 1513,
profiling (1.59 ms) : 1565, 1615
.   : milestone, 1590,
tracing (1.49 ms) : 1465, 1515
.   : milestone, 1490,
section candidate
no_agent (1.362 ms) : 1343, 1382
.   : milestone, 1362,
appsec (1.721 ms) : 1697, 1745
.   : milestone, 1721,
appsec_no_iast (1.737 ms) : 1713, 1762
.   : milestone, 1737,
code_origins (1.668 ms) : 1642, 1695
.   : milestone, 1668,
iast (1.506 ms) : 1481, 1531
.   : milestone, 1506,
profiling (1.5 ms) : 1477, 1524
.   : milestone, 1500,
tracing (1.492 ms) : 1467, 1516
.   : milestone, 1492,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.329 ms, 1.368 ms] -
appsec 1.744 ms [1.721 ms, 1.767 ms] 395.616 µs (29.3%)
appsec_no_iast 1.741 ms [1.717 ms, 1.766 ms] 392.439 µs (29.1%)
code_origins 1.65 ms [1.622 ms, 1.677 ms] 300.925 µs (22.3%)
iast 1.513 ms [1.488 ms, 1.538 ms] 163.874 µs (12.2%)
profiling 1.59 ms [1.565 ms, 1.615 ms] 241.283 µs (17.9%)
tracing 1.49 ms [1.465 ms, 1.515 ms] 141.347 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.382 ms] -
appsec 1.721 ms [1.697 ms, 1.745 ms] 358.436 µs (26.3%)
appsec_no_iast 1.737 ms [1.713 ms, 1.762 ms] 374.792 µs (27.5%)
code_origins 1.668 ms [1.642 ms, 1.695 ms] 305.782 µs (22.4%)
iast 1.506 ms [1.481 ms, 1.531 ms] 143.596 µs (10.5%)
profiling 1.5 ms [1.477 ms, 1.524 ms] 137.87 µs (10.1%)
tracing 1.492 ms [1.467 ms, 1.516 ms] 129.376 µs (9.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/context-root-is-empty
git_commit_date 1742285131 1742294117
git_commit_sha b046b86 543740a
release_version 1.48.0-SNAPSHOT~b046b86617 1.48.0-SNAPSHOT~543740a22b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1742296371 1742296371
ci_job_id 852378945 852378945
ci_pipeline_id 59149119 59149119
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-jrmrzmky-project-304-concurrent-3-noa0raz9 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-jrmrzmky-project-304-concurrent-3-noa0raz9 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~543740a22b, baseline=1.48.0-SNAPSHOT~b046b86617
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.069 s) : 15069000, 15069000
.   : milestone, 15069000,
appsec (14.891 s) : 14891000, 14891000
.   : milestone, 14891000,
iast (19.056 s) : 19056000, 19056000
.   : milestone, 19056000,
iast_GLOBAL (18.223 s) : 18223000, 18223000
.   : milestone, 18223000,
profiling (15.567 s) : 15567000, 15567000
.   : milestone, 15567000,
tracing (14.871 s) : 14871000, 14871000
.   : milestone, 14871000,
section candidate
no_agent (15.188 s) : 15188000, 15188000
.   : milestone, 15188000,
appsec (15.116 s) : 15116000, 15116000
.   : milestone, 15116000,
iast (19.005 s) : 19005000, 19005000
.   : milestone, 19005000,
iast_GLOBAL (18.04 s) : 18040000, 18040000
.   : milestone, 18040000,
profiling (15.183 s) : 15183000, 15183000
.   : milestone, 15183000,
tracing (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.069 s [15.069 s, 15.069 s] -
appsec 14.891 s [14.891 s, 14.891 s] -178.0 ms (-1.2%)
iast 19.056 s [19.056 s, 19.056 s] 3.987 s (26.5%)
iast_GLOBAL 18.223 s [18.223 s, 18.223 s] 3.154 s (20.9%)
profiling 15.567 s [15.567 s, 15.567 s] 498.0 ms (3.3%)
tracing 14.871 s [14.871 s, 14.871 s] -198.0 ms (-1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.188 s [15.188 s, 15.188 s] -
appsec 15.116 s [15.116 s, 15.116 s] -72.0 ms (-0.5%)
iast 19.005 s [19.005 s, 19.005 s] 3.817 s (25.1%)
iast_GLOBAL 18.04 s [18.04 s, 18.04 s] 2.852 s (18.8%)
profiling 15.183 s [15.183 s, 15.183 s] -5.0 ms (-0.0%)
tracing 15.019 s [15.019 s, 15.019 s] -169.0 ms (-1.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~543740a22b, baseline=1.48.0-SNAPSHOT~b046b86617
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.357 ms) : 2313, 2402
.   : milestone, 2357,
iast (2.123 ms) : 2067, 2180
.   : milestone, 2123,
iast_GLOBAL (2.167 ms) : 2111, 2223
.   : milestone, 2167,
profiling (1.987 ms) : 1943, 2031
.   : milestone, 1987,
tracing (1.948 ms) : 1905, 1990
.   : milestone, 1948,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.352 ms) : 2308, 2396
.   : milestone, 2352,
iast (2.127 ms) : 2071, 2182
.   : milestone, 2127,
iast_GLOBAL (2.166 ms) : 2111, 2222
.   : milestone, 2166,
profiling (1.988 ms) : 1943, 2032
.   : milestone, 1988,
tracing (1.953 ms) : 1910, 1995
.   : milestone, 1953,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.357 ms [2.313 ms, 2.402 ms] 885.357 µs (60.1%)
iast 2.123 ms [2.067 ms, 2.18 ms] 651.417 µs (44.3%)
iast_GLOBAL 2.167 ms [2.111 ms, 2.223 ms] 694.938 µs (47.2%)
profiling 1.987 ms [1.943 ms, 2.031 ms] 515.042 µs (35.0%)
tracing 1.948 ms [1.905 ms, 1.99 ms] 475.667 µs (32.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 2.352 ms [2.308 ms, 2.396 ms] 878.987 µs (59.7%)
iast 2.127 ms [2.071 ms, 2.182 ms] 653.672 µs (44.4%)
iast_GLOBAL 2.166 ms [2.111 ms, 2.222 ms] 693.486 µs (47.1%)
profiling 1.988 ms [1.943 ms, 2.032 ms] 514.561 µs (34.9%)
tracing 1.953 ms [1.91 ms, 1.995 ms] 479.71 µs (32.6%)

@mcculls mcculls added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Mar 18, 2025
@mcculls mcculls merged commit 6a24044 into master Mar 18, 2025
@mcculls mcculls deleted the mcculls/context-root-is-empty branch March 18, 2025 11:42
@github-actions github-actions Bot added this to the 1.48.0 milestone Mar 18, 2025
mtoffl01 pushed a commit that referenced this pull request Mar 24, 2025
@mcculls @mtoffl01
Simplification: Context.root() is always empty (#8580)
f7a339e 
We haven't needed a non-empty root context, and collapsing these concepts together simplifies the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@amarziali amarziali amarziali approved these changes

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @PerfectSlayer @amarziali