Skip to content

Simplify activateSpan API to not include async propagation flag#8557

Merged
mcculls merged 1 commit intomasterfrom
mcculls/simplify-activateSpan-api
Mar 14, 2025
Merged

Simplify activateSpan API to not include async propagation flag#8557
mcculls merged 1 commit intomasterfrom
mcculls/simplify-activateSpan-api

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Mar 13, 2025 •
edited by atlassian Bot
Loading

Motivation

These remaining cases were no-op spans which are already not propagated

Contributor Checklist

Jira ticket: APMAPI-981

@mcculls mcculls added tag: do not merge Do not merge changes comp: core Tracer core type: refactoring labels Mar 13, 2025
@mcculls mcculls force-pushed the mcculls/simplify-activateSpan-api branch from 7d25fd4 to 41ae3f7 Compare March 13, 2025 20:38
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 13, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-activateSpan-api
git_commit_date 1741954872 1741956272
git_commit_sha bde13e8 a250aca
release_version 1.48.0-SNAPSHOT~bde13e8991 1.48.0-SNAPSHOT~a250acae00
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741958949 1741958949
ci_job_id 848290469 848290469
ci_pipeline_id 58835876 58835876
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-99grvqzx-project-304-concurrent-1-9l18fmlc 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-99grvqzx-project-304-concurrent-1-9l18fmlc 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~a250acae00, baseline=1.48.0-SNAPSHOT~bde13e8991

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043473
Total [baseline] (10.495 s) : 0, 10494695
Agent [candidate] (1.048 s) : 0, 1048138
Total [candidate] (10.502 s) : 0, 10501657
section appsec
Agent [baseline] (1.182 s) : 0, 1181539
Total [baseline] (10.813 s) : 0, 10813088
Agent [candidate] (1.186 s) : 0, 1186143
Total [candidate] (10.776 s) : 0, 10776265
section iast
Agent [baseline] (1.174 s) : 0, 1174412
Total [baseline] (11.021 s) : 0, 11021159
Agent [candidate] (1.176 s) : 0, 1175600
Total [candidate] (11.047 s) : 0, 11047465
section profiling
Agent [baseline] (1.26 s) : 0, 1260175
Total [baseline] (10.945 s) : 0, 10945238
Agent [candidate] (1.268 s) : 0, 1268386
Total [candidate] (10.948 s) : 0, 10947975
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent appsec 1.182 s 138.066 ms (13.2%)
Agent iast 1.174 s 130.94 ms (12.5%)
Agent profiling 1.26 s 216.702 ms (20.8%)
Total tracing 10.495 s -
Total appsec 10.813 s 318.394 ms (3.0%)
Total iast 11.021 s 526.464 ms (5.0%)
Total profiling 10.945 s 450.543 ms (4.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.186 s 138.005 ms (13.2%)
Agent iast 1.176 s 127.462 ms (12.2%)
Agent profiling 1.268 s 220.248 ms (21.0%)
Total tracing 10.502 s -
Total appsec 10.776 s 274.608 ms (2.6%)
Total iast 11.047 s 545.809 ms (5.2%)
Total profiling 10.948 s 446.318 ms (4.2%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~a250acae00, baseline=1.48.0-SNAPSHOT~bde13e8991

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.857 ms) : 0, 719857
BytebuddyAgent [candidate] (723.045 ms) : 0, 723045
GlobalTracer [baseline] (240.389 ms) : 0, 240389
GlobalTracer [candidate] (241.037 ms) : 0, 241037
AppSec [baseline] (54.989 ms) : 0, 54989
AppSec [candidate] (55.171 ms) : 0, 55171
Remote Config [baseline] (698.886 µs) : 0, 699
Remote Config [candidate] (698.531 µs) : 0, 699
Telemetry [baseline] (12.261 ms) : 0, 12261
Telemetry [candidate] (12.924 ms) : 0, 12924
section appsec
BytebuddyAgent [baseline] (734.679 ms) : 0, 734679
BytebuddyAgent [candidate] (738.197 ms) : 0, 738197
GlobalTracer [baseline] (236.022 ms) : 0, 236022
GlobalTracer [candidate] (237.208 ms) : 0, 237208
AppSec [baseline] (175.574 ms) : 0, 175574
AppSec [candidate] (175.528 ms) : 0, 175528
Remote Config [baseline] (663.131 µs) : 0, 663
Remote Config [candidate] (673.405 µs) : 0, 673
Telemetry [baseline] (8.644 ms) : 0, 8644
Telemetry [candidate] (8.32 ms) : 0, 8320
IAST [baseline] (21.488 ms) : 0, 21488
IAST [candidate] (21.867 ms) : 0, 21867
section iast
BytebuddyAgent [baseline] (839.746 ms) : 0, 839746
BytebuddyAgent [candidate] (841.891 ms) : 0, 841891
GlobalTracer [baseline] (231.06 ms) : 0, 231060
GlobalTracer [candidate] (230.312 ms) : 0, 230312
AppSec [baseline] (56.455 ms) : 0, 56455
AppSec [candidate] (56.166 ms) : 0, 56166
Remote Config [baseline] (604.059 µs) : 0, 604
Remote Config [candidate] (607.192 µs) : 0, 607
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.66 ms) : 0, 8660
IAST [baseline] (22.669 ms) : 0, 22669
IAST [candidate] (22.631 ms) : 0, 22631
section profiling
ProfilingAgent [baseline] (97.031 ms) : 0, 97031
ProfilingAgent [candidate] (97.626 ms) : 0, 97626
BytebuddyAgent [baseline] (707.678 ms) : 0, 707678
BytebuddyAgent [candidate] (714.735 ms) : 0, 714735
GlobalTracer [baseline] (350.093 ms) : 0, 350093
GlobalTracer [candidate] (351.367 ms) : 0, 351367
AppSec [baseline] (54.647 ms) : 0, 54647
AppSec [candidate] (53.87 ms) : 0, 53870
Remote Config [baseline] (673.703 µs) : 0, 674
Remote Config [candidate] (671.268 µs) : 0, 671
Telemetry [baseline] (8.985 ms) : 0, 8985
Telemetry [candidate] (8.994 ms) : 0, 8994
Profiling [baseline] (97.056 ms) : 0, 97056
Profiling [candidate] (97.65 ms) : 0, 97650
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~a250acae00, baseline=1.48.0-SNAPSHOT~bde13e8991

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050927
Total [baseline] (8.699 s) : 0, 8699291
Agent [candidate] (1.041 s) : 0, 1040909
Total [candidate] (8.682 s) : 0, 8681765
section iast
Agent [baseline] (1.181 s) : 0, 1180580
Total [baseline] (9.308 s) : 0, 9307731
Agent [candidate] (1.176 s) : 0, 1175795
Total [candidate] (9.286 s) : 0, 9286137
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171748
Total [baseline] (9.216 s) : 0, 9215831
Agent [candidate] (1.173 s) : 0, 1172525
Total [candidate] (9.222 s) : 0, 9222096
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1176600
Total [baseline] (9.257 s) : 0, 9257445
Agent [candidate] (1.178 s) : 0, 1177882
Total [candidate] (9.308 s) : 0, 9307751
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.181 s 129.653 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 120.821 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.177 s 125.673 ms (12.0%)
Total tracing 8.699 s -
Total iast 9.308 s 608.44 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.216 s 516.54 ms (5.9%)
Total iast_TELEMETRY_OFF 9.257 s 558.154 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent iast 1.176 s 134.886 ms (13.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.173 s 131.616 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.178 s 136.973 ms (13.2%)
Total tracing 8.682 s -
Total iast 9.286 s 604.372 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.222 s 540.331 ms (6.2%)
Total iast_TELEMETRY_OFF 9.308 s 625.986 ms (7.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~a250acae00, baseline=1.48.0-SNAPSHOT~bde13e8991

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.247 ms) : 0, 724247
BytebuddyAgent [candidate] (717.998 ms) : 0, 717998
GlobalTracer [baseline] (241.503 ms) : 0, 241503
GlobalTracer [candidate] (240.088 ms) : 0, 240088
AppSec [baseline] (54.674 ms) : 0, 54674
AppSec [candidate] (54.764 ms) : 0, 54764
Remote Config [baseline] (690.538 µs) : 0, 691
Remote Config [candidate] (692.633 µs) : 0, 693
Telemetry [baseline] (14.464 ms) : 0, 14464
Telemetry [candidate] (12.178 ms) : 0, 12178
section iast
BytebuddyAgent [baseline] (844.998 ms) : 0, 844998
BytebuddyAgent [candidate] (840.676 ms) : 0, 840676
GlobalTracer [baseline] (231.647 ms) : 0, 231647
GlobalTracer [candidate] (231.461 ms) : 0, 231461
IAST [baseline] (22.869 ms) : 0, 22869
IAST [candidate] (22.897 ms) : 0, 22897
AppSec [baseline] (56.427 ms) : 0, 56427
AppSec [candidate] (56.233 ms) : 0, 56233
Remote Config [baseline] (609.258 µs) : 0, 609
Remote Config [candidate] (605.979 µs) : 0, 606
Telemetry [baseline] (8.748 ms) : 0, 8748
Telemetry [candidate] (8.673 ms) : 0, 8673
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.343 ms) : 0, 837343
BytebuddyAgent [candidate] (837.524 ms) : 0, 837524
GlobalTracer [baseline] (230.844 ms) : 0, 230844
GlobalTracer [candidate] (230.882 ms) : 0, 230882
IAST [baseline] (22.868 ms) : 0, 22868
IAST [candidate] (23.102 ms) : 0, 23102
AppSec [baseline] (56.148 ms) : 0, 56148
AppSec [candidate] (56.454 ms) : 0, 56454
Remote Config [baseline] (604.881 µs) : 0, 605
Remote Config [candidate] (613.16 µs) : 0, 613
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (8.687 ms) : 0, 8687
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (841.286 ms) : 0, 841286
BytebuddyAgent [candidate] (842.086 ms) : 0, 842086
GlobalTracer [baseline] (232.125 ms) : 0, 232125
GlobalTracer [candidate] (232.129 ms) : 0, 232129
IAST [baseline] (23.1 ms) : 0, 23100
IAST [candidate] (22.511 ms) : 0, 22511
AppSec [baseline] (55.538 ms) : 0, 55538
AppSec [candidate] (56.46 ms) : 0, 56460
Remote Config [baseline] (603.152 µs) : 0, 603
Remote Config [candidate] (616.356 µs) : 0, 616
Telemetry [baseline] (8.58 ms) : 0, 8580
Telemetry [candidate] (8.627 ms) : 0, 8627
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-14T12:56:55 2025-03-14T13:04:39
git_branch master mcculls/simplify-activateSpan-api
git_commit_date 1741954872 1741956272
git_commit_sha bde13e8 a250aca
release_version 1.48.0-SNAPSHOT~bde13e8991 1.48.0-SNAPSHOT~a250acae00
start_time 2025-03-14T12:56:41 2025-03-14T13:04:25
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741957875 1741957875
ci_job_id 848290470 848290470
ci_pipeline_id 58835876 58835876
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-titz-rmh-project-304-concurrent-0-nhc2fqqk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-titz-rmh-project-304-concurrent-0-nhc2fqqk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~a250acae00, baseline=1.48.0-SNAPSHOT~bde13e8991
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.543 µs) : 360, 399
.   : milestone, 380,
iast (508.782 µs) : 487, 531
.   : milestone, 509,
iast_FULL (729.871 µs) : 708, 752
.   : milestone, 730,
iast_GLOBAL (551.325 µs) : 530, 573
.   : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (516.139 µs) : 494, 538
.   : milestone, 516,
iast_INACTIVE (456.022 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (497.895 µs) : 475, 520
.   : milestone, 498,
tracing (454.606 µs) : 434, 475
.   : milestone, 455,
section candidate
no_agent (382.864 µs) : 362, 403
.   : milestone, 383,
iast (508.698 µs) : 487, 530
.   : milestone, 509,
iast_FULL (732.851 µs) : 711, 755
.   : milestone, 733,
iast_GLOBAL (561.192 µs) : 539, 583
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (504.722 µs) : 483, 526
.   : milestone, 505,
iast_INACTIVE (463.838 µs) : 443, 485
.   : milestone, 464,
iast_TELEMETRY_OFF (500.514 µs) : 478, 523
.   : milestone, 501,
tracing (454.908 µs) : 434, 476
.   : milestone, 455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.543 µs [359.955 µs, 399.131 µs] -
iast 508.782 µs [487.059 µs, 530.505 µs] 129.239 µs (34.1%)
iast_FULL 729.871 µs [708.05 µs, 751.692 µs] 350.328 µs (92.3%)
iast_GLOBAL 551.325 µs [529.679 µs, 572.971 µs] 171.782 µs (45.3%)
iast_HARDCODED_SECRET_DISABLED 516.139 µs [493.836 µs, 538.442 µs] 136.596 µs (36.0%)
iast_INACTIVE 456.022 µs [435.23 µs, 476.813 µs] 76.478 µs (20.2%)
iast_TELEMETRY_OFF 497.895 µs [475.419 µs, 520.372 µs] 118.352 µs (31.2%)
tracing 454.606 µs [433.894 µs, 475.319 µs] 75.063 µs (19.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.864 µs [362.462 µs, 403.266 µs] -
iast 508.698 µs [487.371 µs, 530.024 µs] 125.834 µs (32.9%)
iast_FULL 732.851 µs [710.848 µs, 754.854 µs] 349.987 µs (91.4%)
iast_GLOBAL 561.192 µs [539.415 µs, 582.968 µs] 178.328 µs (46.6%)
iast_HARDCODED_SECRET_DISABLED 504.722 µs [483.11 µs, 526.334 µs] 121.858 µs (31.8%)
iast_INACTIVE 463.838 µs [442.525 µs, 485.151 µs] 80.975 µs (21.1%)
iast_TELEMETRY_OFF 500.514 µs [478.059 µs, 522.969 µs] 117.65 µs (30.7%)
tracing 454.908 µs [434.295 µs, 475.521 µs] 72.045 µs (18.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~a250acae00, baseline=1.48.0-SNAPSHOT~bde13e8991
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.352 ms) : 1333, 1371
.   : milestone, 1352,
appsec (1.751 ms) : 1728, 1775
.   : milestone, 1751,
appsec_no_iast (1.735 ms) : 1710, 1760
.   : milestone, 1735,
code_origins (1.693 ms) : 1667, 1719
.   : milestone, 1693,
iast (1.504 ms) : 1480, 1527
.   : milestone, 1504,
profiling (1.502 ms) : 1478, 1526
.   : milestone, 1502,
tracing (1.499 ms) : 1474, 1523
.   : milestone, 1499,
section candidate
no_agent (1.347 ms) : 1327, 1366
.   : milestone, 1347,
appsec (1.746 ms) : 1723, 1769
.   : milestone, 1746,
appsec_no_iast (1.712 ms) : 1687, 1737
.   : milestone, 1712,
code_origins (1.663 ms) : 1636, 1690
.   : milestone, 1663,
iast (1.515 ms) : 1491, 1538
.   : milestone, 1515,
profiling (1.523 ms) : 1500, 1546
.   : milestone, 1523,
tracing (1.492 ms) : 1467, 1517
.   : milestone, 1492,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.333 ms, 1.371 ms] -
appsec 1.751 ms [1.728 ms, 1.775 ms] 399.222 µs (29.5%)
appsec_no_iast 1.735 ms [1.71 ms, 1.76 ms] 382.57 µs (28.3%)
code_origins 1.693 ms [1.667 ms, 1.719 ms] 340.545 µs (25.2%)
iast 1.504 ms [1.48 ms, 1.527 ms] 151.382 µs (11.2%)
profiling 1.502 ms [1.478 ms, 1.526 ms] 150.224 µs (11.1%)
tracing 1.499 ms [1.474 ms, 1.523 ms] 146.488 µs (10.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.366 ms] -
appsec 1.746 ms [1.723 ms, 1.769 ms] 399.607 µs (29.7%)
appsec_no_iast 1.712 ms [1.687 ms, 1.737 ms] 365.361 µs (27.1%)
code_origins 1.663 ms [1.636 ms, 1.69 ms] 316.383 µs (23.5%)
iast 1.515 ms [1.491 ms, 1.538 ms] 168.145 µs (12.5%)
profiling 1.523 ms [1.5 ms, 1.546 ms] 176.339 µs (13.1%)
tracing 1.492 ms [1.467 ms, 1.517 ms] 145.598 µs (10.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-activateSpan-api
git_commit_date 1741954872 1741956272
git_commit_sha bde13e8 a250aca
release_version 1.48.0-SNAPSHOT~bde13e8991 1.48.0-SNAPSHOT~a250acae00
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741958456 1741958456
ci_job_id 848290471 848290471
ci_pipeline_id 58835876 58835876
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ib4zy3vt-project-304-concurrent-1-nd7ysfsg 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ib4zy3vt-project-304-concurrent-1-nd7ysfsg 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~a250acae00, baseline=1.48.0-SNAPSHOT~bde13e8991
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
.   : milestone, 1480,
appsec (2.354 ms) : 2310, 2398
.   : milestone, 2354,
iast (2.135 ms) : 2079, 2191
.   : milestone, 2135,
iast_GLOBAL (2.181 ms) : 2124, 2237
.   : milestone, 2181,
profiling (1.993 ms) : 1948, 2038
.   : milestone, 1993,
tracing (1.97 ms) : 1927, 2013
.   : milestone, 1970,
section candidate
no_agent (1.478 ms) : 1466, 1489
.   : milestone, 1478,
appsec (2.363 ms) : 2319, 2407
.   : milestone, 2363,
iast (2.14 ms) : 2084, 2197
.   : milestone, 2140,
iast_GLOBAL (2.183 ms) : 2127, 2239
.   : milestone, 2183,
profiling (1.975 ms) : 1931, 2019
.   : milestone, 1975,
tracing (1.96 ms) : 1917, 2002
.   : milestone, 1960,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.48 ms [1.469 ms, 1.492 ms] -
appsec 2.354 ms [2.31 ms, 2.398 ms] 873.743 µs (59.0%)
iast 2.135 ms [2.079 ms, 2.191 ms] 654.98 µs (44.2%)
iast_GLOBAL 2.181 ms [2.124 ms, 2.237 ms] 700.548 µs (47.3%)
profiling 1.993 ms [1.948 ms, 2.038 ms] 512.711 µs (34.6%)
tracing 1.97 ms [1.927 ms, 2.013 ms] 490.01 µs (33.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.466 ms, 1.489 ms] -
appsec 2.363 ms [2.319 ms, 2.407 ms] 885.455 µs (59.9%)
iast 2.14 ms [2.084 ms, 2.197 ms] 662.792 µs (44.9%)
iast_GLOBAL 2.183 ms [2.127 ms, 2.239 ms] 705.116 µs (47.7%)
profiling 1.975 ms [1.931 ms, 2.019 ms] 497.488 µs (33.7%)
tracing 1.96 ms [1.917 ms, 2.002 ms] 481.996 µs (32.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~a250acae00, baseline=1.48.0-SNAPSHOT~bde13e8991
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.304 s) : 15304000, 15304000
.   : milestone, 15304000,
appsec (14.907 s) : 14907000, 14907000
.   : milestone, 14907000,
iast (18.458 s) : 18458000, 18458000
.   : milestone, 18458000,
iast_GLOBAL (18.231 s) : 18231000, 18231000
.   : milestone, 18231000,
profiling (15.62 s) : 15620000, 15620000
.   : milestone, 15620000,
tracing (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,
section candidate
no_agent (15.298 s) : 15298000, 15298000
.   : milestone, 15298000,
appsec (14.952 s) : 14952000, 14952000
.   : milestone, 14952000,
iast (19.019 s) : 19019000, 19019000
.   : milestone, 19019000,
iast_GLOBAL (18.284 s) : 18284000, 18284000
.   : milestone, 18284000,
profiling (15.566 s) : 15566000, 15566000
.   : milestone, 15566000,
tracing (14.825 s) : 14825000, 14825000
.   : milestone, 14825000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.304 s [15.304 s, 15.304 s] -
appsec 14.907 s [14.907 s, 14.907 s] -397.0 ms (-2.6%)
iast 18.458 s [18.458 s, 18.458 s] 3.154 s (20.6%)
iast_GLOBAL 18.231 s [18.231 s, 18.231 s] 2.927 s (19.1%)
profiling 15.62 s [15.62 s, 15.62 s] 316.0 ms (2.1%)
tracing 15.019 s [15.019 s, 15.019 s] -285.0 ms (-1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.298 s [15.298 s, 15.298 s] -
appsec 14.952 s [14.952 s, 14.952 s] -346.0 ms (-2.3%)
iast 19.019 s [19.019 s, 19.019 s] 3.721 s (24.3%)
iast_GLOBAL 18.284 s [18.284 s, 18.284 s] 2.986 s (19.5%)
profiling 15.566 s [15.566 s, 15.566 s] 268.0 ms (1.8%)
tracing 14.825 s [14.825 s, 14.825 s] -473.0 ms (-3.1%)

@mcculls mcculls force-pushed the mcculls/simplify-activateSpan-api branch from 28280e2 to 64f5869 Compare March 13, 2025 23:27
@mcculls mcculls added the run-tests: all Run all tests label Mar 14, 2025
@mcculls mcculls force-pushed the mcculls/simplify-activateSpan-api branch from 64f5869 to 6cdc6fe Compare March 14, 2025 00:14
@mcculls
Simplify activateSpan API to not include async propagation flag
a250aca 
These remaining cases were no-op spans which are already not propagated
@mcculls mcculls force-pushed the mcculls/simplify-activateSpan-api branch from 6cdc6fe to a250aca Compare March 14, 2025 12:46
@mcculls mcculls changed the title WIP - experiment Simplify activateSpan API to not include async propagation flag Mar 14, 2025
@mcculls mcculls added tag: no release notes Changes to exclude from release notes and removed tag: do not merge Do not merge changes labels Mar 14, 2025
@mcculls mcculls marked this pull request as ready for review March 14, 2025 13:44
@mcculls mcculls requested review from a team as code owners March 14, 2025 13:44
@mcculls mcculls requested review from PerfectSlayer and dougqh March 14, 2025 13:44
PerfectSlayer
PerfectSlayer approved these changes Mar 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see AgentTracer / CoreTracer cleaned up!

@mcculls mcculls merged commit ef1ed74 into master Mar 14, 2025
@mcculls mcculls deleted the mcculls/simplify-activateSpan-api branch March 14, 2025 13:56
@github-actions github-actions Bot added this to the 1.48.0 milestone Mar 14, 2025
mtoffl01 pushed a commit that referenced this pull request Mar 24, 2025
@mcculls @mtoffl01
Simplify activateSpan API to not include async propagation flag (#8557)
12fe632 
These remaining cases were no-op spans which are already not propagated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: core Tracer core run-tests: all Run all tests tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @PerfectSlayer