Cleanup Hystrix instrumentation by mcculls · Pull Request #8556 · DataDog/dd-trace-java

mcculls · 2025-03-13T18:52:02Z

What Does This Do

Removes an instrumentation that was only used to temporarily enable async propagation

Motivation

Async propagation is now always on by default, so HystrixThreadPoolInstrumentation is no longer required

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-981

…on is no longer required to temporarily enable it

amarziali

Good catch. I didn't think about it. lgtm

pr-commenter · 2025-03-13T19:32:02Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/cleanup-hystrix-instrumentation
git_commit_date	1741889997	1741891763
git_commit_sha	`46e4075`	`2046f9f`
release_version	1.48.0-SNAPSHOT~46e4075bda	1.48.0-SNAPSHOT~2046f9fbc3

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1741894272	1741894272
ci_job_id	847291440	847291440
ci_pipeline_id	58759933	58759933
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-moshnsiy-project-304-concurrent-3-l40swcyf 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-moshnsiy-project-304-concurrent-3-l40swcyf 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~2046f9fbc3, baseline=1.48.0-SNAPSHOT~46e4075bda

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047530
Total [baseline] (8.671 s) : 0, 8670523
Agent [candidate] (1.047 s) : 0, 1046928
Total [candidate] (8.689 s) : 0, 8689211
section iast
Agent [baseline] (1.178 s) : 0, 1178308
Total [baseline] (9.293 s) : 0, 9292722
Agent [candidate] (1.172 s) : 0, 1172182
Total [candidate] (9.224 s) : 0, 9224098
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174281
Total [baseline] (9.212 s) : 0, 9211646
Agent [candidate] (1.173 s) : 0, 1172623
Total [candidate] (9.214 s) : 0, 9214380
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1175451
Total [baseline] (9.264 s) : 0, 9264039
Agent [candidate] (1.181 s) : 0, 1181218
Total [candidate] (9.263 s) : 0, 9263248

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.178 s	130.777 ms (12.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	126.751 ms (12.1%)
Agent	iast_TELEMETRY_OFF	1.175 s	127.921 ms (12.2%)
Total	tracing	8.671 s	-
Total	iast	9.293 s	622.199 ms (7.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.212 s	541.123 ms (6.2%)
Total	iast_TELEMETRY_OFF	9.264 s	593.516 ms (6.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	iast	1.172 s	125.254 ms (12.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.173 s	125.695 ms (12.0%)
Agent	iast_TELEMETRY_OFF	1.181 s	134.29 ms (12.8%)
Total	tracing	8.689 s	-
Total	iast	9.224 s	534.887 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.214 s	525.169 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.263 s	574.037 ms (6.6%)

gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~2046f9fbc3, baseline=1.48.0-SNAPSHOT~46e4075bda

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.846 ms) : 0, 723846
BytebuddyAgent [candidate] (722.205 ms) : 0, 722205
GlobalTracer [baseline] (241.563 ms) : 0, 241563
GlobalTracer [candidate] (240.647 ms) : 0, 240647
AppSec [baseline] (54.602 ms) : 0, 54602
AppSec [candidate] (55.021 ms) : 0, 55021
Remote Config [baseline] (688.966 µs) : 0, 689
Remote Config [candidate] (701.302 µs) : 0, 701
Telemetry [baseline] (11.511 ms) : 0, 11511
Telemetry [candidate] (13.074 ms) : 0, 13074
section iast
BytebuddyAgent [baseline] (843.33 ms) : 0, 843330
BytebuddyAgent [candidate] (838.421 ms) : 0, 838421
GlobalTracer [baseline] (231.136 ms) : 0, 231136
GlobalTracer [candidate] (230.548 ms) : 0, 230548
IAST [baseline] (22.962 ms) : 0, 22962
IAST [candidate] (22.69 ms) : 0, 22690
AppSec [baseline] (56.21 ms) : 0, 56210
AppSec [candidate] (55.958 ms) : 0, 55958
Remote Config [baseline] (621.448 µs) : 0, 621
Remote Config [candidate] (600.359 µs) : 0, 600
Telemetry [baseline] (8.722 ms) : 0, 8722
Telemetry [candidate] (8.633 ms) : 0, 8633
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.056 ms) : 0, 838056
BytebuddyAgent [candidate] (837.492 ms) : 0, 837492
GlobalTracer [baseline] (232.223 ms) : 0, 232223
GlobalTracer [candidate] (231.004 ms) : 0, 231004
IAST [baseline] (22.96 ms) : 0, 22960
IAST [candidate] (23.829 ms) : 0, 23829
AppSec [baseline] (56.326 ms) : 0, 56326
AppSec [candidate] (55.684 ms) : 0, 55684
Remote Config [baseline] (606.638 µs) : 0, 607
Remote Config [candidate] (618.576 µs) : 0, 619
Telemetry [baseline] (8.733 ms) : 0, 8733
Telemetry [candidate] (8.733 ms) : 0, 8733
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (840.443 ms) : 0, 840443
BytebuddyAgent [candidate] (843.609 ms) : 0, 843609
GlobalTracer [baseline] (231.212 ms) : 0, 231212
GlobalTracer [candidate] (233.493 ms) : 0, 233493
IAST [baseline] (22.543 ms) : 0, 22543
IAST [candidate] (22.841 ms) : 0, 22841
AppSec [baseline] (56.581 ms) : 0, 56581
AppSec [candidate] (56.663 ms) : 0, 56663
Remote Config [baseline] (639.636 µs) : 0, 640
Remote Config [candidate] (607.386 µs) : 0, 607
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (8.717 ms) : 0, 8717

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~2046f9fbc3, baseline=1.48.0-SNAPSHOT~46e4075bda

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048102
Total [baseline] (10.474 s) : 0, 10473564
Agent [candidate] (1.042 s) : 0, 1042083
Total [candidate] (10.42 s) : 0, 10419859
section appsec
Agent [baseline] (1.191 s) : 0, 1190804
Total [baseline] (10.735 s) : 0, 10734937
Agent [candidate] (1.19 s) : 0, 1189646
Total [candidate] (10.725 s) : 0, 10725339
section iast
Agent [baseline] (1.169 s) : 0, 1168963
Total [baseline] (11.035 s) : 0, 11035051
Agent [candidate] (1.173 s) : 0, 1172770
Total [candidate] (11.024 s) : 0, 11023876
section profiling
Agent [baseline] (1.259 s) : 0, 1258549
Total [baseline] (10.788 s) : 0, 10787820
Agent [candidate] (1.27 s) : 0, 1269735
Total [candidate] (10.852 s) : 0, 10851741

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	appsec	1.191 s	142.701 ms (13.6%)
Agent	iast	1.169 s	120.861 ms (11.5%)
Agent	profiling	1.259 s	210.447 ms (20.1%)
Total	tracing	10.474 s	-
Total	appsec	10.735 s	261.374 ms (2.5%)
Total	iast	11.035 s	561.487 ms (5.4%)
Total	profiling	10.788 s	314.256 ms (3.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	appsec	1.19 s	147.563 ms (14.2%)
Agent	iast	1.173 s	130.687 ms (12.5%)
Agent	profiling	1.27 s	227.652 ms (21.8%)
Total	tracing	10.42 s	-
Total	appsec	10.725 s	305.48 ms (2.9%)
Total	iast	11.024 s	604.018 ms (5.8%)
Total	profiling	10.852 s	431.883 ms (4.1%)

gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~2046f9fbc3, baseline=1.48.0-SNAPSHOT~46e4075bda

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.156 ms) : 0, 722156
BytebuddyAgent [candidate] (718.22 ms) : 0, 718220
GlobalTracer [baseline] (240.981 ms) : 0, 240981
GlobalTracer [candidate] (239.687 ms) : 0, 239687
AppSec [baseline] (54.67 ms) : 0, 54670
AppSec [candidate] (54.65 ms) : 0, 54650
Remote Config [baseline] (709.752 µs) : 0, 710
Remote Config [candidate] (691.846 µs) : 0, 692
Telemetry [baseline] (14.268 ms) : 0, 14268
Telemetry [candidate] (13.622 ms) : 0, 13622
section appsec
BytebuddyAgent [baseline] (741.509 ms) : 0, 741509
BytebuddyAgent [candidate] (740.295 ms) : 0, 740295
GlobalTracer [baseline] (237.882 ms) : 0, 237882
GlobalTracer [candidate] (237.767 ms) : 0, 237767
AppSec [baseline] (176.335 ms) : 0, 176335
AppSec [candidate] (176.412 ms) : 0, 176412
Remote Config [baseline] (663.736 µs) : 0, 664
Remote Config [candidate] (662.012 µs) : 0, 662
Telemetry [baseline] (8.249 ms) : 0, 8249
Telemetry [candidate] (8.274 ms) : 0, 8274
IAST [baseline] (21.686 ms) : 0, 21686
IAST [candidate] (21.927 ms) : 0, 21927
section iast
BytebuddyAgent [baseline] (835.423 ms) : 0, 835423
BytebuddyAgent [candidate] (838.065 ms) : 0, 838065
GlobalTracer [baseline] (230.029 ms) : 0, 230029
GlobalTracer [candidate] (231.108 ms) : 0, 231108
AppSec [baseline] (56.117 ms) : 0, 56117
AppSec [candidate] (55.359 ms) : 0, 55359
Remote Config [baseline] (594.856 µs) : 0, 595
Remote Config [candidate] (614.66 µs) : 0, 615
Telemetry [baseline] (8.698 ms) : 0, 8698
Telemetry [candidate] (8.704 ms) : 0, 8704
IAST [baseline] (22.891 ms) : 0, 22891
IAST [candidate] (23.706 ms) : 0, 23706
section profiling
BytebuddyAgent [baseline] (708.71 ms) : 0, 708710
BytebuddyAgent [candidate] (715.108 ms) : 0, 715108
GlobalTracer [baseline] (349.318 ms) : 0, 349318
GlobalTracer [candidate] (351.519 ms) : 0, 351519
AppSec [baseline] (54.194 ms) : 0, 54194
AppSec [candidate] (54.251 ms) : 0, 54251
Remote Config [baseline] (673.904 µs) : 0, 674
Remote Config [candidate] (683.864 µs) : 0, 684
Telemetry [baseline] (8.936 ms) : 0, 8936
Telemetry [candidate] (9.199 ms) : 0, 9199
ProfilingAgent [baseline] (96.046 ms) : 0, 96046
ProfilingAgent [candidate] (97.854 ms) : 0, 97854
Profiling [baseline] (96.073 ms) : 0, 96073
Profiling [candidate] (97.878 ms) : 0, 97878

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-03-13T19:01:32	2025-03-13T19:09:15
git_branch	master	mcculls/cleanup-hystrix-instrumentation
git_commit_date	1741889997	1741891763
git_commit_sha	`46e4075`	`2046f9f`
release_version	1.48.0-SNAPSHOT~46e4075bda	1.48.0-SNAPSHOT~2046f9fbc3
start_time	2025-03-13T19:01:18	2025-03-13T19:09:01

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1741893353	1741893353
ci_job_id	847291441	847291441
ci_pipeline_id	58759933	58759933
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-dgzduy7c-project-304-concurrent-0-0xaqmjz6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-dgzduy7c-project-304-concurrent-0-0xaqmjz6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	worse [+42.014µs; +93.588µs] or [+2.778%; +6.188%]	unstable [-680.065op/s; +452.144op/s] or [-22.102%; +14.695%]	1.580ms	2962.963op/s	1.512ms	3076.923op/s

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/cleanup-hystrix-instrumentation
git_commit_date	1741889997	1741891763
git_commit_sha	`46e4075`	`2046f9f`
release_version	1.48.0-SNAPSHOT~46e4075bda	1.48.0-SNAPSHOT~2046f9fbc3

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1741893687	1741893687
ci_job_id	847291442	847291442
ci_pipeline_id	58759933	58759933
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-gzhmqs6t-project-304-concurrent-0-d546nk2l 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-gzhmqs6t-project-304-concurrent-0-d546nk2l 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~2046f9fbc3, baseline=1.48.0-SNAPSHOT~46e4075bda
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.331 ms) : 2286, 2375
.   : milestone, 2331,
iast (2.111 ms) : 2055, 2167
.   : milestone, 2111,
iast_GLOBAL (2.159 ms) : 2103, 2215
.   : milestone, 2159,
profiling (1.969 ms) : 1925, 2013
.   : milestone, 1969,
tracing (1.945 ms) : 1902, 1987
.   : milestone, 1945,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.335 ms) : 2291, 2378
.   : milestone, 2335,
iast (2.116 ms) : 2059, 2172
.   : milestone, 2116,
iast_GLOBAL (2.146 ms) : 2091, 2202
.   : milestone, 2146,
profiling (2.407 ms) : 2170, 2644
.   : milestone, 2407,
tracing (1.944 ms) : 1902, 1987
.   : milestone, 1944,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.456 ms, 1.479 ms]	-
appsec	2.331 ms [2.286 ms, 2.375 ms]	863.04 µs (58.8%)
iast	2.111 ms [2.055 ms, 2.167 ms]	643.245 µs (43.8%)
iast_GLOBAL	2.159 ms [2.103 ms, 2.215 ms]	691.28 µs (47.1%)
profiling	1.969 ms [1.925 ms, 2.013 ms]	501.153 µs (34.2%)
tracing	1.945 ms [1.902 ms, 1.987 ms]	477.333 µs (32.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	2.335 ms [2.291 ms, 2.378 ms]	862.217 µs (58.6%)
iast	2.116 ms [2.059 ms, 2.172 ms]	642.991 µs (43.7%)
iast_GLOBAL	2.146 ms [2.091 ms, 2.202 ms]	673.914 µs (45.8%)
profiling	2.407 ms [2.17 ms, 2.644 ms]	934.791 µs (63.5%)
tracing	1.944 ms [1.902 ms, 1.987 ms]	471.885 µs (32.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~2046f9fbc3, baseline=1.48.0-SNAPSHOT~46e4075bda
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.12 s) : 15120000, 15120000
.   : milestone, 15120000,
appsec (15.039 s) : 15039000, 15039000
.   : milestone, 15039000,
iast (18.779 s) : 18779000, 18779000
.   : milestone, 18779000,
iast_GLOBAL (17.415 s) : 17415000, 17415000
.   : milestone, 17415000,
profiling (15.469 s) : 15469000, 15469000
.   : milestone, 15469000,
tracing (14.912 s) : 14912000, 14912000
.   : milestone, 14912000,
section candidate
no_agent (15.325 s) : 15325000, 15325000
.   : milestone, 15325000,
appsec (14.903 s) : 14903000, 14903000
.   : milestone, 14903000,
iast (18.811 s) : 18811000, 18811000
.   : milestone, 18811000,
iast_GLOBAL (18.257 s) : 18257000, 18257000
.   : milestone, 18257000,
profiling (15.706 s) : 15706000, 15706000
.   : milestone, 15706000,
tracing (14.929 s) : 14929000, 14929000
.   : milestone, 14929000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.12 s [15.12 s, 15.12 s]	-
appsec	15.039 s [15.039 s, 15.039 s]	-81.0 ms (-0.5%)
iast	18.779 s [18.779 s, 18.779 s]	3.659 s (24.2%)
iast_GLOBAL	17.415 s [17.415 s, 17.415 s]	2.295 s (15.2%)
profiling	15.469 s [15.469 s, 15.469 s]	349.0 ms (2.3%)
tracing	14.912 s [14.912 s, 14.912 s]	-208.0 ms (-1.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.325 s [15.325 s, 15.325 s]	-
appsec	14.903 s [14.903 s, 14.903 s]	-422.0 ms (-2.8%)
iast	18.811 s [18.811 s, 18.811 s]	3.486 s (22.7%)
iast_GLOBAL	18.257 s [18.257 s, 18.257 s]	2.932 s (19.1%)
profiling	15.706 s [15.706 s, 15.706 s]	381.0 ms (2.5%)
tracing	14.929 s [14.929 s, 14.929 s]	-396.0 ms (-2.6%)

…on is no longer required to temporarily enable it (#8556)

Async propagation is on by default, so HystrixThreadPoolInstrumentati…

2046f9f

…on is no longer required to temporarily enable it

mcculls added inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 13, 2025

mcculls marked this pull request as ready for review March 13, 2025 18:54

mcculls requested a review from a team as a code owner March 13, 2025 18:54

mcculls requested a review from amarziali March 13, 2025 18:54

amarziali approved these changes Mar 13, 2025

View reviewed changes

mcculls merged commit 56d8cd8 into master Mar 13, 2025

mcculls deleted the mcculls/cleanup-hystrix-instrumentation branch March 13, 2025 20:33

github-actions Bot added this to the 1.48.0 milestone Mar 13, 2025

mtoffl01 pushed a commit that referenced this pull request Mar 24, 2025

Async propagation is on by default, so HystrixThreadPoolInstrumentati…

518cd4a

…on is no longer required to temporarily enable it (#8556)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup Hystrix instrumentation#8556

Cleanup Hystrix instrumentation#8556
mcculls merged 1 commit intomasterfrom
mcculls/cleanup-hystrix-instrumentation

mcculls commented Mar 13, 2025 •

edited by atlassian Bot

Loading

Uh oh!

amarziali left a comment

Uh oh!

pr-commenter Bot commented Mar 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mcculls commented Mar 13, 2025 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Contributor Checklist

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenter Bot commented Mar 13, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mcculls commented Mar 13, 2025 •

edited by atlassian Bot

Loading