Skip to content

Be consistent when deciding when to do async propagation#8555

Merged
mcculls merged 1 commit intomasterfrom
mcculls/concurrency-cleanup
Mar 13, 2025
Merged

Be consistent when deciding when to do async propagation#8555
mcculls merged 1 commit intomasterfrom
mcculls/concurrency-cleanup

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Mar 13, 2025

Motivation

i.e. we should have a non-null, valid span and the async propagation flag should be set

(also remove some unused variables in the executor advice)

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls
Be consistent when deciding when to do async propagation
4d7f1cf 
i.e. we should have a non-null, valid span and the async propagation flag should be set

(also remove some unused variables in the executor advice)
@mcculls mcculls added inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 13, 2025
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 13, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/concurrency-cleanup
git_commit_date 1741883234 1741883306
git_commit_sha 32f4d6a 4d7f1cf
release_version 1.48.0-SNAPSHOT~32f4d6ac81 1.48.0-SNAPSHOT~4d7f1cf33f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741885786 1741885786
ci_job_id 846950195 846950195
ci_pipeline_id 58736831 58736831
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-gzhmqs6t-project-304-concurrent-1-em6i2r9n 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-gzhmqs6t-project-304-concurrent-1-em6i2r9n 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~4d7f1cf33f, baseline=1.48.0-SNAPSHOT~32f4d6ac81

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039161
Total [baseline] (10.528 s) : 0, 10528420
Agent [candidate] (1.05 s) : 0, 1050341
Total [candidate] (10.579 s) : 0, 10579158
section appsec
Agent [baseline] (1.185 s) : 0, 1185026
Total [baseline] (10.752 s) : 0, 10751548
Agent [candidate] (1.189 s) : 0, 1188664
Total [candidate] (10.801 s) : 0, 10801096
section iast
Agent [baseline] (1.173 s) : 0, 1173191
Total [baseline] (11.011 s) : 0, 11011374
Agent [candidate] (1.171 s) : 0, 1171235
Total [candidate] (11.038 s) : 0, 11038361
section profiling
Agent [baseline] (1.262 s) : 0, 1262274
Total [baseline] (10.859 s) : 0, 10858568
Agent [candidate] (1.278 s) : 0, 1277690
Total [candidate] (10.915 s) : 0, 10914950
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent appsec 1.185 s 145.864 ms (14.0%)
Agent iast 1.173 s 134.03 ms (12.9%)
Agent profiling 1.262 s 223.112 ms (21.5%)
Total tracing 10.528 s -
Total appsec 10.752 s 223.129 ms (2.1%)
Total iast 11.011 s 482.955 ms (4.6%)
Total profiling 10.859 s 330.149 ms (3.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.189 s 138.323 ms (13.2%)
Agent iast 1.171 s 120.894 ms (11.5%)
Agent profiling 1.278 s 227.348 ms (21.6%)
Total tracing 10.579 s -
Total appsec 10.801 s 221.938 ms (2.1%)
Total iast 11.038 s 459.203 ms (4.3%)
Total profiling 10.915 s 335.792 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~4d7f1cf33f, baseline=1.48.0-SNAPSHOT~32f4d6ac81

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.365 ms) : 0, 717365
BytebuddyAgent [candidate] (724.665 ms) : 0, 724665
GlobalTracer [baseline] (239.525 ms) : 0, 239525
GlobalTracer [candidate] (241.823 ms) : 0, 241823
AppSec [baseline] (54.387 ms) : 0, 54387
AppSec [candidate] (55.014 ms) : 0, 55014
Remote Config [baseline] (682.336 µs) : 0, 682
Remote Config [candidate] (696.93 µs) : 0, 697
Telemetry [baseline] (12.076 ms) : 0, 12076
Telemetry [candidate] (12.826 ms) : 0, 12826
section appsec
BytebuddyAgent [baseline] (737.834 ms) : 0, 737834
BytebuddyAgent [candidate] (739.451 ms) : 0, 739451
GlobalTracer [baseline] (236.986 ms) : 0, 236986
GlobalTracer [candidate] (237.366 ms) : 0, 237366
IAST [baseline] (21.321 ms) : 0, 21321
IAST [candidate] (21.747 ms) : 0, 21747
AppSec [baseline] (175.373 ms) : 0, 175373
AppSec [candidate] (176.809 ms) : 0, 176809
Remote Config [baseline] (656.812 µs) : 0, 657
Remote Config [candidate] (661.163 µs) : 0, 661
Telemetry [baseline] (8.317 ms) : 0, 8317
Telemetry [candidate] (8.31 ms) : 0, 8310
section iast
BytebuddyAgent [baseline] (838.808 ms) : 0, 838808
BytebuddyAgent [candidate] (837.929 ms) : 0, 837929
GlobalTracer [baseline] (231.089 ms) : 0, 231089
GlobalTracer [candidate] (230.559 ms) : 0, 230559
IAST [baseline] (22.742 ms) : 0, 22742
IAST [candidate] (24.084 ms) : 0, 24084
AppSec [baseline] (55.922 ms) : 0, 55922
AppSec [candidate] (54.24 ms) : 0, 54240
Remote Config [baseline] (600.819 µs) : 0, 601
Remote Config [candidate] (595.697 µs) : 0, 596
Telemetry [baseline] (8.715 ms) : 0, 8715
Telemetry [candidate] (8.629 ms) : 0, 8629
section profiling
BytebuddyAgent [baseline] (711.346 ms) : 0, 711346
BytebuddyAgent [candidate] (721.201 ms) : 0, 721201
GlobalTracer [baseline] (349.963 ms) : 0, 349963
GlobalTracer [candidate] (353.684 ms) : 0, 353684
AppSec [baseline] (54.392 ms) : 0, 54392
AppSec [candidate] (54.324 ms) : 0, 54324
Remote Config [baseline] (728.136 µs) : 0, 728
Remote Config [candidate] (676.565 µs) : 0, 677
Telemetry [baseline] (8.922 ms) : 0, 8922
Telemetry [candidate] (9.107 ms) : 0, 9107
ProfilingAgent [baseline] (96.336 ms) : 0, 96336
ProfilingAgent [candidate] (97.756 ms) : 0, 97756
Profiling [baseline] (96.361 ms) : 0, 96361
Profiling [candidate] (97.782 ms) : 0, 97782
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~4d7f1cf33f, baseline=1.48.0-SNAPSHOT~32f4d6ac81

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046190
Total [baseline] (8.724 s) : 0, 8724343
Agent [candidate] (1.042 s) : 0, 1041550
Total [candidate] (8.668 s) : 0, 8668431
section iast
Agent [baseline] (1.171 s) : 0, 1171276
Total [baseline] (9.242 s) : 0, 9242148
Agent [candidate] (1.173 s) : 0, 1172924
Total [candidate] (9.244 s) : 0, 9244011
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1172340
Total [baseline] (9.268 s) : 0, 9267894
Agent [candidate] (1.175 s) : 0, 1174919
Total [candidate] (9.24 s) : 0, 9240065
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1173973
Total [baseline] (9.214 s) : 0, 9213574
Agent [candidate] (1.171 s) : 0, 1171237
Total [candidate] (9.242 s) : 0, 9241783
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.171 s 125.086 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 126.15 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.174 s 127.783 ms (12.2%)
Total tracing 8.724 s -
Total iast 9.242 s 517.805 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.268 s 543.551 ms (6.2%)
Total iast_TELEMETRY_OFF 9.214 s 489.231 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent iast 1.173 s 131.373 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 133.369 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.171 s 129.687 ms (12.5%)
Total tracing 8.668 s -
Total iast 9.244 s 575.58 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.24 s 571.634 ms (6.6%)
Total iast_TELEMETRY_OFF 9.242 s 573.352 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~4d7f1cf33f, baseline=1.48.0-SNAPSHOT~32f4d6ac81

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.921 ms) : 0, 722921
BytebuddyAgent [candidate] (718.635 ms) : 0, 718635
GlobalTracer [baseline] (240.632 ms) : 0, 240632
GlobalTracer [candidate] (239.731 ms) : 0, 239731
AppSec [baseline] (54.971 ms) : 0, 54971
AppSec [candidate] (54.464 ms) : 0, 54464
Remote Config [baseline] (691.815 µs) : 0, 692
Remote Config [candidate] (690.557 µs) : 0, 691
Telemetry [baseline] (11.628 ms) : 0, 11628
Telemetry [candidate] (12.878 ms) : 0, 12878
section iast
BytebuddyAgent [baseline] (837.616 ms) : 0, 837616
BytebuddyAgent [candidate] (838.745 ms) : 0, 838745
GlobalTracer [baseline] (230.25 ms) : 0, 230250
GlobalTracer [candidate] (230.791 ms) : 0, 230791
IAST [baseline] (22.77 ms) : 0, 22770
IAST [candidate] (22.932 ms) : 0, 22932
AppSec [baseline] (56.092 ms) : 0, 56092
AppSec [candidate] (55.948 ms) : 0, 55948
Remote Config [baseline] (611.646 µs) : 0, 612
Remote Config [candidate] (615.846 µs) : 0, 616
Telemetry [baseline] (8.763 ms) : 0, 8763
Telemetry [candidate] (8.696 ms) : 0, 8696
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.977 ms) : 0, 837977
BytebuddyAgent [candidate] (839.908 ms) : 0, 839908
GlobalTracer [baseline] (230.803 ms) : 0, 230803
GlobalTracer [candidate] (231.122 ms) : 0, 231122
IAST [baseline] (24.683 ms) : 0, 24683
IAST [candidate] (22.912 ms) : 0, 22912
AppSec [baseline] (54.248 ms) : 0, 54248
AppSec [candidate] (56.383 ms) : 0, 56383
Remote Config [baseline] (606.101 µs) : 0, 606
Remote Config [candidate] (620.039 µs) : 0, 620
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.726 ms) : 0, 8726
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.183 ms) : 0, 839183
BytebuddyAgent [candidate] (837.057 ms) : 0, 837057
GlobalTracer [baseline] (231.168 ms) : 0, 231168
GlobalTracer [candidate] (230.448 ms) : 0, 230448
IAST [baseline] (22.531 ms) : 0, 22531
IAST [candidate] (22.454 ms) : 0, 22454
AppSec [baseline] (56.462 ms) : 0, 56462
AppSec [candidate] (56.642 ms) : 0, 56642
Remote Config [baseline] (612.039 µs) : 0, 612
Remote Config [candidate] (613.192 µs) : 0, 613
Telemetry [baseline] (8.708 ms) : 0, 8708
Telemetry [candidate] (8.715 ms) : 0, 8715
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-13T16:42:02 2025-03-13T16:49:46
git_branch master mcculls/concurrency-cleanup
git_commit_date 1741883234 1741883306
git_commit_sha 32f4d6a 4d7f1cf
release_version 1.48.0-SNAPSHOT~32f4d6ac81 1.48.0-SNAPSHOT~4d7f1cf33f
start_time 2025-03-13T16:41:48 2025-03-13T16:49:32
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741884983 1741884983
ci_job_id 846950196 846950196
ci_pipeline_id 58736831 58736831
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-88rxttzv-project-304-concurrent-1-sbetusou 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-88rxttzv-project-304-concurrent-1-sbetusou 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~4d7f1cf33f, baseline=1.48.0-SNAPSHOT~32f4d6ac81
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1329, 1368
.   : milestone, 1348,
appsec (1.732 ms) : 1708, 1755
.   : milestone, 1732,
appsec_no_iast (1.748 ms) : 1723, 1772
.   : milestone, 1748,
code_origins (1.682 ms) : 1656, 1709
.   : milestone, 1682,
iast (1.52 ms) : 1495, 1544
.   : milestone, 1520,
profiling (1.543 ms) : 1518, 1568
.   : milestone, 1543,
tracing (1.493 ms) : 1469, 1518
.   : milestone, 1493,
section candidate
no_agent (1.351 ms) : 1331, 1371
.   : milestone, 1351,
appsec (1.713 ms) : 1690, 1736
.   : milestone, 1713,
appsec_no_iast (1.746 ms) : 1721, 1771
.   : milestone, 1746,
code_origins (1.691 ms) : 1665, 1718
.   : milestone, 1691,
iast (1.499 ms) : 1474, 1524
.   : milestone, 1499,
profiling (1.531 ms) : 1506, 1556
.   : milestone, 1531,
tracing (1.491 ms) : 1465, 1516
.   : milestone, 1491,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.329 ms, 1.368 ms] -
appsec 1.732 ms [1.708 ms, 1.755 ms] 383.389 µs (28.4%)
appsec_no_iast 1.748 ms [1.723 ms, 1.772 ms] 399.277 µs (29.6%)
code_origins 1.682 ms [1.656 ms, 1.709 ms] 333.963 µs (24.8%)
iast 1.52 ms [1.495 ms, 1.544 ms] 171.256 µs (12.7%)
profiling 1.543 ms [1.518 ms, 1.568 ms] 194.263 µs (14.4%)
tracing 1.493 ms [1.469 ms, 1.518 ms] 144.666 µs (10.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.331 ms, 1.371 ms] -
appsec 1.713 ms [1.69 ms, 1.736 ms] 361.99 µs (26.8%)
appsec_no_iast 1.746 ms [1.721 ms, 1.771 ms] 395.028 µs (29.2%)
code_origins 1.691 ms [1.665 ms, 1.718 ms] 340.522 µs (25.2%)
iast 1.499 ms [1.474 ms, 1.524 ms] 148.029 µs (11.0%)
profiling 1.531 ms [1.506 ms, 1.556 ms] 179.814 µs (13.3%)
tracing 1.491 ms [1.465 ms, 1.516 ms] 139.948 µs (10.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~4d7f1cf33f, baseline=1.48.0-SNAPSHOT~32f4d6ac81
    dateFormat X
    axisFormat %s
section baseline
no_agent (381.762 µs) : 362, 401
.   : milestone, 382,
iast (512.456 µs) : 490, 535
.   : milestone, 512,
iast_FULL (730.497 µs) : 709, 752
.   : milestone, 730,
iast_GLOBAL (568.63 µs) : 545, 592
.   : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (508.163 µs) : 486, 530
.   : milestone, 508,
iast_INACTIVE (469.507 µs) : 446, 493
.   : milestone, 470,
iast_TELEMETRY_OFF (502.202 µs) : 479, 525
.   : milestone, 502,
tracing (459.686 µs) : 438, 481
.   : milestone, 460,
section candidate
no_agent (384.719 µs) : 365, 404
.   : milestone, 385,
iast (508.63 µs) : 487, 530
.   : milestone, 509,
iast_FULL (729.603 µs) : 707, 752
.   : milestone, 730,
iast_GLOBAL (557.973 µs) : 535, 580
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (518.94 µs) : 497, 541
.   : milestone, 519,
iast_INACTIVE (464.439 µs) : 443, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (491.522 µs) : 470, 513
.   : milestone, 492,
tracing (457.803 µs) : 437, 479
.   : milestone, 458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.762 µs [362.036 µs, 401.487 µs] -
iast 512.456 µs [490.198 µs, 534.713 µs] 130.694 µs (34.2%)
iast_FULL 730.497 µs [708.504 µs, 752.491 µs] 348.736 µs (91.3%)
iast_GLOBAL 568.63 µs [544.911 µs, 592.349 µs] 186.868 µs (48.9%)
iast_HARDCODED_SECRET_DISABLED 508.163 µs [486.293 µs, 530.033 µs] 126.401 µs (33.1%)
iast_INACTIVE 469.507 µs [445.95 µs, 493.064 µs] 87.746 µs (23.0%)
iast_TELEMETRY_OFF 502.202 µs [479.222 µs, 525.183 µs] 120.441 µs (31.5%)
tracing 459.686 µs [438.2 µs, 481.172 µs] 77.924 µs (20.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.719 µs [365.069 µs, 404.369 µs] -
iast 508.63 µs [486.775 µs, 530.485 µs] 123.911 µs (32.2%)
iast_FULL 729.603 µs [707.414 µs, 751.791 µs] 344.884 µs (89.6%)
iast_GLOBAL 557.973 µs [535.484 µs, 580.462 µs] 173.254 µs (45.0%)
iast_HARDCODED_SECRET_DISABLED 518.94 µs [497.03 µs, 540.85 µs] 134.221 µs (34.9%)
iast_INACTIVE 464.439 µs [442.712 µs, 486.165 µs] 79.72 µs (20.7%)
iast_TELEMETRY_OFF 491.522 µs [470.301 µs, 512.743 µs] 106.803 µs (27.8%)
tracing 457.803 µs [436.828 µs, 478.778 µs] 73.084 µs (19.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/concurrency-cleanup
git_commit_date 1741883234 1741883306
git_commit_sha 32f4d6a 4d7f1cf
release_version 1.48.0-SNAPSHOT~32f4d6ac81 1.48.0-SNAPSHOT~4d7f1cf33f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741885309 1741885309
ci_job_id 846950197 846950197
ci_pipeline_id 58736831 58736831
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-3nhalxzn-project-304-concurrent-0-p3zfwc7w 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-3nhalxzn-project-304-concurrent-0-p3zfwc7w 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~4d7f1cf33f, baseline=1.48.0-SNAPSHOT~32f4d6ac81
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
appsec (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
iast (19.108 s) : 19108000, 19108000
.   : milestone, 19108000,
iast_GLOBAL (18.274 s) : 18274000, 18274000
.   : milestone, 18274000,
profiling (15.31 s) : 15310000, 15310000
.   : milestone, 15310000,
tracing (14.946 s) : 14946000, 14946000
.   : milestone, 14946000,
section candidate
no_agent (15.448 s) : 15448000, 15448000
.   : milestone, 15448000,
appsec (15.121 s) : 15121000, 15121000
.   : milestone, 15121000,
iast (19.035 s) : 19035000, 19035000
.   : milestone, 19035000,
iast_GLOBAL (17.918 s) : 17918000, 17918000
.   : milestone, 17918000,
profiling (15.03 s) : 15030000, 15030000
.   : milestone, 15030000,
tracing (14.668 s) : 14668000, 14668000
.   : milestone, 14668000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.951 s [14.951 s, 14.951 s] -
appsec 15.027 s [15.027 s, 15.027 s] 76.0 ms (0.5%)
iast 19.108 s [19.108 s, 19.108 s] 4.157 s (27.8%)
iast_GLOBAL 18.274 s [18.274 s, 18.274 s] 3.323 s (22.2%)
profiling 15.31 s [15.31 s, 15.31 s] 359.0 ms (2.4%)
tracing 14.946 s [14.946 s, 14.946 s] -5.0 ms (-0.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.448 s [15.448 s, 15.448 s] -
appsec 15.121 s [15.121 s, 15.121 s] -327.0 ms (-2.1%)
iast 19.035 s [19.035 s, 19.035 s] 3.587 s (23.2%)
iast_GLOBAL 17.918 s [17.918 s, 17.918 s] 2.47 s (16.0%)
profiling 15.03 s [15.03 s, 15.03 s] -418.0 ms (-2.7%)
tracing 14.668 s [14.668 s, 14.668 s] -780.0 ms (-5.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~4d7f1cf33f, baseline=1.48.0-SNAPSHOT~32f4d6ac81
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.343 ms) : 2299, 2387
.   : milestone, 2343,
iast (2.121 ms) : 2065, 2177
.   : milestone, 2121,
iast_GLOBAL (2.165 ms) : 2109, 2221
.   : milestone, 2165,
profiling (1.983 ms) : 1939, 2028
.   : milestone, 1983,
tracing (1.947 ms) : 1905, 1990
.   : milestone, 1947,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.344 ms) : 2301, 2388
.   : milestone, 2344,
iast (2.118 ms) : 2062, 2174
.   : milestone, 2118,
iast_GLOBAL (2.16 ms) : 2104, 2216
.   : milestone, 2160,
profiling (2.444 ms) : 2263, 2625
.   : milestone, 2444,
tracing (1.948 ms) : 1905, 1991
.   : milestone, 1948,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.343 ms [2.299 ms, 2.387 ms] 874.2 µs (59.5%)
iast 2.121 ms [2.065 ms, 2.177 ms] 652.379 µs (44.4%)
iast_GLOBAL 2.165 ms [2.109 ms, 2.221 ms] 696.243 µs (47.4%)
profiling 1.983 ms [1.939 ms, 2.028 ms] 514.565 µs (35.0%)
tracing 1.947 ms [1.905 ms, 1.99 ms] 478.407 µs (32.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.458 ms, 1.481 ms] -
appsec 2.344 ms [2.301 ms, 2.388 ms] 874.724 µs (59.5%)
iast 2.118 ms [2.062 ms, 2.174 ms] 648.127 µs (44.1%)
iast_GLOBAL 2.16 ms [2.104 ms, 2.216 ms] 690.066 µs (47.0%)
profiling 2.444 ms [2.263 ms, 2.625 ms] 974.625 µs (66.3%)
tracing 1.948 ms [1.905 ms, 1.991 ms] 478.407 µs (32.6%)

@mcculls mcculls marked this pull request as ready for review March 13, 2025 17:31
@mcculls mcculls requested review from a team as code owners March 13, 2025 17:31
@mcculls mcculls requested review from amarziali and dougqh March 13, 2025 17:31
@mcculls mcculls enabled auto-merge (squash) March 13, 2025 17:31
amarziali
amarziali approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcculls mcculls merged commit 46e4075 into master Mar 13, 2025
@mcculls mcculls deleted the mcculls/concurrency-cleanup branch March 13, 2025 18:19
@github-actions github-actions Bot added this to the 1.48.0 milestone Mar 13, 2025
mtoffl01 pushed a commit that referenced this pull request Mar 24, 2025
@mcculls @mtoffl01
Be consistent when deciding when to do async propagation (#8555)
26c11f4 
i.e. we should have a non-null, valid span and the async propagation flag should be set

(also remove some unused variables in the executor advice)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarziali amarziali amarziali approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @amarziali