Skip to content

Remove unnecessary calls to setAsyncPropagationEnabled#8551

Merged
mcculls merged 1 commit intomasterfrom
mcculls/remove-unnecessary-async-propagation-settings
Mar 13, 2025
Merged

Remove unnecessary calls to setAsyncPropagationEnabled#8551
mcculls merged 1 commit intomasterfrom
mcculls/remove-unnecessary-async-propagation-settings

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Mar 13, 2025 •
edited by atlassian Bot
Loading

What Does This Do

Most of these are calls after activating a continuation - but scopes created from continuations have async propagation enabled already: https://github.com/DataDog/dd-trace-java/blob/v1.47.0/dd-trace-core/src/main/java/datadog/trace/core/scopemanager/ContinuableScopeManager.java#L160

The other non-test changes are a few places in the servlet / play instrumentations where we turned off async propagation for scopes that we've closed and are about to remove from the scope stack. Setting async propagation at this point has no affect.

The remaining cases are leftovers from refactoring in test code

Motivation

Helps make it clearer where we really need/want to change the async propagation flag.

Contributor Checklist

Jira ticket: APMAPI-981

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 13, 2025
@mcculls mcculls marked this pull request as ready for review March 13, 2025 15:31
@mcculls mcculls requested review from a team as code owners March 13, 2025 15:31
@mcculls mcculls requested review from PerfectSlayer and ygree March 13, 2025 15:31
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 13, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-unnecessary-async-propagation-settings
git_commit_date 1741874133 1741877386
git_commit_sha 7e831d5 efc9b0f
release_version 1.48.0-SNAPSHOT~7e831d561e 1.48.0-SNAPSHOT~efc9b0f996
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741879834 1741879834
ci_job_id 846654468 846654468
ci_pipeline_id 58717989 58717989
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-q781ysy3-project-304-concurrent-0-a4x2xhp4 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-q781ysy3-project-304-concurrent-0-a4x2xhp4 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 2 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~efc9b0f996, baseline=1.48.0-SNAPSHOT~7e831d561e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041647
Total [baseline] (8.683 s) : 0, 8683413
Agent [candidate] (1.039 s) : 0, 1039097
Total [candidate] (8.677 s) : 0, 8677471
section iast
Agent [baseline] (1.171 s) : 0, 1171034
Total [baseline] (9.259 s) : 0, 9259129
Agent [candidate] (1.167 s) : 0, 1167329
Total [candidate] (9.246 s) : 0, 9246077
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1176372
Total [baseline] (9.249 s) : 0, 9248862
Agent [candidate] (1.172 s) : 0, 1172458
Total [candidate] (9.246 s) : 0, 9245901
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1167427
Total [baseline] (9.27 s) : 0, 9270215
Agent [candidate] (1.167 s) : 0, 1166578
Total [candidate] (9.247 s) : 0, 9246678
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent iast 1.171 s 129.387 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 134.724 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.167 s 125.78 ms (12.1%)
Total tracing 8.683 s -
Total iast 9.259 s 575.716 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.249 s 565.45 ms (6.5%)
Total iast_TELEMETRY_OFF 9.27 s 586.803 ms (6.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent iast 1.167 s 128.233 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 133.361 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.167 s 127.482 ms (12.3%)
Total tracing 8.677 s -
Total iast 9.246 s 568.606 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.246 s 568.43 ms (6.6%)
Total iast_TELEMETRY_OFF 9.247 s 569.207 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~efc9b0f996, baseline=1.48.0-SNAPSHOT~7e831d561e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.761 ms) : 0, 718761
BytebuddyAgent [candidate] (717.049 ms) : 0, 717049
GlobalTracer [baseline] (239.315 ms) : 0, 239315
GlobalTracer [candidate] (239.049 ms) : 0, 239049
AppSec [baseline] (54.79 ms) : 0, 54790
AppSec [candidate] (54.353 ms) : 0, 54353
Remote Config [baseline] (699.709 µs) : 0, 700
Remote Config [candidate] (683.77 µs) : 0, 684
Telemetry [baseline] (12.865 ms) : 0, 12865
Telemetry [candidate] (12.763 ms) : 0, 12763
section iast
BytebuddyAgent [baseline] (837.688 ms) : 0, 837688
BytebuddyAgent [candidate] (835.013 ms) : 0, 835013
GlobalTracer [baseline] (230.308 ms) : 0, 230308
GlobalTracer [candidate] (229.811 ms) : 0, 229811
AppSec [baseline] (55.804 ms) : 0, 55804
AppSec [candidate] (55.737 ms) : 0, 55737
Remote Config [baseline] (602.282 µs) : 0, 602
Remote Config [candidate] (597.67 µs) : 0, 598
Telemetry [baseline] (8.6 ms) : 0, 8600
Telemetry [candidate] (8.576 ms) : 0, 8576
IAST [baseline] (22.773 ms) : 0, 22773
IAST [candidate] (22.405 ms) : 0, 22405
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (841.004 ms) : 0, 841004
BytebuddyAgent [candidate] (837.007 ms) : 0, 837007
GlobalTracer [baseline] (230.92 ms) : 0, 230920
GlobalTracer [candidate] (231.331 ms) : 0, 231331
AppSec [baseline] (56.525 ms) : 0, 56525
AppSec [candidate] (56.557 ms) : 0, 56557
Remote Config [baseline] (619.018 µs) : 0, 619
Remote Config [candidate] (619.769 µs) : 0, 620
Telemetry [baseline] (8.751 ms) : 0, 8751
Telemetry [candidate] (8.75 ms) : 0, 8750
IAST [baseline] (23.152 ms) : 0, 23152
IAST [candidate] (22.916 ms) : 0, 22916
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.468 ms) : 0, 834468
BytebuddyAgent [candidate] (834.184 ms) : 0, 834184
GlobalTracer [baseline] (230.166 ms) : 0, 230166
GlobalTracer [candidate] (230.136 ms) : 0, 230136
AppSec [baseline] (56.057 ms) : 0, 56057
AppSec [candidate] (55.769 ms) : 0, 55769
Remote Config [baseline] (608.606 µs) : 0, 609
Remote Config [candidate] (620.528 µs) : 0, 621
Telemetry [baseline] (8.562 ms) : 0, 8562
Telemetry [candidate] (8.524 ms) : 0, 8524
IAST [baseline] (22.343 ms) : 0, 22343
IAST [candidate] (22.085 ms) : 0, 22085
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~efc9b0f996, baseline=1.48.0-SNAPSHOT~7e831d561e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044646
Total [baseline] (10.494 s) : 0, 10493867
Agent [candidate] (1.04 s) : 0, 1039774
Total [candidate] (10.559 s) : 0, 10558689
section appsec
Agent [baseline] (1.182 s) : 0, 1181821
Total [baseline] (10.788 s) : 0, 10788467
Agent [candidate] (1.187 s) : 0, 1187253
Total [candidate] (10.752 s) : 0, 10751659
section iast
Agent [baseline] (1.176 s) : 0, 1176333
Total [baseline] (11.042 s) : 0, 11042027
Agent [candidate] (1.17 s) : 0, 1170362
Total [candidate] (11.016 s) : 0, 11016105
section profiling
Agent [baseline] (1.258 s) : 0, 1258195
Total [baseline] (10.849 s) : 0, 10848575
Agent [candidate] (1.261 s) : 0, 1260649
Total [candidate] (10.884 s) : 0, 10883718
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.182 s 137.175 ms (13.1%)
Agent iast 1.176 s 131.687 ms (12.6%)
Agent profiling 1.258 s 213.55 ms (20.4%)
Total tracing 10.494 s -
Total appsec 10.788 s 294.6 ms (2.8%)
Total iast 11.042 s 548.16 ms (5.2%)
Total profiling 10.849 s 354.708 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.04 s -
Agent appsec 1.187 s 147.478 ms (14.2%)
Agent iast 1.17 s 130.588 ms (12.6%)
Agent profiling 1.261 s 220.875 ms (21.2%)
Total tracing 10.559 s -
Total appsec 10.752 s 192.97 ms (1.8%)
Total iast 11.016 s 457.416 ms (4.3%)
Total profiling 10.884 s 325.029 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~efc9b0f996, baseline=1.48.0-SNAPSHOT~7e831d561e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.741 ms) : 0, 721741
BytebuddyAgent [candidate] (717.846 ms) : 0, 717846
GlobalTracer [baseline] (240.63 ms) : 0, 240630
GlobalTracer [candidate] (239.456 ms) : 0, 239456
AppSec [baseline] (54.849 ms) : 0, 54849
AppSec [candidate] (54.459 ms) : 0, 54459
Remote Config [baseline] (698.547 µs) : 0, 699
Remote Config [candidate] (690.288 µs) : 0, 690
Telemetry [baseline] (11.471 ms) : 0, 11471
Telemetry [candidate] (12.068 ms) : 0, 12068
section appsec
BytebuddyAgent [baseline] (735.075 ms) : 0, 735075
BytebuddyAgent [candidate] (738.684 ms) : 0, 738684
GlobalTracer [baseline] (235.945 ms) : 0, 235945
GlobalTracer [candidate] (237.087 ms) : 0, 237087
AppSec [baseline] (176.121 ms) : 0, 176121
AppSec [candidate] (176.584 ms) : 0, 176584
Remote Config [baseline] (652.502 µs) : 0, 653
Remote Config [candidate] (668.325 µs) : 0, 668
Telemetry [baseline] (8.232 ms) : 0, 8232
Telemetry [candidate] (8.324 ms) : 0, 8324
IAST [baseline] (21.241 ms) : 0, 21241
IAST [candidate] (21.363 ms) : 0, 21363
section iast
BytebuddyAgent [baseline] (840.757 ms) : 0, 840757
BytebuddyAgent [candidate] (837.371 ms) : 0, 837371
GlobalTracer [baseline] (231.559 ms) : 0, 231559
GlobalTracer [candidate] (230.088 ms) : 0, 230088
AppSec [baseline] (56.372 ms) : 0, 56372
AppSec [candidate] (55.757 ms) : 0, 55757
Remote Config [baseline] (615.902 µs) : 0, 616
Remote Config [candidate] (593.961 µs) : 0, 594
Telemetry [baseline] (8.78 ms) : 0, 8780
Telemetry [candidate] (8.588 ms) : 0, 8588
IAST [baseline] (22.953 ms) : 0, 22953
IAST [candidate] (22.726 ms) : 0, 22726
section profiling
ProfilingAgent [baseline] (96.551 ms) : 0, 96551
ProfilingAgent [candidate] (95.516 ms) : 0, 95516
BytebuddyAgent [baseline] (708.635 ms) : 0, 708635
BytebuddyAgent [candidate] (711.766 ms) : 0, 711766
GlobalTracer [baseline] (348.504 ms) : 0, 348504
GlobalTracer [candidate] (349.433 ms) : 0, 349433
AppSec [baseline] (54.25 ms) : 0, 54250
AppSec [candidate] (53.203 ms) : 0, 53203
Remote Config [baseline] (678.693 µs) : 0, 679
Remote Config [candidate] (660.532 µs) : 0, 661
Telemetry [baseline] (8.943 ms) : 0, 8943
Telemetry [candidate] (9.05 ms) : 0, 9050
Profiling [baseline] (96.578 ms) : 0, 96578
Profiling [candidate] (95.54 ms) : 0, 95540
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-13T15:00:48 2025-03-13T15:08:36
git_branch master mcculls/remove-unnecessary-async-propagation-settings
git_commit_date 1741874133 1741877386
git_commit_sha 7e831d5 efc9b0f
release_version 1.48.0-SNAPSHOT~7e831d561e 1.48.0-SNAPSHOT~efc9b0f996
start_time 2025-03-13T15:00:33 2025-03-13T15:08:22
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741878915 1741878915
ci_job_id 846654471 846654471
ci_pipeline_id 58717989 58717989
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-q781ysy3-project-304-concurrent-1-thtjhrqk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-q781ysy3-project-304-concurrent-1-thtjhrqk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~efc9b0f996, baseline=1.48.0-SNAPSHOT~7e831d561e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.377 ms) : 1357, 1396
.   : milestone, 1377,
appsec (1.737 ms) : 1712, 1762
.   : milestone, 1737,
appsec_no_iast (1.779 ms) : 1755, 1804
.   : milestone, 1779,
code_origins (1.687 ms) : 1659, 1714
.   : milestone, 1687,
iast (1.524 ms) : 1499, 1548
.   : milestone, 1524,
profiling (1.54 ms) : 1517, 1563
.   : milestone, 1540,
tracing (1.524 ms) : 1499, 1549
.   : milestone, 1524,
section candidate
no_agent (1.369 ms) : 1349, 1389
.   : milestone, 1369,
appsec (1.739 ms) : 1716, 1762
.   : milestone, 1739,
appsec_no_iast (1.726 ms) : 1700, 1751
.   : milestone, 1726,
code_origins (1.709 ms) : 1682, 1736
.   : milestone, 1709,
iast (1.517 ms) : 1493, 1541
.   : milestone, 1517,
profiling (1.54 ms) : 1515, 1564
.   : milestone, 1540,
tracing (1.502 ms) : 1476, 1527
.   : milestone, 1502,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.377 ms [1.357 ms, 1.396 ms] -
appsec 1.737 ms [1.712 ms, 1.762 ms] 360.686 µs (26.2%)
appsec_no_iast 1.779 ms [1.755 ms, 1.804 ms] 402.874 µs (29.3%)
code_origins 1.687 ms [1.659 ms, 1.714 ms] 309.982 µs (22.5%)
iast 1.524 ms [1.499 ms, 1.548 ms] 146.959 µs (10.7%)
profiling 1.54 ms [1.517 ms, 1.563 ms] 163.103 µs (11.8%)
tracing 1.524 ms [1.499 ms, 1.549 ms] 147.299 µs (10.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.369 ms [1.349 ms, 1.389 ms] -
appsec 1.739 ms [1.716 ms, 1.762 ms] 370.055 µs (27.0%)
appsec_no_iast 1.726 ms [1.7 ms, 1.751 ms] 356.652 µs (26.1%)
code_origins 1.709 ms [1.682 ms, 1.736 ms] 340.069 µs (24.8%)
iast 1.517 ms [1.493 ms, 1.541 ms] 147.925 µs (10.8%)
profiling 1.54 ms [1.515 ms, 1.564 ms] 170.649 µs (12.5%)
tracing 1.502 ms [1.476 ms, 1.527 ms] 132.528 µs (9.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~efc9b0f996, baseline=1.48.0-SNAPSHOT~7e831d561e
    dateFormat X
    axisFormat %s
section baseline
no_agent (385.57 µs) : 365, 406
.   : milestone, 386,
iast (520.007 µs) : 499, 541
.   : milestone, 520,
iast_FULL (746.603 µs) : 725, 769
.   : milestone, 747,
iast_GLOBAL (559.803 µs) : 538, 581
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (523.171 µs) : 501, 545
.   : milestone, 523,
iast_INACTIVE (473.395 µs) : 452, 495
.   : milestone, 473,
iast_TELEMETRY_OFF (507.346 µs) : 486, 529
.   : milestone, 507,
tracing (471.056 µs) : 450, 492
.   : milestone, 471,
section candidate
no_agent (388.084 µs) : 369, 408
.   : milestone, 388,
iast (519.422 µs) : 497, 542
.   : milestone, 519,
iast_FULL (737.681 µs) : 715, 760
.   : milestone, 738,
iast_GLOBAL (558.881 µs) : 537, 581
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (521.091 µs) : 499, 543
.   : milestone, 521,
iast_INACTIVE (471.352 µs) : 450, 493
.   : milestone, 471,
iast_TELEMETRY_OFF (508.381 µs) : 485, 532
.   : milestone, 508,
tracing (470.547 µs) : 449, 492
.   : milestone, 471,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 385.57 µs [364.985 µs, 406.156 µs] -
iast 520.007 µs [498.54 µs, 541.473 µs] 134.436 µs (34.9%)
iast_FULL 746.603 µs [724.629 µs, 768.577 µs] 361.033 µs (93.6%)
iast_GLOBAL 559.803 µs [538.253 µs, 581.354 µs] 174.233 µs (45.2%)
iast_HARDCODED_SECRET_DISABLED 523.171 µs [500.946 µs, 545.395 µs] 137.6 µs (35.7%)
iast_INACTIVE 473.395 µs [451.862 µs, 494.928 µs] 87.824 µs (22.8%)
iast_TELEMETRY_OFF 507.346 µs [485.53 µs, 529.161 µs] 121.775 µs (31.6%)
tracing 471.056 µs [449.777 µs, 492.334 µs] 85.485 µs (22.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 388.084 µs [368.521 µs, 407.648 µs] -
iast 519.422 µs [497.322 µs, 541.521 µs] 131.337 µs (33.8%)
iast_FULL 737.681 µs [715.402 µs, 759.96 µs] 349.597 µs (90.1%)
iast_GLOBAL 558.881 µs [536.992 µs, 580.77 µs] 170.797 µs (44.0%)
iast_HARDCODED_SECRET_DISABLED 521.091 µs [499.081 µs, 543.101 µs] 133.007 µs (34.3%)
iast_INACTIVE 471.352 µs [449.779 µs, 492.926 µs] 83.268 µs (21.5%)
iast_TELEMETRY_OFF 508.381 µs [485.257 µs, 531.505 µs] 120.297 µs (31.0%)
tracing 470.547 µs [448.958 µs, 492.136 µs] 82.463 µs (21.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-unnecessary-async-propagation-settings
git_commit_date 1741874133 1741877386
git_commit_sha 7e831d5 efc9b0f
release_version 1.48.0-SNAPSHOT~7e831d561e 1.48.0-SNAPSHOT~efc9b0f996
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741879566 1741879566
ci_job_id 846654475 846654475
ci_pipeline_id 58717989 58717989
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-q781ysy3-project-304-concurrent-2-rkmv2ioi 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-q781ysy3-project-304-concurrent-2-rkmv2ioi 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~efc9b0f996, baseline=1.48.0-SNAPSHOT~7e831d561e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.343 ms) : 2299, 2387
.   : milestone, 2343,
iast (2.129 ms) : 2073, 2186
.   : milestone, 2129,
iast_GLOBAL (2.16 ms) : 2103, 2216
.   : milestone, 2160,
profiling (1.986 ms) : 1940, 2031
.   : milestone, 1986,
tracing (1.942 ms) : 1900, 1985
.   : milestone, 1942,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.341 ms) : 2296, 2385
.   : milestone, 2341,
iast (2.117 ms) : 2062, 2173
.   : milestone, 2117,
iast_GLOBAL (2.163 ms) : 2107, 2220
.   : milestone, 2163,
profiling (1.994 ms) : 1949, 2040
.   : milestone, 1994,
tracing (1.947 ms) : 1905, 1990
.   : milestone, 1947,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.343 ms [2.299 ms, 2.387 ms] 873.672 µs (59.5%)
iast 2.129 ms [2.073 ms, 2.186 ms] 660.065 µs (44.9%)
iast_GLOBAL 2.16 ms [2.103 ms, 2.216 ms] 690.431 µs (47.0%)
profiling 1.986 ms [1.94 ms, 2.031 ms] 516.385 µs (35.1%)
tracing 1.942 ms [1.9 ms, 1.985 ms] 472.892 µs (32.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 2.341 ms [2.296 ms, 2.385 ms] 869.585 µs (59.1%)
iast 2.117 ms [2.062 ms, 2.173 ms] 645.993 µs (43.9%)
iast_GLOBAL 2.163 ms [2.107 ms, 2.22 ms] 692.22 µs (47.1%)
profiling 1.994 ms [1.949 ms, 2.04 ms] 523.084 µs (35.6%)
tracing 1.947 ms [1.905 ms, 1.99 ms] 476.197 µs (32.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~efc9b0f996, baseline=1.48.0-SNAPSHOT~7e831d561e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.354 s) : 15354000, 15354000
.   : milestone, 15354000,
appsec (14.798 s) : 14798000, 14798000
.   : milestone, 14798000,
iast (19.02 s) : 19020000, 19020000
.   : milestone, 19020000,
iast_GLOBAL (18.043 s) : 18043000, 18043000
.   : milestone, 18043000,
profiling (15.173 s) : 15173000, 15173000
.   : milestone, 15173000,
tracing (14.758 s) : 14758000, 14758000
.   : milestone, 14758000,
section candidate
no_agent (15.656 s) : 15656000, 15656000
.   : milestone, 15656000,
appsec (15.072 s) : 15072000, 15072000
.   : milestone, 15072000,
iast (19.081 s) : 19081000, 19081000
.   : milestone, 19081000,
iast_GLOBAL (17.607 s) : 17607000, 17607000
.   : milestone, 17607000,
profiling (15.194 s) : 15194000, 15194000
.   : milestone, 15194000,
tracing (15.127 s) : 15127000, 15127000
.   : milestone, 15127000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.354 s [15.354 s, 15.354 s] -
appsec 14.798 s [14.798 s, 14.798 s] -556.0 ms (-3.6%)
iast 19.02 s [19.02 s, 19.02 s] 3.666 s (23.9%)
iast_GLOBAL 18.043 s [18.043 s, 18.043 s] 2.689 s (17.5%)
profiling 15.173 s [15.173 s, 15.173 s] -181.0 ms (-1.2%)
tracing 14.758 s [14.758 s, 14.758 s] -596.0 ms (-3.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.656 s [15.656 s, 15.656 s] -
appsec 15.072 s [15.072 s, 15.072 s] -584.0 ms (-3.7%)
iast 19.081 s [19.081 s, 19.081 s] 3.425 s (21.9%)
iast_GLOBAL 17.607 s [17.607 s, 17.607 s] 1.951 s (12.5%)
profiling 15.194 s [15.194 s, 15.194 s] -462.0 ms (-3.0%)
tracing 15.127 s [15.127 s, 15.127 s] -529.0 ms (-3.4%)

@mcculls mcculls enabled auto-merge (squash) March 13, 2025 15:41
PerfectSlayer
PerfectSlayer approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up! 👍

@mcculls mcculls merged commit 32f4d6a into master Mar 13, 2025
@mcculls mcculls deleted the mcculls/remove-unnecessary-async-propagation-settings branch March 13, 2025 16:27
@github-actions github-actions Bot added this to the 1.48.0 milestone Mar 13, 2025
mtoffl01 pushed a commit that referenced this pull request Mar 24, 2025
@mcculls @mtoffl01
Remove unnecessary calls to setAsyncPropagationEnabled (#8551)
0a8bc73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @PerfectSlayer