Skip to content

Simplify activateSpan calls which use the default value for isAsyncPropagating#8543

Merged
mcculls merged 1 commit intomasterfrom
mcculls/simplify-activateSpan-calls
Mar 12, 2025
Merged

Simplify activateSpan calls which use the default value for isAsyncPropagating#8543
mcculls merged 1 commit intomasterfrom
mcculls/simplify-activateSpan-calls

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Mar 12, 2025 •
edited
Loading

isAsyncPropagating is always true by default now, so these calls can all be simplified.

Contributor Checklist

Jira ticket: APMAPI-960

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 12, 2025
@mcculls mcculls requested review from a team as code owners March 12, 2025 14:18
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 12, 2025

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-activateSpan-calls
git_commit_date 1741782299 1741788829
git_commit_sha 6ac0942 48eb755
See matching parameters
Baseline Candidate
ci_job_date 1741790251 1741790251
ci_job_id 844437938 844437938
ci_pipeline_id 58564658 58564658
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 12, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-activateSpan-calls
git_commit_date 1741789383 1741788829
git_commit_sha 1a0dcdf 48eb755
release_version 1.48.0-SNAPSHOT~1a0dcdf624 1.48.0-SNAPSHOT~48eb7553b1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741791619 1741791619
ci_job_id 844437926 844437926
ci_pipeline_id 58564658 58564658
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-2wkmbgws-project-304-concurrent-0-sllrjfy2 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-2wkmbgws-project-304-concurrent-0-sllrjfy2 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~48eb7553b1, baseline=1.48.0-SNAPSHOT~1a0dcdf624

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041572
Total [baseline] (8.725 s) : 0, 8725363
Agent [candidate] (1.041 s) : 0, 1040599
Total [candidate] (8.698 s) : 0, 8697925
section iast
Agent [baseline] (1.179 s) : 0, 1178585
Total [baseline] (9.25 s) : 0, 9249804
Agent [candidate] (1.171 s) : 0, 1171098
Total [candidate] (9.238 s) : 0, 9238099
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1176707
Total [baseline] (9.202 s) : 0, 9202210
Agent [candidate] (1.171 s) : 0, 1171173
Total [candidate] (9.206 s) : 0, 9206143
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1167877
Total [baseline] (9.246 s) : 0, 9245849
Agent [candidate] (1.17 s) : 0, 1169603
Total [candidate] (9.261 s) : 0, 9261298
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent iast 1.179 s 137.013 ms (13.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 135.135 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.168 s 126.305 ms (12.1%)
Total tracing 8.725 s -
Total iast 9.25 s 524.441 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.202 s 476.847 ms (5.5%)
Total iast_TELEMETRY_OFF 9.246 s 520.486 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent iast 1.171 s 130.499 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 130.574 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.17 s 129.005 ms (12.4%)
Total tracing 8.698 s -
Total iast 9.238 s 540.174 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.206 s 508.218 ms (5.8%)
Total iast_TELEMETRY_OFF 9.261 s 563.373 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~48eb7553b1, baseline=1.48.0-SNAPSHOT~1a0dcdf624

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.811 ms) : 0, 718811
BytebuddyAgent [candidate] (718.113 ms) : 0, 718113
GlobalTracer [baseline] (239.652 ms) : 0, 239652
GlobalTracer [candidate] (239.212 ms) : 0, 239212
AppSec [baseline] (55.173 ms) : 0, 55173
AppSec [candidate] (54.877 ms) : 0, 54877
Remote Config [baseline] (702.118 µs) : 0, 702
Remote Config [candidate] (712.479 µs) : 0, 712
Telemetry [baseline] (12.332 ms) : 0, 12332
Telemetry [candidate] (12.89 ms) : 0, 12890
section iast
BytebuddyAgent [baseline] (843.316 ms) : 0, 843316
BytebuddyAgent [candidate] (837.105 ms) : 0, 837105
GlobalTracer [baseline] (230.743 ms) : 0, 230743
GlobalTracer [candidate] (230.702 ms) : 0, 230702
IAST [baseline] (23.159 ms) : 0, 23159
IAST [candidate] (22.836 ms) : 0, 22836
AppSec [baseline] (57.01 ms) : 0, 57010
AppSec [candidate] (56.26 ms) : 0, 56260
Remote Config [baseline] (618.838 µs) : 0, 619
Remote Config [candidate] (614.424 µs) : 0, 614
Telemetry [baseline] (8.735 ms) : 0, 8735
Telemetry [candidate] (8.704 ms) : 0, 8704
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.362 ms) : 0, 840362
BytebuddyAgent [candidate] (837.214 ms) : 0, 837214
GlobalTracer [baseline] (231.852 ms) : 0, 231852
GlobalTracer [candidate] (230.367 ms) : 0, 230367
IAST [baseline] (23.201 ms) : 0, 23201
IAST [candidate] (22.817 ms) : 0, 22817
AppSec [baseline] (56.971 ms) : 0, 56971
AppSec [candidate] (56.61 ms) : 0, 56610
Remote Config [baseline] (636.304 µs) : 0, 636
Remote Config [candidate] (615.236 µs) : 0, 615
Telemetry [baseline] (8.767 ms) : 0, 8767
Telemetry [candidate] (8.704 ms) : 0, 8704
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.795 ms) : 0, 834795
BytebuddyAgent [candidate] (836.362 ms) : 0, 836362
GlobalTracer [baseline] (229.639 ms) : 0, 229639
GlobalTracer [candidate] (230.384 ms) : 0, 230384
IAST [baseline] (23.139 ms) : 0, 23139
IAST [candidate] (22.216 ms) : 0, 22216
AppSec [baseline] (56.213 ms) : 0, 56213
AppSec [candidate] (56.594 ms) : 0, 56594
Remote Config [baseline] (607.429 µs) : 0, 607
Remote Config [candidate] (617.388 µs) : 0, 617
Telemetry [baseline] (8.661 ms) : 0, 8661
Telemetry [candidate] (8.584 ms) : 0, 8584
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~48eb7553b1, baseline=1.48.0-SNAPSHOT~1a0dcdf624

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042357
Total [baseline] (10.499 s) : 0, 10498603
Agent [candidate] (1.045 s) : 0, 1045127
Total [candidate] (10.471 s) : 0, 10470703
section appsec
Agent [baseline] (1.191 s) : 0, 1190787
Total [baseline] (10.796 s) : 0, 10795917
Agent [candidate] (1.182 s) : 0, 1182186
Total [candidate] (10.754 s) : 0, 10753715
section iast
Agent [baseline] (1.181 s) : 0, 1180722
Total [baseline] (11.049 s) : 0, 11048667
Agent [candidate] (1.172 s) : 0, 1172351
Total [candidate] (10.997 s) : 0, 10996791
section profiling
Agent [baseline] (1.267 s) : 0, 1266913
Total [baseline] (10.912 s) : 0, 10912139
Agent [candidate] (1.259 s) : 0, 1259077
Total [candidate] (10.815 s) : 0, 10815382
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent appsec 1.191 s 148.429 ms (14.2%)
Agent iast 1.181 s 138.365 ms (13.3%)
Agent profiling 1.267 s 224.556 ms (21.5%)
Total tracing 10.499 s -
Total appsec 10.796 s 297.314 ms (2.8%)
Total iast 11.049 s 550.064 ms (5.2%)
Total profiling 10.912 s 413.535 ms (3.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.182 s 137.059 ms (13.1%)
Agent iast 1.172 s 127.224 ms (12.2%)
Agent profiling 1.259 s 213.95 ms (20.5%)
Total tracing 10.471 s -
Total appsec 10.754 s 283.013 ms (2.7%)
Total iast 10.997 s 526.089 ms (5.0%)
Total profiling 10.815 s 344.68 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~48eb7553b1, baseline=1.48.0-SNAPSHOT~1a0dcdf624

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.295 ms) : 0, 719295
BytebuddyAgent [candidate] (721.796 ms) : 0, 721796
GlobalTracer [baseline] (239.919 ms) : 0, 239919
GlobalTracer [candidate] (240.757 ms) : 0, 240757
AppSec [baseline] (55.403 ms) : 0, 55403
AppSec [candidate] (55.415 ms) : 0, 55415
Remote Config [baseline] (709.343 µs) : 0, 709
Remote Config [candidate] (701.271 µs) : 0, 701
Telemetry [baseline] (12.216 ms) : 0, 12216
Telemetry [candidate] (11.492 ms) : 0, 11492
section appsec
BytebuddyAgent [baseline] (740.466 ms) : 0, 740466
BytebuddyAgent [candidate] (735.334 ms) : 0, 735334
GlobalTracer [baseline] (238.012 ms) : 0, 238012
GlobalTracer [candidate] (236.084 ms) : 0, 236084
IAST [baseline] (21.534 ms) : 0, 21534
IAST [candidate] (21.28 ms) : 0, 21280
AppSec [baseline] (177.186 ms) : 0, 177186
AppSec [candidate] (176.381 ms) : 0, 176381
Remote Config [baseline] (699.587 µs) : 0, 700
Remote Config [candidate] (668.931 µs) : 0, 669
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.245 ms) : 0, 8245
section iast
BytebuddyAgent [baseline] (844.447 ms) : 0, 844447
BytebuddyAgent [candidate] (837.798 ms) : 0, 837798
GlobalTracer [baseline] (231.731 ms) : 0, 231731
GlobalTracer [candidate] (230.277 ms) : 0, 230277
IAST [baseline] (23.072 ms) : 0, 23072
IAST [candidate] (22.825 ms) : 0, 22825
AppSec [baseline] (56.988 ms) : 0, 56988
AppSec [candidate] (57.133 ms) : 0, 57133
Remote Config [baseline] (631.327 µs) : 0, 631
Remote Config [candidate] (626.129 µs) : 0, 626
Telemetry [baseline] (8.876 ms) : 0, 8876
Telemetry [candidate] (8.815 ms) : 0, 8815
section profiling
BytebuddyAgent [baseline] (711.667 ms) : 0, 711667
BytebuddyAgent [candidate] (709.668 ms) : 0, 709668
GlobalTracer [baseline] (351.951 ms) : 0, 351951
GlobalTracer [candidate] (349.483 ms) : 0, 349483
AppSec [baseline] (55.454 ms) : 0, 55454
AppSec [candidate] (53.957 ms) : 0, 53957
Remote Config [baseline] (691.408 µs) : 0, 691
Remote Config [candidate] (670.445 µs) : 0, 670
Telemetry [baseline] (9.073 ms) : 0, 9073
Telemetry [candidate] (8.896 ms) : 0, 8896
ProfilingAgent [baseline] (97.741 ms) : 0, 97741
ProfilingAgent [candidate] (96.106 ms) : 0, 96106
Profiling [baseline] (97.766 ms) : 0, 97766
Profiling [candidate] (96.133 ms) : 0, 96133
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-12T14:30:35 2025-03-12T14:38:20
git_branch master mcculls/simplify-activateSpan-calls
git_commit_date 1741789383 1741788829
git_commit_sha 1a0dcdf 48eb755
release_version 1.48.0-SNAPSHOT~1a0dcdf624 1.48.0-SNAPSHOT~48eb7553b1
start_time 2025-03-12T14:30:21 2025-03-12T14:38:06
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741790700 1741790700
ci_job_id 844437929 844437929
ci_pipeline_id 58564658 58564658
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-2wkmbgws-project-304-concurrent-1-nufwqhrf 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-2wkmbgws-project-304-concurrent-1-nufwqhrf 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~48eb7553b1, baseline=1.48.0-SNAPSHOT~1a0dcdf624
    dateFormat X
    axisFormat %s
section baseline
no_agent (390.598 µs) : 371, 410
.   : milestone, 391,
iast (513.144 µs) : 492, 535
.   : milestone, 513,
iast_FULL (730.852 µs) : 709, 753
.   : milestone, 731,
iast_GLOBAL (559.815 µs) : 537, 582
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (511.121 µs) : 489, 533
.   : milestone, 511,
iast_INACTIVE (471.502 µs) : 450, 493
.   : milestone, 472,
iast_TELEMETRY_OFF (508.589 µs) : 485, 532
.   : milestone, 509,
tracing (461.53 µs) : 441, 482
.   : milestone, 462,
section candidate
no_agent (382.088 µs) : 360, 404
.   : milestone, 382,
iast (515.342 µs) : 493, 537
.   : milestone, 515,
iast_FULL (729.934 µs) : 708, 752
.   : milestone, 730,
iast_GLOBAL (566.474 µs) : 544, 589
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (514.909 µs) : 493, 536
.   : milestone, 515,
iast_INACTIVE (468.357 µs) : 446, 490
.   : milestone, 468,
iast_TELEMETRY_OFF (500.424 µs) : 478, 523
.   : milestone, 500,
tracing (456.649 µs) : 436, 477
.   : milestone, 457,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 390.598 µs [370.911 µs, 410.285 µs] -
iast 513.144 µs [491.642 µs, 534.646 µs] 122.546 µs (31.4%)
iast_FULL 730.852 µs [708.793 µs, 752.911 µs] 340.254 µs (87.1%)
iast_GLOBAL 559.815 µs [537.165 µs, 582.464 µs] 169.216 µs (43.3%)
iast_HARDCODED_SECRET_DISABLED 511.121 µs [489.414 µs, 532.828 µs] 120.523 µs (30.9%)
iast_INACTIVE 471.502 µs [449.924 µs, 493.079 µs] 80.903 µs (20.7%)
iast_TELEMETRY_OFF 508.589 µs [485.307 µs, 531.871 µs] 117.99 µs (30.2%)
tracing 461.53 µs [440.711 µs, 482.349 µs] 70.932 µs (18.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.088 µs [360.42 µs, 403.755 µs] -
iast 515.342 µs [493.47 µs, 537.214 µs] 133.254 µs (34.9%)
iast_FULL 729.934 µs [707.932 µs, 751.937 µs] 347.846 µs (91.0%)
iast_GLOBAL 566.474 µs [544.209 µs, 588.739 µs] 184.386 µs (48.3%)
iast_HARDCODED_SECRET_DISABLED 514.909 µs [493.323 µs, 536.494 µs] 132.821 µs (34.8%)
iast_INACTIVE 468.357 µs [446.467 µs, 490.247 µs] 86.27 µs (22.6%)
iast_TELEMETRY_OFF 500.424 µs [478.187 µs, 522.661 µs] 118.336 µs (31.0%)
tracing 456.649 µs [435.914 µs, 477.385 µs] 74.561 µs (19.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~48eb7553b1, baseline=1.48.0-SNAPSHOT~1a0dcdf624
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.373 ms) : 1354, 1393
.   : milestone, 1373,
appsec (1.729 ms) : 1706, 1752
.   : milestone, 1729,
appsec_no_iast (1.749 ms) : 1725, 1773
.   : milestone, 1749,
code_origins (1.673 ms) : 1645, 1700
.   : milestone, 1673,
iast (1.516 ms) : 1491, 1540
.   : milestone, 1516,
profiling (1.54 ms) : 1516, 1565
.   : milestone, 1540,
tracing (1.49 ms) : 1465, 1516
.   : milestone, 1490,
section candidate
no_agent (1.37 ms) : 1350, 1389
.   : milestone, 1370,
appsec (1.73 ms) : 1707, 1754
.   : milestone, 1730,
appsec_no_iast (1.747 ms) : 1722, 1771
.   : milestone, 1747,
code_origins (1.685 ms) : 1657, 1712
.   : milestone, 1685,
iast (1.518 ms) : 1494, 1543
.   : milestone, 1518,
profiling (1.56 ms) : 1528, 1591
.   : milestone, 1560,
tracing (1.493 ms) : 1468, 1518
.   : milestone, 1493,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.373 ms [1.354 ms, 1.393 ms] -
appsec 1.729 ms [1.706 ms, 1.752 ms] 355.58 µs (25.9%)
appsec_no_iast 1.749 ms [1.725 ms, 1.773 ms] 375.788 µs (27.4%)
code_origins 1.673 ms [1.645 ms, 1.7 ms] 299.556 µs (21.8%)
iast 1.516 ms [1.491 ms, 1.54 ms] 142.365 µs (10.4%)
profiling 1.54 ms [1.516 ms, 1.565 ms] 167.065 µs (12.2%)
tracing 1.49 ms [1.465 ms, 1.516 ms] 116.958 µs (8.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.37 ms [1.35 ms, 1.389 ms] -
appsec 1.73 ms [1.707 ms, 1.754 ms] 360.415 µs (26.3%)
appsec_no_iast 1.747 ms [1.722 ms, 1.771 ms] 376.838 µs (27.5%)
code_origins 1.685 ms [1.657 ms, 1.712 ms] 314.722 µs (23.0%)
iast 1.518 ms [1.494 ms, 1.543 ms] 148.522 µs (10.8%)
profiling 1.56 ms [1.528 ms, 1.591 ms] 189.679 µs (13.8%)
tracing 1.493 ms [1.468 ms, 1.518 ms] 123.148 µs (9.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-activateSpan-calls
git_commit_date 1741789383 1741788829
git_commit_sha 1a0dcdf 48eb755
release_version 1.48.0-SNAPSHOT~1a0dcdf624 1.48.0-SNAPSHOT~48eb7553b1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741791266 1741791266
ci_job_id 844437933 844437933
ci_pipeline_id 58564658 58564658
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-2wkmbgws-project-304-concurrent-2-p1iuq37x 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-2wkmbgws-project-304-concurrent-2-p1iuq37x 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~48eb7553b1, baseline=1.48.0-SNAPSHOT~1a0dcdf624
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.361 ms) : 2316, 2405
.   : milestone, 2361,
iast (2.142 ms) : 2085, 2199
.   : milestone, 2142,
iast_GLOBAL (2.183 ms) : 2126, 2240
.   : milestone, 2183,
profiling (2.005 ms) : 1958, 2051
.   : milestone, 2005,
tracing (1.952 ms) : 1909, 1995
.   : milestone, 1952,
section candidate
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.358 ms) : 2314, 2403
.   : milestone, 2358,
iast (2.14 ms) : 2084, 2196
.   : milestone, 2140,
iast_GLOBAL (2.172 ms) : 2116, 2229
.   : milestone, 2172,
profiling (2.005 ms) : 1960, 2050
.   : milestone, 2005,
tracing (1.958 ms) : 1915, 2001
.   : milestone, 1958,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 2.361 ms [2.316 ms, 2.405 ms] 884.265 µs (59.9%)
iast 2.142 ms [2.085 ms, 2.199 ms] 665.156 µs (45.0%)
iast_GLOBAL 2.183 ms [2.126 ms, 2.24 ms] 706.497 µs (47.8%)
profiling 2.005 ms [1.958 ms, 2.051 ms] 528.089 µs (35.8%)
tracing 1.952 ms [1.909 ms, 1.995 ms] 474.974 µs (32.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 2.358 ms [2.314 ms, 2.403 ms] 883.715 µs (59.9%)
iast 2.14 ms [2.084 ms, 2.196 ms] 665.321 µs (45.1%)
iast_GLOBAL 2.172 ms [2.116 ms, 2.229 ms] 697.735 µs (47.3%)
profiling 2.005 ms [1.96 ms, 2.05 ms] 530.303 µs (36.0%)
tracing 1.958 ms [1.915 ms, 2.001 ms] 483.048 µs (32.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~48eb7553b1, baseline=1.48.0-SNAPSHOT~1a0dcdf624
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.949 s) : 14949000, 14949000
.   : milestone, 14949000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.618 s) : 18618000, 18618000
.   : milestone, 18618000,
iast_GLOBAL (18.196 s) : 18196000, 18196000
.   : milestone, 18196000,
profiling (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
tracing (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
section candidate
no_agent (15.399 s) : 15399000, 15399000
.   : milestone, 15399000,
appsec (14.972 s) : 14972000, 14972000
.   : milestone, 14972000,
iast (18.19 s) : 18190000, 18190000
.   : milestone, 18190000,
iast_GLOBAL (18.243 s) : 18243000, 18243000
.   : milestone, 18243000,
profiling (15.032 s) : 15032000, 15032000
.   : milestone, 15032000,
tracing (14.696 s) : 14696000, 14696000
.   : milestone, 14696000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.949 s [14.949 s, 14.949 s] -
appsec 14.998 s [14.998 s, 14.998 s] 49.0 ms (0.3%)
iast 18.618 s [18.618 s, 18.618 s] 3.669 s (24.5%)
iast_GLOBAL 18.196 s [18.196 s, 18.196 s] 3.247 s (21.7%)
profiling 14.988 s [14.988 s, 14.988 s] 39.0 ms (0.3%)
tracing 15.016 s [15.016 s, 15.016 s] 67.0 ms (0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.399 s [15.399 s, 15.399 s] -
appsec 14.972 s [14.972 s, 14.972 s] -427.0 ms (-2.8%)
iast 18.19 s [18.19 s, 18.19 s] 2.791 s (18.1%)
iast_GLOBAL 18.243 s [18.243 s, 18.243 s] 2.844 s (18.5%)
profiling 15.032 s [15.032 s, 15.032 s] -367.0 ms (-2.4%)
tracing 14.696 s [14.696 s, 14.696 s] -703.0 ms (-4.6%)

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 12, 2025

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-activateSpan-calls
git_commit_date 1741782299 1741788829
git_commit_sha 6ac0942 48eb755
See matching parameters
Baseline Candidate
ci_job_date 1741790304 1741790304
ci_job_id 844437940 844437940
ci_pipeline_id 58564658 58564658
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@mcculls mcculls merged commit ab73c44 into master Mar 12, 2025
@mcculls mcculls deleted the mcculls/simplify-activateSpan-calls branch March 12, 2025 15:54
@github-actions github-actions Bot added this to the 1.48.0 milestone Mar 12, 2025
mtoffl01 pushed a commit that referenced this pull request Mar 24, 2025
@mcculls @mtoffl01
Simplify activateSpan calls which use the default value for isAsyncPr…
c1d1693 
…opagating (#8543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@juan-fernandez juan-fernandez Awaiting requested review from juan-fernandez juan-fernandez was automatically assigned from DataDog/ci-app-libraries-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@amarziali amarziali Awaiting requested review from amarziali

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @PerfectSlayer