Skip to content

Remove AgentScope.source() from instrumentation API#8539

Merged
mcculls merged 1 commit intomasterfrom
mcculls/remove-agent-scope-source
Mar 12, 2025
Merged

Remove AgentScope.source() from instrumentation API#8539
mcculls merged 1 commit intomasterfrom
mcculls/remove-agent-scope-source

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Mar 12, 2025 •
edited by atlassian Bot
Loading

Motivation

No reason to leak this into the instrumentation API

Contributor Checklist

Jira ticket: APMAPI-960

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 12, 2025
@mcculls mcculls marked this pull request as ready for review March 12, 2025 11:26
@mcculls mcculls requested review from a team as code owners March 12, 2025 11:26
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 12, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-agent-scope-source
git_commit_date 1741723291 1741775794
git_commit_sha 11015ee b2ee479
release_version 1.48.0-SNAPSHOT~11015eec16 1.48.0-SNAPSHOT~b2ee479713
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741781152 1741781152
ci_job_id 844086647 844086647
ci_pipeline_id 58544206 58544206
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-h-q5abda-project-304-concurrent-0-prgoknlo 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-h-q5abda-project-304-concurrent-0-prgoknlo 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~b2ee479713, baseline=1.48.0-SNAPSHOT~11015eec16

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044627
Total [baseline] (10.456 s) : 0, 10455856
Agent [candidate] (1.045 s) : 0, 1044662
Total [candidate] (10.454 s) : 0, 10454229
section appsec
Agent [baseline] (1.182 s) : 0, 1181504
Total [baseline] (10.725 s) : 0, 10724538
Agent [candidate] (1.194 s) : 0, 1193791
Total [candidate] (10.808 s) : 0, 10808473
section iast
Agent [baseline] (1.178 s) : 0, 1178404
Total [baseline] (10.956 s) : 0, 10956247
Agent [candidate] (1.182 s) : 0, 1182246
Total [candidate] (11.001 s) : 0, 11000922
section profiling
Agent [baseline] (1.274 s) : 0, 1273605
Total [baseline] (10.887 s) : 0, 10887375
Agent [candidate] (1.263 s) : 0, 1262557
Total [candidate] (10.812 s) : 0, 10812045
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.182 s 136.877 ms (13.1%)
Agent iast 1.178 s 133.777 ms (12.8%)
Agent profiling 1.274 s 228.978 ms (21.9%)
Total tracing 10.456 s -
Total appsec 10.725 s 268.683 ms (2.6%)
Total iast 10.956 s 500.392 ms (4.8%)
Total profiling 10.887 s 431.52 ms (4.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.194 s 149.129 ms (14.3%)
Agent iast 1.182 s 137.584 ms (13.2%)
Agent profiling 1.263 s 217.895 ms (20.9%)
Total tracing 10.454 s -
Total appsec 10.808 s 354.243 ms (3.4%)
Total iast 11.001 s 546.693 ms (5.2%)
Total profiling 10.812 s 357.816 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~b2ee479713, baseline=1.48.0-SNAPSHOT~11015eec16

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.81 ms) : 0, 721810
BytebuddyAgent [candidate] (718.546 ms) : 0, 718546
GlobalTracer [baseline] (240.506 ms) : 0, 240506
GlobalTracer [candidate] (240.551 ms) : 0, 240551
AppSec [baseline] (55.302 ms) : 0, 55302
AppSec [candidate] (55.636 ms) : 0, 55636
Remote Config [baseline] (709.567 µs) : 0, 710
Remote Config [candidate] (694.931 µs) : 0, 695
Telemetry [baseline] (11.386 ms) : 0, 11386
Telemetry [candidate] (14.392 ms) : 0, 14392
section appsec
BytebuddyAgent [baseline] (734.678 ms) : 0, 734678
BytebuddyAgent [candidate] (743.671 ms) : 0, 743671
GlobalTracer [baseline] (236.13 ms) : 0, 236130
GlobalTracer [candidate] (238.344 ms) : 0, 238344
AppSec [baseline] (176.296 ms) : 0, 176296
AppSec [candidate] (176.944 ms) : 0, 176944
Remote Config [baseline] (659.256 µs) : 0, 659
Remote Config [candidate] (670.557 µs) : 0, 671
Telemetry [baseline] (8.262 ms) : 0, 8262
Telemetry [candidate] (8.34 ms) : 0, 8340
IAST [baseline] (21.299 ms) : 0, 21299
IAST [candidate] (21.725 ms) : 0, 21725
section iast
BytebuddyAgent [baseline] (843.58 ms) : 0, 843580
BytebuddyAgent [candidate] (845.731 ms) : 0, 845731
GlobalTracer [baseline] (230.907 ms) : 0, 230907
GlobalTracer [candidate] (231.897 ms) : 0, 231897
AppSec [baseline] (56.685 ms) : 0, 56685
AppSec [candidate] (57.01 ms) : 0, 57010
Remote Config [baseline] (613.581 µs) : 0, 614
Remote Config [candidate] (613.289 µs) : 0, 613
Telemetry [baseline] (8.687 ms) : 0, 8687
Telemetry [candidate] (8.837 ms) : 0, 8837
IAST [baseline] (22.952 ms) : 0, 22952
IAST [candidate] (23.165 ms) : 0, 23165
section profiling
ProfilingAgent [baseline] (97.841 ms) : 0, 97841
ProfilingAgent [candidate] (96.76 ms) : 0, 96760
BytebuddyAgent [baseline] (716.478 ms) : 0, 716478
BytebuddyAgent [candidate] (710.498 ms) : 0, 710498
GlobalTracer [baseline] (353.426 ms) : 0, 353426
GlobalTracer [candidate] (351.109 ms) : 0, 351109
AppSec [baseline] (55.337 ms) : 0, 55337
AppSec [candidate] (54.21 ms) : 0, 54210
Remote Config [baseline] (692.952 µs) : 0, 693
Remote Config [candidate] (701.605 µs) : 0, 702
Telemetry [baseline] (9.09 ms) : 0, 9090
Telemetry [candidate] (8.971 ms) : 0, 8971
Profiling [baseline] (97.865 ms) : 0, 97865
Profiling [candidate] (96.784 ms) : 0, 96784
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~b2ee479713, baseline=1.48.0-SNAPSHOT~11015eec16

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041570
Total [baseline] (8.665 s) : 0, 8665081
Agent [candidate] (1.046 s) : 0, 1046120
Total [candidate] (8.69 s) : 0, 8689890
section iast
Agent [baseline] (1.177 s) : 0, 1177163
Total [baseline] (9.274 s) : 0, 9274382
Agent [candidate] (1.174 s) : 0, 1174299
Total [candidate] (9.276 s) : 0, 9275702
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1180793
Total [baseline] (9.233 s) : 0, 9233011
Agent [candidate] (1.169 s) : 0, 1169462
Total [candidate] (9.157 s) : 0, 9157190
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165954
Total [baseline] (9.259 s) : 0, 9258525
Agent [candidate] (1.168 s) : 0, 1167500
Total [candidate] (9.21 s) : 0, 9209753
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent iast 1.177 s 135.593 ms (13.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 139.224 ms (13.4%)
Agent iast_TELEMETRY_OFF 1.166 s 124.385 ms (11.9%)
Total tracing 8.665 s -
Total iast 9.274 s 609.301 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.233 s 567.93 ms (6.6%)
Total iast_TELEMETRY_OFF 9.259 s 593.444 ms (6.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.174 s 128.18 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 123.342 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.168 s 121.381 ms (11.6%)
Total tracing 8.69 s -
Total iast 9.276 s 585.812 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.157 s 467.3 ms (5.4%)
Total iast_TELEMETRY_OFF 9.21 s 519.864 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~b2ee479713, baseline=1.48.0-SNAPSHOT~11015eec16

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.285 ms) : 0, 719285
BytebuddyAgent [candidate] (723.511 ms) : 0, 723511
GlobalTracer [baseline] (239.718 ms) : 0, 239718
GlobalTracer [candidate] (241.296 ms) : 0, 241296
AppSec [baseline] (54.902 ms) : 0, 54902
AppSec [candidate] (55.498 ms) : 0, 55498
Remote Config [baseline] (686.43 µs) : 0, 686
Remote Config [candidate] (701.634 µs) : 0, 702
Telemetry [baseline] (12.137 ms) : 0, 12137
Telemetry [candidate] (10.105 ms) : 0, 10105
section iast
BytebuddyAgent [baseline] (841.892 ms) : 0, 841892
BytebuddyAgent [candidate] (839.618 ms) : 0, 839618
GlobalTracer [baseline] (231.013 ms) : 0, 231013
GlobalTracer [candidate] (230.782 ms) : 0, 230782
AppSec [baseline] (56.842 ms) : 0, 56842
AppSec [candidate] (56.529 ms) : 0, 56529
Remote Config [baseline] (611.188 µs) : 0, 611
Remote Config [candidate] (611.173 µs) : 0, 611
Telemetry [baseline] (8.793 ms) : 0, 8793
Telemetry [candidate] (8.824 ms) : 0, 8824
IAST [baseline] (23.083 ms) : 0, 23083
IAST [candidate] (23.019 ms) : 0, 23019
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (844.398 ms) : 0, 844398
BytebuddyAgent [candidate] (835.972 ms) : 0, 835972
GlobalTracer [baseline] (231.75 ms) : 0, 231750
GlobalTracer [candidate] (230.208 ms) : 0, 230208
AppSec [baseline] (56.935 ms) : 0, 56935
AppSec [candidate] (56.43 ms) : 0, 56430
Remote Config [baseline] (616.034 µs) : 0, 616
Remote Config [candidate] (603.308 µs) : 0, 603
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.62 ms) : 0, 8620
IAST [baseline] (23.333 ms) : 0, 23333
IAST [candidate] (22.759 ms) : 0, 22759
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.252 ms) : 0, 833252
BytebuddyAgent [candidate] (834.635 ms) : 0, 834635
GlobalTracer [baseline] (229.872 ms) : 0, 229872
GlobalTracer [candidate] (230.076 ms) : 0, 230076
AppSec [baseline] (56.465 ms) : 0, 56465
AppSec [candidate] (56.64 ms) : 0, 56640
Remote Config [baseline] (612.641 µs) : 0, 613
Remote Config [candidate] (608.388 µs) : 0, 608
Telemetry [baseline] (8.602 ms) : 0, 8602
Telemetry [candidate] (8.546 ms) : 0, 8546
IAST [baseline] (22.359 ms) : 0, 22359
IAST [candidate] (22.153 ms) : 0, 22153
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-12T11:35:53 2025-03-12T11:43:38
git_branch master mcculls/remove-agent-scope-source
git_commit_date 1741723291 1741775794
git_commit_sha 11015ee b2ee479
release_version 1.48.0-SNAPSHOT~11015eec16 1.48.0-SNAPSHOT~b2ee479713
start_time 2025-03-12T11:35:39 2025-03-12T11:43:24
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741780215 1741780215
ci_job_id 844086648 844086648
ci_pipeline_id 58544206 58544206
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-dgzduy7c-project-304-concurrent-0-xb66citf 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-dgzduy7c-project-304-concurrent-0-xb66citf 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~b2ee479713, baseline=1.48.0-SNAPSHOT~11015eec16
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.027 µs) : 361, 403
.   : milestone, 382,
iast (516.576 µs) : 494, 539
.   : milestone, 517,
iast_FULL (726.716 µs) : 705, 749
.   : milestone, 727,
iast_GLOBAL (562.832 µs) : 541, 585
.   : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (509.371 µs) : 488, 531
.   : milestone, 509,
iast_INACTIVE (463.98 µs) : 442, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (501.695 µs) : 480, 523
.   : milestone, 502,
tracing (461.03 µs) : 440, 482
.   : milestone, 461,
section candidate
no_agent (375.274 µs) : 355, 395
.   : milestone, 375,
iast (509.179 µs) : 488, 531
.   : milestone, 509,
iast_FULL (728.18 µs) : 706, 750
.   : milestone, 728,
iast_GLOBAL (559.029 µs) : 537, 581
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (510.672 µs) : 489, 533
.   : milestone, 511,
iast_INACTIVE (463.735 µs) : 442, 485
.   : milestone, 464,
iast_TELEMETRY_OFF (500.582 µs) : 479, 522
.   : milestone, 501,
tracing (461.765 µs) : 441, 483
.   : milestone, 462,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.027 µs [361.304 µs, 402.749 µs] -
iast 516.576 µs [494.3 µs, 538.852 µs] 134.55 µs (35.2%)
iast_FULL 726.716 µs [704.879 µs, 748.553 µs] 344.689 µs (90.2%)
iast_GLOBAL 562.832 µs [540.793 µs, 584.87 µs] 180.805 µs (47.3%)
iast_HARDCODED_SECRET_DISABLED 509.371 µs [487.675 µs, 531.068 µs] 127.345 µs (33.3%)
iast_INACTIVE 463.98 µs [442.426 µs, 485.534 µs] 81.953 µs (21.5%)
iast_TELEMETRY_OFF 501.695 µs [479.893 µs, 523.496 µs] 119.668 µs (31.3%)
tracing 461.03 µs [439.801 µs, 482.26 µs] 79.004 µs (20.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.274 µs [355.214 µs, 395.333 µs] -
iast 509.179 µs [487.517 µs, 530.841 µs] 133.906 µs (35.7%)
iast_FULL 728.18 µs [706.203 µs, 750.158 µs] 352.907 µs (94.0%)
iast_GLOBAL 559.029 µs [537.418 µs, 580.64 µs] 183.755 µs (49.0%)
iast_HARDCODED_SECRET_DISABLED 510.672 µs [488.655 µs, 532.689 µs] 135.398 µs (36.1%)
iast_INACTIVE 463.735 µs [442.221 µs, 485.248 µs] 88.461 µs (23.6%)
iast_TELEMETRY_OFF 500.582 µs [478.732 µs, 522.432 µs] 125.308 µs (33.4%)
tracing 461.765 µs [440.671 µs, 482.859 µs] 86.491 µs (23.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~b2ee479713, baseline=1.48.0-SNAPSHOT~11015eec16
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1343, 1382
.   : milestone, 1362,
appsec (1.718 ms) : 1694, 1743
.   : milestone, 1718,
appsec_no_iast (1.735 ms) : 1711, 1759
.   : milestone, 1735,
code_origins (1.689 ms) : 1662, 1716
.   : milestone, 1689,
iast (1.533 ms) : 1509, 1557
.   : milestone, 1533,
profiling (1.511 ms) : 1487, 1536
.   : milestone, 1511,
tracing (1.492 ms) : 1468, 1516
.   : milestone, 1492,
section candidate
no_agent (1.342 ms) : 1323, 1362
.   : milestone, 1342,
appsec (1.73 ms) : 1706, 1754
.   : milestone, 1730,
appsec_no_iast (1.749 ms) : 1725, 1772
.   : milestone, 1749,
code_origins (1.687 ms) : 1661, 1713
.   : milestone, 1687,
iast (1.528 ms) : 1504, 1552
.   : milestone, 1528,
profiling (1.553 ms) : 1529, 1578
.   : milestone, 1553,
tracing (1.483 ms) : 1458, 1508
.   : milestone, 1483,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.382 ms] -
appsec 1.718 ms [1.694 ms, 1.743 ms] 356.307 µs (26.2%)
appsec_no_iast 1.735 ms [1.711 ms, 1.759 ms] 372.716 µs (27.4%)
code_origins 1.689 ms [1.662 ms, 1.716 ms] 326.768 µs (24.0%)
iast 1.533 ms [1.509 ms, 1.557 ms] 171.04 µs (12.6%)
profiling 1.511 ms [1.487 ms, 1.536 ms] 149.269 µs (11.0%)
tracing 1.492 ms [1.468 ms, 1.516 ms] 129.73 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.323 ms, 1.362 ms] -
appsec 1.73 ms [1.706 ms, 1.754 ms] 387.233 µs (28.8%)
appsec_no_iast 1.749 ms [1.725 ms, 1.772 ms] 406.112 µs (30.3%)
code_origins 1.687 ms [1.661 ms, 1.713 ms] 344.917 µs (25.7%)
iast 1.528 ms [1.504 ms, 1.552 ms] 185.378 µs (13.8%)
profiling 1.553 ms [1.529 ms, 1.578 ms] 211.009 µs (15.7%)
tracing 1.483 ms [1.458 ms, 1.508 ms] 140.709 µs (10.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-agent-scope-source
git_commit_date 1741723291 1741775794
git_commit_sha 11015ee b2ee479
release_version 1.48.0-SNAPSHOT~11015eec16 1.48.0-SNAPSHOT~b2ee479713
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741780718 1741780718
ci_job_id 844086649 844086649
ci_pipeline_id 58544206 58544206
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-gzhmqs6t-project-304-concurrent-0-59pvg0mc 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-gzhmqs6t-project-304-concurrent-0-59pvg0mc 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~b2ee479713, baseline=1.48.0-SNAPSHOT~11015eec16
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.041 s) : 15041000, 15041000
.   : milestone, 15041000,
appsec (15.214 s) : 15214000, 15214000
.   : milestone, 15214000,
iast (18.403 s) : 18403000, 18403000
.   : milestone, 18403000,
iast_GLOBAL (17.573 s) : 17573000, 17573000
.   : milestone, 17573000,
profiling (15.282 s) : 15282000, 15282000
.   : milestone, 15282000,
tracing (14.636 s) : 14636000, 14636000
.   : milestone, 14636000,
section candidate
no_agent (15.504 s) : 15504000, 15504000
.   : milestone, 15504000,
appsec (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,
iast (18.653 s) : 18653000, 18653000
.   : milestone, 18653000,
iast_GLOBAL (17.77 s) : 17770000, 17770000
.   : milestone, 17770000,
profiling (14.956 s) : 14956000, 14956000
.   : milestone, 14956000,
tracing (14.644 s) : 14644000, 14644000
.   : milestone, 14644000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.041 s [15.041 s, 15.041 s] -
appsec 15.214 s [15.214 s, 15.214 s] 173.0 ms (1.2%)
iast 18.403 s [18.403 s, 18.403 s] 3.362 s (22.4%)
iast_GLOBAL 17.573 s [17.573 s, 17.573 s] 2.532 s (16.8%)
profiling 15.282 s [15.282 s, 15.282 s] 241.0 ms (1.6%)
tracing 14.636 s [14.636 s, 14.636 s] -405.0 ms (-2.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.504 s [15.504 s, 15.504 s] -
appsec 15.094 s [15.094 s, 15.094 s] -410.0 ms (-2.6%)
iast 18.653 s [18.653 s, 18.653 s] 3.149 s (20.3%)
iast_GLOBAL 17.77 s [17.77 s, 17.77 s] 2.266 s (14.6%)
profiling 14.956 s [14.956 s, 14.956 s] -548.0 ms (-3.5%)
tracing 14.644 s [14.644 s, 14.644 s] -860.0 ms (-5.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~b2ee479713, baseline=1.48.0-SNAPSHOT~11015eec16
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.365 ms) : 2321, 2409
.   : milestone, 2365,
iast (2.137 ms) : 2081, 2193
.   : milestone, 2137,
iast_GLOBAL (2.194 ms) : 2138, 2251
.   : milestone, 2194,
profiling (1.98 ms) : 1936, 2024
.   : milestone, 1980,
tracing (1.962 ms) : 1919, 2004
.   : milestone, 1962,
section candidate
no_agent (1.485 ms) : 1473, 1496
.   : milestone, 1485,
appsec (2.364 ms) : 2320, 2408
.   : milestone, 2364,
iast (2.132 ms) : 2077, 2188
.   : milestone, 2132,
iast_GLOBAL (2.18 ms) : 2124, 2236
.   : milestone, 2180,
profiling (2.008 ms) : 1963, 2054
.   : milestone, 2008,
tracing (1.978 ms) : 1934, 2021
.   : milestone, 1978,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.365 ms [2.321 ms, 2.409 ms] 891.408 µs (60.5%)
iast 2.137 ms [2.081 ms, 2.193 ms] 663.591 µs (45.0%)
iast_GLOBAL 2.194 ms [2.138 ms, 2.251 ms] 720.271 µs (48.9%)
profiling 1.98 ms [1.936 ms, 2.024 ms] 506.528 µs (34.4%)
tracing 1.962 ms [1.919 ms, 2.004 ms] 488.021 µs (33.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.485 ms [1.473 ms, 1.496 ms] -
appsec 2.364 ms [2.32 ms, 2.408 ms] 879.184 µs (59.2%)
iast 2.132 ms [2.077 ms, 2.188 ms] 647.734 µs (43.6%)
iast_GLOBAL 2.18 ms [2.124 ms, 2.236 ms] 695.658 µs (46.9%)
profiling 2.008 ms [1.963 ms, 2.054 ms] 523.924 µs (35.3%)
tracing 1.978 ms [1.934 ms, 2.021 ms] 492.952 µs (33.2%)

PerfectSlayer
PerfectSlayer approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice moving logic away from tracer itself 👍

@mcculls mcculls merged commit 6ac0942 into master Mar 12, 2025
@mcculls mcculls deleted the mcculls/remove-agent-scope-source branch March 12, 2025 12:25
@github-actions github-actions Bot added this to the 1.48.0 milestone Mar 12, 2025
mtoffl01 pushed a commit that referenced this pull request Mar 24, 2025
@mcculls @mtoffl01
Remove AgentScope.source() from instrumentation API (#8539)
4c2a2f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@amarziali amarziali amarziali approved these changes

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @PerfectSlayer @amarziali