Exclude datadog.trace.api.Config from coverage verification#8454
Merged
Exclude datadog.trace.api.Config from coverage verification#8454
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~5bebee6f43, baseline=1.47.0-SNAPSHOT~9466d9584d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053935
Total [baseline] (8.691 s) : 0, 8690579
Agent [candidate] (1.034 s) : 0, 1034277
Total [candidate] (8.666 s) : 0, 8665560
section iast
Agent [baseline] (1.173 s) : 0, 1172758
Total [baseline] (9.267 s) : 0, 9267338
Agent [candidate] (1.174 s) : 0, 1173743
Total [candidate] (9.269 s) : 0, 9269079
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1169659
Total [baseline] (9.229 s) : 0, 9229380
Agent [candidate] (1.17 s) : 0, 1169946
Total [candidate] (9.228 s) : 0, 9228042
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1166837
Total [baseline] (9.227 s) : 0, 9226922
Agent [candidate] (1.174 s) : 0, 1174073
Total [candidate] (9.272 s) : 0, 9271750
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~5bebee6f43, baseline=1.47.0-SNAPSHOT~9466d9584d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (728.001 ms) : 0, 728001
BytebuddyAgent [candidate] (714.971 ms) : 0, 714971
GlobalTracer [baseline] (243.163 ms) : 0, 243163
GlobalTracer [candidate] (238.346 ms) : 0, 238346
AppSec [baseline] (56.655 ms) : 0, 56655
AppSec [candidate] (55.407 ms) : 0, 55407
Remote Config [baseline] (712.788 µs) : 0, 713
Remote Config [candidate] (694.743 µs) : 0, 695
Telemetry [baseline] (10.231 ms) : 0, 10231
Telemetry [candidate] (10.012 ms) : 0, 10012
section iast
BytebuddyAgent [baseline] (839.587 ms) : 0, 839587
BytebuddyAgent [candidate] (839.884 ms) : 0, 839884
GlobalTracer [baseline] (228.857 ms) : 0, 228857
GlobalTracer [candidate] (229.768 ms) : 0, 229768
IAST [baseline] (22.911 ms) : 0, 22911
IAST [candidate] (23.539 ms) : 0, 23539
AppSec [baseline] (57.064 ms) : 0, 57064
AppSec [candidate] (56.167 ms) : 0, 56167
Remote Config [baseline] (614.808 µs) : 0, 615
Remote Config [candidate] (611.596 µs) : 0, 612
Telemetry [baseline] (8.683 ms) : 0, 8683
Telemetry [candidate] (8.699 ms) : 0, 8699
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.47 ms) : 0, 835470
BytebuddyAgent [candidate] (836.356 ms) : 0, 836356
GlobalTracer [baseline] (229.454 ms) : 0, 229454
GlobalTracer [candidate] (229.84 ms) : 0, 229840
IAST [baseline] (22.998 ms) : 0, 22998
IAST [candidate] (22.679 ms) : 0, 22679
AppSec [baseline] (57.286 ms) : 0, 57286
AppSec [candidate] (56.73 ms) : 0, 56730
Remote Config [baseline] (627.006 µs) : 0, 627
Remote Config [candidate] (605.15 µs) : 0, 605
Telemetry [baseline] (8.858 ms) : 0, 8858
Telemetry [candidate] (8.748 ms) : 0, 8748
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.526 ms) : 0, 833526
BytebuddyAgent [candidate] (839.446 ms) : 0, 839446
GlobalTracer [baseline] (229.454 ms) : 0, 229454
GlobalTracer [candidate] (230.366 ms) : 0, 230366
IAST [baseline] (24.792 ms) : 0, 24792
IAST [candidate] (25.689 ms) : 0, 25689
AppSec [baseline] (54.898 ms) : 0, 54898
AppSec [candidate] (54.284 ms) : 0, 54284
Remote Config [baseline] (607.316 µs) : 0, 607
Remote Config [candidate] (613.791 µs) : 0, 614
Telemetry [baseline] (8.624 ms) : 0, 8624
Telemetry [candidate] (8.665 ms) : 0, 8665
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~5bebee6f43, baseline=1.47.0-SNAPSHOT~9466d9584d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039684
Total [baseline] (10.41 s) : 0, 10409696
Agent [candidate] (1.046 s) : 0, 1045935
Total [candidate] (10.479 s) : 0, 10478637
section appsec
Agent [baseline] (1.183 s) : 0, 1183055
Total [baseline] (10.766 s) : 0, 10765929
Agent [candidate] (1.183 s) : 0, 1183181
Total [candidate] (10.761 s) : 0, 10761018
section iast
Agent [baseline] (1.171 s) : 0, 1171377
Total [baseline] (10.952 s) : 0, 10952139
Agent [candidate] (1.171 s) : 0, 1171440
Total [candidate] (11.049 s) : 0, 11048608
section profiling
Agent [baseline] (1.277 s) : 0, 1276597
Total [baseline] (10.885 s) : 0, 10885052
Agent [candidate] (1.259 s) : 0, 1259423
Total [candidate] (10.877 s) : 0, 10877045
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~5bebee6f43, baseline=1.47.0-SNAPSHOT~9466d9584d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.381 ms) : 0, 716381
BytebuddyAgent [candidate] (721.142 ms) : 0, 721142
GlobalTracer [baseline] (239.003 ms) : 0, 239003
GlobalTracer [candidate] (240.187 ms) : 0, 240187
AppSec [baseline] (55.731 ms) : 0, 55731
AppSec [candidate] (55.804 ms) : 0, 55804
Remote Config [baseline] (702.947 µs) : 0, 703
Remote Config [candidate] (700.921 µs) : 0, 701
Telemetry [baseline] (12.949 ms) : 0, 12949
Telemetry [candidate] (13.077 ms) : 0, 13077
section appsec
BytebuddyAgent [baseline] (734.74 ms) : 0, 734740
BytebuddyAgent [candidate] (736.507 ms) : 0, 736507
GlobalTracer [baseline] (236.385 ms) : 0, 236385
GlobalTracer [candidate] (235.79 ms) : 0, 235790
AppSec [baseline] (177.276 ms) : 0, 177276
AppSec [candidate] (176.376 ms) : 0, 176376
Remote Config [baseline] (672.087 µs) : 0, 672
Remote Config [candidate] (658.372 µs) : 0, 658
Telemetry [baseline] (8.258 ms) : 0, 8258
Telemetry [candidate] (8.267 ms) : 0, 8267
IAST [baseline] (21.603 ms) : 0, 21603
IAST [candidate] (21.279 ms) : 0, 21279
section iast
BytebuddyAgent [baseline] (837.211 ms) : 0, 837211
BytebuddyAgent [candidate] (837.216 ms) : 0, 837216
GlobalTracer [baseline] (229.798 ms) : 0, 229798
GlobalTracer [candidate] (229.914 ms) : 0, 229914
AppSec [baseline] (57.2 ms) : 0, 57200
AppSec [candidate] (57.251 ms) : 0, 57251
Remote Config [baseline] (618.493 µs) : 0, 618
Remote Config [candidate] (603.71 µs) : 0, 604
Telemetry [baseline] (8.661 ms) : 0, 8661
Telemetry [candidate] (8.723 ms) : 0, 8723
IAST [baseline] (22.853 ms) : 0, 22853
IAST [candidate] (22.725 ms) : 0, 22725
section profiling
BytebuddyAgent [baseline] (717.919 ms) : 0, 717919
BytebuddyAgent [candidate] (708.69 ms) : 0, 708690
GlobalTracer [baseline] (353.372 ms) : 0, 353372
GlobalTracer [candidate] (349.695 ms) : 0, 349695
AppSec [baseline] (56.319 ms) : 0, 56319
AppSec [candidate] (54.765 ms) : 0, 54765
Remote Config [baseline] (682.586 µs) : 0, 683
Remote Config [candidate] (663.054 µs) : 0, 663
Telemetry [baseline] (9.043 ms) : 0, 9043
Telemetry [candidate] (8.999 ms) : 0, 8999
ProfilingAgent [baseline] (98.332 ms) : 0, 98332
ProfilingAgent [candidate] (96.245 ms) : 0, 96245
Profiling [baseline] (98.356 ms) : 0, 98356
Profiling [candidate] (96.268 ms) : 0, 96268
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~5bebee6f43, baseline=1.47.0-SNAPSHOT~9466d9584d
dateFormat X
axisFormat %s
section baseline
no_agent (381.827 µs) : 362, 402
. : milestone, 382,
iast (509.573 µs) : 488, 531
. : milestone, 510,
iast_FULL (726.996 µs) : 705, 749
. : milestone, 727,
iast_GLOBAL (554.104 µs) : 532, 576
. : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (510.796 µs) : 489, 532
. : milestone, 511,
iast_INACTIVE (463.38 µs) : 442, 485
. : milestone, 463,
iast_TELEMETRY_OFF (500.452 µs) : 479, 522
. : milestone, 500,
tracing (462.884 µs) : 442, 484
. : milestone, 463,
section candidate
no_agent (383.69 µs) : 364, 403
. : milestone, 384,
iast (515.662 µs) : 493, 538
. : milestone, 516,
iast_FULL (729.17 µs) : 707, 751
. : milestone, 729,
iast_GLOBAL (557.802 µs) : 536, 579
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (515.181 µs) : 493, 537
. : milestone, 515,
iast_INACTIVE (462.616 µs) : 442, 484
. : milestone, 463,
iast_TELEMETRY_OFF (498.159 µs) : 475, 521
. : milestone, 498,
tracing (460.991 µs) : 440, 482
. : milestone, 461,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~5bebee6f43, baseline=1.47.0-SNAPSHOT~9466d9584d
dateFormat X
axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1378
. : milestone, 1359,
appsec (1.748 ms) : 1724, 1772
. : milestone, 1748,
appsec_no_iast (1.766 ms) : 1740, 1792
. : milestone, 1766,
code_origins (1.689 ms) : 1656, 1722
. : milestone, 1689,
iast (1.507 ms) : 1483, 1531
. : milestone, 1507,
profiling (1.507 ms) : 1483, 1531
. : milestone, 1507,
tracing (1.504 ms) : 1479, 1528
. : milestone, 1504,
section candidate
no_agent (1.353 ms) : 1333, 1374
. : milestone, 1353,
appsec (1.758 ms) : 1735, 1782
. : milestone, 1758,
appsec_no_iast (1.769 ms) : 1745, 1793
. : milestone, 1769,
code_origins (1.684 ms) : 1650, 1718
. : milestone, 1684,
iast (1.512 ms) : 1489, 1536
. : milestone, 1512,
profiling (1.514 ms) : 1492, 1537
. : milestone, 1514,
tracing (1.49 ms) : 1465, 1515
. : milestone, 1490,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~5bebee6f43, baseline=1.47.0-SNAPSHOT~9466d9584d
dateFormat X
axisFormat %s
section baseline
no_agent (15.549 s) : 15549000, 15549000
. : milestone, 15549000,
appsec (14.783 s) : 14783000, 14783000
. : milestone, 14783000,
iast (18.483 s) : 18483000, 18483000
. : milestone, 18483000,
iast_GLOBAL (18.366 s) : 18366000, 18366000
. : milestone, 18366000,
profiling (15.147 s) : 15147000, 15147000
. : milestone, 15147000,
tracing (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
section candidate
no_agent (15.221 s) : 15221000, 15221000
. : milestone, 15221000,
appsec (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
iast (18.706 s) : 18706000, 18706000
. : milestone, 18706000,
iast_GLOBAL (17.948 s) : 17948000, 17948000
. : milestone, 17948000,
profiling (15.6 s) : 15600000, 15600000
. : milestone, 15600000,
tracing (15.128 s) : 15128000, 15128000
. : milestone, 15128000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~5bebee6f43, baseline=1.47.0-SNAPSHOT~9466d9584d
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.34 ms) : 2298, 2383
. : milestone, 2340,
iast (2.096 ms) : 2041, 2151
. : milestone, 2096,
iast_GLOBAL (2.143 ms) : 2087, 2198
. : milestone, 2143,
profiling (1.97 ms) : 1925, 2014
. : milestone, 1970,
tracing (1.931 ms) : 1889, 1973
. : milestone, 1931,
section candidate
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.356 ms) : 2313, 2400
. : milestone, 2356,
iast (2.101 ms) : 2047, 2156
. : milestone, 2101,
iast_GLOBAL (2.151 ms) : 2095, 2206
. : milestone, 2151,
profiling (1.966 ms) : 1922, 2010
. : milestone, 1966,
tracing (1.937 ms) : 1895, 1979
. : milestone, 1937,
|
PerfectSlayer
requested changes
Feb 26, 2025
PerfectSlayer
approved these changes
Feb 27, 2025
Contributor
PerfectSlayer
left a comment
There was a problem hiding this comment.
Thanks for the quick fix 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
task ':internal-api:jacocoTestCoverageVerification' is failing due to current datadog.trace.api.Config coverage it's lower than 0.8
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]