Skip to content

Introduce new flag to enable the live debugger specifically#8418

Merged
evanchooly merged 2 commits intomasterfrom
evanchooly/DEBUG-3493
Feb 21, 2025
Merged

Introduce new flag to enable the live debugger specifically#8418
evanchooly merged 2 commits intomasterfrom
evanchooly/DEBUG-3493

Conversation

@evanchooly
Copy link
Copy Markdown
Contributor

@evanchooly evanchooly commented Feb 18, 2025 •
edited by atlassian Bot
Loading

What Does This Do

Adds a new configuration option specifically for dynamic instrumentation's live debugger

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-3493

@evanchooly evanchooly requested review from a team as code owners February 18, 2025 21:47
@evanchooly evanchooly requested review from jpbempel and smola and removed request for a team February 18, 2025 21:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 18, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@evanchooly evanchooly requested review from shatzi and removed request for jpbempel and smola February 18, 2025 21:49
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 18, 2025 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1740086940 1740087321
end_time 2025-02-20T21:30:17 2025-02-20T21:36:38
git_branch master evanchooly/DEBUG-3493
git_commit_sha 121f38f edd5350
start_time 2025-02-20T21:29:01 2025-02-20T21:35:22
See matching parameters
Baseline Candidate
ci_job_id 816900376 816900376
ci_pipeline_id 56492764 56492764
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1740086346 1740086346

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 6 metrics, 7 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic worse
[+8.884µs; +27.654µs] or [+3.313%; +10.312%]		 worse
[+4.710µs; +33.834µs] or [+1.585%; +11.390%]		 unstable
[+1.097µs; +36.463µs] or [+0.356%; +11.827%]		 unstable
[-43.110µs; +72.887µs] or [-8.097%; +13.690%]		 unstable
[-260.254op/s; +132.049op/s] or [-10.150%; +5.150%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-29.423µs; +57.765µs] or [-10.881%; +21.362%]		 unstable
[-41.068µs; +70.715µs] or [-13.178%; +22.692%]		 unstable
[-51.529µs; +84.463µs] or [-15.790%; +25.882%]		 unstable
[-339.695µs; +856.008µs] or [-56.176%; +141.560%]		 same
scenario:loop unsure
[+40.744µs; +98.179µs] or [+0.386%; +0.930%]		 unsure
[+36.646µs; +117.857µs] or [+0.342%; +1.099%]		 unsure
[+23.869µs; +129.125µs] or [+0.221%; +1.195%]		 same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (311.631 µs) : 274, 349
.   : milestone, 312,
basic (297.05 µs) : 287, 308
.   : milestone, 297,
loop (10.728 ms) : 10685, 10771
.   : milestone, 10728,
section candidate
noprobe (326.455 µs) : 261, 392
.   : milestone, 326,
basic (316.321 µs) : 299, 334
.   : milestone, 316,
loop (10.805 ms) : 10774, 10837
.   : milestone, 10805,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 311.631 µs [273.965 µs, 349.298 µs]
basic 297.05 µs [286.57 µs, 307.529 µs]
loop 10.728 ms [10.685 ms, 10.771 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 326.455 µs [261.203 µs, 391.706 µs]
basic 316.321 µs [299.138 µs, 333.505 µs]
loop 10.805 ms [10.774 ms, 10.837 ms]

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 18, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-3493
git_commit_date 1740074363 1740086346
git_commit_sha 121f38f edd5350
release_version 1.47.0-SNAPSHOT~121f38f42d 1.47.0-SNAPSHOT~edd5350d33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1740088811 1740088811
ci_job_id 816900359 816900359
ci_pipeline_id 56492764 56492764
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-p15wvcmg-project-304-concurrent-4-5nb31ecy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-p15wvcmg-project-304-concurrent-4-5nb31ecy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~edd5350d33, baseline=1.47.0-SNAPSHOT~121f38f42d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062868
Total [baseline] (10.529 s) : 0, 10528821
Agent [candidate] (1.05 s) : 0, 1049766
Total [candidate] (10.539 s) : 0, 10539497
section appsec
Agent [baseline] (1.188 s) : 0, 1187946
Total [baseline] (10.764 s) : 0, 10763534
Agent [candidate] (1.181 s) : 0, 1181216
Total [candidate] (10.725 s) : 0, 10725201
section iast
Agent [baseline] (1.175 s) : 0, 1174996
Total [baseline] (11.022 s) : 0, 11021841
Agent [candidate] (1.183 s) : 0, 1182852
Total [candidate] (11.008 s) : 0, 11007653
section profiling
Agent [baseline] (1.27 s) : 0, 1269695
Total [baseline] (10.882 s) : 0, 10882426
Agent [candidate] (1.263 s) : 0, 1263249
Total [candidate] (10.838 s) : 0, 10838282
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.188 s 125.078 ms (11.8%)
Agent iast 1.175 s 112.128 ms (10.5%)
Agent profiling 1.27 s 206.827 ms (19.5%)
Total tracing 10.529 s -
Total appsec 10.764 s 234.713 ms (2.2%)
Total iast 11.022 s 493.021 ms (4.7%)
Total profiling 10.882 s 353.606 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.181 s 131.449 ms (12.5%)
Agent iast 1.183 s 133.086 ms (12.7%)
Agent profiling 1.263 s 213.483 ms (20.3%)
Total tracing 10.539 s -
Total appsec 10.725 s 185.704 ms (1.8%)
Total iast 11.008 s 468.157 ms (4.4%)
Total profiling 10.838 s 298.785 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~edd5350d33, baseline=1.47.0-SNAPSHOT~121f38f42d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (734.091 ms) : 0, 734091
BytebuddyAgent [candidate] (724.476 ms) : 0, 724476
GlobalTracer [baseline] (244.402 ms) : 0, 244402
GlobalTracer [candidate] (241.898 ms) : 0, 241898
AppSec [baseline] (56.468 ms) : 0, 56468
AppSec [candidate] (55.922 ms) : 0, 55922
Remote Config [baseline] (723.671 µs) : 0, 724
Remote Config [candidate] (706.12 µs) : 0, 706
Telemetry [baseline] (11.731 ms) : 0, 11731
Telemetry [candidate] (11.388 ms) : 0, 11388
section appsec
BytebuddyAgent [baseline] (738.069 ms) : 0, 738069
BytebuddyAgent [candidate] (733.852 ms) : 0, 733852
GlobalTracer [baseline] (237.452 ms) : 0, 237452
GlobalTracer [candidate] (236.424 ms) : 0, 236424
IAST [baseline] (21.384 ms) : 0, 21384
IAST [candidate] (21.312 ms) : 0, 21312
AppSec [baseline] (177.202 ms) : 0, 177202
AppSec [candidate] (176.137 ms) : 0, 176137
Remote Config [baseline] (670.521 µs) : 0, 671
Remote Config [candidate] (655.959 µs) : 0, 656
Telemetry [baseline] (8.651 ms) : 0, 8651
Telemetry [candidate] (8.286 ms) : 0, 8286
section iast
BytebuddyAgent [baseline] (838.74 ms) : 0, 838740
BytebuddyAgent [candidate] (844.847 ms) : 0, 844847
GlobalTracer [baseline] (231.524 ms) : 0, 231524
GlobalTracer [candidate] (232.208 ms) : 0, 232208
IAST [baseline] (22.795 ms) : 0, 22795
IAST [candidate] (23.068 ms) : 0, 23068
AppSec [baseline] (57.223 ms) : 0, 57223
AppSec [candidate] (57.765 ms) : 0, 57765
Remote Config [baseline] (616.955 µs) : 0, 617
Remote Config [candidate] (626.661 µs) : 0, 627
Telemetry [baseline] (8.809 ms) : 0, 8809
Telemetry [candidate] (8.818 ms) : 0, 8818
section profiling
BytebuddyAgent [baseline] (712.251 ms) : 0, 712251
BytebuddyAgent [candidate] (709.803 ms) : 0, 709803
GlobalTracer [baseline] (352.722 ms) : 0, 352722
GlobalTracer [candidate] (351.038 ms) : 0, 351038
AppSec [baseline] (55.445 ms) : 0, 55445
AppSec [candidate] (54.672 ms) : 0, 54672
Remote Config [baseline] (670.172 µs) : 0, 670
Remote Config [candidate] (666.902 µs) : 0, 667
Telemetry [baseline] (9.243 ms) : 0, 9243
Telemetry [candidate] (8.95 ms) : 0, 8950
ProfilingAgent [baseline] (96.837 ms) : 0, 96837
ProfilingAgent [candidate] (95.87 ms) : 0, 95870
Profiling [baseline] (96.862 ms) : 0, 96862
Profiling [candidate] (95.894 ms) : 0, 95894
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~edd5350d33, baseline=1.47.0-SNAPSHOT~121f38f42d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049340
Total [baseline] (8.68 s) : 0, 8679619
Agent [candidate] (1.047 s) : 0, 1047054
Total [candidate] (8.672 s) : 0, 8671647
section iast
Agent [baseline] (1.187 s) : 0, 1187159
Total [baseline] (9.263 s) : 0, 9262755
Agent [candidate] (1.18 s) : 0, 1180073
Total [candidate] (9.231 s) : 0, 9231488
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171878
Total [baseline] (9.24 s) : 0, 9240440
Agent [candidate] (1.172 s) : 0, 1172105
Total [candidate] (9.202 s) : 0, 9202437
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1171293
Total [baseline] (9.273 s) : 0, 9273453
Agent [candidate] (1.178 s) : 0, 1177920
Total [candidate] (9.234 s) : 0, 9233832
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.187 s 137.819 ms (13.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 122.538 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.171 s 121.954 ms (11.6%)
Total tracing 8.68 s -
Total iast 9.263 s 583.136 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.24 s 560.821 ms (6.5%)
Total iast_TELEMETRY_OFF 9.273 s 593.834 ms (6.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.18 s 133.019 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 125.051 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.178 s 130.866 ms (12.5%)
Total tracing 8.672 s -
Total iast 9.231 s 559.84 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.202 s 530.79 ms (6.1%)
Total iast_TELEMETRY_OFF 9.234 s 562.185 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~edd5350d33, baseline=1.47.0-SNAPSHOT~121f38f42d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.608 ms) : 0, 724608
BytebuddyAgent [candidate] (722.05 ms) : 0, 722050
GlobalTracer [baseline] (241.802 ms) : 0, 241802
GlobalTracer [candidate] (239.976 ms) : 0, 239976
AppSec [baseline] (55.972 ms) : 0, 55972
AppSec [candidate] (55.321 ms) : 0, 55321
Remote Config [baseline] (700.191 µs) : 0, 700
Remote Config [candidate] (692.889 µs) : 0, 693
Telemetry [baseline] (10.861 ms) : 0, 10861
Telemetry [candidate] (13.715 ms) : 0, 13715
section iast
BytebuddyAgent [baseline] (847.741 ms) : 0, 847741
BytebuddyAgent [candidate] (842.294 ms) : 0, 842294
GlobalTracer [baseline] (232.608 ms) : 0, 232608
GlobalTracer [candidate] (232.068 ms) : 0, 232068
IAST [baseline] (23.19 ms) : 0, 23190
IAST [candidate] (22.956 ms) : 0, 22956
AppSec [baseline] (58.368 ms) : 0, 58368
AppSec [candidate] (57.947 ms) : 0, 57947
Remote Config [baseline] (639.976 µs) : 0, 640
Remote Config [candidate] (622.278 µs) : 0, 622
Telemetry [baseline] (8.855 ms) : 0, 8855
Telemetry [candidate] (8.794 ms) : 0, 8794
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.105 ms) : 0, 836105
BytebuddyAgent [candidate] (836.391 ms) : 0, 836391
GlobalTracer [baseline] (230.441 ms) : 0, 230441
GlobalTracer [candidate] (230.41 ms) : 0, 230410
IAST [baseline] (22.817 ms) : 0, 22817
IAST [candidate] (22.949 ms) : 0, 22949
AppSec [baseline] (57.635 ms) : 0, 57635
AppSec [candidate] (57.636 ms) : 0, 57636
Remote Config [baseline] (607.308 µs) : 0, 607
Remote Config [candidate] (622.372 µs) : 0, 622
Telemetry [baseline] (8.827 ms) : 0, 8827
Telemetry [candidate] (8.863 ms) : 0, 8863
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.483 ms) : 0, 835483
BytebuddyAgent [candidate] (840.849 ms) : 0, 840849
GlobalTracer [baseline] (231.219 ms) : 0, 231219
GlobalTracer [candidate] (232.328 ms) : 0, 232328
IAST [baseline] (27.01 ms) : 0, 27010
IAST [candidate] (27.208 ms) : 0, 27208
AppSec [baseline] (52.941 ms) : 0, 52941
AppSec [candidate] (52.875 ms) : 0, 52875
Remote Config [baseline] (629.611 µs) : 0, 630
Remote Config [candidate] (618.279 µs) : 0, 618
Telemetry [baseline] (8.702 ms) : 0, 8702
Telemetry [candidate] (8.681 ms) : 0, 8681
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-20T21:30:10 2025-02-20T21:37:15
git_branch master evanchooly/DEBUG-3493
git_commit_date 1740074363 1740086346
git_commit_sha 121f38f edd5350
release_version 1.47.0-SNAPSHOT~121f38f42d 1.47.0-SNAPSHOT~edd5350d33
start_time 2025-02-20T21:29:56 2025-02-20T21:37:01
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1740087792 1740087792
ci_job_id 816900361 816900361
ci_pipeline_id 56492764 56492764
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-64dctnlg-project-304-concurrent-0-hdkegfqi 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-64dctnlg-project-304-concurrent-0-hdkegfqi 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~edd5350d33, baseline=1.47.0-SNAPSHOT~121f38f42d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.36 ms) : 1340, 1380
.   : milestone, 1360,
appsec (1.743 ms) : 1720, 1767
.   : milestone, 1743,
appsec_no_iast (1.776 ms) : 1753, 1799
.   : milestone, 1776,
iast (1.509 ms) : 1484, 1533
.   : milestone, 1509,
profiling (1.531 ms) : 1506, 1556
.   : milestone, 1531,
tracing (1.522 ms) : 1497, 1547
.   : milestone, 1522,
section candidate
no_agent (1.363 ms) : 1343, 1383
.   : milestone, 1363,
appsec (1.744 ms) : 1720, 1767
.   : milestone, 1744,
appsec_no_iast (1.769 ms) : 1746, 1792
.   : milestone, 1769,
iast (1.515 ms) : 1490, 1540
.   : milestone, 1515,
profiling (1.522 ms) : 1499, 1545
.   : milestone, 1522,
tracing (1.503 ms) : 1479, 1527
.   : milestone, 1503,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.38 ms] -
appsec 1.743 ms [1.72 ms, 1.767 ms] 383.218 µs (28.2%)
appsec_no_iast 1.776 ms [1.753 ms, 1.799 ms] 415.63 µs (30.6%)
iast 1.509 ms [1.484 ms, 1.533 ms] 148.513 µs (10.9%)
profiling 1.531 ms [1.506 ms, 1.556 ms] 171.014 µs (12.6%)
tracing 1.522 ms [1.497 ms, 1.547 ms] 161.624 µs (11.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.343 ms, 1.383 ms] -
appsec 1.744 ms [1.72 ms, 1.767 ms] 380.789 µs (27.9%)
appsec_no_iast 1.769 ms [1.746 ms, 1.792 ms] 405.757 µs (29.8%)
iast 1.515 ms [1.49 ms, 1.54 ms] 152.267 µs (11.2%)
profiling 1.522 ms [1.499 ms, 1.545 ms] 158.618 µs (11.6%)
tracing 1.503 ms [1.479 ms, 1.527 ms] 139.917 µs (10.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~edd5350d33, baseline=1.47.0-SNAPSHOT~121f38f42d
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.645 µs) : 358, 399
.   : milestone, 379,
iast (518.471 µs) : 495, 542
.   : milestone, 518,
iast_FULL (731.109 µs) : 709, 753
.   : milestone, 731,
iast_GLOBAL (549.476 µs) : 528, 571
.   : milestone, 549,
iast_HARDCODED_SECRET_DISABLED (513.271 µs) : 490, 536
.   : milestone, 513,
iast_INACTIVE (468.213 µs) : 446, 491
.   : milestone, 468,
iast_TELEMETRY_OFF (504.009 µs) : 481, 528
.   : milestone, 504,
tracing (461.292 µs) : 440, 483
.   : milestone, 461,
section candidate
no_agent (380.605 µs) : 360, 402
.   : milestone, 381,
iast (511.803 µs) : 490, 534
.   : milestone, 512,
iast_FULL (725.233 µs) : 703, 747
.   : milestone, 725,
iast_GLOBAL (562.855 µs) : 540, 586
.   : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (505.2 µs) : 483, 528
.   : milestone, 505,
iast_INACTIVE (458.936 µs) : 437, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (499.334 µs) : 476, 523
.   : milestone, 499,
tracing (456.851 µs) : 436, 478
.   : milestone, 457,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.645 µs [358.308 µs, 398.981 µs] -
iast 518.471 µs [495.111 µs, 541.831 µs] 139.826 µs (36.9%)
iast_FULL 731.109 µs [709.042 µs, 753.176 µs] 352.464 µs (93.1%)
iast_GLOBAL 549.476 µs [527.818 µs, 571.134 µs] 170.831 µs (45.1%)
iast_HARDCODED_SECRET_DISABLED 513.271 µs [490.363 µs, 536.178 µs] 134.626 µs (35.6%)
iast_INACTIVE 468.213 µs [445.856 µs, 490.571 µs] 89.569 µs (23.7%)
iast_TELEMETRY_OFF 504.009 µs [480.505 µs, 527.513 µs] 125.365 µs (33.1%)
tracing 461.292 µs [439.866 µs, 482.717 µs] 82.647 µs (21.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.605 µs [359.672 µs, 401.538 µs] -
iast 511.803 µs [490.048 µs, 533.558 µs] 131.198 µs (34.5%)
iast_FULL 725.233 µs [703.278 µs, 747.188 µs] 344.628 µs (90.5%)
iast_GLOBAL 562.855 µs [540.101 µs, 585.61 µs] 182.25 µs (47.9%)
iast_HARDCODED_SECRET_DISABLED 505.2 µs [482.768 µs, 527.631 µs] 124.595 µs (32.7%)
iast_INACTIVE 458.936 µs [437.117 µs, 480.754 µs] 78.331 µs (20.6%)
iast_TELEMETRY_OFF 499.334 µs [476.069 µs, 522.599 µs] 118.729 µs (31.2%)
tracing 456.851 µs [435.89 µs, 477.811 µs] 76.246 µs (20.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-3493
git_commit_date 1740074363 1740086346
git_commit_sha 121f38f edd5350
release_version 1.47.0-SNAPSHOT~121f38f42d 1.47.0-SNAPSHOT~edd5350d33
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1740088392 1740088392
ci_job_id 816900364 816900364
ci_pipeline_id 56492764 56492764
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-hmquynjz-project-304-concurrent-0-r8pqy3ip 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-hmquynjz-project-304-concurrent-0-r8pqy3ip 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~edd5350d33, baseline=1.47.0-SNAPSHOT~121f38f42d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.367 ms) : 2324, 2410
.   : milestone, 2367,
iast (2.115 ms) : 2060, 2170
.   : milestone, 2115,
iast_GLOBAL (2.157 ms) : 2102, 2213
.   : milestone, 2157,
profiling (1.974 ms) : 1930, 2018
.   : milestone, 1974,
tracing (1.948 ms) : 1906, 1991
.   : milestone, 1948,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.363 ms) : 2319, 2406
.   : milestone, 2363,
iast (2.111 ms) : 2056, 2166
.   : milestone, 2111,
iast_GLOBAL (2.158 ms) : 2103, 2213
.   : milestone, 2158,
profiling (1.969 ms) : 1924, 2013
.   : milestone, 1969,
tracing (1.947 ms) : 1904, 1989
.   : milestone, 1947,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.367 ms [2.324 ms, 2.41 ms] 892.491 µs (60.5%)
iast 2.115 ms [2.06 ms, 2.17 ms] 640.817 µs (43.5%)
iast_GLOBAL 2.157 ms [2.102 ms, 2.213 ms] 682.967 µs (46.3%)
profiling 1.974 ms [1.93 ms, 2.018 ms] 499.806 µs (33.9%)
tracing 1.948 ms [1.906 ms, 1.991 ms] 473.955 µs (32.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.363 ms [2.319 ms, 2.406 ms] 891.029 µs (60.6%)
iast 2.111 ms [2.056 ms, 2.166 ms] 639.689 µs (43.5%)
iast_GLOBAL 2.158 ms [2.103 ms, 2.213 ms] 686.445 µs (46.6%)
profiling 1.969 ms [1.924 ms, 2.013 ms] 497.084 µs (33.8%)
tracing 1.947 ms [1.904 ms, 1.989 ms] 475.267 µs (32.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~edd5350d33, baseline=1.47.0-SNAPSHOT~121f38f42d
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.876 s) : 14876000, 14876000
.   : milestone, 14876000,
appsec (14.873 s) : 14873000, 14873000
.   : milestone, 14873000,
iast (18.676 s) : 18676000, 18676000
.   : milestone, 18676000,
iast_GLOBAL (17.928 s) : 17928000, 17928000
.   : milestone, 17928000,
profiling (15.099 s) : 15099000, 15099000
.   : milestone, 15099000,
tracing (15.058 s) : 15058000, 15058000
.   : milestone, 15058000,
section candidate
no_agent (15.271 s) : 15271000, 15271000
.   : milestone, 15271000,
appsec (14.986 s) : 14986000, 14986000
.   : milestone, 14986000,
iast (18.613 s) : 18613000, 18613000
.   : milestone, 18613000,
iast_GLOBAL (18.114 s) : 18114000, 18114000
.   : milestone, 18114000,
profiling (15.376 s) : 15376000, 15376000
.   : milestone, 15376000,
tracing (14.7 s) : 14700000, 14700000
.   : milestone, 14700000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.876 s [14.876 s, 14.876 s] -
appsec 14.873 s [14.873 s, 14.873 s] -3.0 ms (-0.0%)
iast 18.676 s [18.676 s, 18.676 s] 3.8 s (25.5%)
iast_GLOBAL 17.928 s [17.928 s, 17.928 s] 3.052 s (20.5%)
profiling 15.099 s [15.099 s, 15.099 s] 223.0 ms (1.5%)
tracing 15.058 s [15.058 s, 15.058 s] 182.0 ms (1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.271 s [15.271 s, 15.271 s] -
appsec 14.986 s [14.986 s, 14.986 s] -285.0 ms (-1.9%)
iast 18.613 s [18.613 s, 18.613 s] 3.342 s (21.9%)
iast_GLOBAL 18.114 s [18.114 s, 18.114 s] 2.843 s (18.6%)
profiling 15.376 s [15.376 s, 15.376 s] 105.0 ms (0.7%)
tracing 14.7 s [14.7 s, 14.7 s] -571.0 ms (-3.7%)

shatzi
shatzi reviewed Feb 19, 2025
View reviewed changes
Comment thread dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/origin/CodeOriginTest.java Outdated
@jpbempel
Copy link
Copy Markdown
Member

jpbempel commented Feb 19, 2025

should add also the value in the StatusLogger here along with exception replay, code origin and di

@evanchooly evanchooly force-pushed the evanchooly/DEBUG-3493 branch from 5d8a0fc to 2e26a63 Compare February 19, 2025 17:57
@evanchooly evanchooly requested a review from shatzi February 19, 2025 18:21
@evanchooly evanchooly added type: enhancement Enhancements and improvements comp: debugger Dynamic Instrumentation inst: java Core Java language instrumentation tag: no release notes Changes to exclude from release notes labels Feb 19, 2025
@evanchooly evanchooly force-pushed the evanchooly/DEBUG-3493 branch from 32d6482 to c479c18 Compare February 20, 2025 15:03
@evanchooly evanchooly merged commit 19ce7f1 into master Feb 21, 2025
@evanchooly evanchooly deleted the evanchooly/DEBUG-3493 branch February 21, 2025 17:31
@github-actions github-actions Bot added this to the 1.47.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shatzi shatzi shatzi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation inst: java Core Java language instrumentation tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

3 participants

@evanchooly @jpbempel @shatzi