Fix test name uniqueness#8410
Merged
PerfectSlayer merged 1 commit intomasterfrom Feb 18, 2025
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~2a3526fc61, baseline=1.47.0-SNAPSHOT~eeba960fd3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046701
Total [baseline] (10.563 s) : 0, 10563201
Agent [candidate] (1.045 s) : 0, 1044914
Total [candidate] (10.479 s) : 0, 10478605
section appsec
Agent [baseline] (1.183 s) : 0, 1183328
Total [baseline] (10.762 s) : 0, 10761706
Agent [candidate] (1.192 s) : 0, 1192081
Total [candidate] (10.761 s) : 0, 10761046
section iast
Agent [baseline] (1.185 s) : 0, 1185394
Total [baseline] (10.933 s) : 0, 10932520
Agent [candidate] (1.175 s) : 0, 1174775
Total [candidate] (11.026 s) : 0, 11026193
section profiling
Agent [baseline] (1.266 s) : 0, 1265590
Total [baseline] (10.94 s) : 0, 10939578
Agent [candidate] (1.274 s) : 0, 1273724
Total [candidate] (10.89 s) : 0, 10890147
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~2a3526fc61, baseline=1.47.0-SNAPSHOT~eeba960fd3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.417 ms) : 0, 721417
BytebuddyAgent [candidate] (719.524 ms) : 0, 719524
GlobalTracer [baseline] (241.143 ms) : 0, 241143
GlobalTracer [candidate] (240.813 ms) : 0, 240813
AppSec [baseline] (55.834 ms) : 0, 55834
AppSec [candidate] (55.486 ms) : 0, 55486
Remote Config [baseline] (701.392 µs) : 0, 701
Remote Config [candidate] (701.865 µs) : 0, 702
Telemetry [baseline] (12.23 ms) : 0, 12230
Telemetry [candidate] (13.1 ms) : 0, 13100
section appsec
BytebuddyAgent [baseline] (735.453 ms) : 0, 735453
BytebuddyAgent [candidate] (740.483 ms) : 0, 740483
GlobalTracer [baseline] (236.92 ms) : 0, 236920
GlobalTracer [candidate] (238.532 ms) : 0, 238532
AppSec [baseline] (176.129 ms) : 0, 176129
AppSec [candidate] (177.809 ms) : 0, 177809
Remote Config [baseline] (665.643 µs) : 0, 666
Remote Config [candidate] (666.619 µs) : 0, 667
Telemetry [baseline] (8.274 ms) : 0, 8274
Telemetry [candidate] (8.285 ms) : 0, 8285
IAST [baseline] (21.307 ms) : 0, 21307
IAST [candidate] (21.867 ms) : 0, 21867
section iast
BytebuddyAgent [baseline] (848.582 ms) : 0, 848582
BytebuddyAgent [candidate] (837.406 ms) : 0, 837406
GlobalTracer [baseline] (231.675 ms) : 0, 231675
GlobalTracer [candidate] (232.221 ms) : 0, 232221
AppSec [baseline] (57.34 ms) : 0, 57340
AppSec [candidate] (57.323 ms) : 0, 57323
Remote Config [baseline] (612.14 µs) : 0, 612
Remote Config [candidate] (613.815 µs) : 0, 614
Telemetry [baseline] (8.752 ms) : 0, 8752
Telemetry [candidate] (8.784 ms) : 0, 8784
IAST [baseline] (22.953 ms) : 0, 22953
IAST [candidate] (23.158 ms) : 0, 23158
section profiling
BytebuddyAgent [baseline] (708.967 ms) : 0, 708967
BytebuddyAgent [candidate] (715.782 ms) : 0, 715782
GlobalTracer [baseline] (351.69 ms) : 0, 351690
GlobalTracer [candidate] (353.953 ms) : 0, 353953
AppSec [baseline] (55.91 ms) : 0, 55910
AppSec [candidate] (54.843 ms) : 0, 54843
Remote Config [baseline] (691.283 µs) : 0, 691
Remote Config [candidate] (677.996 µs) : 0, 678
Telemetry [baseline] (8.954 ms) : 0, 8954
Telemetry [candidate] (8.929 ms) : 0, 8929
ProfilingAgent [baseline] (96.871 ms) : 0, 96871
ProfilingAgent [candidate] (96.524 ms) : 0, 96524
Profiling [baseline] (96.896 ms) : 0, 96896
Profiling [candidate] (96.549 ms) : 0, 96549
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~2a3526fc61, baseline=1.47.0-SNAPSHOT~eeba960fd3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049021
Total [baseline] (8.667 s) : 0, 8666891
Agent [candidate] (1.049 s) : 0, 1049229
Total [candidate] (8.701 s) : 0, 8700529
section iast
Agent [baseline] (1.169 s) : 0, 1169168
Total [baseline] (9.268 s) : 0, 9267578
Agent [candidate] (1.176 s) : 0, 1176246
Total [candidate] (9.281 s) : 0, 9280929
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1175335
Total [baseline] (9.235 s) : 0, 9235337
Agent [candidate] (1.185 s) : 0, 1184934
Total [candidate] (9.349 s) : 0, 9349061
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1166805
Total [baseline] (9.209 s) : 0, 9208965
Agent [candidate] (1.168 s) : 0, 1167919
Total [candidate] (9.264 s) : 0, 9263713
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~2a3526fc61, baseline=1.47.0-SNAPSHOT~eeba960fd3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.872 ms) : 0, 723872
BytebuddyAgent [candidate] (723.635 ms) : 0, 723635
GlobalTracer [baseline] (241.673 ms) : 0, 241673
GlobalTracer [candidate] (241.586 ms) : 0, 241586
AppSec [baseline] (55.82 ms) : 0, 55820
AppSec [candidate] (55.711 ms) : 0, 55711
Remote Config [baseline] (711.518 µs) : 0, 712
Remote Config [candidate] (703.175 µs) : 0, 703
Telemetry [baseline] (11.534 ms) : 0, 11534
Telemetry [candidate] (12.24 ms) : 0, 12240
section iast
BytebuddyAgent [baseline] (834.863 ms) : 0, 834863
BytebuddyAgent [candidate] (839.191 ms) : 0, 839191
GlobalTracer [baseline] (229.951 ms) : 0, 229951
GlobalTracer [candidate] (231.615 ms) : 0, 231615
IAST [baseline] (22.702 ms) : 0, 22702
IAST [candidate] (22.98 ms) : 0, 22980
AppSec [baseline] (57.181 ms) : 0, 57181
AppSec [candidate] (57.722 ms) : 0, 57722
Remote Config [baseline] (613.87 µs) : 0, 614
Remote Config [candidate] (615.803 µs) : 0, 616
Telemetry [baseline] (8.629 ms) : 0, 8629
Telemetry [candidate] (8.806 ms) : 0, 8806
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.915 ms) : 0, 838915
BytebuddyAgent [candidate] (846.344 ms) : 0, 846344
GlobalTracer [baseline] (231.254 ms) : 0, 231254
GlobalTracer [candidate] (232.352 ms) : 0, 232352
IAST [baseline] (22.827 ms) : 0, 22827
IAST [candidate] (23.362 ms) : 0, 23362
AppSec [baseline] (57.665 ms) : 0, 57665
AppSec [candidate] (57.89 ms) : 0, 57890
Remote Config [baseline] (607.952 µs) : 0, 608
Remote Config [candidate] (632.738 µs) : 0, 633
Telemetry [baseline] (8.741 ms) : 0, 8741
Telemetry [candidate] (8.89 ms) : 0, 8890
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.986 ms) : 0, 832986
BytebuddyAgent [candidate] (833.068 ms) : 0, 833068
GlobalTracer [baseline] (230.347 ms) : 0, 230347
GlobalTracer [candidate] (230.756 ms) : 0, 230756
IAST [baseline] (23.711 ms) : 0, 23711
IAST [candidate] (25.486 ms) : 0, 25486
AppSec [baseline] (55.291 ms) : 0, 55291
AppSec [candidate] (53.916 ms) : 0, 53916
Remote Config [baseline] (621.335 µs) : 0, 621
Remote Config [candidate] (630.731 µs) : 0, 631
Telemetry [baseline] (8.586 ms) : 0, 8586
Telemetry [candidate] (8.736 ms) : 0, 8736
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~2a3526fc61, baseline=1.47.0-SNAPSHOT~eeba960fd3
dateFormat X
axisFormat %s
section baseline
no_agent (387.134 µs) : 367, 407
. : milestone, 387,
iast (510.736 µs) : 489, 532
. : milestone, 511,
iast_FULL (752.144 µs) : 730, 774
. : milestone, 752,
iast_GLOBAL (561.317 µs) : 540, 583
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (519.377 µs) : 497, 542
. : milestone, 519,
iast_INACTIVE (467.143 µs) : 445, 489
. : milestone, 467,
iast_TELEMETRY_OFF (503.874 µs) : 481, 527
. : milestone, 504,
tracing (460.436 µs) : 440, 481
. : milestone, 460,
section candidate
no_agent (384.477 µs) : 365, 404
. : milestone, 384,
iast (514.741 µs) : 493, 536
. : milestone, 515,
iast_FULL (748.894 µs) : 727, 771
. : milestone, 749,
iast_GLOBAL (570.851 µs) : 548, 593
. : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (516.115 µs) : 494, 538
. : milestone, 516,
iast_INACTIVE (475.907 µs) : 453, 498
. : milestone, 476,
iast_TELEMETRY_OFF (507.112 µs) : 483, 531
. : milestone, 507,
tracing (461.781 µs) : 441, 483
. : milestone, 462,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~2a3526fc61, baseline=1.47.0-SNAPSHOT~eeba960fd3
dateFormat X
axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1378
. : milestone, 1359,
appsec (1.758 ms) : 1735, 1782
. : milestone, 1758,
appsec_no_iast (1.767 ms) : 1743, 1791
. : milestone, 1767,
iast (1.514 ms) : 1490, 1538
. : milestone, 1514,
profiling (1.504 ms) : 1481, 1528
. : milestone, 1504,
tracing (1.502 ms) : 1477, 1527
. : milestone, 1502,
section candidate
no_agent (1.367 ms) : 1346, 1387
. : milestone, 1367,
appsec (1.767 ms) : 1743, 1791
. : milestone, 1767,
appsec_no_iast (1.779 ms) : 1755, 1803
. : milestone, 1779,
iast (1.525 ms) : 1500, 1550
. : milestone, 1525,
profiling (1.553 ms) : 1528, 1578
. : milestone, 1553,
tracing (1.502 ms) : 1477, 1528
. : milestone, 1502,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~2a3526fc61, baseline=1.47.0-SNAPSHOT~eeba960fd3
dateFormat X
axisFormat %s
section baseline
no_agent (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
appsec (15.131 s) : 15131000, 15131000
. : milestone, 15131000,
iast (19.065 s) : 19065000, 19065000
. : milestone, 19065000,
iast_GLOBAL (18.33 s) : 18330000, 18330000
. : milestone, 18330000,
profiling (15.168 s) : 15168000, 15168000
. : milestone, 15168000,
tracing (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
section candidate
no_agent (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
appsec (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
iast (18.685 s) : 18685000, 18685000
. : milestone, 18685000,
iast_GLOBAL (17.678 s) : 17678000, 17678000
. : milestone, 17678000,
profiling (15.025 s) : 15025000, 15025000
. : milestone, 15025000,
tracing (15.059 s) : 15059000, 15059000
. : milestone, 15059000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~2a3526fc61, baseline=1.47.0-SNAPSHOT~eeba960fd3
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.361 ms) : 2318, 2404
. : milestone, 2361,
iast (2.102 ms) : 2047, 2157
. : milestone, 2102,
iast_GLOBAL (2.146 ms) : 2090, 2201
. : milestone, 2146,
profiling (2.446 ms) : 2262, 2630
. : milestone, 2446,
tracing (1.946 ms) : 1903, 1988
. : milestone, 1946,
section candidate
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.357 ms) : 2313, 2400
. : milestone, 2357,
iast (2.107 ms) : 2052, 2162
. : milestone, 2107,
iast_GLOBAL (2.144 ms) : 2088, 2199
. : milestone, 2144,
profiling (1.987 ms) : 1943, 2032
. : milestone, 1987,
tracing (1.949 ms) : 1907, 1992
. : milestone, 1949,
|
smola
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR fixes test name uniqueness.
Motivation
This will help with CI monitoring to keep track of test execution.
Additional Notes
This also moved specification from
DDSpecificationto SpockSpecificationfor the tests will be lighter.Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]